From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a1a6d68b4c-236ac450-e237-46bb-83e3-8cbb3487e67d-000000@eu-central-1.amazonses.com> Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11023119.outbound.protection.outlook.com [40.107.159.119]) by lore.virtuozzo.com (Postfix) with ESMTPS id 2850680E7E for ; Wed, 4 Nov 2026 13:54:14 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KdtqgguHShW0/jX2y4zZt5d0pngnHAXOCzE3I7VdrpTetb0Nc2C59L6DBBItjdNu4nDnVAigR3qbcGxSQY/JHEC/CjtaRtZ5BZJqBSBYbDj8jGPDqAt6Vf7YznJvBTuE0BhyGYCR8816USRLdUkMF8IcQS4ew266DZJph9XG4/as1h6RSmXWGeZdjYFbcUMfx/u9bXaaTzlXYAYw1ltWT2OST2F4qt0Q8u7it5WeeYDg1Na0NnAUEcRGiRxfpFWyHdi9Ekp8GNXd1CMSHXW1mVSdIYbcC5FoyVXfeJwLckm9h5r+/s/oMR9NUYpQ44B+yhX9I63TJv/Fd6J1s5/6ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zd4iteUDwYKvQL/14TviLS4exjmeSX0sOdB27edQp3g=; b=jrqKQ8OFkpTm5h8wt0e52L2cs2Qpufo/gacX3f+ViTjoHLGsU6Z5kMBDCKNVM/Chm6UFeibfcXVXiQR2ZDZZOzoVWeVb4yVkxKdzYghywD782pOCfBhxPmmvDA+e9qM/kFDdFFu4+69LVWYwt0w/7mdowx3X54PoGD72tD55Wtc8NksSsgaqGBv8BGlc55uXmENgAJdoN1dQPKYQVzPFsZVBdSolcb3L/sKg821VbzeXXjO2Y68GgHDRT00zQdeQvGF8rebe1qorvTMsc0mVRC68Ca0YysUOkfRL0cFTtnctRmAVqfY0tz7L9CXd0jln1nVp4c/JR5VmdgjKtljdDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.5) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zd4iteUDwYKvQL/14TviLS4exjmeSX0sOdB27edQp3g=; b=fNNLZgL9yVgrgJnlc8Ph8UQR9yAIsH58KiReH7bbYNKr6St0pC5XV9zVMYsoZHBIOIWidksougBaC+l7S/Bv8IPGslhsr/fD79eG5WYDqFau0ovWOXfil3LckAeZ9LtsamoLN7oqPugomMMhW2uzkh6dZUuvvBUu66W/6SfGI3k= Received: from DUZPR01CA0184.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b3::7) by GV1PR08MB10536.eurprd08.prod.outlook.com (2603:10a6:150:164::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Wed, 4 Nov 2026 13:54:03 +0000 Received: from DB1PEPF00050A01.eurprd03.prod.outlook.com (2603:10a6:10:4b3:cafe::70) by DUZPR01CA0184.outlook.office365.com (2603:10a6:10:4b3::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.10 via Frontend Transport; Wed, 4 Nov 2026 13:54:01 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.5) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.5 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.5; helo=b224-5.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-5.smtp-out.eu-central-1.amazonses.com (69.169.224.5) by DB1PEPF00050A01.mail.protection.outlook.com (10.167.242.43) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Wed, 4 Nov 2026 13:54:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793800440; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=dMXPTfjRaRG9SemBcSP8K42XO4Qb/1G2va4gQDBITL8=; b=r9M5zX4nnRZBsw0qaDsAJx6EoaUcSknYsrj4mHxDa3aL0COF63qxsrn9/0wPK6H2 Hzc1h00+clrIpTf60hDJAk1/2FQVMKX+cIxykSEwPKeowIjP3jJLkbDmYA+MFRoveQX YxgNZylE8Fv25O5WehXWrPqYmdCru3yNszg9ieEgyUbLOnWxcioCeneX9M0pArOBFqL q7xJMwihs79aEltOpQf2TuJQNztDb/uTJNT3wcBkKJ6JuzK0nSGmo93DRTo0wfng7Xk EMyehQn7GYJmuFDIIxOrYcCdSIbrZB3KHYzSPtIqOBqRsV1UWVDhP1beXAVMtbjNoJe isfX41i8Rw== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793800440; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=dMXPTfjRaRG9SemBcSP8K42XO4Qb/1G2va4gQDBITL8=; b=goplH+kOwd4hT1A+6vx8CLOzZ1+AieqDk2Y0jU3brZNVmRzBgfWfolA+m8dyO4N2 9uQDrDt+o2OgvM1BJriMWzok35KxxxlKzVfp4s+jfWpX/7wrzcZksuc2q/za5eQYPIz w7DcooL2rolZTH1mNwOXymb0qwWLBqsvTRsdqvVc= Message-ID: <010701a1a6d68b4c-236ac450-e237-46bb-83e3-8cbb3487e67d-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH hci-dev 4/6] tests/qtest/virtio-scsi: cover a replacement that changes the size #VSTOR-130961 To: andrey.drobyshev@virtuozzo.com, "Denis V. Lunev" Cc: svt-core@virtuozzo.com, den@openvz.org In-Reply-To: <20261104134539.1519657-5-den@openvz.org> References: <20261104134539.1519657-1-den@openvz.org> <20261104134539.1519657-5-den@openvz.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 4 Nov 2026 13:54:00 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.04-69.169.224.5 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB1PEPF00050A01:EE_|GV1PR08MB10536:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 3e0e760d-2047-4a36-f580-08df3a7b14b2 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704161411799003|48200799018|376014|61400799027|9140799003|32142699015|56012099006|261028144727099003|5023799004|4143699003|5063699009|261021121427099003|261026135527099003|261022105027099003|261026140227099003|261009223027099003|18056099003|10067099003|16102099003|18002099003|261102123227099003|55112099003|22082099003|6133799003|5113699003|4113699003|13003099007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SFRycUdmMEpKOWpHY1ljOUFYdDFhWjYwK04yUU9PcUJYZnNyQ1hwTUdOQml4?= =?utf-8?B?ZFF4MWhhT0JRa2NNUnNvaHlJaTFraVluM2hRTTg1ZnJmbUxPdURYY3JTdWt2?= =?utf-8?B?YWhCaVc2V0hXaGJBclV5MFo0Ylowdi82M29vUzBFOW9Qd1RicXFoTHBaeGc3?= =?utf-8?B?SUZtTzhBeFZHYldvSFBWTjJSSFYweXZLazRMNnZtWm9SUmIyWFh0ditYdU15?= =?utf-8?B?dW1TR2h2dXNvVm1XdGtJK2dRR3hVVnlYUkQ0Uy9OcURodUJnU3VPbTlibjA1?= =?utf-8?B?eTd2YWtZZ254SjhheVBmVElsQ3FTTVY4OTc1TTlqd25HK25RVWpvamVKRFdy?= =?utf-8?B?RTdiTlJrMFA0ZEJUeUhRaXhicngvbEZKS1lxUG9VbmNoZnI2aFNNRHQ5QXJD?= =?utf-8?B?WDd5TUY0NmhFUHRvenFOcHZxM1lpZGdvYklPWFFyby9pMWZqajlMYXZOZnhj?= =?utf-8?B?MUNTR0NxWWxtYmpSbDQwNVV1T2x4SUtNYkgxTWZmOTBvOWxXVW9FajFYbHFH?= =?utf-8?B?YmJmZ21tSjFRaXM3Ym1XTkpFNGE0bHJCWFdONGsrMXdZWjZuZmY2elRYL29z?= =?utf-8?B?T0JMNkc5cVVhdXlOZ3hxMXkrL0hBeFljc2pIRndMK2kzRTZ0TXE5WFBJelNr?= =?utf-8?B?d2hFSHhLQUx1Nit4RDZmKzMyc0FSREZrZUgrM0FULzhBdlJNV2lxekdmUUJx?= =?utf-8?B?MVZCc2hkWGYxeEE3TmdHU0lLL2xmL1RZY2pPN2p1TXZML1dORytUVVpZd0tF?= =?utf-8?B?dEJ0ZVFscjdxbUNibW1uZE94bU1tTDNDdEwzcHZLTTE2N2o3RGd3Z1M5eVFE?= =?utf-8?B?MFRycGxPZ1RSUG5FaGN0SFRXNW55MGowVGt4eFRKTlZlZUtrZWdQVE1YdGxL?= =?utf-8?B?dGc5SmZUMjYwNkl5enNlSzZzWjZTbzNhYURvT3M4V0hOZmx0K1FuazdtNW9T?= =?utf-8?B?aFhzUi8zRDJHb2MvRUFBREZhbnlUbEdBWm5HcXYvQytjdkVSd3VTTmhzcGxz?= =?utf-8?B?aHRoaCtVODN5YWtIQjVUVHF6aWt3STVQWU1paFRXOGEzbEJzcDNONWtsdVpJ?= =?utf-8?B?YnBsN0NkT0VubXY0VUJwT3F0cTRjdzNMNnVYOCtRY2NnaWg0OFVtMTI1NHBv?= =?utf-8?B?SExOUjF4UjV1QVBHQmFnUE15RmZnNXVsMVJrL3o4OU11K2c4UU9WeCtVUW9O?= =?utf-8?B?a3dXZXNiVnBEbjhZb1JQT2hLdm9SUG1vYXlUV1BkeUJoejNxcVYxeVhyUWpE?= =?utf-8?B?Y0ZGV1h3N2dzcmV0RlhKbi9PdkhrU1crTGZxYzArczgxeUlmL0FsWFQycVd2?= =?utf-8?Q?NCXWYsE/C8MwQ=3D?= X-Forefront-Antispam-Report: CIP:69.169.224.5;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-5.smtp-out.eu-central-1.amazonses.com;PTR:b224-5.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704161411799003)(48200799018)(376014)(61400799027)(9140799003)(32142699015)(56012099006)(261028144727099003)(5023799004)(4143699003)(5063699009)(261021121427099003)(261026135527099003)(261022105027099003)(261026140227099003)(261009223027099003)(18056099003)(10067099003)(16102099003)(18002099003)(261102123227099003)(55112099003)(22082099003)(6133799003)(5113699003)(4113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: v8NJFmVBP0/uLHTkwv6aCpaLtSaFXSfEt+N0RGtoyLTXihKcdt8YLMDx5Imk1vIZg7GGWMTqFLO7OsZNipyyNpz7SHmMuLqJfKcbRdaORlig7/PmkQb+Fjs0nb6T518aZJgCnSgfxsuOeZwBCDxHHSFx9JCUVOQJ9xBOaxKuPNOogkmt/yO4sCEBum3ePherje0AeoIiT5NN9lOB/qGBgz+FFIUair9/+PIoVBdH6XMDx3ObRdzGwymnX2bJ/bTGJXr0v9ksJBD92anrXBp2dNXXhjb9Bixg+HBSh3YUyGxEqEOCOFVjcKELddFNgcCkwwFMBtpN9+rAptUJcMN7Mv8k+7psloZWLEh+hJ9/xPWqu9D9jvYvZDdIg4tgVXIShSw9jTMJgrYdNcAAWvQvKnlff/zGoYad+6QR2Ri4bZrHfXcnWohNBEChDj3QL2Mx X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2026 13:54:01.1682 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3e0e760d-2047-4a36-f580-08df3a7b14b2 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF00050A01.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB10536 Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] qtest: replaced-node tests never check equal-size or multi-parent n= otification -- Subject: Re: [PATCH] tests/qtest/virtio-scsi: cover a replacement that chan= ges the size #VSTOR-130961 commit dfa745e49f7f99a718150defda33d68b4cb092a9 Author: Denis V. Lunev tests/qtest/virtio-scsi: cover a replacement that changes the size #VSTOR-1= 30961 This adds a qtest that realizes a scsi-hd on a 1 MiB null-co node, replaces it with a 128 MiB node via qom-set, and checks for the CAPACITY DATA HAS CHANGED unit attention followed by a successful read that only fits in the new node. Message-ID: <20260812121500.1034178-4-den@openvz.org> > diff --git a/tests/qtest/virtio-scsi-test.c b/tests/qtest/virtio-scsi-tes= t.c > --- a/tests/qtest/virtio-scsi-test.c > +++ b/tests/qtest/virtio-scsi-test.c [ ... ] > +/* Test replacing the backing node with one of a different size */ > +static void test_replaced_node_size(void *obj, void *data, > + QGuestAllocator *t_alloc) > +{ [ ... ] > + /* Swap in a 128 MiB node; the device is not reset by this */ > + qtest_qmp_assert_success(global_qtest, > + "{'execute': 'qom-set', 'arguments': {" > + " 'path': '/machine/peripheral/scsi-hd0'," > + " 'property': 'drive', 'value': 'big'}}"); [Severity: Low] This isn't a bug, but is the coverage here complete enough? test_replaced_node_size() only exercises a size-changing replacement (small at 1 MiB to big at 128 MiB) with a single parent, scsi-hd0. The notification is issued from bdrv_replace_resize_commit() in block.c: if (old_len >=3D 0 && new_len >=3D 0 && new_len !=3D old_len) { bdrv_parent_cb_resize(s->new_bs); } Would this test still pass if the new_len !=3D old_len check were dropped? An equal-size replacement would then send a spurious capacity-changed unit attention, and nothing here would catch it. Also, bdrv_parent_cb_resize() goes through bdrv_co_parent_cb_resize(), which notifies every parent of new_bs, not only the replaced child. Would it be worth adding a case where new_bs has a second parent, to check that behaviour? Looking at the final state of the series, the later patches only add further size-changing replacements (node4 at 2 MiB in the qom-set-drive iotest, and the huge node via vz-x-blockdev-replace). I did not see an equal-size case or a multi-parent case added anywhere in the series. [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/2026110413453= 9.1519657-1-den@openvz.org?part=3D4