From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a1a7044710-40841a08-a5f3-45d1-b949-7ce736ce20c8-000000@eu-central-1.amazonses.com> Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020076.outbound.protection.outlook.com [52.101.69.76]) by lore.virtuozzo.com (Postfix) with ESMTPS id 6CC728017D for ; Wed, 4 Nov 2026 14:44:04 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WmD7W5L2xDv7Jl0vjksSeZMeYvD/HTKD4TBjv2U+iP/jB7NDx67UFhHJpusyKmF0SGNyENGDPOluEOtXaEI1MeeSZk62F18Gqp/AVFcSsMjahjPrsaYwfz+dLDjdmmhWMA7/kpKFzcoQo9mtRCC8k1r+sb+QA70HSblpnnni8aagkqOB8sc+lPeNz3tKDropJm75f/+HJb51t6bzD1YO57hBTnoIF28obvJE2xx0zRt2c/lEPpZLT6Khgipj94JQSbSj+REytDWniL15rla6GLYo9gy4tRhh/e87NxOWySy1iWfmzudbAbhe5OPJPuO9bjOpm2RL746S0hxipTizBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/nl+/IVovY8m79Ez0/9g0K2ULYLHcGCaJPhxxt5KztY=; b=S8fYAjJw8FM0wctx0p1f3zZFTkb2W3mMzMQMgyNtHJaKU8B6rlIcEy5RGfzkEQ1Fy1V+ti2Wu0xt6VCIJTC2lJBKcKEOftZo2/zYC0RbZbujRlf/zplD1eEEbeCdzBY+mQJaqRJF4kEBvfDWLwPaln5QgQ2kbvuB9qIEH0zqSNuWkokeFSrZOz1l19DVvw+xDSqBgk9HFgBXYJEZU+9wqL5USDdilx9FDy3TJtuA9USMrKNDf8RRALdp8JtyL3dDAyRzJzaKsWDMeomgDeE0y3qax0MWvh4Vlo2fQZuK0aDr7Wz5aABeGA7RCV6OLjRQqdMWAKkXbbxf3mbG24nbpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.6) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/nl+/IVovY8m79Ez0/9g0K2ULYLHcGCaJPhxxt5KztY=; b=SqUJdTi2/Qv7zkzZOKtjXEJQGSffOO8xNxXadDk90RXZrynrpdzEppcBmrUgbBNM5D/SIuKoW21YdfQT2+1zd3gE0BjxLoUGmH+LfYt4rFiCtY+bu3QhE3qUrybe0/sp/RoMJoi6RriQ4Iv5Wu/zXIvLj1XVRqPYb70dpA9WyAg= Received: from AS4PR09CA0020.eurprd09.prod.outlook.com (2603:10a6:20b:5d4::7) by AM9PR08MB6211.eurprd08.prod.outlook.com (2603:10a6:20b:2de::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Wed, 4 Nov 2026 14:43:58 +0000 Received: from AMS1EPF0000009E.eurprd02.prod.outlook.com (2603:10a6:20b:5d4:cafe::a5) by AS4PR09CA0020.outlook.office365.com (2603:10a6:20b:5d4::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.10 via Frontend Transport; Wed, 4 Nov 2026 14:43:58 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.6) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.6 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.6; helo=b224-6.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-6.smtp-out.eu-central-1.amazonses.com (69.169.224.6) by AMS1EPF0000009E.mail.protection.outlook.com (10.167.242.75) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Wed, 4 Nov 2026 14:43:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793803437; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=2YV4+JKM9RJteENKn9QgIaXz7AUKqx4FSY1YKqBzcyk=; b=Q9HsH+5/Af19AK75241norXFNnI2eihr+4FiErZcJ/ID+yFZQ6awUua4iXdZAwFY vo6rX/GwJo/aCN0RSNIcZb+yG9JkCPy2Qf5bTvRuw02rNHxTCUi724/CejAJlLm4q4S JjmN7Std7BXuamy1qPrzpnlPJM9HXSGFC7n/p07sOt0+QWl5mkCxK+7ZIARm14VoHVJ q/doGc60gZTzdvuA1zU1Al4aS/KoLJ0iY2XdVH1UyQ1AQAn1gr79imYFS0L7qRv4ROj y4p+cmtFfjcz96DYO00EWjMGMCUKVDV6XzsLgHsuzvwzGzTZxYANdcnLGaiqM6tWlo8 eZubYWqCUA== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793803437; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=2YV4+JKM9RJteENKn9QgIaXz7AUKqx4FSY1YKqBzcyk=; b=a5tv2HPBvBF0cL8AcOCR19t4pZEr7vHe7Um7mQBlqSxpfQEqudn671zcnJQERoHO DBqg3HP3gQfoA2GajoyTxslu1bU3vEKBTxjkE/qcwfwcPkCFr+Ac/bRasqqDxdifSKa iXCxcGuxwm/aTq6itozaYhPvFDaqPaV0qwelH5uc= Message-ID: <010701a1a7044710-40841a08-a5f3-45d1-b949-7ce736ce20c8-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH hci-dev 2/2] block: reject a reopen of an unusable node instead of crashing #VSTOR-140073 To: "Denis V. Lunev" , andrey.drobyshev@virtuozzo.com Cc: svt-core@virtuozzo.com, den@openvz.org In-Reply-To: <20261104144113.1587724-3-den@openvz.org> References: <20261104144113.1587724-1-den@openvz.org> <20261104144113.1587724-3-den@openvz.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 4 Nov 2026 14:43:57 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.04-69.169.224.6 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS1EPF0000009E:EE_|AM9PR08MB6211:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 412f399d-bf73-4f9a-3bf5-08df3a820f10 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704160211799003|376014|48200799018|61400799027|9140799003|32142699015|261026135527099003|261026140227099003|4143699003|56012099006|261009223027099003|261028144727099003|5063699009|261022075727099003|261022115727099003|261022105027099003|261021121427099003|10067099003|55112099003|18002099003|261102123227099003|16102099003|22082099003|4113699003|5113699003|13003099007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UDg5OFUyWVU1dkhJV2lobGJxV1djeitZWmlQSEdCMmc5VStsSEhGaFZJaHNC?= =?utf-8?B?ZFlsbDBzT0ZyNmZxdFBOT0w2QWdFYXJheU02R2pnY3k0RVlUaXhUeGJ0VUpR?= =?utf-8?B?c084anRvNkQ0MXV4bUJxbGtFT1RLNkEyRXhRQ0gyZm5Nby9WL1dtL2wyQ0pQ?= =?utf-8?B?SzZBRmwwK0F4ZDlUY2g0STVabWJHN3NEbGFqSS8wQnVHMU5ValN6T2NLTm1U?= =?utf-8?B?UjhZQ1NlU2FFLzZuaHRwNm1mSUlmMVh4WVdKVVUvT0tCL2liVm8wVDFFYkI5?= =?utf-8?B?cDk1UDdnV2xPSitwVlo1MGVobjVheXpkcEw1VUlmSzlaNkp6WEhyT3M5YlJN?= =?utf-8?B?MTdDdGcyNTZyR0haRkZ4cUtjam4zYTdSQWgwWTdIYmhWWVBudjdZejBYQk5t?= =?utf-8?B?UllKYnNSdFFZRHU2cVZEVnQ2Wk0welBtOTUvb2hyRjBQSEFPcVIxdzFjMDl4?= =?utf-8?B?U1Y1Y1VYZll1RGZxZHlJc1BqbWk3MDNIOGo3eVlTUEtFb3dRR01yQzA4Y1lZ?= =?utf-8?B?U3lzcFd4SU5OekpId3JtYWUzanFyK2sxSEVoelEreTBwcGhHZDNpQUk1ODVP?= =?utf-8?B?RW9rMlpYbHloRTgrcXhmdS81SDdvai9mbjE5M1dieEZueEtQaUluU0oybGJz?= =?utf-8?B?QXNkaWFWYURhRkV5WmJaZ2pSbmJUTWJ3emIzZFBUQys0MnhxR2pXcVVOaGJN?= =?utf-8?B?bkt0VmRTSkM3b1AyT2ZCN0kzRCsyY1BRQmNFVHBJNlR1V3ZxVEpabXNVU2cx?= =?utf-8?B?M3ZVWStPOTVJSGpBay93V2R2VVZxVXJldFdkaU04RjRMUGZOeHRialVpQUlM?= =?utf-8?B?SnQwR0g1blU5K0FtMktrclREc0xOOW54dzdoalpGU0xXa0wxVHNaZ2NTN2s2?= =?utf-8?B?ZGJ0WGtaRWZ2L2kyR01ubjJScm41bUFsY1BKV21iUEowcGZSeC92SzhzL3Bx?= =?utf-8?B?aHJMY3FEWExORndWbDdCWkh0b0xXQnZmOCtqRDU1Wm55bzBaWWRRYWJ2bWkx?= =?utf-8?B?Mnczem1tWHRsVnpCOSttYnFHcEpMWGdJczArc09ITUNLcS8vWEp1MzQ0WUVL?= =?utf-8?B?K0k0ZzBWVTEreVJRT2dGSzRoekQ0L2xwNUNXUVhlQUFBa1ozNzNHQVNSTmtN?= =?utf-8?B?b2F2TzBPV3hmYUVicVhuSGduMHlWdXl6UURhZlk4bzVOQjdUNXRCL3BnZUJz?= =?utf-8?B?VDZEMkJqNTJyaXN2eXM3eEdabVFjUHJLK0xnYk1oMjVEdGxoL0paZ0ZCVjVQ?= =?utf-8?B?STV3cHJCWkR1OWtRTG1SWEtJd24xTEFXYzlxRXhxZGpPRVBBZFMzSlFzTnpx?= =?utf-8?B?KzdPZkZhL2MzS2tvM2dBODg3V1FrTXdiS3ZYaXJyNWZSZlVBY1lYTWszRkJQ?= =?utf-8?B?N01IeUlTVlV4WU0yU2pQNnVmT3k5MnhsZFBBWlBFM3dFN0Evd3o0LzdtOWls?= =?utf-8?B?eGpINkJESzRlS0ZwUVNMeWxUdStENHlSMUQzVWlWdnA5Rm1hVVZhd0IzMnMx?= =?utf-8?B?QUpON1FhT3RlQjI1R1ZtOCt6RDN5aWZTQnRFNG9pU3BEcDZRUVN3WU0wMG5a?= =?utf-8?B?TCs3UT09?= X-Forefront-Antispam-Report: CIP:69.169.224.6;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-6.smtp-out.eu-central-1.amazonses.com;PTR:b224-6.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704160211799003)(376014)(48200799018)(61400799027)(9140799003)(32142699015)(261026135527099003)(261026140227099003)(4143699003)(56012099006)(261009223027099003)(261028144727099003)(5063699009)(261022075727099003)(261022115727099003)(261022105027099003)(261021121427099003)(10067099003)(55112099003)(18002099003)(261102123227099003)(16102099003)(22082099003)(4113699003)(5113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: DrMpwk8XKxd1ULxEVlMjXnm3l4t6lf5Q8d/LVfjI7DE5lrr0BZg9qCuUYJr5AfvUYAgTE368lighBa2miAXcx5jltZNEeNpv4t6TIphIeKYzMUnbpR4j9Gok+xf555/i5WIfNYBqCHVGUyREAAjfpCS9M/kOo2N1nWLR/0ZGJ6dFyOw0UXWQd7PKzvBnz4qBgN0nZaD2KKZi7qzR6m1G9gh8HKfVnG43isbAmEoCVoWZ7mCICUZT7RuOS5xRxe2+Rz6heIu2YCq/y+4mlRDyTzLi3iT9rxgkmcreuc94R+BbaPvl91DmFVIWl19AEmycRiKbh0ZVTnuvPiIzau8IvoZSoQL1XTldWtuqvf1a8AsO0L7cImamqk3GtMhhQ2QtrIBFKmZ2XvU6ANwsQrILfxiuNqTw3bq6Zs/PkgjZDG3DeaHcX0mlsjujyWuFp7CD X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2026 14:43:58.2180 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 412f399d-bf73-4f9a-3bf5-08df3a820f10 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF0000009E.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6211 > From: Denis V. Lunev >=20 > qcow2_signal_corruption() drops bs->drv, so a node can lose its driver > at any time and a reopen has to expect that. Both ends of the path > assume otherwise: >=20 > $ qemu-io -c "read 0 64k" -c "reopen -r" corrupt.qcow2 > qcow2: Marking image as corrupt: Cluster allocation offset 0x1200 > unaligned (L2 offset: 0x40000, L2 index: 0); ... > Segmentation fault >=20 > bdrv_reopen_queue_child() dereferences bs->drv while descending into > the children the node opened itself, and bdrv_reopen_prepare() asserts > on it. commit_clean() reopens the base of a commit job back to > read-only, so a base which goes corrupt under the job arrives here too. > [ ... ] > CC: Andrey Drobyshev > Cc: qemu-stable@nongnu.org > Message-ID: <20260824133729.1141990-3-den@openvz.org> > Reviewed-by: Kevin Wolf > Signed-off-by: Kevin Wolf Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/2026110414411= 3.1587724-1-den@openvz.org?part=3D2