From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11023106.outbound.protection.outlook.com [40.107.162.106]) by lore.virtuozzo.com (Postfix) with ESMTPS id 8D222803D6 for ; Fri, 4 Sep 2026 10:12:28 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=y8gifDLygLrhKAoI7+r+fOzoOWOrFKkTxgzyR2hmdwfBC8z0GgFiooP/vM+eRa5zUMknstVUVkds7AQwrG79FNPzismblBLN9+FdeEaZSoMcoqvhk7NZhOx28DOkpNEScR+JTO5V5oJjZNmL1qC/LtEWAG6bKdbCZd7L77DQwqQvAdMzLDm8TQ4DVAe0IIhq8j3v2U49zNJDnanqmjXow5hJGkGwgyap6F5SzdBM9H+RsTonPcaqfPl2f/ORDuz8wfmBRPHj1y0BElVX18dyn8c4T0ZfvGkcvioufGhdluloIzkecoifZ9XAwSJaq7de/ZahwQvDnR8yHb8/H8HDLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lmNGbQjw/Pog46gQi7ixzsqLMsrOJYYHKPGIxtH86WE=; b=BUExJPDiYI0kd4nu1UUm/NfzD+pCjxNzb6xDGPV8fQ++Utk6UnxVe4QFygaqR032xwh6MQ/Wyl1PIydC65acTxSLg+j7X7kbHyB46KPI+2wmVedcedDxX5S/D5uVOJx/zo6nK8SOJs7HQZUeFJZ9bwqKOTvjDKN8HHVxR+1hxpDvMMcJIlHdgHvRPStKcB4mG82hNK3n9YpOqTTGO7zmeOoR9YRnbMEuZIQ1v+MvGyFjSOtk9awdb/aVfkXHU+pvRN5j/QaPHVb733uJlCYY3jNSgOpBM/U9tfoz2cdEzJG4lQZP9d8ho+huU7txKVqPUcNV+rDMJcmCbioz2PzB6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lmNGbQjw/Pog46gQi7ixzsqLMsrOJYYHKPGIxtH86WE=; b=DSK++mqKAy5PtDV+nxaNV9VTLgdzRv3/P7rbz66q91XokH/2xofAcIjTib8pGb2bXVQ/PPU5M8dQETV4t1RR4xK1gT1VNf3rxTrclHiE5ZXlLn+F/2P71PTK0OciYy4qfkfCZ7sGHrzulmI5xVw730HyKOlhjeDOz24CjIX1324TPIJ78dU872hAQqvkmLz4dP2cWcSy1KTx8BLyaYXd3MgvnmKKB83AoA0OozRFw42rIC2I7KW7tdHikx9CRXoy0x+SYvIZ1qisyYTfg75KhXCnytGcRl8O7x2w5V3vK1DkzDfXYq6AJGnBpEGxI/z6jQCSQqlN7bhEotocfMKn1A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by DBBPR08MB6105.eurprd08.prod.outlook.com (2603:10a6:10:20d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.10; Fri, 4 Sep 2026 10:12:27 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0382.007; Fri, 4 Sep 2026 10:12:27 +0000 From: Andrey Drobyshev To: svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com, den@openvz.org Subject: [QEMU HCI-8.0 PATCH 12/15] ui/vnc: remove redundant rows computation Date: Fri, 4 Sep 2026 13:12:02 +0300 Message-ID: <20260904101206.701978-13-andrey.drobyshev@virtuozzo.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260904101206.701978-1-andrey.drobyshev@virtuozzo.com> References: <20260904101206.701978-1-andrey.drobyshev@virtuozzo.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: VIUP296CA0052.AUTP296.PROD.OUTLOOK.COM (2603:10a6:800:34b::10) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|DBBPR08MB6105:EE_ X-MS-Office365-Filtering-Correlation-Id: d8f55ad5-5588-4571-ab51-08df0a6d030b X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|23010399003|52116014|5113699003|18002099003|22082099003|56012099006|10067099003|38350700014; X-Microsoft-Antispam-Message-Info: lItiXdDpyPgqaECjstjbnmYA6ezP625Dq3fjOhmzaSMBUILxtzYnI8HwYYicIHTW39QSj7DjL6kYHL3IGEOMd+6L7T4f4banXEGlvH7/QVHYYwpcutTehpHMEADIHSvh4Vole0vLBfC0CCbQXRrObybVGgndjgyT6ZAY2CBmSSRVvJ9DqJvY7ToP6y44Sg1jmWfM6MN54aF6ZPW4z4EKAXmAUwGpwC3LbBbWKAPrd13vATnmOKNNOYc5ydVIqaoFpZVJqViqfdtv3eEGzIN6B+/pvLl8OS/EzMTUM74FcwCxIgmTQwfnxfWwbFuNFFa37m4aV/oxsgz8i4jwADR2RZeIRwdvCByfW+2NuYLo58HomPY8cAEIY2B2w8jiuZGO7iV4/Yhvc+z9+DVXuLRdbxVv5AQ78P9iE3e7iWDsAsQpEaQa2Aum41SvfGDHx3FoLVSp9rOH6RQtZyfUXEzugODKzc12zA0w6qzB8nhWUzPph0heXpqjkp/1QXmftXBSWdT71AI4PgwbR4Z24BcDVGYd2zCYp4afhKKTgi/8HU3uCFSxdcw9d/uQqkd+9yKbIMaF+WBnkVKcwtvuZVMj8LbXb452xHcf3N7j9UN062U3CmSrbKEDerI8Z3Y2yaRoqc/K+9keebGbVRFgDPt1h78UxF02fl2EIpDX6s55Nvp52BD6Gpk0OFkXhRDLbNIy34hRDNUusUntKN8hsEvwRyVT7bGCVD3V5/ngq41lLU8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR08MB10656.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(23010399003)(52116014)(5113699003)(18002099003)(22082099003)(56012099006)(10067099003)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1pOYzlrM1djbW9vemplYjRKRzN0RHFISUdrYUg2TElSaHd2ZnlNUDVHeENM?= =?utf-8?B?djlocVp5Y3lWMGszc1MyWHZQeWErR2ZQK1BXWTFsenZIREpqNzhPN25SNysz?= =?utf-8?B?ZDRSYWt2RlFKNDF1NXUwRTVvVk45UllHNHJmYTRXQUhSRDFpaDl2dHhTQnNH?= =?utf-8?B?WDBvK2EzbFF1dUVlLytSa2d2QkEybVBDb3luaXpySHVwZDUxeUhORndQTFpD?= =?utf-8?B?VTRCdmcrNlVSSm1KSXgwUUxnR1RwSDhsZEpUSDVCNXdBeml3cG10aXpONW8x?= =?utf-8?B?RzRBb1pRVjlxcS9HMi9hb3orWEYrdlJBbmhVR0x1UmN0RkNKbkFiM0M5U0pP?= =?utf-8?B?RGhhdlY2TVFkS2kvdWJ3MXU3cG5teEtpWXpNcHprdG5vSFF0clNxdzVYeDVZ?= =?utf-8?B?TEZoenFNSUMzeGxialBVMytHWEdSZmdFUjZPR3c1djNRQWFzTkdBWEVxSks2?= =?utf-8?B?VzgwYlJ3QlFMbFBiV0s4T1VrR1hZV0treEUzc2UrR09ZWkw3YXNRQWhaYXJo?= =?utf-8?B?REs1TzFCVy85eXAyaExrRElrVDhMakNtSjZIOG9UdGFvMVJZTkpsL1IxTitR?= =?utf-8?B?ZjlxTTcvVGdSbTdXNldlRFF0ajFzbVFaSW42MXVnYmxESHFrU2RDaGEvMWsw?= =?utf-8?B?WlFRVlU1eXZOMUhnOEowVWJGMWJuVzVVbGNxSlhrYlc5bURsNi9LQ1pVOVpi?= =?utf-8?B?VlRraXJZcmpQckZkdy9UVEtvSy9tUVJ5R1h0L3o2Q0tldkZUK21BcVNFb09Y?= =?utf-8?B?dkYvMlBXUm5Zam5mVWFxSFhsMUpnM0pONEhaVmIyc21zRHVLdGMzd0tuZkpZ?= =?utf-8?B?ZS85MlBVUVlETTJWZTdTbE1TcVhCaUlYQUxpaGlCTStYdk9nQklISUkycm9O?= =?utf-8?B?NE5tM05yb2d2ZUNHZTIzd29ydzhLVWNTNDIvNG5xMUcyTFdvaWhOK0t4Wk8v?= =?utf-8?B?bXZ5OW9EL3BPRU9UaytkOUxzbjgzb0JNd1VQcFRROWlBMUNFcFpERm13YW9a?= =?utf-8?B?Q01PTlF0RFRVS0pMNlExSm9yMDh1U1ptUncxU0xOQnNWOEhOUUphQlpjQlZD?= =?utf-8?B?YlFkVWVKOU5QZU5iVWtYb1hNendUL2NaRmpUSEhYbDIyeDU3OENKMUEyWjNq?= =?utf-8?B?OUYrSGh5ZXI1M2RQY1lBUmRVNU9Eai94QjczRVVueXpkd3lDWHZqdGpieHhy?= =?utf-8?B?MFlrY1J0eU91SVFtb1oxUTdvQWZrcmt4cUd6RjZzMDY1R1pJSElxcUtpMkx6?= =?utf-8?B?MEs5OVQ4Q2lSQlIxUmtQR2YyRkhIOWlBa3NaeXRDc2JRQ21zUi9Pd3YybUZX?= =?utf-8?B?VkcxUFU2ZUF4Q05IRGZuRW5jQmEvTHhOK1pNamMwK1BBT0psS0RsQzRKcW9E?= =?utf-8?B?Wi9EOFBaMHg0QVc4bnRKUWtwV1FMVDBYSklGSjYxNStyWWUwejY4RFdWNjFl?= =?utf-8?B?RS9zSmhZdUxUQlJXci9GRllBUUZCTzlHd3RJTEkwSnRiRDJVcG9vUzVRR3Yw?= =?utf-8?B?cnRNYXptOFB3L0REeDhOdjNhWVRzandOZURKQ0s5cG4zdmdSZEEwR2xQUFdw?= =?utf-8?B?d0YxUzhybGJTTUFWUUsyRXgwNmRYaUtUMm0wQzVHbElUb0lwdzJ6RHZkSEFP?= =?utf-8?B?SXl6TGhRVWRhZnlJSDU2NE8rS3p4OHJvWXRKOUxjckVLK3p3aDVjTEU3NTFX?= =?utf-8?B?dkIrZHNqTFpiSUxkbVJtTjNlVVlPOGNnSmQ3ODg2dmpITS9TS3RuUHRPcERz?= =?utf-8?B?UjlyZTVtMFVJMjlhQzRVdkpWeUVGV09HQkN5MG55Z0lpYlVCSzNKTklweFU1?= =?utf-8?B?R1RLZG9FQjh6SjFqOWwzZitGSy9raUp5b2V4KzFqNVUzazdhQSt5VW9KMjky?= =?utf-8?B?akY0dGlaam52WmxhSFl1bENjdnlreVBXVWZzYWhLbElaUXlRTUpaNHFYQjl0?= =?utf-8?B?a3ZGVWsyODNGZlBpbVFaNnkrOXVIcmZ6TXZhTXM3T1o2cDB5YkFQaTVTQStH?= =?utf-8?B?OEJpK1JsZ2FZVU9zejBCa0xuY0ZEWi9ZdFJEczJVUDFLSXNLNnU2RmJPUXJ5?= =?utf-8?B?Yzl3c3QrZkRudkNsNnRjV2RJeGlUa1NPcytIZTlOdTFsYTl1cW5hdTNqbHNw?= =?utf-8?B?ZHI0d2lXNlZZc2tDS2M4VmxnOStQZFFhc2JZcmdMMVlPUWRkWWFoVU91Qmd2?= =?utf-8?B?U04xWkdJSDhTSzhaUGdWZWthc2pQS05OOXBvNXpHYStqK1h0ZTEwM2NNYk1m?= =?utf-8?B?MFgvMGt5RFRSWUdZamFhMVdLT1RvV2lFck9MQkVWbDRCaE5IMFRhQjRLMGVt?= =?utf-8?B?L2tLMGJITUpmT280VHpzNnJEOE4yODROeGJzQ0RoQUtOQ3lWL05pMFdDL1Y2?= =?utf-8?Q?bujfynyo74M/KDrs=3D?= X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8f55ad5-5588-4571-ab51-08df0a6d030b X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2026 10:12:23.0389 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bOtDebZ2jAvTcsZKOBmZmEOdyio7dpMeucRO702MewbvjOgWmbyv67vsh1AZ8gcAYpRHWo7zfCXo485AoMOcdNWO4x9prGbrvbGAMg3Zuoo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6105 From: Marc-André Lureau "rows" was already computed in an earlier commit 3543c2b855 ("ui/vnc: fix OOB write in vnc_refresh_lossy_rect"). Fixes: e650e4fe0f ("ui/vnc: fix out-of-bounds write in lossy refresh dirty marking") Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Marc-André Lureau (cherry picked from commit efa7244b2a0bd5e40ec334dbec4a09af0134d91f) --- ui/vnc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index 5e06e079e45..6c4132b8dbc 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3037,7 +3037,6 @@ static int vnc_refresh_lossy_rect(VncDisplay *vd, int x, int y, y = QEMU_ALIGN_DOWN(y, VNC_STAT_RECT); x = QEMU_ALIGN_DOWN(x, VNC_STAT_RECT); - rows = MIN(VNC_STAT_RECT, height - y); rows = MIN(VNC_STAT_RECT, height - y); if (rows <= 0) { -- 2.47.1