From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11023072.outbound.protection.outlook.com [40.107.162.72]) by lore.virtuozzo.com (Postfix) with ESMTPS id 34B44804D5 for ; Fri, 4 Sep 2026 10:12:29 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eXHv2Wi4x5gQ6zGKTjHBsbYngb+0cHLWK1jOika6Kn4vPRrsI+QT0aD3+U8ThvTW6zFsVaHRhcxUEx8rnGso0ndr9ad9FRpqW5fhn91eMh2bzWoWnBSU2Jsts0ti9di++5lAB1ZipibKNYt7rWr24bt9P1ek2d6/wm4cfDAmyRq+i6zEdtxOfuoMz5bf7AoKf7nXWBWSDWmZOdlFeEoMnPtZGTbiJJB2+VsG6Xyy8V/h12lUujNzURYcK4QNhCFwc682E8G2NCJIF/vF1NfalWnWzvLLpRLmna+ELzrjdjMlKy/ixmOQWpP+XuhcwJhCmJ72XH06wLzUjU+vr0t1qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j2KUqexDGR9SBz8L2HILXheeUzyfRo1XS819xvm54yA=; b=b3nLOs9NGUEL7ybJW/4Hjlyw+TL9qEZQJLj+yF2ZVAYUydXc6oS3Oh0DAIOe1iA2MTr6bQzxO+PH9xVnCvMXeIPkHTw3eiucBYJBzPq5y8bW0K87ddTkWn3yyzKsaEWvlwZmdu2+xjUoJ7gwSPcKkkeTZEvrcodZvvbfYk699IgA9Sd9qk3MF1UTmVOTmLWxRjGufS5wVJf4h6WFVXi3qlwAdtehxMrzsMyDACT965KFG5uS9I3xLmpcTcn4bX3pvsN/+82XGhYWst7QDEvqWMibdU1z4SKz+qyEO/wdgwDgao78p5yMX5gBJ350TjnU1RMUCUaZhGwg6fk9ondH/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j2KUqexDGR9SBz8L2HILXheeUzyfRo1XS819xvm54yA=; b=jCwskUvU6DB9nHa8wTo+Xis3iML/jKziVh7nbCZz2oOzmIp+scOnNsykCXylkGjLaI1ThDe+cKJdVCk3vyHPjFV0MyCPImid5LlGlT8QEjR2r7SGgOPwYISgChVpUSXNtYqWndkqZY7vVEMUhUa/c5MdsP3w+9vibjYqq4OeXbWwBiewx0NXGp+6pZa89AFBe1/HLLE3Bra7d1IqDua/5Pdd7wRLMtAm0qcGMWGGf5KosHzU0cuontZN2vsuPInRu1LkjSI5RLLY4gS30eeizD3U6jpTsOVIEhZSQ4YzYsyKb1Wo+Ojh5sKE6mgoKlsrU+morUnLXj1haIYVnZGkew== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by DBBPR08MB6105.eurprd08.prod.outlook.com (2603:10a6:10:20d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.10; Fri, 4 Sep 2026 10:12:28 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0382.007; Fri, 4 Sep 2026 10:12:28 +0000 From: Andrey Drobyshev To: svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com, den@openvz.org Subject: [QEMU HCI-8.0 PATCH 14/15] ui/vnc: Fix qemu abort when query vnc info Date: Fri, 4 Sep 2026 13:12:04 +0300 Message-ID: <20260904101206.701978-15-andrey.drobyshev@virtuozzo.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260904101206.701978-1-andrey.drobyshev@virtuozzo.com> References: <20260904101206.701978-1-andrey.drobyshev@virtuozzo.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: VIUP296CA0052.AUTP296.PROD.OUTLOOK.COM (2603:10a6:800:34b::10) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|DBBPR08MB6105:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ca1e792-f399-4fdd-5af3-08df0a6d03c1 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|23010399003|52116014|5113699003|18002099003|22082099003|56012099006|10067099003|38350700014; X-Microsoft-Antispam-Message-Info: egAyOtfPv43kUTPIV1EGNDOtQfRY/2WxNgvEdDrAvp8K7Qd04g4oMJ2zwli8wRg0uSqjDyXUTpNiW/dcpspifhw54a+Fyj1bOjBliEvh4w1FXS80O4ibcV4casx2Xwx1ay5ljsTmDovCDvizSBMp2flr7j6Zal6EthF2cQloz1rKlMV0oxIgmbTu+iTlShp66uCRfOF6jyhpyEZrAKrHAfWi7Dvxxhcl3ftJEDi5JfWJUt+TiDmGFMlMC0qU298PwFGa3shZex2D+R9k2w6ONu9Rt2saHv41IfY4a1hnVy+Ym+PH4JBydt91m1pHNeT0XmmeF1g7WGiBRgDumuNj5nIIXkLLcZ4ou2wKR0BVS4KJ/+O4LQn4O8beqSw60YyZAPWzS76Mq7sh6k8lxxJmG7gxhJ5FYxNvnOKF4FbMmRZ69y/rFq1C1/R4MJu5uV7h/a5meNJxIGuCLXubn+7Icsnf80bQjZxEzVrsOs/TJE68t4rLVACwQ8vLdYPd6ybquDRfJUdqG63DCCyH6Ajqqe/PC7RgDSyEKKoMzAV4+HlemnfV3tj/bqyPUWDSyfZcjemMmpBPvQZaRPM8ykJNBiJgecH2ORCeFO5MS4SQLSMt9BZR4whXxgudZIf6BsCvv0k5LQiI8QZ2gRnKXdCNv48uCyCw7UGM4yd8OKOmKOY/YTfKfh2hDhetx+kEYQx1Z+XcrJWksUJoEZx3Zi5gAAietaBmublxJSOnu8S0ZPE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR08MB10656.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(23010399003)(52116014)(5113699003)(18002099003)(22082099003)(56012099006)(10067099003)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eitJeVRpSzBZNWFvNmVnZWZLOVg2M1Q3WU15RkcwVktIMUo5amlkYWwwcnBS?= =?utf-8?B?NVY0WkJSbGhYOUxNT3ZLaitibkxiUm4yaWlDeGFtWWQrbG04aTBJTkFyMTRm?= =?utf-8?B?ZVJkREc5dWVYUWtHZWQrQmQrdGZZZHE2MllYd3JFcWN0dU5sRFBNVmlOamRi?= =?utf-8?B?NEJ5QWEvd2VkS0tRTXNZUGRIQ2F5aWh5NC9GUWVqRzZoUi9PWHNwTzA2alVu?= =?utf-8?B?Vzd5R2w1STZmOFIwWnZpQVZzcFJlL1JtUktLNjRDemJROXk2QjNLS1Q2NHc5?= =?utf-8?B?VEZiU2Jrb0xSOGt6Y2NBZEtYQ1pTdHVNWGVjRVJXSzVlT3JiSUhrQjU2UzdZ?= =?utf-8?B?LzdyWERnVVBLOGZwU2gzekZwNjU5MnA4UDZZdTVDMVVMSTJzazRiNk9GSVlU?= =?utf-8?B?Zzc0cDFuVEhURDFGYlowT0c3NC9SR2pjQUFJWFJ1L0MrWEFHNEZFbkVsenVG?= =?utf-8?B?VnpNcUJUeW9CV1MydVMxRnZoeGJybEdlVUVxUTY3dFZKdWJTemlFNDF3bDF2?= =?utf-8?B?aVlnbHA5ZlNiazJCNjdzS05HTmQ1V0I1aUI0OFNYcGQ5U2laQmJHWG5wS1Zh?= =?utf-8?B?L3ppb00vVmlvWmJPay9QWDdROHBqTmJoVHIzWUJ5MmM0YXd3THJPWGdvZXFE?= =?utf-8?B?UG5xbUNyajh2TUtoa3lqYjIvWUh3N0RUcmNUTk5qdEE0Zlg3S0RkWjlJNE5q?= =?utf-8?B?VkpFTFcvdHpNRWNTMGt2blVFeC83WHd3clFieGY2c3RaWnRpMGx1SFd1VzlS?= =?utf-8?B?RmtFNSt1YVRRNkswOFIzMmU0aFRxSUJsU2NkTGgxa1lRSG1Va0F3VFZCOGJk?= =?utf-8?B?ckp0L1l6TkY4R2pqejhibk9ySWRsNkJLbm8rb01DaWxGanp5YWZ3cXBqVm0r?= =?utf-8?B?dFVUczRLVFc3Ym1UQXV0NVRsR0VxZ0Yrd3gxalNPZHdSVGp2N2JvcEx6VTc5?= =?utf-8?B?ZFNmbUptN1lVeVc2NjRDUGMxZEozRkI0VHdrVmdWUndiZ3JvNjRQOHhEd0Y4?= =?utf-8?B?RGkxdmlvK3VhRWRzUFNWS1BtNHlEMWFLcGEvb2lhUnJJc256QlBoTTFJdzU4?= =?utf-8?B?ZkRHNERFc3F4QXdLV1lWZU1aeWNGWndGUm4xamJkYWZCUitFR09wT1hLamla?= =?utf-8?B?RVhZbWlSc1ZRdU1iUXBiVDJwTGZCV2Q2TG9KOXV6V2p3ZXNEeko1WjdBR2hs?= =?utf-8?B?QktGMFMyYWpqK0FiLzUwME5OK0xUYmZ3MlRFSUFwR3ZMeHhMbFFpa05iT1dO?= =?utf-8?B?N0lUcW1UU0g1V2dLbXJiTkZ6Y1I5LzdGWmlwUnh3VUVOWDNDamNJcHYxMVNt?= =?utf-8?B?RzgxdkNrUTA2UjZ1Q1VXdHM5aE8ycnNKVWUzaWgrTnVyMDVyUjMxLytqZEJW?= =?utf-8?B?cDdyMVJSRmZKMDBsQ1hzQ2N3TWdRM2RMMlBMZmpMR0ZINnRFQ096T2V6RHA4?= =?utf-8?B?aVkyNmJaRE1uSG44SXpzMWMxcjUvVnBZVm0rb2ozanFvMFM4WGl3blZvaU1h?= =?utf-8?B?NXpKUVdnMTVIOVBta09oU3d6UU5KV2g3djQ0OVJ0aGlZbm1wekRUUlJ6R3Zy?= =?utf-8?B?L2FUa1RLbzdoTHlSekxWYVQyWmYwZ3FwQmJhelFiSmpEcHU4a3lnR1FxVVV1?= =?utf-8?B?TlA5UzlKanhGUVpybCtpWGJtSHN2SzZUNVBBUnA1UzFMYU03ZEUxRjF1VnRS?= =?utf-8?B?MDVpM1hnMFJjNjZLekVBR1R6YmphUGd6Y2d5NXI4V1Nxb092YVh1M3haOXg4?= =?utf-8?B?WFJiZGtyUlZwUzVXUEVVWEd4dHJrVHNONkloUGRFVUIxZWZiWldhc2J5TjRX?= =?utf-8?B?Y3ZaamJ5R29zTll0WXlNdEQvUzg0bG9HZURYQVFMNlE3aWYvR2I4N1BMUkVk?= =?utf-8?B?a3RNV29ZdUpmMytGSkJlTitSYTFmMTZpaHM2dnFoQm8yeUkzSHFoU0dHODdI?= =?utf-8?B?NUtDK1lsWlBvcGFqMS9ETkovV0R2UEkraHkwam9rY3pyN0p0MHJmeS9oODVB?= =?utf-8?B?V0lqcTZaMDg5YzE3WHN5TmZMSlNvdHo5TzRkUm80SFdtYzZvU0lpK3ZISG1N?= =?utf-8?B?eFoxWVZwQ1ArRG4wY28ybCs0MUdqMjI4YnN1SUFtVWEvR3VvYjZadlVYQzUx?= =?utf-8?B?R3dCeEZ3T1J0NmtHNktLMGQ0ZmJuRWFmSDIvWlBiRlI0b3V5VTMrbHc2SkdJ?= =?utf-8?B?R2VveWIyUWt2QjB1NTh3ZTU0VXIzUXZ4cDZBVzBxRE5jNWFVaVBNZmpUNmRF?= =?utf-8?B?Y09EOFZJcSs1RHJ5ckJMdTFpQVoxaC9oMVpNZVJubnRsN3M3SkdIRWNFaUR5?= =?utf-8?B?aGlwckEyK1pBTUJnOEFCanZIRms3RHUyMlpaTHBTMHBqSjNUdFVCZ3I3Y1BZ?= =?utf-8?Q?9+4R9CFscltLSYHI=3D?= X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ca1e792-f399-4fdd-5af3-08df0a6d03c1 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2026 10:12:24.2256 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SJsthPz1NeGmAzAlCp05XNDwBsmBdEhXRcHj/y4jgWy4hmsnxjAZSMd2FdrGjfQZLbpxSvwbZ1IIMKgwRh6rnLGxckJ5cgOsRzBMK6OsHZ0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6105 From: "AlanoSong@163.com" When there is no display device on qemu machine, and user only access qemu by remote vnc. At the same time user input `info vnc` by QMP, the qemu will abort. To avoid the abort above, I add display device check, when query vnc info in qmp_query_vnc_servers(). Reviewed-by: Marc-AndréLureau Signed-off-by: Alano Song [ Marc-André - removed useless Error *err ] Signed-off-by: Marc-André Lureau Message-ID: <20251125131955.7024-1-AlanoSong@163.com> (cherry picked from commit 4c1646e23f761e3dc6d88c8995f13be8f668a012) Signed-off-by: Michael Tokarev (cherry picked from commit 13aae93f72f304235d46950b05e71b3267456771) --- ui/vnc.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 016a3b0eb45..b9369dbe21c 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -555,9 +555,12 @@ VncInfo2List *qmp_query_vnc_servers(Error **errp) qmp_query_auth(vd->auth, vd->subauth, &info->auth, &info->vencrypt, &info->has_vencrypt); if (vd->dcl.con) { - dev = DEVICE(object_property_get_link(OBJECT(vd->dcl.con), - "device", &error_abort)); - info->display = g_strdup(dev->id); + Object *obj = object_property_get_link(OBJECT(vd->dcl.con), + "device", NULL); + if (obj) { + dev = DEVICE(obj); + info->display = g_strdup(dev->id); + } } for (i = 0; vd->listener != NULL && i < vd->listener->nsioc; i++) { info->server = qmp_query_server_entry( -- 2.47.1