From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020089.outbound.protection.outlook.com [52.101.69.89]) by lore.virtuozzo.com (Postfix) with ESMTPS id A5B3C80266 for ; Fri, 4 Sep 2026 10:12:32 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wT0OiesZ5OGEpSijgmBqm2ahEjtHNZWyWyu8juBrLPvm/sjiBiFXyAjc+aKw9hIpeX205FFsfeD3q6xCYJAU/De83rYLQDQwyVNsQ+AUUgu2GLLv6Q6xaQNr5Ew5g+FJrTmEgEk2ULwvv3ApKk7v+4gbqa543hhptkZLlOjyGqCbrGsnhq9y63SCQTwxKZoMH3FiQds/AqQl1lSIemJr0Zom5E7mMmgFXRrdgUJyqZQNOMwvr3llDGagRoO3cSvcJqKgrXq5PGAxLKgDe3/JyAPlMKNs0PTaryH1jW5r0cp+Hz//6JZCGgj4EL4UkTje7BC4EXwIZ/r0WC7nWSbnGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FIa0MoJGAM6uxWmpdDIwFORN5IG0805NUus6op/NweU=; b=kRI6oDx/3wopIgsdmqX/+VzOU+CPlageYT7dQHbZEyxOYSzX38Ecd9/9MTh9c9Uqy5y5wKFzEqY8s+NThYEaaUpnH2l67shL2BcaOR6S9dLF9b0d0EL/BFhAlLMfEIFKrQN9EeSF/RxEeicQYCCaK4SEod8vmth59zC6OUbjzPq5NZPHwJlLqWrfghCWXpYYPWgwdb0uFA9ox866YzWw+1NkONzoX1Hci0D834jORAFFHXBDTn01lwgmILxOXI4+yeDcJrV7aYjhZmyqQHl1HLJKxw0AMNB6OOGmpEouwycV35AlK9X14l7AFnl6QT9zlr/tSOK3880OuJhWRqHe7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FIa0MoJGAM6uxWmpdDIwFORN5IG0805NUus6op/NweU=; b=rILgTL1vsQVV98ZYRfCy3NXuRyhejvqrkhf8VOT8v8kSvozeyJ0wroTpMGauVj+HgjU+uRY3DAHvZW676wyKA6U7z7d8qimEjxdvdemX+Xig+bg1Qged1c+mLVhLXiqjk6IXoA2SnjVXGHpifJfkz4K0xmkb+l/zOu0suudgs8HN1wfe3YPGmcAnthumjo4XoLdO/whHFruCDiJbrSgDHRCRrZOeHSEiwMMepVlMW7rIH2GFvTTQx9njskJBEWLyRvq8ms9kK58a3RHojaHzWtNO+03Ku9Y96XX3npXia9E4I7hrx4lxyozAOjfXSs5w6Nj8WIR0K5pR8b99SCZuzA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by GVXPR08MB11399.eurprd08.prod.outlook.com (2603:10a6:150:2e5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.10; Fri, 4 Sep 2026 10:12:28 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0382.007; Fri, 4 Sep 2026 10:12:28 +0000 From: Andrey Drobyshev To: svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com, den@openvz.org Subject: [QEMU HCI-8.0 PATCH 15/15] ui/spice: fix crash when disabling GL scanout on Date: Fri, 4 Sep 2026 13:12:05 +0300 Message-ID: <20260904101206.701978-16-andrey.drobyshev@virtuozzo.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260904101206.701978-1-andrey.drobyshev@virtuozzo.com> References: <20260904101206.701978-1-andrey.drobyshev@virtuozzo.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: VIUP296CA0052.AUTP296.PROD.OUTLOOK.COM (2603:10a6:800:34b::10) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|GVXPR08MB11399:EE_ X-MS-Office365-Filtering-Correlation-Id: b43f1c2f-3b7a-4ea6-bcba-08df0a6d0417 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|376014|1800799024|52116014|38350700014|56012099006|10067099003|5113699003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: CAVs2qpqxVeT+JHtN0lsWZtYzZTcflbgrOn8ze+Z0hSlxv71Hwg9JAEbsKO0z7JuvHq93e8Dn9t+iMiBi1ysa0Rg7BPREBh39VXDDB6I4/pwAQtiUPAbdWasmB+sJ+ySvskJgSIcWWpqXjYAPEajJ1y2T4qEr9+rXyNVq/fCkV7AurI9kz32knN38atcn1J1ZlQYCJpyz3LSPDxw2V/CMbAn8nlFBkWhmX46GSpbPm4LglL4UMdgBnf7eofpuGnqbDfyr1aC3ZAa8hGlJXUaToJy1YieTpfiFwbVfV+EJAmAl1bWmH3j/mEQpoBHRyqPMnViHOha1OuDwoiEM27gyaYQvyYp24ui26A9vblnh2xoYOEZsAmNiI5T2qOI2ZcisdPPrDVGQyH+w4TS+TEvmhHsARo+xNSVhNiJp+4xLdAhsOaOIEl//gD+C38vhKObq3JUdzGdLKSQA6gl+Thb1PxVuAcz54whM4JLvp5K6SLLJRt6dUg2tlJIzBMTjhRVowYOi+nNz8/znSCN0xU1itBfZ7SUamVcYaV/eCyPUU5+QEFG2ByGF2ZKFU5p/N+nJ9ADXKptmQ6MVzZjtIyIbjdPJWPJlomOZTl4DoE/cxAjNE2izg3EjBvMwmR+Wco+UGyA4o0i6bIxFBjZkaFQ10jY0OWcjBkoSt24Ze3N6DM4cb92p30gPGFovGhstJhRpf5kiju+aCPiFn+ChXngoxTxYbx8LA5E+uLyZqbf9xU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR08MB10656.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(376014)(1800799024)(52116014)(38350700014)(56012099006)(10067099003)(5113699003)(18002099003)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aTZZQk9iMHJZaVVXMlFSMzZGVHJTckMxc1BMRDdNOXU1MFhBM3ZnZWMvSmZh?= =?utf-8?B?Tk5nbTg5Tm9ReXloTGlXK1hzNGRhQ0RWRE5wVEZ6VmZQY1BwUGUvNmJzck5N?= =?utf-8?B?T3RSU1o1UmRsazZrTzl1WjR1c3k0N29rUkJ4bk5KbmxsUWxMYW9JdDhUWFQz?= =?utf-8?B?eGxzcHJXb0sxbmJOS0RyMFVPaEZpWmZTcjVyOEFmemhlcHJrWWQ2VmdKTkt0?= =?utf-8?B?VHZBUmNpTlJFM09RMWs3cjcwZlNaUSs3TWpFdXdmRnhZOE5OOUdXbjNhTkQ2?= =?utf-8?B?K2hLRjJrcFJWZlNocGY5Z3BBWlRCVXIvUFV2QmsyYXd0bFhqRExKSHZJcnFS?= =?utf-8?B?cGFseExHQ05FV2NweFJpczZ2RnZRRVJVdERBMnpNcVZGRktYRFQxZVMxOTJq?= =?utf-8?B?YXptbWVQUy8wVnYvNnlzMlYxbTlYbHEvZVpPVExSZ2p2aUttRlFtVXpxdlJy?= =?utf-8?B?NlR0am44cWFzZlNPSCtLdE00Qk5zQWJhZWNlc0QyUVIwWFhDME9uR3U2M1hi?= =?utf-8?B?U1JoZ1hyL1piSTdPeGNDSlpjeUVYVkp1YW1pYkJrR28yWWpBbktXVHZ4cGNL?= =?utf-8?B?TmJVS1NXVVJEclRBNzJiVGF1OXl4SURkZDk3ejNZQXpyenNpeHVJUHByVit6?= =?utf-8?B?cXBmMUY3Lzk0T2RrdENGS0lJdDVzNnk3YVA3UW5ZOEdFR1owcXBmRllrZ1pH?= =?utf-8?B?ck53T2JuN041TEdGN1VpSEpHUS9uM01Xc1RHWVdjbjFldXhvSlJnL3lPUTAz?= =?utf-8?B?K080MFhlcTQ0b1pEa0ltYlo0cVBHcWN3MXoxeTFVR0VoVE12S0locG4rZkdX?= =?utf-8?B?MXgxblVsU25wbW5qb21rRkowMGdrVFlSQ2diOXlEcHBZdjdPeFZsRkYxNHJJ?= =?utf-8?B?eGJhWWRrRURwK1hmMW9JVWZRY21MWmdZdVBOUURKOXZtNDI3SmcyZGpCSWUv?= =?utf-8?B?cHhlSm9RZFg3cENza0lkYzJ2anBRZE5DZmRSQytLQXpKNzU2ZVFicHYzdHFs?= =?utf-8?B?UjNXUmV1TXBtN2toYjVrWk1LeVpjTXFYeHBSUVpOc3NYWVc0ZEUwTEE1ZHoz?= =?utf-8?B?bUR1RDc2cmxNRXRxaSt0Zm1sK0UvOU5hck50VFc0WUtiMktYTkhXR0N4ZU8x?= =?utf-8?B?STVEc0g5VFdSeHkzaFp5emYxNHJJOFozN29hMjJNZTJ2OXFCc2NwZGJHYTZI?= =?utf-8?B?L3kwU0VZbzBRcnkvcmxSd1E4b0J0ejdMMG1GVXNoMzV2bTdrZ1pXY1ZxMnQ3?= =?utf-8?B?QUdEZU83OVBlM2tNRU9ZL05ITll1dldHdUh2YS90QkMrYUM2VnNVWmFyc1RT?= =?utf-8?B?SE90cURmaW1FUHZYZGt4TnUrZE9kVlpseHJKcTYyV2lGTU53cVBwTEgwNmhZ?= =?utf-8?B?bitJeEhQSDNrU1p6OWZhQStncmRQcFg1NmtHTlNiSW1LbWoxbEpkQTBHd0pR?= =?utf-8?B?OUN2K2VnSWVIb05ydFhGR1NDVUJ5TnBMT2hRakZYU1FEcGFsSHlLNzlKR0JI?= =?utf-8?B?ZEh4bzNlYWdJdGNwNDJKYkJoY0RMNko1QUIvb25zK1ltMUM4YTBWVWliOGVr?= =?utf-8?B?Q3M1OEFaWjBZUVFyK3B5UU5EbU5TNk83Y2QzcEdrU25ZMEVFT0gzKzFvQVMv?= =?utf-8?B?WnF5QmlTR0dNL3piWTRtOVpXbkRpZnpDNFhtck5HaEZOQ21oNzZLVzlPT3A4?= =?utf-8?B?N3JRRWVjcW51em04cmZvYmVtSHR4Wllhd2YrOWsycm5SWXhBNmtXY3NURnpx?= =?utf-8?B?NCtidW9sY1g0VFZWMFYrK1E5WFZHOWpHWi96YlNGQWsxV3VPSVpTUDBrMUlB?= =?utf-8?B?TlFkZVdIRWxXU2grTWxRNTRRa1BXT2VDekFiZXBhbXQ1cUFDZER6RkhrTk96?= =?utf-8?B?K2phZCtHZWRFeFJZSUFKVVA5OFNQYXVkbUNERUdKYjhETWpOazRsYUdYUXQz?= =?utf-8?B?a2t0TGNGVXo1b0srQ3h2WjZ0UHVxdXI5WGM3eU0vZFZTZ2lqejBsTkFzeGRI?= =?utf-8?B?NXA0dThUdFplci9WeEVDdmpNblN0MTRnZG8vaFVJVVRoOU1FQzJQVjhINGlX?= =?utf-8?B?OVdqSWhzUEtrb2xOeGdYUDN0a1dTTDkyaTVNeHc0clplN3pMM3l4TnZDRi9G?= =?utf-8?B?endFZHFTa0ZVdnd4N3hTWFJieTRkOUJscDlsU0dhSFpxWGpsM040K3Y1Qkph?= =?utf-8?B?ZXJwYk01VFBKZ1EzaTdrUkE5OFNKVXhSNklWRVhUQTNRdmxFdW10UStTVkQ3?= =?utf-8?B?bUo4OWF2RFhQYlZwWGxBWW4yakdGMjd2SzcvaitPQWNCUE5UVTkva2I4YXpx?= =?utf-8?B?NlNOOGZ1VWs4Wm43dkI5MlFVazBCb1dmd1UrMG82UW1pWGFFNFR5d0NJQm5N?= =?utf-8?Q?oK0y/QgEb5Uvk8yw=3D?= X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: b43f1c2f-3b7a-4ea6-bcba-08df0a6d0417 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2026 10:12:24.8828 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hZ+hqYi7ljWy7XMjO7Flnka8QPITc8P3I1INE8sqet4qpQ3B6gt6qb5ICi4ThAX+zM7HzyzXNkr8qta+yb0g1HXy+Pgaxvv8u4okavj6fAw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB11399 From: Marc-André Lureau When spice_qxl_gl_scanout2() isn't available, the fallback code incorrectly handles NULL arguments to disable the scanout, leading to: Program terminated with signal SIGSEGV, Segmentation fault. #0 spice_server_gl_scanout (qxl=0x55a25ce57ae8, fd=0x0, width=0, height=0, offset=0x0, stride=0x0, num_planes=0, format=0, modifier=72057594037927935, y_0_top=0) at ../ui/spice-display.c:983 983 if (num_planes <= 1) { Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2391334 Fixes: 98a050ca93afd8 ("ui/spice: support multi plane dmabuf scanout") Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Reviewed-by: Michael Tokarev Message-Id: <20250903193818.2460914-1-marcandre.lureau@redhat.com> (cherry picked from commit 62fd247a24290dba2b2de4ee8575624a7993973c) Signed-off-by: Michael Tokarev (cherry picked from commit ecc1aef81eafa53b7267fb4d93aaf2eb6a1e3d5a) --- ui/spice-display.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ui/spice-display.c b/ui/spice-display.c index 669832c5612..db71e866f89 100644 --- a/ui/spice-display.c +++ b/ui/spice-display.c @@ -980,7 +980,9 @@ static void spice_server_gl_scanout(QXLInstance *qxl, spice_qxl_gl_scanout2(qxl, fd, width, height, offset, stride, num_planes, format, modifier, y_0_top); #else - if (num_planes <= 1) { + if (fd == NULL) { + spice_qxl_gl_scanout(qxl, -1, 0, 0, 0, 0, false); + } else if (num_planes <= 1) { spice_qxl_gl_scanout(qxl, fd[0], width, height, stride[0], format, y_0_top); } else { error_report("SPICE server does not support multi plane GL scanout"); -- 2.47.1