From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DB5PR08MB10215.eurprd08.prod.outlook.com (2603:10a6:10:48b::7) by PAXPR08MB6942.eurprd08.prod.outlook.com with HTTPS; Wed, 16 Sep 2026 15:24:57 +0000 Received: from AS9PR05CA0215.eurprd05.prod.outlook.com (2603:10a6:20b:494::33) by DB5PR08MB10215.eurprd08.prod.outlook.com (2603:10a6:10:48b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7; Wed, 16 Sep 2026 15:24:54 +0000 Received: from MI3PEPF0000855D.eurprd05.prod.outlook.com (2603:10a6:20b:494:cafe::49) by AS9PR05CA0215.outlook.office365.com (2603:10a6:20b:494::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.11 via Frontend Transport; Wed, 16 Sep 2026 15:24:54 +0000 Authentication-Results: spf=softfail (sender IP is 99.81.216.78) smtp.mailfrom=openvz.org; dkim=pass (signature was verified) header.d=openvz.org;dmarc=pass action=none header.from=openvz.org;compauth=pass reason=100 Received-SPF: SoftFail (protection.outlook.com: domain of transitioning openvz.org discourages use of 99.81.216.78 as permitted sender) Received: from nat.eu.perception-point.io (99.81.216.78) by MI3PEPF0000855D.mail.protection.outlook.com (10.167.240.25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Wed, 16 Sep 2026 15:24:53 +0000 X-PERCEPTION-POINT-VERDICT: CLN X-PERCEPTION-POINT-SPF: X-PERCEPTION-POINT-SPAM: PASS X-PERCEPTION-POINT-SENDER-IP: 2a00:1450:4864:31::11 X-PP-Forefront-Antispam-Report: CIP:2a00:1450:4864:31::11;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail-wm2-x11.google.com;PTR:mail-wm2-x11.google.com;CAT:NONE;SFS:(13230040)(82310400026)(6059299003)(12012899012)(43022699015)(2092899012)(3072899012)(5063699009)(5023799004)(16102099003)(22082099003)(18002099003)(10067099003)(19002099009)(57112099003)(55112099003);DIR:INB; Received: from DUZPR08CU001.outbound.protection.outlook.com (mail-duzpr08cu00104.outbound.protection.outlook.com [40.93.64.68]) by inbound-smtp.eu-west-1.amazonaws.com with SMTP id agr0h7dus9nedkd6e8dph6h26jakir3le95dlp01; Wed, 16 Sep 2026 15:24:50 +0000 (UTC) X-SES-Spam-Verdict: PASS X-SES-Virus-Verdict: PASS Received-SPF: softfail (spfCheck: transitioning domain of openvz.org does not designate 40.93.64.68 as permitted sender) client-ip=40.93.64.68; envelope-from=den@openvz.org; helo=DUZPR08CU001.outbound.protection.outlook.com; Authentication-Results-Original: amazonses.com; spf=softfail (spfCheck: transitioning domain of openvz.org does not designate 40.93.64.68 as permitted sender) client-ip=40.93.64.68; envelope-from=den@openvz.org; helo=DUZPR08CU001.outbound.protection.outlook.com; dkim=pass header.i=@openvz.org; dmarc=pass header.from=openvz.org; X-SES-RECEIPT: AEFBQUFBQUFBQUFHZ0NDUHlTOXMzOE5QQnRndDF4UGZtYmhNSEpvQUtpU0lKMEZTbHVaZXRCWEYrbVQ3NDduZmg0UWoyWnptVTdNZlJRMDJmQWEyV09wRVRCT2xaVWg0NmdTYXBCVFlUTkJkcXFra0ZDMGtqM0lQY2dFSkl0MkFBb0RiOWNydTlmZXBjWmZtT254Ri94REZFdEhDdjAxUTV6cTAzclBUZUJrSHliTzR1YXZsZng0c3RvRTl0WWJoT3BnQ2YyWUJzUnRoVGx2bDVyYmQ1S0NLMUUxbUVUUkNhaFMrc1BCZnpkYVh4T1ZLK3pRL05XZmRRSEpqVTBmVCtpN3puVFYxdnBYTFE1dHdLcGRkSGFZdCs5RXppaS9Md3V6UG84ZTNneDBBRmxOV0M2MjQ1Ync9PQ== X-SES-DKIM-SIGNATURE: a=rsa-sha256; q=dns/txt; b=xJ8/Kj9AAZMBabdkjgVaRYSjpsiDxrSOY+Nbx0zL5oF2+4mNGO/AqCguwtXFAChdbMaw+2zMqV0SLXJ/+PBlx8IiUnaiiaKyvuEFYOex9Ssr/yjhGOshiCSYnnbXAany5Yq9RXs4DJYiDpT4jLQrT/DBGjmiAJPMbjrdhyVyGOo=; c=relaxed/simple; s=shh3fegwg5fppqsuzphvschd53n6ihuv; d=amazonses.com; t=1789572291; v=1; bh=fiXRwEglNQOTkG4wjzHaZ0bNTXXAk1Qf6Dh5jK1Cayk=; h=From:To:Cc:Bcc:Subject:Date:Message-ID:MIME-Version:Content-Type:X-SES-RECEIPT; Received: from DUZP191CA0016.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4f9::15) by PA4PR08MB6079.eurprd08.prod.outlook.com (2603:10a6:102:ee::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.8; Wed, 16 Sep 2026 15:24:46 +0000 Received: from MA3PEPF0000040A.eurprd04.prod.outlook.com (2603:10a6:10:4f9:cafe::21) by DUZP191CA0016.outlook.office365.com (2603:10a6:10:4f9::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.11 via Frontend Transport; Wed, 16 Sep 2026 15:24:45 +0000 Authentication-Results-Original: spf=pass (sender IP is 2a00:1450:4864:31::11) smtp.mailfrom=openvz.org; dkim=pass (signature was verified) header.d=openvz.org;dmarc=pass action=none header.from=openvz.org;compauth=pass reason=100 Received-SPF: Pass (protection.outlook.com: domain of openvz.org designates 2a00:1450:4864:31::11 as permitted sender) receiver=protection.outlook.com; client-ip=2a00:1450:4864:31::11; helo=mail-wm2-x11.google.com; pr=C Received: from mail-wm2-x11.google.com (2a00:1450:4864:31::11) by MA3PEPF0000040A.mail.protection.outlook.com (2603:10b6:140::19b) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Wed, 16 Sep 2026 15:24:45 +0000 Received: by mail-wm2-x11.google.com with SMTP id 5b1f17b1804b1-49e7bcb94d3so8367435e9.2 for ; Wed, 16 Sep 2026 08:24:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1789572285; x=1790177085; darn=virtuozzo.com; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zecoH/JdEAUxAWOqDTMmGBEzTZ6W20gQbKtrExW4/J0=; b=Nt6RVRYMuvhjY4W61c6MaomJoypncowq9II8GKbcaooPL/5Tver1J4WRPAHybNq8Os TitPnLAdGaekJmhrQWG8L8q/jUGrxJi0yFSVO08sMgqfOETVhQUxBDnfL0ol9kpV/tmz gjTgLyMApJ6U8oS49x2nlfK/H1aLkEb5BBuS05M1xKtuIByHZo1DnU8YUoJBcsOnPbFy kuIYMg7rK7fJFKEUQ1klKc80OxLKHDrGyLtqiFrh9WqAx5i5JV2sB/6ySA+H5nEFjiaw /TE0DT23yU24u/AcqCX7LsoJP1hBG+uel1d1eFSu+fASc5gOsGN/jG2kvH2Qdy1ES4Re cSNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789572285; x=1790177085; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=zecoH/JdEAUxAWOqDTMmGBEzTZ6W20gQbKtrExW4/J0=; b=VYvo0S/2HIl3MxUmvWYBG1HZH8wy10IUccTMTVV30iAvPghGEV0Z1tC78cb0/enu59 aImDaWY+vtMVWY/AcVdprfTlJXeYrFtPvF4vEvJZ+Tk81SoGtsWTHItWPQ8jQQF+eh+G sRc4mqW3xpGjBOlLz7tBIL7VJMudjkpOHPhmDZJUF9644K5/OFS0V/SVSH40bxoZ05pV yporFmMUXKncrzcJ704CI725w8t1P3iG88x7zJYso1eyo6uc9oWyfEbFiulid0otVT/2 hWovSPBJWtaT7FqN6SdCqLqFE4rqlpgu3u28RbveancNNaZ7xg93BlcRB+Hi3cJ4fo7Z PiKQ== X-Gm-Message-State: AFuF++lMLC/cmHf0lBgILru19ijmn61lcVOWdQIJw/zW/rCNE+1W8oVG Fsz1Qn7nQJhmozL4AhdPUyqEqtt7b6pGjQXpyH75yyS5RY8MablB7qRW/t56sjnDr5IHtgPMWeN uwRFA1RQ= X-Gm-Gg: AYBFou3f8y8v6U1RVkZJt1F7CK1FfoxiYopWXFH4Jm2qjHQXFBD7QAFqdvr2YAI6xjr AC6gRJjsCD9sZgxvHzpWzvS/uy1oJrh1DrpQmR5EyUGdXgRcxLKSC4/qEoiEX4X3s7FYUmxeBZO tJ2R07niEHldvknc42ZnaEvZpnjf5ijcqUntpiuDB+SzBbkI6Ovxvr6+qZBIAehxAvs+z+BTGEa N+YRmmVinoSS6nfdlfj0E0H3/yoc2rOWJjJekl/g1k9wY02sntFLKRaNEqL/Wfmik8d5iMqmysF 8T19Eyp24Ivr2LFJKO4cb3MV3rFUkdwPUVS1UYsV83qT51aF/9KkwNWGBs5cupJVIqV9gXagZfT /p72mjPRy14K1T+4mMMtRkiUkDsqXJJwBT+xdI4PhhKL7JQ8bVca2apF+gB8shWFHFAMEUx9qey xHKcvFPHJLdVRu+NlXhgkFJj1arG0VdkZbaXpcA6//Khn6+qaUGjlIcwJU2dFqWZoVHhnu X-Received: by 2002:a05:600c:548f:b0:49c:fc6e:8cbb with SMTP id 5b1f17b1804b1-49ec0543ce6mr38853325e9.31.1789572285061; Wed, 16 Sep 2026 08:24:45 -0700 (PDT) Return-Path: den@openvz.org Received: from athena.sw.ru ([2a06:5b06:b600:300:f56f:c51e:c53f:b1ce]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fbd0c39dcsm1836415e9.12.2026.09.16.08.24.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 08:24:42 -0700 (PDT) From: "Denis V. Lunev" To: svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com, den@openvz.org Subject: [PATCH hci-8.0 3/5] block: let bdrv_reopen_commit_post() report a failure #VSTOR-140073 Date: Wed, 16 Sep 2026 17:24:35 +0200 Message-ID: <20260916152437.1787889-4-den@openvz.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260916152437.1787889-1-den@openvz.org> References: <20260916152437.1787889-1-den@openvz.org> Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 1 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:1 X-MS-TrafficTypeDiagnostic: MA3PEPF0000040A:EE_|PA4PR08MB6079:EE_|MI3PEPF0000855D:EE_|DB5PR08MB10215:EE_|PAXPR08MB6942:EE_ X-MS-Office365-Filtering-Correlation-Id: 29acc584-9d81-48cc-471c-08df1406a86f X-MS-Exchange-AtpMessageProperties: SA|SL X-PERCEPTION-POINT-CUSTOM: vzpp X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|82310400026|6059299003|12012899012|43022699015|2092899012|3072899012|5063699009|5023799004|16102099003|22082099003|18002099003|10067099003|19002099009|57112099003|55112099003; X-Microsoft-Antispam-Message-Info-Original: =?us-ascii?Q?sEnNTzuGb+UBqOa1YNqe5PFxRPbP19hzTTbeuoNNC1ewU/WR8saHm3aURsLz?= =?us-ascii?Q?BAAQ9d8J8N3xEFmy8qNq2wErle5pmjNXeMsikOCS8tRhiTt5entFG7uAuHxB?= =?us-ascii?Q?WtwBZsj4/Fgn5wEX2ioFnup8CUaOcvu6qyo1CFgraqnTeE/KSFqKvheVrq23?= =?us-ascii?Q?kqiSxrDoSDpkRmIhp/Pdp4U3r2Ed7a2S8k4b2xiC9U2YqwNjlYJxQoa1CqkY?= =?us-ascii?Q?Y22TM+X4AQF3gmPa3jSe2RbuGYp2tobNSQ0V7/DBUOyWTSU+EAsK5zYktyo+?= =?us-ascii?Q?tz7MNN7w3gdwPea/Ngf2AXQDiB/AUMWhYX9T6wboywa7mAczCUrg+BZOaqBY?= =?us-ascii?Q?t9EsQN31c+/nkBzAMY5TwbMBydFkZOL1CwOqiL81unz1QPY63KSkfF7R/32a?= =?us-ascii?Q?lUj6POYTGdq942rhzSZ5EWEW2akYpC8cQRHnw9ceKnQuS0bDJd53jdplaVpC?= =?us-ascii?Q?+A2SF8RFN8+fzJq2e9EnRdpD8IGDzAK5rD0Kifl4IfRPpbtpgAPbpKnUjjSH?= =?us-ascii?Q?wM1uTNn2hYj1BDsPYS5V816pEzX6s6ww9LxD8tLDd57JJiiHhi8l0zzimBcb?= =?us-ascii?Q?BB6vuckUA7auUvhYRVQ59gbfiUjPkq5WWPxBYBmiowX5BkbjS6XPdU8MKzJk?= =?us-ascii?Q?29HFQHlErm5CGlkbDIPnWqkl0injbQWWGbFbbfRW9XElriaUY79nkbU2VKBG?= =?us-ascii?Q?A2+/MCzQrsfi2WR5z8FKozecq0pqJm7rF6eQ7iJCS6OE47HzmLSS8UKC1qrz?= =?us-ascii?Q?ifDMR7cwJaJQAzwLSGej+Xq70UDNtLRaUiBqdaUzI4QdUJENf9pg3Riuywtd?= =?us-ascii?Q?5EjLq/xp7ZgM/tNErsQt0wd2ptdJcXYn2TCO2c3dNwccgL5zgxJaC9O33h3c?= =?us-ascii?Q?r0NoVoBegu5kjZLiI437dOsYtKxyf4IyxgXsgKG/SCYxjQ1S+mMG3bLbkZzS?= =?us-ascii?Q?nfKQocsE2AthaFDwrEEekEJ5wTPXONJB4n6SFDcE3xO9ZVr2cZs3j8Vb6wOU?= =?us-ascii?Q?44X/xst77q2PY9BxAS6YQOeNVN1P0EvZfTy1QaxfJav66hGZZYN1B2VXDB+c?= =?us-ascii?Q?pr0KSnJYAaDNa+mRQC2Lqd40wScrPJGXEv1vlAREOk0WKNio8L+yRNv3g9cG?= =?us-ascii?Q?tAAHAytUVMdtiOl+Hsj4oH7DNnCMQNS/W+pJD5K4TO2Wd/XMxQPBtfBD4HWX?= =?us-ascii?Q?DLpQMTVMgemNrSDGjYSoNzFf8pTqKS+1b/cnjA0gn/SdthUTeBD30Y0FpM2q?= =?us-ascii?Q?yT1SFDjV50ejYXVKwz+wOykyVIv4LZtxxRUR8sPCuDrfOt2J0jCGNDje+D57?= =?us-ascii?Q?UdLoM1R1JcIfq7wI2GsbCQMRwCNMlolsKrBi9zEJR7GOLNNvZsp+BOYBb0BC?= =?us-ascii?Q?3bubL3kubBPVQvs6DR2rIQ78k0HqycarB0FvZvUuMQADOkTnyKJQGKVTiwKI?= =?us-ascii?Q?hRlWnzOIeWtaoF4IosY9LLY/zsFgiXV/S9jPiVWLcNcC66+AxHs6qve2gCsY?= =?us-ascii?Q?buw4B12s0hsjcq4B7dPJwzCdhpZZPnpc4sBvKTCClDo01IdXUky82jGYUx0w?= =?us-ascii?Q?PT27RVSnAn3sxulb/n+nu4WrwuVUA0f5GNYG0cYG9G/6/NVrMyTFSaQX1qD3?= =?us-ascii?Q?MkEOteRAJZ5qsZjvlfBCITqs+x6Q1MTwJMFjZoptaChPtd9LhUPG1MVeuqlj?= =?us-ascii?Q?xasXY6qsWp2dibZ6Jx3Rq5+589U+AgvFDkrkJ2VQp8YVxsOugQLiuUgT2v7c?= =?us-ascii?Q?wwXnnKcP+8RoKYSJIBa5Iha1zXdEXN5nnNByzNlpTWEdvlGOeLy/rm860SOl?= =?us-ascii?Q?AK6g6v1V+HGgxoxz/9f+BRrZTCN0Rsb8ZxVYZFmrOllAyoOagGyZmMMzFCPn?= =?us-ascii?Q?nZliQviRGzwhhPb0nn3FQ05IKiy+L6Ww9mxgy37eeoP33D/M9+42tMmrs9Em?= =?us-ascii?Q?LwlFMaw1qQCVyaFadJkebp79N6lKy4jjI1hW55ekGsTEPpXddEtEJpQ86ebS?= =?us-ascii?Q?tbQXyQu5AyRvS8KdmCMijAk6MUko3iEsYUWqkxR9S0tgF3OxYOeWq+Fi34AX?= =?us-ascii?Q?O1eS6Kc74H2zLBA3Fe+9D5ga5V2ce6DNYWVZlXNx0S3KlfWMsinD4wvhn3wd?= =?us-ascii?Q?6vMLEeHIypcA?= X-Forefront-Antispam-Report-Untrusted: CIP:2a00:1450:4864:31::11;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail-wm2-x11.google.com;PTR:mail-wm2-x11.google.com;CAT:NONE;SFS:(13230040)(82310400026)(6059299003)(12012899012)(43022699015)(2092899012)(3072899012)(5063699009)(5023799004)(16102099003)(22082099003)(18002099003)(10067099003)(19002099009)(57112099003)(55112099003);DIR:INB; X-Auto-Response-Suppress: DR, OOF, AutoReply X-Exchange-RoutingPolicyChecked: OGzKU0I7ROM7WElKitrBu9JNN/hCJfvRmftxaMOKhFOR34yIFZOrK4SHW2XWTF73ZI/hBc857S07ZYUfc8LyS4Ecu0/MrtqH5Af4n9hZAMz2C8ZhAeTV2cpS/E4/fyTz4Lm9lUvJ5EgRzgnhxDZIYky5xTtqdauU2tAv127FFBua0UxlM8uGc2ruFt7OtHF6gIQaJ44CqJcraHU8xl/aUoa8M0MyWmAeDFar5dJBXVOpFtx7s92k/TlqXI7A/q83+EXfZtd7KQw1rOhhpiKsUm9PzUUNfoARfZ1d/+GWhSl09TpxsGDv0J+xCzV5et9AKi9q2LimiaDbApupyzXFLQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6079 X-MS-Exchange-Organization-ExpirationStartTime: 16 Sep 2026 15:24:53.8124 (UTC) X-MS-Exchange-Organization-ExpirationStartTimeReason: OriginalSubmit X-MS-Exchange-Organization-ExpirationInterval: 1:00:00:00.0000000 X-MS-Exchange-Organization-ExpirationIntervalReason: OriginalSubmit X-MS-Exchange-Organization-Network-Message-Id: 29acc584-9d81-48cc-471c-08df1406a86f X-MS-Exchange-Organization-MessageDirectionality: Incoming X-MS-Exchange-Transport-CrossTenantHeadersStripped: MI3PEPF0000855D.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Exchange-Organization-AuthSource: MI3PEPF0000855D.eurprd05.prod.outlook.com X-MS-Exchange-Organization-AuthAs: Anonymous X-MS-Office365-Filtering-Correlation-Id-Prvs: 82d99835-6efb-4310-eec9-08df1406a3b3 X-MS-Exchange-Organization-SCL: -1 X-Microsoft-Antispam: BCL:0;ARA:13230040|3072899012|12012899012|2092899012|35042699022|43022699015|82310400026|6059299003|56012099006|5023799004|5063699009|19002099009|10067099003|55112099003|16102099003|22082099003|18003699003|5133699003; X-Forefront-Antispam-Report: CIP:99.81.216.78;CTRY:IE;LANG:en;SCL:-1;SRV:;IPV:CAL;SFV:SKN;H:nat.eu.perception-point.io;PTR:nat2.eu.perception-point.io;CAT:NONE;SFS:(13230040)(3072899012)(12012899012)(2092899012)(35042699022)(43022699015)(82310400026)(6059299003)(56012099006)(5023799004)(5063699009)(19002099009)(10067099003)(55112099003)(16102099003)(22082099003)(18003699003)(5133699003);DIR:INB; X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 15:24:53.1014 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 29acc584-9d81-48cc-471c-08df1406a86f X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MI3PEPF0000855D.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB10215 X-MS-Exchange-Transport-EndToEndLatency: 00:00:04.0374956 X-MS-Exchange-Processed-By-BccFoldering: 15.21.0451.004 Content-Type: text/plain X-Microsoft-Antispam-Mailbox-Delivery: ucf:0;jmr:0;auth:0;dest:I;ENG:(910005)(944506478)(944626604)(920097)(930201)(20251009189)(140003); X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?CFHJfgkL4PaNwoEuITLJavOK+RuQUSVagyFWHev0jKnWL3jSq7p3DFJNP9?= =?iso-8859-1?Q?RtHvBqSQ5p5+aUAK90u7E6NLuDIFpuWoBTbbJ7O0gHnIMPX2Dv4UwVdt8L?= =?iso-8859-1?Q?sXfVR1V4kLMKHC+Pno/Wz8hZ/3az0u5V4dkPEQeK+PVWaiAWFEIHIyTcy0?= =?iso-8859-1?Q?WPKAkfcVH7WdmW1DcSl2MG4EpZPSnyHFN9Jrzb+13fLDnc8m3cooIQ0U4b?= =?iso-8859-1?Q?7dlOdetxiVi6NDWPVCNigvW48RUFvWcBb4cMKO65kV5iwNV1g/gJTNglaC?= =?iso-8859-1?Q?Ud7cGOgMC03OMgrOgF4u1ltTsxXHssGIr4w/pT4jDCI0MixA+yybo8R8mM?= =?iso-8859-1?Q?q9xa2hCE4L8wMgfFkPZXcq82lxPjj98gDdzCLanRoU+BE3UrD6aCNse43Q?= =?iso-8859-1?Q?Aa6rjzbFcZgu/XuTp8fkmqOwlVkBes6zgVhwuvk4bgg0+VUUPkd8DO4AlF?= =?iso-8859-1?Q?9sKf65h9SCsZRwXZ9LSyUp4T3UM9x8g4LLe9KnelSUZ/RnjyI6tOcnvD67?= =?iso-8859-1?Q?Xfxfv7ahlexmI/cGwXiBghpAsbi6apoCGWG2qNB0rcuZ2A+MzEDQkh9EvX?= =?iso-8859-1?Q?uQEfjQ4aAEiio4UECiAXaNBnxOxyxWxjXbSzZSayMZp3mAfUO5zF2Lao8M?= =?iso-8859-1?Q?Ud8G9Jzx5yusW/GwOENOuLCUhuYbYv/a4Zhbo1qApUKiKG7xkgK1vtbdbc?= =?iso-8859-1?Q?Fw3qaT65U85OP1blZgFAW0lvH1A5bx0sapwnkC9G8f8//Se30+F1p2MazQ?= =?iso-8859-1?Q?fIt92GR2FV8qQ9YHqLv8CtE4ng8iFGgpoJW8pCkWETN+OrjvAhKeb7vlKl?= =?iso-8859-1?Q?8W6nJKISZL51cFHf4w22Riw0Z1QZfZIpHznICbrZ9SCIqmMnQbcyCG2c93?= =?iso-8859-1?Q?XsO5rFc0O5OUjrQne1NYjxxEmtdPF+AF1SsaxO1GFGNu4qS+KarKrO8qM8?= =?iso-8859-1?Q?nr29n88Oe7mOZ1Wvn/my6DHyJlQDP+G79BlpnaHQnA5a7C43PDShLLIa2K?= =?iso-8859-1?Q?hj4ftvMz5zjHEy+El//0vYuxGwWcgENKPQrmH0uidspkPowqM5xzOz/ibY?= =?iso-8859-1?Q?yFBvyC3QFD+UnZrB/2WFe+J8M12VsbJOlJ7Z2n6gsu2f63uOkU7vICnOl1?= =?iso-8859-1?Q?rN6l5nHp+oM2cuoqWF2CbeDunE2bag+h3KPfq/C4odM1An6c8CENBAuFzf?= =?iso-8859-1?Q?rdDO1G6df5ao1C1QWpnXIPp2BpljFy2w3vY7pdFwE0+Uw03wNYuYa6H6QS?= =?iso-8859-1?Q?BjGs3Y+4xBMYLGdJLxML6WqfKKvuOEhUPq94lhPbXTqVImtiBOU5Eh2WtN?= =?iso-8859-1?Q?Fg4mB59K3h4aisMKPpGq8p18N6ho5NNScN8glj2u87Yn4d6q9OHpAJ0vuE?= =?iso-8859-1?Q?38AL5vSostuaEo6rmzz7wLf6QoBjfPxsWm4dRlNi6O0FibPN9+Q9ZYiOft?= =?iso-8859-1?Q?BwOtMp/Ubg5iHht4jK1UCF8KEkHPcyyrjGwAdjYKR7x8ZfRg32LRJyWar3?= =?iso-8859-1?Q?APtZKxtFQme2c0+UexhLBuXMKlRPe5BJIzqp5n0o1ypL1WdCEFQomcFKhW?= =?iso-8859-1?Q?fcHGWgHpIb41IrRHxoEAZD8LZcSRvAiudPvZzRHi+y2r2N7O3CyhHK8kVM?= =?iso-8859-1?Q?6ozchciYCAODp5eBHlLJRZ8fVMkNH78KUDaWM5PUorVjR+w32xvYwCfnOV?= =?iso-8859-1?Q?zgt5YVwRSPAq8Q0t0JX6ONfiADEV/QWCpg2BomAYwTyzI/JwzO0VIMkziE?= =?iso-8859-1?Q?EGwHqCY4cfOOzo5dwYpOvt5vXr2P4LBP6T1oChksmIRbiI9piNmzj8A0Qf?= =?iso-8859-1?Q?Y/tqYVVRIvOLoJrlGVHVzEl3sEzkGc7KHLF/241luVOOTbNtLu678fmXQ/?= =?iso-8859-1?Q?45l/jpiCw2FQ8ESwvsJVtKsJn+5bcIyVLlFfwvEEIX95DL6g6Q3AG4tFdA?= =?iso-8859-1?Q?/fmdOsKDHu7pYI9WwMOV/mA/Ay9nBYPzZhZNJ1mTQ995C5XPRLBG9HeZtP?= =?iso-8859-1?Q?prdexgSZEqsR+6o1htiCAQRhwy0GpxI56S712gRgb3mrsIHJKecZarqi+U?= =?iso-8859-1?Q?fZ1307OK3IHxxg3bmo8Hv1MRPWQRhRiUDQJcFVyOBprNaG6kWkgFVIBc3L?= =?iso-8859-1?Q?P02KGe7LoNuD6NZtyz70gt+o0wpR5ZLy5xyg+ip/E5ivwmXYPbLF2+SzQW?= =?iso-8859-1?Q?5waArlO6kbXuI9/gy6ZInenCRH7LXq+QaoEAKnSVFP7G/BuY0RrL3Ggai5?= =?iso-8859-1?Q?376+ttWJsrD7xwGMQdh0+Wc0yDNSTIo0+mS/BHR/XB0nqbCAR0Cfnf0RZg?= =?iso-8859-1?Q?wFREF6xoTzgZ1znwaUdus8gqkpt8YrULPOsjJu7G+HmVSiBAeBHdjS/0mw?= =?iso-8859-1?Q?HGhsYnk2WI3/9tipfe0nOdtVa8PKRVHrHFhdjD5kRtZGPhI6yv5+756jsF?= =?iso-8859-1?Q?f0YVHnTYBe8RCSb+iDsgzP4b96bd1KqdMzKzUOs3u3bW08/bnqm3KxuO94?= =?iso-8859-1?Q?oGBlBy3w0qerP36AsHYeVofwdIZPR13fil40Kl5Kw8Lxroe5AKbJpn1I90?= =?iso-8859-1?Q?wTiwKtcJZ7z8Lv2KqorgsM6ydmKwLdVKA42fnJYKEU2YeExzJGU/fT8gID?= =?iso-8859-1?Q?OpKDuqiSINmDshbA9ZkdZRsen3/vwUpgT+fC0ZqK7g7dj8G8GfWI8EnLKK?= =?iso-8859-1?Q?KczBrupgpeGEzaoTAXAyqctGBYQ8iioV6+vviTve6Ywd8ivFhMbqfqsTJ0?= =?iso-8859-1?Q?cz3LR0of9SspGLmEFd9g16G6rOhAXQFgW/TgaBF90Q8Pa0pet26O6ojCh2?= =?iso-8859-1?Q?50iIg/oS7cq3xbVRfQPE1OKXXkMXqGD/mCDQtFAcwQ=3D=3D?= MIME-Version: 1.0 List-Id: From: Denis V. Lunev The callback runs after bdrv_reopen_multiple() has committed the transaction, so it cannot reject the reopen. It can still find that the node it has just made writable is unusable, and has no way to say so: bdrv_reopen() returns success and the caller carries on. Give it a return value and an Error argument. The reopen stays committed, the error only reports that the node is gone. Every queued node still gets its callback, the first error is the one reported. A callback may leave its node without a driver, and so may the I/O of a later bdrv_reopen_prepare(), so do not assume that the nodes still ahead of it in the queue have one. qcow2 is the only implementation and does not fail yet. An error therefore means one of two things now, either that the reopen was denied and nothing changed, or that it went through and left a tree which cannot be used. Nothing is undone in the second case: the node is beyond repair by another reopen, and a caller which reacts to the error by reopening anything is making it worse. bdrv_reopen_multiple() says so, nothing else changes. Signed-off-by: Denis V. Lunev Reviewed-by: Andrey Drobyshev CC: Kevin Wolf CC: Hanna Reitz CC: Andrey Drobyshev Cc: qemu-stable@nongnu.org --- block.c | 24 +++++++++++++++++++++--- block/qcow2.c | 4 +++- include/block/block_int-common.h | 9 +++++++-- 3 files changed, 31 insertions(+), 6 deletions(-) diff --git a/block.c b/block.c index 44afa191930..0978ab2a0ea 100644 --- a/block.c +++ b/block.c @@ -4622,6 +4622,10 @@ void bdrv_reopen_queue_free(BlockReopenQueue *bs_queue) * If all devices prepare successfully, then the changes are committed * to all devices. * + * A failure means either that the reopen was denied and nothing changed, + * or that it went through and a driver then found the node unusable. In + * the second case nothing is undone and the tree is no longer usable. + * * All affected nodes must be drained between bdrv_reopen_queue() and * bdrv_reopen_multiple(). * @@ -4698,15 +4702,29 @@ int bdrv_reopen_multiple(BlockReopenQueue *bs_queue, Error **errp) tran_commit(tran); bdrv_graph_wrunlock(); + ret = 0; QTAILQ_FOREACH_REVERSE(bs_entry, bs_queue, entry) { BlockDriverState *bs = bs_entry->state.bs; + Error *local_err = NULL; + int commit_ret; - if (bs->drv->bdrv_reopen_commit_post) { - bs->drv->bdrv_reopen_commit_post(&bs_entry->state); + if (!bs->drv || !bs->drv->bdrv_reopen_commit_post) { + continue; + } + + commit_ret = bs->drv->bdrv_reopen_commit_post(&bs_entry->state, + &local_err); + assert(commit_ret >= 0 || local_err); + + if (commit_ret < 0 && ret == 0) { + /* Committed already, so report the first failure and go on */ + error_propagate(errp, local_err); + ret = commit_ret; + } else { + error_free(local_err); } } - ret = 0; goto cleanup; abort: diff --git a/block/qcow2.c b/block/qcow2.c index 3e0a219e156..ddad39a3084 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -2233,7 +2233,7 @@ static void qcow2_reopen_commit(BDRVReopenState *state) g_free(state->opaque); } -static void qcow2_reopen_commit_post(BDRVReopenState *state) +static int qcow2_reopen_commit_post(BDRVReopenState *state, Error **errp) { GRAPH_RDLOCK_GUARD_MAINLOOP(); @@ -2251,6 +2251,8 @@ static void qcow2_reopen_commit_post(BDRVReopenState *state) bdrv_get_node_name(state->bs)); } } + + return 0; } static void qcow2_reopen_abort(BDRVReopenState *state) diff --git a/include/block/block_int-common.h b/include/block/block_int-common.h index 50848de07f4..7afbe8c4ae5 100644 --- a/include/block/block_int-common.h +++ b/include/block/block_int-common.h @@ -262,8 +262,13 @@ struct BlockDriver { BDRVReopenState *reopen_state, BlockReopenQueue *queue, Error **errp); void GRAPH_UNLOCKED_PTR (*bdrv_reopen_commit)( BDRVReopenState *reopen_state); - void GRAPH_UNLOCKED_PTR (*bdrv_reopen_commit_post)( - BDRVReopenState *reopen_state); + /* + * Runs once the reopen is committed, so it cannot reject it. Returns 0, + * or a negative errno with @errp set to report that the node it has + * just reopened is unusable, which it may leave without a driver. + */ + int GRAPH_UNLOCKED_PTR (*bdrv_reopen_commit_post)( + BDRVReopenState *reopen_state, Error **errp); void GRAPH_UNLOCKED_PTR (*bdrv_reopen_abort)( BDRVReopenState *reopen_state); void (*bdrv_join_options)(QDict *options, QDict *old_options); -- 2.53.0