From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11022106.outbound.protection.outlook.com [52.101.66.106]) by lore.virtuozzo.com (Postfix) with ESMTPS id 98EC5802A5 for ; Wed, 30 Sep 2026 11:17:59 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ngUEa1WmCQA05lbGo149dPjdjks9tyS6QXk8aKpwdLUlM9LOrKuUkaTSUC5ZmTges0sanNq/iUlQxwYpgyBFzJQkx3jRmgL3GXq5bEdlC1j1xJcjLMotL5ksk38nyyB9dS75FeVZQTXc9Tpsu6GqA+OHzLBlFinhNaPejIQSLRZn2XjyiWCaEoi3YHPHLXmx1Izz091RCeov32GowSzw93UN2Oi/zOXV4B8vVjwM3fG9IeKUQ7LH7orUagfg3lC3HNBBpJcllkpW8fuiplvAS0u9Xh7wjQgA7IpdtCBXz01pu57rOywvC8siDDY8sDYJlT9X4OXp6xdRlFsGPIQPbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Whr2vDivmG5XfTYuekgjjGns7vqLmZvvwFoWrceknxM=; b=VAgMrGzWEAgZYj1LukpJS0ZLRXNdUjA3BadAh2M3h17hS8mKXZt5s5RyUylIRdPT3ynziONpfZ7Z+aBYGi6FDHeD+VyHtRAhNsEw/YklSBQOh9vFO1LiI4FvtyjT2IhSk+dOd3BdO3/jD7dAj7se+zaPGab75tR01+4LBbG7BIyHAs6IH/bqb3Hk0N+7DD+CeGYhflX4Iud0UW4z3RRkJ9U/cpQMzrRnpVq5dRFx5mDDmCbu/XwOZymsjvH/lEcpqdGmDoE3DpsDiTJN77bQJFrJXRbqevqLxJvFIoP01gF6jnkzRAnSTd/p8m1sjE5lXCsKeMseY3AsYPBNMvqYEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 2a00:1450:4864:31::10) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=openvz.org; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=openvz.org; dkim=pass (signature was verified) header.d=openvz.org; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Whr2vDivmG5XfTYuekgjjGns7vqLmZvvwFoWrceknxM=; b=Ree/L9yAx+dqbpJiRzJQ61EjV7YTzzslXIs8zwrRjECFeP9BC3LFz55umqDK2sC61xcxxGOmK/z/jiP4HQ+BLST5NbRJhgvGnGEUVfvqw3sAK2TpREmJJ5ZCq6a9i/a09x3I3IQwqRsZqa9Vmuzy9vOKwLG7wLmqvp66TnEfd6I= Received: from DUZPR01CA0194.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b6::19) by DU0PR08MB9004.eurprd08.prod.outlook.com (2603:10a6:10:47a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.472.14; Wed, 30 Sep 2026 11:17:54 +0000 Received: from MA3PEPF00000408.eurprd04.prod.outlook.com (2603:10a6:10:4b6:cafe::9e) by DUZPR01CA0194.outlook.office365.com (2603:10a6:10:4b6::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.472.15 via Frontend Transport; Wed, 30 Sep 2026 11:17:54 +0000 Authentication-Results: spf=pass (sender IP is 2a00:1450:4864:31::10) smtp.mailfrom=openvz.org; dkim=pass (signature was verified) header.d=openvz.org;dmarc=pass action=none header.from=openvz.org; Received-SPF: Pass (protection.outlook.com: domain of openvz.org designates 2a00:1450:4864:31::10 as permitted sender) receiver=protection.outlook.com; client-ip=2a00:1450:4864:31::10; helo=mail-wm2-x10.google.com; pr=C Received: from mail-wm2-x10.google.com (2a00:1450:4864:31::10) by MA3PEPF00000408.mail.protection.outlook.com (2603:10b6:140::199) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.472.14 via Frontend Transport; Wed, 30 Sep 2026 11:17:52 +0000 Received: by mail-wm2-x10.google.com with SMTP id 5b1f17b1804b1-49ffbd83a92so32254835e9.0 for ; Wed, 30 Sep 2026 04:17:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1790767072; x=1791371872; darn=virtuozzo.com; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Whr2vDivmG5XfTYuekgjjGns7vqLmZvvwFoWrceknxM=; b=VMIjarrIkHprBr3E7Z3rfsSnTIjm5IPRYYBbdJzSW7wSU/ZG3qXoOCCHKfMxp7wU9k tHvfvG82gjYmofCRCKhWxnGf2QtO4G6kzu7XlunrLFenNMUZjCzxCVInOsdEVADocLnI /wi29xttw71pedX7zwmn0zU2sauCKXaMW2q2aiFv07ezpUgdMfuULX838pC1ZdPR8az9 481THq6DS57hL0uf+ii0SGWplEe7sfp06/wSTysE6Hcl0ybDoheP41DveUta+lsUhqN7 xIN4MIzoVupDWFirrlp/Xo+e+MrM1a6F/958umoQ915Yom7kNkNnRd009JokuM7/HLYm odEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790767072; x=1791371872; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Whr2vDivmG5XfTYuekgjjGns7vqLmZvvwFoWrceknxM=; b=fCc+OP2i4mvCNdAfhct+gGwlL4YrmsoPjLp0aXhoQqRU6yCKMqlTO25OMgR7DpxZ+a Fqgcjp+7IrS7GBe+Ai+XheGXeX43SzUef7I7Su/sg74UOPxevWzK5Pzs5NMOvUwX3//6 0bk3cEFvWgwBxyVtKWjKc/29cBedRtn3EgahycNUf0qjOpTYo9evE8Bg+p8hfGcZtsBO 1/4pASE+XxXMDLbR1ISr1/ipGLPbT96r9vXbQMiOwitKHaR4yqPmlU1KEjHjmLLP2KlS UhPjVYJwPmN17zQiQBs8TCqAFViVvEusNjRvBQTNMMU8gR4r4ln/IpfWk8NQY9oIDNUx 6BWw== X-Gm-Message-State: AFuF++lNWNVCNhEEW9M6vPBWWpbpJRaWyWpdq1keeIle0N5t8NaZ+VPd o4kkfobTQqPeKjzra8tLl0Z8NMIDSkfixl8qRXvcFcYEsKXJ3s9W5RwCHTX/VF4bNE8Oclwl9sx AT7tcbUc= X-Gm-Gg: AYBFou3d2nAiNGob4xfBPpfAnQ7v6rIEI1jqmgfTOb0phwjyFHEnEtjAndI/nmeM7mk Cr7gmPrBHyvxUhWK0+HZAFgyd6C+PNSYl9tbDAIlmsgVTdbG/0ZzZascg/+7Zz9GcRbdlidEG2E lahcbisrrg8nvBX7vPAX4QBwwKQtRR+XyGjP03/RSBRSmCUsqtL9AJvB6t15zdRBrlWMd7i64+h YLIWmnLsIaVAhYpoIv9FED4I3M8rm665Nnkmz1uMfryjTnwIojuFa2f80fx83fsZMLo8NcIaiFj vMGQy3hUZJcx9A3uXzC066bOjZcTwbtp8VSdcj8H/IYTs0KoSQZxQzbk8noJ3SuOhIInJHXib83 a+AsrO9XetvBVdtoG/H/wwohaK3R+lVH7UY4inDKtcFCCeLezG7kfIV9uGTaw3EL3fdaMT9DvHt q2EgMrJFLg8NYoZxEJmYhRl50BkjbmyR4ZNJJqxsmMVdZGnNYItcnHvIn3Stp3PccT/WP8g0Lod ivCAw== X-Received: by 2002:a05:600c:4687:b0:49f:bd3c:bc25 with SMTP id 5b1f17b1804b1-4a01b131ea9mr17504715e9.32.1790767072199; Wed, 30 Sep 2026 04:17:52 -0700 (PDT) Received: from athena.sw.ru ([2a06:5b06:b600:300:c6b8:98e2:93f0:2de6]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a01cd002bcsm3092365e9.4.2026.09.30.04.17.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2026 04:17:51 -0700 (PDT) From: "Denis V. Lunev" To: svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com, den@virtuozzo.com Subject: [PATCH hci-8.0 5/9] block/block-copy: don't reserve memory for zero tasks #VSTOR-134085 Date: Wed, 30 Sep 2026 13:17:35 +0200 Message-ID: <20260930111739.3866427-6-den@openvz.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260930111739.3866427-1-den@openvz.org> References: <20260930111739.3866427-1-den@openvz.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MA3PEPF00000408:EE_|DU0PR08MB9004:EE_ X-MS-Office365-Filtering-Correlation-Id: 8dc4ccee-ad51-4bf7-938a-08df1ee47852 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 0 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|9140799003|48200799018|61400799027|6059299003|43022699015|5023799004|5063699009|56012099006|10067099003|18002099003|22082099003|16102099003|55112099003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?OMKsvS9R6lb6UQ5iEjYqHOdL8xwxl87gbaCVjtKJxTUSyY0SMvNoZu9pBCLL?= =?us-ascii?Q?bgNG8ywcd+v7cwuEc5Fh0lRe04s6WTQM85Uxv6sAiggbBS+prc230EKXx45/?= =?us-ascii?Q?uq93ZPLdDl6xyGcPwG+FiJuPm3F0gIhscyL2LKGttTenALy6frBUboupdIHN?= =?us-ascii?Q?eaJx2R23G4kjUFpTvhUsxSb1dO1LBJxjql9087xhvhwhgnQwjjs/FwWPiIbw?= =?us-ascii?Q?EfeqgqwfFmRZYUB8X/IYDKte/MaVX56lIzPI/4uMZ/F3qBLDlNCaqaUt9/XJ?= =?us-ascii?Q?2Z/PrpuVBQm2Rn6DxWaiw2Hi/aYKzTbk0pNeGDkjxP7LP/dKM5UEUTrywzcg?= =?us-ascii?Q?cGzZR0JbZAfJYMTlCCfYfmTZUOuGaHb2yMDyE0t5CrbuS+y37071b9xi/Ty4?= =?us-ascii?Q?h0xObirnRD4I2mqvf0TybKutGnQGQregbVWc91a4lrNshsOR8IzrFglgol2W?= =?us-ascii?Q?MGZdZIPVU+AJJUhXaRQiKLXuK1bjoPblCkowpRC+MbHikV2BZaia57Jr9lYb?= =?us-ascii?Q?O1M6ClRnYV2U1PP8AJ9tHfsMGVbCF8E1BdoGZPhsuFjrgZCu0njryVrbLyIm?= =?us-ascii?Q?CGftNztkBqAsRmsC8ZUmGzBxivaFwi8zKTOyvhaJscHxDuHKXRxBoGLMW/Ri?= =?us-ascii?Q?FSXQ5jrWPV0AHHu3CbP47yJGlrD9UkedKbZXggsmWTjZMF4xAs4co5mj9QeG?= =?us-ascii?Q?TO9GrVN+JkcoxbQnmIVA5z4LaV4lOEEw0KEFgmPICwjtBPtyB+K4ApA1IrGP?= =?us-ascii?Q?BeCNSmm+TRfN+lF0vUS1sJSZU9Aa6QhTZtiUJvc6KSCBu+H4vkL4PVCQf9+F?= =?us-ascii?Q?5JXmCHG8P7/cNdx7d9fxYgEat/kYHciw7y4B9TizjfQwY83na7lasgf/sXqv?= =?us-ascii?Q?xBcjBlD30h1HAMGLJjCrisBFMhOuNJjFdWLY/aLTNfK+Bxs8/mx/wEnt/KDS?= =?us-ascii?Q?X+ff5ZlY6IEnrWK+FcYkVDXKRGS2FAnoBF5bdQRI4ks=3D?= X-Forefront-Antispam-Report: CIP:2a00:1450:4864:31::10;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail-wm2-x10.google.com;PTR:mail-wm2-x10.google.com;CAT:NONE;SFS:(13230040)(82310400026)(376014)(9140799003)(48200799018)(61400799027)(6059299003)(43022699015)(5023799004)(5063699009)(56012099006)(10067099003)(18002099003)(22082099003)(16102099003)(55112099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: MGMrOvCx6HMe6Iw9rN/wXwNIWi/5j4f9eSbOaw2rbb9OiGwWcHHpFWX3o345xeZyPEY6TjYg/tO+RI2UzDDDnBMZn8J9bVfFJ5HZgqToAA+RYxvhYwpAxLeh4xQ9KbGtkcoaBVbul5TJPzxtPrCC/KDgLF9SqG4vEc8JrAAhqEGB74mg+pCcpsIR3IDDPyvLxkRwhkOT8XRDlrDclzIAYTMwyYPyY0faWFJy0HUTLzhigsSMPJVfOspUy+PJCLKe/l4MfRUcRGl7ZSOt33WLCQPYjfIbDcm/MdTnUucXseJ3y3LMPAOToHL5Z73PqcrKX3ejkcyRcv56LVWlgwHoYWqQSJysWv+9hqdQsHwjTf8q415atpXUrGxoNvmUb+3uvWZvinONW11uI3wy0Y7IAOl1UXzrIi6QOQ+Mc2u+o9wxwB0S1ba5myDV34keOj3n X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2026 11:17:52.9130 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8dc4ccee-ad51-4bf7-938a-08df1ee47852 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MA3PEPF00000408.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9004 List-Id: From: Denis V. Lunev block_copy_dirty_clusters() charges task->req.bytes to the shared memory pool for every task, but a COPY_WRITE_ZEROES task allocates no bounce buffer, so there is nothing to account for. Add block_copy_task_shres_bytes() and use it at all three call sites. Zero tasks lose the throttling the pool gave them incidentally and are bounded only by BLOCK_COPY_MAX_WORKERS (64). Reviewed-by: Andrey Drobyshev Signed-off-by: Denis V. Lunev CC: Vladimir Sementsov-Ogievskiy CC: John Snow CC: Andrey Drobyshev --- block/block-copy.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/block/block-copy.c b/block/block-copy.c index e68d3d8b141..aecbe0c16ab 100644 --- a/block/block-copy.c +++ b/block/block-copy.c @@ -470,6 +470,11 @@ void block_copy_set_progress_meter(BlockCopyState *s, ProgressMeter *pm) s->progress = pm; } +static uint64_t block_copy_task_shres_bytes(BlockCopyTask *task) +{ + return task->method == COPY_WRITE_ZEROES ? 0 : task->req.bytes; +} + /* * Takes ownership of @task * @@ -491,7 +496,7 @@ static coroutine_fn int block_copy_task_run(AioTaskPool *pool, aio_task_pool_wait_slot(pool); if (aio_task_pool_status(pool) < 0) { - co_put_to_shres(task->s->mem, task->req.bytes); + co_put_to_shres(task->s->mem, block_copy_task_shres_bytes(task)); block_copy_task_end(task, -ECANCELED); g_free(task); return -ECANCELED; @@ -636,7 +641,7 @@ static coroutine_fn int block_copy_task_entry(AioTask *task) progress_work_done(s->progress, t->req.bytes); } } - co_put_to_shres(s->mem, t->req.bytes); + co_put_to_shres(s->mem, block_copy_task_shres_bytes(t)); block_copy_task_end(t, ret); if (s->discard_source && ret == 0) { @@ -855,7 +860,7 @@ block_copy_dirty_clusters(BlockCopyCallState *call_state) trace_block_copy_process(s, task->req.offset); - co_get_from_shres(s->mem, task->req.bytes); + co_get_from_shres(s->mem, block_copy_task_shres_bytes(task)); offset = task_end(task); bytes = end - offset; -- 2.53.0