From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11021093.outbound.protection.outlook.com [52.101.70.93]) by lore.virtuozzo.com (Postfix) with ESMTPS id C134E802A5 for ; Tue, 13 Oct 2026 15:28:11 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eI1LLsiG8VtIwY8394MoLs+Z38cLEayjoGGD3oCnB5z1CRfiqvqBJL5WxnX3JegedpTLyNcK6DnsJXD+BMXdyH+GlDJ7/YDaFLxp+gpxuAuaCaClDwLHChxqNk9by0NufWwQMqEcAppBjnNpJZ4L2heYiaJW/mYSI1l39QhnNtkvRJmBD7i6m5gwBBAbqDtPmS1AD8xhYl+FQ19ylEba3o8nMvPs/nfpXxy3t0paqTK9rjaF5GUP8krDo0VN3M/SObKf6p+IyKSDvds4td6v8dIDeAs/SwyrKRsNUAph3nYJXIzJs3sJbLoLjRWfsI4ZYybBU36H0seLxXEnkgbMlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8k/X2Be6k/dLDlB2uMCJXMXD+kWjirmbxjhgQtVsvXg=; b=x82etuYHRFCNA0LDIUUKdpvkg2v3R3JcsPVJTgjxg71n5KZR/o2e/fTsSjMb8DfOCHeMsHEvZSqpP2n9GCDncWuiYgVQTgfgrk49aJX7F6kvMd5XPaZ++qD4KGhh+XhRVzhKRkWSa8lcLMpRkYKNaPCEDLMcZ6SNnDvo8b4QBDu0h3csmP1MXC2ioj4T2MxiprUVfX7H5in8UflTDhUX9rUOYVOHXtVcMbYjRn7o7XcTLfgAaBwnbHY8i/BambsXgmyVj8ube4bqE8cbH6L47owSEmr5jhiCl/79gkuk+tFtpZluXhDzTjlt9gdbKGH8SmchxgEURhcB+GfpY2InQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8k/X2Be6k/dLDlB2uMCJXMXD+kWjirmbxjhgQtVsvXg=; b=Tw1xQC5NQ7A0HuIVHdVSr1jvc1Jlx2/9N4ry7BFVC5BkrEIGcCmTS2uJ4RuHuUuO5Ocn6rNaZUD2PkeuaEGKvftkQa5ZP8sky+Vybxhzls/KvZba4tGJS02ZhobMcMrz5B27Rzq68nYOzqfYQq5gs8ZFlVAn76VprQUiUzwrySBjg84dZEqSncrKvy7V4nixZpvU8rOE4PPIzkzY02tB6At5y4Et/Ct6bN0OMv8FSqlFbd/mwYGoSF0tPvhS9sUIMPGKnqxJNAEUTKL6RdMY+MtY3rZdfAD1DA3yU+zan9ZyewxTVSrusKJ5ZwHMp0y0qmiX3by0ZOPQx8zXaM/U/w== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by AM7PR08MB5448.eurprd08.prod.outlook.com (2603:10a6:20b:106::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.11; Tue, 13 Oct 2026 15:28:10 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0522.008; Tue, 13 Oct 2026 15:28:09 +0000 From: Andrey Drobyshev Date: Tue, 13 Oct 2026 18:28:05 +0300 Subject: [PATCH QEMU HCI-8.1 v2 01/24] migration: Plug memory leaks after migrate_set_error() Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261013-vfio_v1-v2-1-433455c0a294@virtuozzo.com> References: <20261013-vfio_v1-v2-0-433455c0a294@virtuozzo.com> In-Reply-To: <20261013-vfio_v1-v2-0-433455c0a294@virtuozzo.com> To: svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com X-Mailer: b4 0.16.0 X-ClientProxiedBy: VI5PEPF00000939.AUTP296.PROD.OUTLOOK.COM (2603:10a6:808:1::833) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|AM7PR08MB5448:EE_ X-MS-Office365-Filtering-Correlation-Id: 87626b1b-8897-4d46-e781-08df293e95e4 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|52116014|376014|366016|10067099003|261009223027099003|38350700014|5113699003|18002099003|22082099003|56012099006; X-Microsoft-Antispam-Message-Info: 6MtlJllW34zvy8m2rHBFrdI2E69Gc6yqehfbDrD/8WxFBeaNZhOYkh23WFsNzW/Ng+j7CGe24yrAn1w5QJgkCsB2OSRlVLUDstooz3yjySkmtiozRdZegAek/c2xAL+cUCGgRTz1VcgFbu4YsPoQW9uUv6mvalYnEnufiXW1HjwCfVrG327egVPqkt1s8pob8QftzCP1aG9hsJhIOrrBhdcF6pASnMLKovI9YafngKrb3umFOYMaawu2XLTMq3+yT99wwHVwyS0iP/9TQDxIO6f56LGhFouImliOA8xIEZjCxxoL+sNYpfnxygjw89h+XboecCc7WBHdogx+5UrMhee6bMRep46ERs9W1HvnS7bt0kfO+pwaddnC2s9ixPGInWD4UztIQGRnfUI4Y/qg6uKoLT96jS3g5EUuPyculSuQHNGgho0iOWQFt96HEwDGdDjNcnJjQXceYOIKvLk0tP42+QfrgXmqpSv0K5O4WmXwKVlX5JuHVjVhaVx6yVAsrOsGZhIKjX413GulhYAd5gb/JhGIWYXG12y1cKGmqqmZSklUygt0hOBLYd8u0IqlayIoN8if7VuzSEgRKUcQ6PcqmmmuZnGNjGC4IgCAXw8u6yoGprU54rKz3rUfwo6qYGT5WYYFD8JT4t/XjgxkEX/phoR9JcKeTSPOtQFor24= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR08MB10656.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(52116014)(376014)(366016)(10067099003)(261009223027099003)(38350700014)(5113699003)(18002099003)(22082099003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVZLc1BKMDF4QnYrbnBuSmxQbU1IdHA3dDJ6VWJLeURpTXJuVEt4YU9mYjEz?= =?utf-8?B?KzRBcytmc0p6YWU4bEpzeGRkNjhaeEJDV1hDZDJsL2UwNC9QL0JRL1dtZ0J0?= =?utf-8?B?bFVyRmtTOVRhYVArRS81L1lmWGRLSGd6MlphdmZJUjJqVmNUaXJCN01kN2x6?= =?utf-8?B?Uk82VnRPaFhpbGxXN21DaFZ6cFJKaS9SVTMzN0RGMVdOSDBZaFUxRWtsQ3JM?= =?utf-8?B?SzZBdlJUdlppMENqQjgyNEREUVdKcUYrN0o5UGRIWFVpaC8rZE1kQktxenMr?= =?utf-8?B?aHc5R3BKNmR2b1RKaGJQTUpONlRpN3pIekNEYlVCU01RN0VJWnFZbnd5T1VV?= =?utf-8?B?YlJiUG1KYXZ2RVpMWDVxWmZvUFliWmlvTWtTaHp1VVc0V0dsb1BJbG5Wd1ht?= =?utf-8?B?NmUrcWM2OXcvYzVQcFFCRnlIVE9qMG1TeTBjcjVLZG5jWFVTTnA3L2FiYm15?= =?utf-8?B?YkZCdFByaVRiZXhOR0VzODZZcDZ1dWx6Kzc3dU5IZDFveENCUWVkcTYxUmtq?= =?utf-8?B?dnp4TitHVzB6bkdJTFc0RldNc3FtaUM2UnVTYVpVSkRMczRoYVFRZXAzbFE0?= =?utf-8?B?OXZXSUlHRU0rVm5qSkxndmk1WThQK3ZZY3hRaTdNU1lJclIrWTFkeTJ3MGxn?= =?utf-8?B?VmNDd0pLQ3hZRS94Yy8rUnFUQnlpcExDdGRtKzhrUlJVWEdLaWg1QWp2UXhj?= =?utf-8?B?OVRaQWVVV29QL2hwL1B6NTNxay82Y040TjBJMm1rbG5RTkxZa0xETjNxMktS?= =?utf-8?B?YUV2bzNSRnYzVEdSYXVmYjlGcnJoWUpMUlhDY1ZCckIxTndicm9XaHB5UHho?= =?utf-8?B?L3lkMkpvMGk3RWU4bEJlZ0drZHR6SlJkTldwVGpqL1dKdEJmQXBZaWh2RENv?= =?utf-8?B?bDU5cE1qbmczRWgvdlBBTURPRXdzVzRpVlpqK2NpZDAvL1dnQ2tSTmRzcVQ4?= =?utf-8?B?ZnVJaHExUm1FcDBxRUkrdWdUdmVKV3FoWDdGRjE1aDRaU2x4My9qM29OVGw3?= =?utf-8?B?VUJPMmRiakd5aU9kSXMyRmhRTU5haUZjWDlxSTJqOTh4bHRTdFJYNS9qdVBx?= =?utf-8?B?SUhJWk83NGNvVk1NWUxZZE1tTnpEZ0dKYkxRT1p0SjhuMnRhbjdIZW1sdnJD?= =?utf-8?B?M0FYVGpuSFdQYjFKaFdoaHR2eUFsM1puZFhpWTNHLzVWMUsrZmdjWUk0WUlD?= =?utf-8?B?bXVtbVRnVXhra0w4V0pHYnp6a2tzUmN0RHhENTZJMERsUFhyUnEyWno1dlA1?= =?utf-8?B?aTZhWStGOWo4RCt2amY2UklRT2F1SG53V1NUWU9jYTlJZzg3NElnQkluQzhi?= =?utf-8?B?bmpRRVBwbytpNGVtd0tUOUhvTGRaNlUzK0ZiTzJNR1ZEYTZXbHpNV2VMaHZW?= =?utf-8?B?TEtIcGhkMC93U2RNSGhCbEsxeXF6WjF4QWwyd0UzVG5XbWU5V2MvTk9tY3NR?= =?utf-8?B?WGQ4TTVZK2JOK09zSSs3bDdyMndMeW5lUmRIMXorQktabFowNC9EYTF5Nk5l?= =?utf-8?B?MDhGOTZOYVVvSzBUWS9PRXRiZDV1cmNXMjlBVzBRZ1UwckxvdGptMEgvU29p?= =?utf-8?B?ZEpybmVDQlpZaDR4UU5HNmM4aUlWVzhPb2NJa2pqTnh1QWc0ei9sRnBXSy9a?= =?utf-8?B?TTR0ZmQ4MXg4bWFBZDkyS09tYkVEZlBDV0E0TFVIZEI0YTRTZS9wd3g4Z2Rx?= =?utf-8?B?QjhwNmVTRkpabmFCNDIweWV2SnVVKzBuWGVoV3BteEdJMTJmd3NvSHlZVkZM?= =?utf-8?B?WHhnUms1RER2amRQL0ZVNkUyaDdHTmZHRXQ3M2FSWFhHNzZSdzVmSURkTzEv?= =?utf-8?B?MU5XcmNSdmFSOWRTcnFFbUdGYno5WFFkTytIVU1tRDdUS1BCVlkrbTVSNGQ2?= =?utf-8?B?UEhEd0NERWQ2K0NnZ3N1OVE0SWovOWJiNURRKzVZMkMyU2NTdFQ5VFJPeUJM?= =?utf-8?B?czlmRHBhaHhudGk5a2MxR2Q1YjRFODVOQjc2dEt2NGdJRG5CaVVOcHdEMk5l?= =?utf-8?B?WVNUcG9OeXJFd2oxUGF0QjBTUi9aRG1vcHJjazBhYWhCQWtmQm5aNndWU0Ju?= =?utf-8?B?ZFlCdVd0K3ZSaEpPdkg3Nk9ITGphT3NGd3hsd0hGVUhqb3dSajZzNElKYWZC?= =?utf-8?B?aW5QdCtMVmdrRmFoNDI3T3JZRitvSTMyMDFSRHlnVERyMFJkbUtpazh6aWdI?= =?utf-8?B?WlBrT2JKYmI0TjRObWR0S0lJd3U3eTVpaHllbGlsc3EyQkY3NEZTZkpIYWFM?= =?utf-8?B?Tk93cXZDZGRZSGYxVlRRVmQyTjBybnd4bkh6Zi9YLzZLMXhaSCtWZUZPdzVm?= =?utf-8?B?VVhGOVp6ZUYyZXlvVng5VitBS2o5SmxlMWxrS1VZZFhVTHFOMVFRb2ZWbDA5?= =?utf-8?Q?nmKkYbKKJjs9k3Pk=3D?= X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87626b1b-8897-4d46-e781-08df293e95e4 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2026 15:28:09.1048 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xF1REE2IArFrWKFPfgS8MEVJwh9z+7Wou/ckWqMpcjJyeJbW4+vA6+XYWkuAaN4Fnh9b8bEMocSDJxVyqp+lSTBch/M/c3ku4C1XqE4zJHg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5448 From: Markus Armbruster migrate_set_error(s, err) stores a copy of @err in @s. The original @err is not freed. Most callers free it immediately. Some callers free it later, or pass it on. And some leak it. Fix those. Perhaps migrate_set_error(s, err) should take ownership of @err. The callers that free it immediately would become simpler, and avoid a copy and a deallocation. The others would have to pass error_copy(err). andrey.drobyshev: This commit is cherry-picked as-is, with no modifications, from the upstream commit 93817ec39656. Signed-off-by: Markus Armbruster Link: https://lore.kernel.org/r/20251115083500.2753895-2-armbru@redhat.com Signed-off-by: Peter Xu --- migration/cpr-exec.c | 3 ++- migration/multifd.c | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/migration/cpr-exec.c b/migration/cpr-exec.c index edace3f0bd8..7b7609e19cd 100644 --- a/migration/cpr-exec.c +++ b/migration/cpr-exec.c @@ -227,11 +227,12 @@ static void cpr_exec_cb(void *opaque) error_report_err(error_copy(err)); migrate_set_state(&s->state, s->state, MIGRATION_STATUS_FAILED); migrate_set_error(s, err); + error_free(err); + err = NULL; /* Note, we can go from state COMPLETED to FAILED */ migration_call_notifiers(MIG_EVENT_PRECOPY_FAILED, NULL); - err = NULL; if (!migration_block_activate(&err)) { /* error was already reported */ error_free(err); diff --git a/migration/multifd.c b/migration/multifd.c index 5a723ae25d2..e369421b3ff 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -966,6 +966,7 @@ bool multifd_send_setup(void) if (!multifd_new_send_channel_create(p, &local_err)) { migrate_set_error(s, local_err); + error_free(local_err); ret = -1; } } @@ -990,6 +991,7 @@ bool multifd_send_setup(void) ret = multifd_send_state->ops->send_setup(p, &local_err); if (ret) { migrate_set_error(s, local_err); + error_free(local_err); goto err; } assert(p->iov); -- 2.47.1