From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11023092.outbound.protection.outlook.com [52.101.72.92]) by lore.virtuozzo.com (Postfix) with ESMTPS id 8F6DB80B0E for ; Fri, 16 Oct 2026 15:26:10 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qvEw/Q+C1C1U9eioV2ebROC/KlNZLXq1rD9UY4y7/sJub9lzkfpfDk+LN3i9fzRLa1+AT1W6aZFRQlPSSaQyR0F6NvMhWc75lqoRGcqknjgDnB2m4+L9cN3HkPPQV9YK4KG/1NS6zME00HGkN63mIIzGQIl7e5n8JjMUuDy9a1EnwqocWC5BZWiw/lXgDzFKdlcdnz/jXUR854mmE7rkjf5RcWomNfzLHNu+lLKSMJYTZp+GLoOBbHAM8LX1k/51OzDW3KqAxkaXU5Xtj3eqkXaOvGHmOquK9iTrJkjL3EQ4LH+1n7B0pAJBK9KlMIfaxNuWIbG6+zdbDhsOPpDZ8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Vl2nGLsOdR1rT1rPPRP1wtRiv7O73Djt8igMcAzGVY=; b=YBB8Nd/KcBvn+7Y3mJgs4jStlAPJ2DaOtsFWeBe8FHnztJCuU6fVvKV2A3q2haEdL+kWogVsX9imbbOEj4BOtD4MbLd0tXfs78bm5zcvP0aOrq10YFovvI+q9WUtSTvnHa7T7Ce3xr9gMjQ66RjZffV/bix80WXRntmlN48+v+8BE1oQp1w5SrXtNmpIReMY3E9E1sXM3KG/wTf8JFjWxofGgQz4NRtjBiGJp5QXJhAR/iRpdDB1E9dcj8lps9jaahwrn+q563fCR+lTi76YqNUrMZGoPJJC5rA4RoRvlSZG21rALy+3p2OQfRqaGByjqqaGm55BhZV3Mw/Mv+HwGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Vl2nGLsOdR1rT1rPPRP1wtRiv7O73Djt8igMcAzGVY=; b=paEnBU7zLG4+vz/vO7C5v5vbCyoCiVqYbScYfyG9fVdwQ+I24DCriCieUHxKwH5uSvCku2W7q6vDM49SjJgOs9y1boZvkhnxR0ZRhMtUyIsl+w2RgMNduvjxWme9pNUAg+7pAUrZ2aXHMOIjG1ClR/Ef453VkqlMD4HssjJwP1dq8rkXQahPfCgGKP2Jo3S2n5lW8jVgHI1yku61rRMc/M0HkCscF/mQeXeQ/UKjSvtxcCYi2IgiMs8kTLCoEYuxFQLJWvQb4wBNu7b4+ocDgTYfXaD8Szx5yIZ3D2R3wAvUkQZsuM5s8QY+84viH6mhPGZJP0nLTw9bi5dlZqbEWA== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by DU0PR08MB8907.eurprd08.prod.outlook.com (2603:10a6:10:47f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.9; Fri, 16 Oct 2026 15:26:08 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0546.006; Fri, 16 Oct 2026 15:26:08 +0000 From: Andrey Drobyshev Date: Fri, 16 Oct 2026 18:25:59 +0300 Subject: [PATCH QEMU HCI-8.1 v3 01/28] VZ: migration/cpr-exec: fix Error leak in preserve_ram() Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261016-vfio_v1-v3-1-47487cb5a8e5@virtuozzo.com> References: <20261016-vfio_v1-v3-0-47487cb5a8e5@virtuozzo.com> In-Reply-To: <20261016-vfio_v1-v3-0-47487cb5a8e5@virtuozzo.com> To: svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com X-Mailer: b4 0.16.0 X-ClientProxiedBy: VI1PR10CA0088.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:803:28::17) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|DU0PR08MB8907:EE_ X-MS-Office365-Filtering-Correlation-Id: bbe03a49-fec0-44ad-a469-08df2b99cbe8 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|52116014|1800799024|366016|376014|5113699003|18002099003|22082099003|10067099003|56012099006|38350700014; X-Microsoft-Antispam-Message-Info: iFpjvgATGkyeHjmJm5XvlEEzxuEaNB6vGPEzKR1NB7QJWWIp6Rqs3Momz+m5RONb9nIHaOSLTrt2gO1f4oMVkAxM8jn1rJNmHJRz2fxLB5KZd2uu1jaOQ5VydzRYWuM2nl9cV+mEFDBzFc2skqYZEapny7ERBq3EtG38RxvD5UFFGnseTgByH655v8RLufnjMb30i6s0Fxykj6WmwhFBNCYV4hrzGRFtMGHSokdWIM+XwdNrPIslUnMsLDfFiJiuB2wv47XmS9J7aQrOdvBPFk5RBD7eyFU/9sqZ8t9Si9FHtY8R04vJtgTVjPcY3MnyZhJTqa8YLo263ytWk398g8PasYoiaqYb8v7e3C8E+j74bWbf8hSXps4HJ+KVkSjBLESLnt5ktH9NZlHjkfeMImjb4b8CVrFAhgZsdr8RKg0D1vFNy+SlMXWxB/Q7hf5opNk9NbFOnsxNezFt/urIjjVflqdTJ7cuvbglp+jKAUUqLc9ielHpw/RZgApfpZzKOj0Ti8W9PZqFBdx6SWs5JspKe6oQPZK1BpXUxb9eM9mcX9PmbUQEF000h58rwwEecfNkqV9cu8P5Huz+ohSaP3qhwKaE3GBav8q79+Jn0ZjJuqAKGBCYDtseb7cWbgY6gUMtyUpax5HBxTjru1Ra3wdDBU7sdlO5E2x9nxvsIFbmWV39lmt/BjAJ3nDFLGO7rdI2iHHkbJu1sENNhFv8j2jz+vtzHRWE3EzcpyzNF1g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR08MB10656.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(52116014)(1800799024)(366016)(376014)(5113699003)(18002099003)(22082099003)(10067099003)(56012099006)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eEZwbytaOHlkZHNhUU1IdSthMnlpc1BJdndQd1F6TmVXalJwUFN6Ry9FZzlW?= =?utf-8?B?Uk9IZ21vb1FMM243WXI2N3pjbTgzeXJMZWQ0bGxaU2ZBRWZscGJGdmYrSjJK?= =?utf-8?B?QWdzMmlMSFpBWXF3Rk1sOGs5dzRyb25ybFNEUFE4QjJ5bTZpaHYwRUlDSnpT?= =?utf-8?B?T1E3cXBuNUZlaWhwSTlON3N3TVR0dTdHeVFvaGp4R0ppM1htMnI2UTA0dGlt?= =?utf-8?B?c29NZndXTzNYWjJmNUFaMmROOFhpMU9TRTdIQmRUVm5xajdwOE5LbUMwcGJq?= =?utf-8?B?b0ZHVFpGRUkrbWtpaE9YNDBSUmcyL2tuWVNrby9ZM1JsWXg4WUJIWmdXR1l5?= =?utf-8?B?ZFVpdDJGZGpndngwTnlPenM1YlZVZUZOR05ydFhOUnhqbVRxU2RrLzlTUTV5?= =?utf-8?B?bGk2RFJyeWduRkk1bkNHNHl1K0x3V1dhdUVvb01NdUZabDBraW14RWRzT2x0?= =?utf-8?B?NFhWSEZjZ2U2RmhDYjk4UmtyNTd6Wmxva2FlV0lxdzd2dm94dE41RkgrUHBW?= =?utf-8?B?NGwyd200QllIbENZaXJReDMwRjVKUnQ0eHBCRGFNbFh6MkhNQ1EvRE5FMkd5?= =?utf-8?B?ejRZOStQZ1o1MUJCMnhOd2crZ0ljdC9uZWY0Y1cyNWlPRlNPb25UcWpNbm5O?= =?utf-8?B?cURsL1BoVlZOMDR1cld4aVBwb2FodUN1VUd0V0JSTlNNQ0ltZ29uMm5VWUtJ?= =?utf-8?B?bzVqa1pTOGptM3ZVVGEybDhlcG9xM3ZJQ2Y4ZTlxQnhzbWJGcFRyR20ybm8v?= =?utf-8?B?UnpJVXFIbHpGUS8zTmtLQUdXV3ZzdFFCQmNoRldaLysxQ1VUcnFQSi9CSXl1?= =?utf-8?B?OUtaRmF6eTNYQ2hBM0x4dGJjWTJ2WlFERXRRUzlJZWhSME5IeXlvUEJBc2tQ?= =?utf-8?B?UHRoSXUzVExmMkxyN0xRK3JCUVpJdS9wNXpFalNTRjUzZFRHLzlMUXZHTmxr?= =?utf-8?B?Rmp5SWN4TkhVdXcxcmNGbzdPK0M5NnA2UFIvblU1ai9UUGIyekdXY1VvTGR2?= =?utf-8?B?M0VTcG1JRzVvSFNVRHU0ZU1GcW5pNmpqSDhHUkMzOXZSd3RFamFPODdLTUVj?= =?utf-8?B?cWJZTXlWTldKVW5FRTFoNzI4clhSL1psdFlnQ09FbERieCt5K3FOaHh1ZjN4?= =?utf-8?B?Y3J1dDJrM0luU1BJd203Wks5RjhWMzZsVEYwV0wwd0w4QlF3ditIL01FeTJu?= =?utf-8?B?NmFtYkJpaW9ZOTZFRkpzUllrZXJ2aXRwVlNlTDdZTzVSQmFIK0RYR0NNM2R4?= =?utf-8?B?Sk5YTFhWb1FTYlF2YUtFczRyMWg0bzFkZ2lXa2t1WXlGTkJQeHJjY2NZM2NL?= =?utf-8?B?M2U3VjlxWjVEUFloU1p3Q1AwbXluZFRnaFZTU1hTelVGR0hSdVBOSzJDZXlU?= =?utf-8?B?eEszY3ZSYzRZRFp5cUptVkd5Vzl6NCtiQ3I4Wm1kTlBqRTFQMmJPcUlnci9S?= =?utf-8?B?eDd6M08rY20yNGsvdk5OSUJUdkdHT0pDY0ZueXlteXdLdnhyTjNJS2JYVVhq?= =?utf-8?B?RWdGUlBKdnBIQlFMNWlSVUJvVElnRHF5YytCQW1Mem1HT3NEb1k3eUpvNmhl?= =?utf-8?B?ZE5iNDZzeVNxT1RPaHJEaG5vbVUzZUc1VG02Nmpub2pCZVc4YVhodjBWWmkz?= =?utf-8?B?N3p0UDNmV0pSR1EySDNVaFFRamgrOXdXbFdKZUFCcjEzbXhJaDJwTG0rR0ZZ?= =?utf-8?B?QXhPUEpqaksvOTM0NzBTdWNKazVJNzQ1L2lBZE5OMXRHcFFRUXg3OERIM0pq?= =?utf-8?B?OVBnY09yT2QxVFhqc0RwamRxcEYyRDRnckdnUGxKSllWSjkvMXRqOUp0aTlH?= =?utf-8?B?MlM3UDRtTXNMTHM4MWtKcjFqOGUrb1hmUmprUFVuZ1FnYi91bWN2ZHQ2TFZX?= =?utf-8?B?QkxaV1RsZG9RZFhEVExYU2hQVHBBS1JGUEY5NkptSmlpOGxJa1JGamxtME5M?= =?utf-8?B?N2MwM3N4RndXeWVPUjBZU3ZJS0FuL2p5bHd4RDV4eDBFTjhNUDJDWWRxTDdL?= =?utf-8?B?UFlvWEFLbEpDWXFNZDJ3RFBBcVU4YStJWVgyVjN0WXIrcWhwQ2Fvc254ZDE3?= =?utf-8?B?WVRTZFIybVZWakQwZ0dzUjh3Z0lSdEIveTMyNlJIdmtDTHBGRUhhbzVrTzFE?= =?utf-8?B?akJuaHNLYnpPM2w1UDdWR29IdW14YmtqY1JIZ2hZNUJXYk9RRll6TVgwazdw?= =?utf-8?B?MkpPbHZzOGpneVZQSnFJdlpIOWJEYkEvMlBOcU9mTGhacGhyNzdIRlhSSzlW?= =?utf-8?B?aktYbjBWZm5FZXExbmxLSEpyV3ZoVVkxMzZ2V3A2RmJvQUJ4bURSdTREY1JH?= =?utf-8?B?dXA5OGg0L0hJTEZMM0pmcWxXVDZmQ1B6VW1OQTJtTGlCRkJnMmpkL1g2Zlcz?= =?utf-8?Q?CB2XJIdnL0x+vTNI=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbe03a49-fec0-44ad-a469-08df2b99cbe8 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 15:26:06.2156 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QYcVx3R7PxtIXoiqOtbU3AmjySori+vxowGIR64WdDwsf9ftxSQXa7tvbWC8CMyr9de9j7GqEmoc/IthycpJYcxoTyzQZVUJyZve4FLEBGo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8907 migrate_set_error() stores its own copy of the error, so free ours. Fixes: a3745506daf9 ("VZ: migration/cpr-exec: mark saved RAM blocks with MADV_DOEXEC before execve") Signed-off-by: Andrey Drobyshev --- migration/cpr-exec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/cpr-exec.c b/migration/cpr-exec.c index edace3f0bd8..9fd3515753a 100644 --- a/migration/cpr-exec.c +++ b/migration/cpr-exec.c @@ -148,6 +148,7 @@ static bool preserve_ram(cpr_ramblock_t ram, char *name) error_report_err(error_copy(err)); migrate_set_state(&s->state, s->state, MIGRATION_STATUS_FAILED); migrate_set_error(s, err); + error_free(err); return false; } -- 2.47.1