From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020085.outbound.protection.outlook.com [52.101.69.85]) by lore.virtuozzo.com (Postfix) with ESMTPS id A9E6080CAF for ; Fri, 23 Oct 2026 16:54:18 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SHhGwRtwHO+LLgZ7dOfXJNDcfZ6sPq/c6ltftpKGPLxq99QB9VveNkydTow232SVTAVjbe/HBr7/UnChHmYA5KDYHKdh6NscLa2HDqJrlOchYabp7+shq7iWDzyEh/cEa9ThReX/+y/Y0J3SXWMpjndDgsnbh86G7UUJnqCnSZ2dbI37byAmIisJhreMuXyKwDZLKP/+ojkJU84KR3HCyp0/geR/+lYxyNBzk5RXmRebH4zO2I5ZqOGCSkFjsxwEpK2KC3SZKPM7bvsqGj0SvJlbGpFRz1octBha8fnoJ94thIb1f6iJL+lGHmPFR2SymjdcliXRBGTf4x8s74q0BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Vl2nGLsOdR1rT1rPPRP1wtRiv7O73Djt8igMcAzGVY=; b=TnfL1EjfPsxNnwo/xF4qrwIvzGN+M7757TuuBlUOQUBivPvw7jtP88ObKvJLTTyzAR0xLjRI2bDE7Jhy2NwlFKXnKkTFi7hfr0OTBQ7n1/r7W+heoe+T9tgv87kabsZkw3Gar20NwzdCXL2/t3+AQq3KYHqd3WKG3gMcup0gI1VwAspyK9TXK6ZDWfmK++UUHEW6s1Z6KM2SzkMuIrriP8Zo8tLRz+qX96+12ZTuj14Cis7necrvjR+FOqJxfYEust10/wjt28cPY+KiLmRo8cQFVHc0+5V5XYnKHKSVRvbd7OsoyjEmH3vGrtEYnCHitSPRhDmPC0CUIt0d4LcJlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Vl2nGLsOdR1rT1rPPRP1wtRiv7O73Djt8igMcAzGVY=; b=VjHgQv1wpOgoz4C6ePjZCdNRhHK2lwviy0OUEYZnnH85/l7jg335SxSfCWi9lOOIJWF2d/GdA98A4cLmYQrER1ouiTMyiqtbXBG7iIY/AMUhRbGIpBqg6TWjkiEMcF6QJGFANT0djTNDBkeuBPVCqcE2Xiw4LbUl4bGKhEXu0agmLZscgtKVjYmx7TGIPqKruavkqZ+wQmHw/btE93LvbdLAWFVjIoexrunPHRTislYKnm85Ffg3hUDpkQOpktyF1J3ZOA4KNOGUTUjma2yXKFh1e6lC6/RrWiogbU2WV8EW42CwyhpEjMDMObs0Fsi9FmG/kpMAbVyxT+XsnqxL+A== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by DU4PR08MB11747.eurprd08.prod.outlook.com (2603:10a6:10:646::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.19; Fri, 23 Oct 2026 16:54:16 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0546.017; Fri, 23 Oct 2026 16:54:16 +0000 From: Andrey Drobyshev Date: Fri, 23 Oct 2026 19:53:38 +0300 Subject: [PATCH QEMU HCI-8.1 v5 01/36] VZ: migration/cpr-exec: fix Error leak in preserve_ram() Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261023-vfio_v1-v5-1-ba0bf3c6d122@virtuozzo.com> References: <20261023-vfio_v1-v5-0-ba0bf3c6d122@virtuozzo.com> In-Reply-To: <20261023-vfio_v1-v5-0-ba0bf3c6d122@virtuozzo.com> To: svt-core@virtuozzo.com Cc: Andrey Drobyshev X-Mailer: b4 0.16.0 X-ClientProxiedBy: VI1PR0902CA0027.eurprd09.prod.outlook.com (2603:10a6:802:1::16) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|DU4PR08MB11747:EE_ X-MS-Office365-Filtering-Correlation-Id: e6657120-598e-4ad3-a3f0-08df3126454a X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|23010399003|376014|52116014|5113699003|22082099003|18002099003|38350700014|10067099003|261022105027099003|261021121427099003|56012099006; X-Microsoft-Antispam-Message-Info: cFVCJag8LCHmR3NIF+BVhaupdzcDD9Uy2YSynQWqbRW0Bv5ij4t+xihmk41cZkv4lSuQKjnxZlVrjwK3iOBnKB6cDStED7V7iyJyBytccaVRZY8auMhXZlWqcoN/1KKxe8bFP7BvpnuPz3lUzBDuUxQidLqA/TDZ8P697wD4LAEf1Abs2rH2Z/29XCY8tFt9Dhw+hIdjYRPAny09CkkxQk7JJZXZRTKESoG+QgFmzYhnArhRSAmV4xH6nQZyRUjevhpKc64FKFk9+AIkK+4STe8wnnguPwIKqD1Yy35b5ACo2/Qwnv4Zd6PBGvHluOcUPvHl7PCaRpISnDiG/1HBJouU5EUenzssU1x4KGC9EhoKxU1qwDbukcEE6KR7hFZy2VcoBZ93K8Yiw14924boAmqjx9BwG+ZzevAKDlK6wOrWoy9+2KOSPTd3oQ9JufkwHYaugVz9A+2rWRcX1EpfS6ljjXQyzPu/E58ME/RTECewEY2/4wGG8yNTm6M+b7fkLEHT1X9ioTJELBcUQCLejcDXUmQqlucH7Xj5lFAhv8TVXJfmkvHJzbq8/vfigsXT+f4KVT9Ui9trhSZIR6XGNK1iqW6ax0wGYJ5hn77kQhgMxcu7crXBQujcJbCNq3uxJmmZxgVVaJchN2w3+FEPpsaUTf5fGLSeLQmfN5+QrZs/34+L0IKIYel/X9oyKCOkiqQuAoNHzC3+a94uWz+BzwavkdoZ3eKC+xdwVuyf/RQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR08MB10656.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(23010399003)(376014)(52116014)(5113699003)(22082099003)(18002099003)(38350700014)(10067099003)(261022105027099003)(261021121427099003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VVlRQUViNFkrK3NqU3dQZnYwOHJiczk4U2QzT01NdE1tM3NROHVJcVVCaVYy?= =?utf-8?B?Qi9vUHFieFByZnJ5WHFoOXdmL1NuTjhEa0hoNzNFcWk4dFgxb3didDNKRmxP?= =?utf-8?B?a3BmUm5xTXBtYTJtd1hHODUrUVkvbHh6OXg1bVZQamlQZEY2dlRHdTBwU1p1?= =?utf-8?B?MVBvTW9rWGJNSHgwRVh2NE95R0FheUltZHk2ZlU2aURSYmhuSU9BSEFzVWVN?= =?utf-8?B?d2VJdWtPQ2VKeUhTZVQyK0kwWTBYaFl0d21LUGZhWVZ1Mk5lSDZkMHNjK3JR?= =?utf-8?B?d2tOREZXRnlzd2VjaUJsVVQrMU1WODhIcURabzU2L0FlYUVQYjc0WjZyem5j?= =?utf-8?B?ckN6OGZpY0F5VWpCZXBkS0tUS0dPczY1L2NuYm5kZlRDSXd4RmhlNUYrUGhL?= =?utf-8?B?V2QraHVGem9nM0JaZmo2M0VZbmt1QWdoOFJqOGQ3ajVtVkxkcHZSWVR3aHUx?= =?utf-8?B?SENGRXdTeVd5NGFoc08zSDhDcDZLOVpJbjZ0YzlhTEFJQjdmblpTNkN3NWRP?= =?utf-8?B?RGRsdkhhMWdSTE1FSFhhR3AveC9TR1BEOEFsd1VyU3RORFFQa1dKb0Z1TUlu?= =?utf-8?B?ejgrVGd4MzNuanBDTTBuenpRcWdhZUxlQ1BKZk9SYTJmVXF3WFpKNldwc0pJ?= =?utf-8?B?ck0rNUFOWklWSTR5ZGxYeWZ4RTBDbVdZNTQ2cWkzM09wU0pkb0hvOFp0YzJm?= =?utf-8?B?MHlRQllzZ2FoaTBWYW9ZdHVhS3FyZ2JHckIydjhHTWh3R1kxMEtVKzZDN3Bs?= =?utf-8?B?SzBpU3dUMVRWZlhwL2trSHB4M2dRMG12TzlVMnBZTEM1QlNzQzBkQ0oyRmcx?= =?utf-8?B?dVFGdEZzV0Nuck9FQUk0cmdGVU02M2JJMzFvdFJEQzZhQWpQcWlSV0hSRWhV?= =?utf-8?B?QWQ1YjdlZHdVdENoTENCUWllak0vRmY4aWgyNmdMdXlMckQ0T1BUK2I3RHJW?= =?utf-8?B?Mlo4MzRQQlRZTlJMeHVFWlpFcG9oQkpoeGROZzdvd21LWmZQalpkd1NGR0Rl?= =?utf-8?B?RFZlOUV1S2xyR2krVzNlU0RHS0N2dzJjak9yRUcxUFR3Yi9RZm1qcHRPcjZl?= =?utf-8?B?VHRhUEp0bUtyNVNQNjA4R2FmTm1CT3REYzI3RjZRQzRSZEtoZ2RiY1drMzVl?= =?utf-8?B?QTE0eUM3M3E2azN4OGtuNE5TT296aGFBUmRpNUlkOEl6cjNoUkwxYm5EUnY1?= =?utf-8?B?bm1lemxBcmZNck5GeWtVNTBDcll5dDBVWFRYL2ZpZTFwaUNtaG55VU5IbVBY?= =?utf-8?B?Mmk3UEl0dU9iUitPNTNmSDlWK2VMbnIvbW9vTFp6U1YrYmxXcVhEVm82eTJt?= =?utf-8?B?c1lWN2VyWTZOWkxoVVJwS1dhMGxIb0poRmtUOWUxbUpWOEhmQmNXL1haWjRQ?= =?utf-8?B?YmxmamZzOWlsRnh6U1dEQlZDaGlCcVdDeStVSXJxVXhYRVBzNEdVYm9UbFIr?= =?utf-8?B?Z3RtNUtDaHhpdjR4MFZXS3pXOFcrN1dGNkhFcGxuRmRvOEdqUmFqRjZONjlt?= =?utf-8?B?enp0MFpNUm9rR3ZVVWh5TDdUYlFCRUFFN3RhaC9oSytYL2k1YWFvcjRPSjAw?= =?utf-8?B?cWRxREQxYmFMeFVQVkNTS1hUUE81SERnSENPc0pJc242clhzcU1sNCtNQnFD?= =?utf-8?B?WDFpTTh5bldTUzZ4akpHb3BHbjkydWtuQ3ZCQzd0Y2o0RFFFYzRrTFFQOGpa?= =?utf-8?B?R0h5L2FkYjBjWll5UEpRWStDUjFwU012bXpBSGRNeUNOTTJRNFZvOGxQUXpl?= =?utf-8?B?TkxEaUVpRmtlTmdqMExSTkJaek5vcVppMTlBT1hzYUsraUpiRWFvZFJ1Tmhv?= =?utf-8?B?U2xVQ1NrNWZEQ3hRUEFxMWt1UTU3L1g3UjdsYVAySzl6YXViUlVJbmh6bEor?= =?utf-8?B?eVdoaUNGdklKeE1DOFdqNHZlSWJ3UmQySWM0UEsyc0Mwa2ZkR1RiZ3pMSlk0?= =?utf-8?B?TWhCZ2JYQWZtNDh0blgzSldVQTF1bnFiRUZ3azJDd1hVaE9TRnhYenZqbklq?= =?utf-8?B?eXBXcHdVZ3Z0VG1iZ3JxTUUyOERrQWFuWkpTdWZVWFlrVHpZODNjblpBWkpl?= =?utf-8?B?allJeFZGOFRmWi9BWmx0R3RyaXczZ0hTQnZ2Vi9TY3duYWhIZThLNjJMcmUx?= =?utf-8?B?eVZPbnN4RHVsZkpsc1p3M2Z3M2NLcHVsTTdTeU5iYzNVT3poV2R2Sk5CREox?= =?utf-8?B?MW52UHcxOFRxTFZwNVcyN05vTDNIVnhnNFpodlFFWldtRXk0QjJ2VlI2d0d6?= =?utf-8?B?L2NFMXNyUHNGak51bElIYXNuSzRvaTg1Nys1YzV4TUNRQmFMME9STVFJRFdw?= =?utf-8?B?NWQ4VHBjdEdQWWRPL0FUdG1XYUQyWmtqRUQ3V2VrNUI3Y3VHVVpWaU90U0kw?= =?utf-8?Q?oDfqLtELH8Z9h9n4=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6657120-598e-4ad3-a3f0-08df3126454a X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2026 16:54:15.4259 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MubtNGNi2i14buREsX4PzTfGHX4/DgvIAgOgjOlsjHqH/1LFC3beXZ8ffLFNmMHZ+WzCBCjydA9YxnHcEsZgfAnfiVK40xzMj9RvP0dAUNI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU4PR08MB11747 migrate_set_error() stores its own copy of the error, so free ours. Fixes: a3745506daf9 ("VZ: migration/cpr-exec: mark saved RAM blocks with MADV_DOEXEC before execve") Signed-off-by: Andrey Drobyshev --- migration/cpr-exec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/cpr-exec.c b/migration/cpr-exec.c index edace3f0bd8..9fd3515753a 100644 --- a/migration/cpr-exec.c +++ b/migration/cpr-exec.c @@ -148,6 +148,7 @@ static bool preserve_ram(cpr_ramblock_t ram, char *name) error_report_err(error_copy(err)); migrate_set_state(&s->state, s->state, MIGRATION_STATUS_FAILED); migrate_set_error(s, err); + error_free(err); return false; } -- 2.47.1