From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11023094.outbound.protection.outlook.com [52.101.72.94]) by lore.virtuozzo.com (Postfix) with ESMTPS id 4819C8045D for ; Fri, 23 Oct 2026 16:54:31 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OUMtTBn8jRjEagGgBK3ox+1ZkjT0asSG/6k5wrJZAFTTjwGhqw9suLAIXb0L8vrBHSEh3x1hHXOIXQ7cwTSrXbxEoLONTs/Ea4vb4hIolz+0pHWu75ordlMNtDlEru5QaMvrNZarJkKpcTtMhZyJpDMKFGtikqamjvAkcwJLt5HY/lUlqX7xJOY2DqbMBWQKuWpBxup2ZUaxAUf5vtdqkiTS46kcLn74E88AQftSsfD7ja4osKiMNBl2936jVDQRE3RbAIMP2dw/V80wbRjBkQBs7SzNR5eEchey2q21iEmNGDFGui0AzUGdvb4VOgP9ov7oQpuaZ8ZsTcT+XhbQlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZxOeb4Ah+mB7BjkyMeUYqqn4cmd9TpiyWVFTAjD37Ls=; b=hupJlrWc7Mm8AuCxTijY6bAHLx2rLkyXAtPzNunPBPV8V32MxdCIiGZwTgZNx9uhLiQ87/QzSgWNUjvRCAGHwvSkqTunGniTBEkUhqZuJtbUUVtGPY9MJgzPGwXN6jH4xOqur8WRKqIi7j+9CZtPNSsIT+/LRW+KC8U+T5a+l3mQaG2HsW9amTHM/LgWtenIgOloTPa2qD2dVwgyVUWDY3x2KoQZjUougppvrJVd97w23e4QxxUNVd2kaw+ujPUWjnJzWdBHwTFiwrngXtl527/OFAjxGJYMYVj4+laXCEHq3xZswQJlHYQRZsJdbwq5iyQRzMrfjwgcj4urBVlBew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZxOeb4Ah+mB7BjkyMeUYqqn4cmd9TpiyWVFTAjD37Ls=; b=hNrVDVKdsf+LYKCLDwupEouKLVSKffDWTmakUBHOlALjlQL8cJTAS4nGJii5jlc6G+qGzet/XVrVHlko56IuDvyJzfoPL4AdZM0d2fyu3nf3uhViaW3aHD5RAXVFDT/dQHZ5JZT67/JtGnKCx74eQw4GnJI93gW7CFMVl7l/WtUWTEnBjicbLNx+YBNwXL4HoTpCPnyBPITNWuj3qWAx89Np5SOMPO3pDHtRhNHMgLq2fP1aKCFTJ2+bKgLkWOCK+y5tzwyXjC2wFCJ3X1JMiFlfkbEu0zn4ok2mu/JGbKwGOkVCrv+9Zrl4AzmVpdRysSNmR7HRStPyfxxJZmUVpA== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by AMBPR08MB11658.eurprd08.prod.outlook.com (2603:10a6:20b:735::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.16; Fri, 23 Oct 2026 16:54:29 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0546.017; Fri, 23 Oct 2026 16:54:29 +0000 From: Andrey Drobyshev Date: Fri, 23 Oct 2026 19:53:42 +0300 Subject: [PATCH QEMU HCI-8.1 v5 05/36] migration: close the CPR state if the outgoing channel fails to open Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261023-vfio_v1-v5-5-ba0bf3c6d122@virtuozzo.com> References: <20261023-vfio_v1-v5-0-ba0bf3c6d122@virtuozzo.com> In-Reply-To: <20261023-vfio_v1-v5-0-ba0bf3c6d122@virtuozzo.com> To: svt-core@virtuozzo.com Cc: Andrey Drobyshev X-Mailer: b4 0.16.0 X-ClientProxiedBy: VI1PR0902CA0027.eurprd09.prod.outlook.com (2603:10a6:802:1::16) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|AMBPR08MB11658:EE_ X-MS-Office365-Filtering-Correlation-Id: 0e8fa1e4-b421-4079-d8ca-08df312646e4 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|366016|376014|52116014|38350700014|56012099006|261009223027099003|261021121427099003|10067099003|22082099003|18002099003|5113699003; X-Microsoft-Antispam-Message-Info: HcUp1ue8B8IMvemdfBORmehpYwsjh3A6iu+AHhtyL9m0CIrohaMnGKwZBAvR4drfZZlqP59wfOjmWcK0e2pW6iTn7t2GjdlYjtBjI2oXhPwubjDGUwhypANYOopLPLXGPQpmvGaFqaXPVaPChOZjGvcQuCxQ8FiviRNg9PFqHpxfNFJLsRnTPyM0LqxA+CcKMkRIYpAp+ikHSPbddEsOIMetGUpQ0DA18Y+YGG8kqv/RN+cL+Gct62ZQhXPPtMU2zVNGwEqvLWP98Dkig60aP0c8C8sUWeTLDIdlKjrepU6+j5JzesE8DfDOkTP03XfIvjyT4AZLPsaiOG/VtPOiwBZB/fL9fARETyxGdBFaS53rzg8ZDCrDm09s+cFVYAzLYFKfxfJ1PQ/O5xPI7YttRlQfH8dUsaTCaDtowMg36gQ9j/i5Ki6Uu+RMB7sw1LCzFHs5ADGMwRXpyYddMn3L7eM51GqUSaOnVuO9TTkgc7zv6s1IIhfOvhsi2M4SKGM5nxtVfiwQenY79nqqyoiCY7xG7VumQlW1XbI/2O5EPaL8vgWrhQ238br79dVHF+KGRgOCNRmy3b1cgGF8K3dVh3oJLbDgNWiO0S1uMtTSNCfxL9ikRBWqqa2PxAifMpTnkwalhch76690EWA7QhIH55qypzrhtXLdiaeFn+uEEYPyWIut1JUUbTzX1Wv+vBC7wxdSj5cTQd4ucDG2lo9zkxKK93rq/xIhr1oFOSs/s34= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR08MB10656.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(52116014)(38350700014)(56012099006)(261009223027099003)(261021121427099003)(10067099003)(22082099003)(18002099003)(5113699003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHBQQ25tdkcwQmlMMjRiRDZVZkZSc2VQTXd6TTFhY1htcTJPRVA3cU1JTzEr?= =?utf-8?B?Q1lVSmc2c0oyeG8wNTBMMUxFRlpZaElBa0phV09US2xDQ3NzR29MdHNxTjlD?= =?utf-8?B?QXFiZ1F5L1lCWlo3YUthOXAzU0RmU1g2UzBnem9lM3V2RVE1MFp5TStTNDFO?= =?utf-8?B?RGhhaUtxS0RaQUNRcTBaWksvVHoySHpucU1YUTlzeWp4THkyOXloZ042Mk1a?= =?utf-8?B?OUFXdlY4Q2RlRk9JeVU4R2VFemFUalZpb05jaU4rVDhJTlk3S0phbjZmaUtt?= =?utf-8?B?Z3RuUFcxM1pWbHR1UW1Ma1IwenFuZUZxR2lBNk01Zm9kejZ1ZkxSdFBiQkhv?= =?utf-8?B?cHFyUFQ2YnlPRVJJY3lJTnh0MUFQajhKaHhKaG1jbzBTUzE4a2JER3NYVVBU?= =?utf-8?B?cEZlNk9WUkV6WTNxLzVBSHFwcFFHUlJ0b243YlZtaEtvYS9QeFdEMHZQWS9o?= =?utf-8?B?dm1HSkczRVhRSmY1TFZRZzVMWmM0T1hRbENYRWJDT3VickFjeUZMVDdWUkl0?= =?utf-8?B?ZTd3Q0FSbUZNZ2czL3ZwZnI0aVRsOGlvNEltclA1b2EzdStYS2o1WS9VZmVD?= =?utf-8?B?VDAwNHM5VVY4OGZZVzNUenFvbDljQzFlWlpUUm84Ukd5UnR5aG90WDFFQ0xx?= =?utf-8?B?TzZMemVWa2V5NXNuQXdCYmdZK0w4Q2poR3JleWJ6c2xqYk41S1pKWTh3UnVK?= =?utf-8?B?cWVkT1hwQW1EeXd6d1djTEpjUTluL0VFMWJ4bUpxcCtFekxIZlAxN3NsSUht?= =?utf-8?B?L0kzTDBNSTU1bzAzOHNzdmpuMUQrUlc2YS9IN0xTOGRTOEd3V0hhN25RM3lP?= =?utf-8?B?ZFV6Tm9vK3ovcXN1ekVVampZaUJnelA3eFVKMkpSVy9PZWJQYkRPNnl1NkVD?= =?utf-8?B?ZVJrUTg2OVo2WElmZDVSRWF6YzJIckFoYjZaL2MraW04TllQZmttYmVmblh3?= =?utf-8?B?Q1lUQmI4L1pXa1NRU2xTNzdnbGVTZllIdENqemQrWUVmbURwbjhaekllVDc2?= =?utf-8?B?UUpIUHhPVUJVYnErdGFudDdYOU5oZmEvbUFycDQzbVh2VXpPQlBFNlBUZFpF?= =?utf-8?B?a3VEYXRwUCszbjJyRFVseElYSko1KzRYb2FOblRpZjFSZWZvbDB6N3pYMjlx?= =?utf-8?B?cUlvTmdLY25EQ2o2WjBTVHkwYkJOSGlnd2VQUFRaUGRVTFFxYVFmdmh0QTgw?= =?utf-8?B?L0VHdCtRN0dCbDdKc2U5NE9wM24zMlFpR0JsekpSNmJwMW1sVDB2QTVreWNk?= =?utf-8?B?cGkvYjUwZ2xsakk2VW9NU0lKeDgxbG9pcVNrVDFPcHlFays0VUpBK2tXTklQ?= =?utf-8?B?THVmM0lQMG8xTTVHbDRuNVVFeVdTa3NtZ1RHMkU5K3ZvbXdjNmZhakpERFZW?= =?utf-8?B?ZHdzZEtZbUxpdHlxL2NJTEc3M21Vb2hwZXY3ckp0UG42NVZNUnFXVHVUZ0R6?= =?utf-8?B?WGliVVhhbkxPWHFrSUcvRW1uZ1dUUUxlOUx0WWZRcHJsWFJlVmVFRzFtWUFU?= =?utf-8?B?NmxDNHkwWmI4ZGFybWkxQW5tdGptN1R6TXRMRm1qY0xpdDFsK2FZSXhWbU85?= =?utf-8?B?THMwWkRaUUFuNXRyT3Y1cU83Q0JRNFV1SW5xYkltNjFxekNIcFpVcE5Ddmsv?= =?utf-8?B?VkJhZ01tbjdkUnBpa2NvOGRMc2JIRkd1N1gvbTVmdGgwcm1TaE5hYk9OZHY5?= =?utf-8?B?K2tMU29WTGNvaHZEVFBDcTkySGd4UUI2NmFTWmtmZENaVmRTSGVTZW1YQ2pv?= =?utf-8?B?ajgvTHA4Q0VhQWxES0FadDhNcTdDVitIcnhVRFdxczEybXpmNE1pVWZVakJY?= =?utf-8?B?M1lpY0ZWZS96NitNb3I0VXpsTUdVMHV3dkRYeHhnek8rTlorT2t0Y1RJbmxH?= =?utf-8?B?QmUvNnRLSmpCVGk5N2x4a1E2UDl3aHFobmtTWkI3WXplcm8yMVM2MmVsNS9i?= =?utf-8?B?MEQ2bnNoZWxDckVqb05Ja2YxNTF0WFl3Mm9UMlB5WjNFMmk0NTJtbFc5UkpZ?= =?utf-8?B?R0xiY3ZIVk9JYzQxN2NKRFFISzFXUjhzdTVVTWI1VzZEQkd2YjBzSElqcXJr?= =?utf-8?B?ajNsQnZ6aEVWbVJZcTlFSk9zWDdJMVFvcithaHdFK0RPNEVjT21HWHdvUm53?= =?utf-8?B?N3daZUdMTFZXY3d4blFNd3JKS1ZNOENSLytVS0NvYlBCTmVRODg0YStoN2dS?= =?utf-8?B?UVBCVDBQNFRSeGJYVGxnT0lQekpUWkZ2bjJ3cExnWVRIUGZqNFpLYTJCQzRo?= =?utf-8?B?SzRsRlE5TlJuUS9TSktDNkpnV29FNkk5T0hFY0d2eVVCZzFqaDBTdTZUNWxp?= =?utf-8?B?djY1NElrZ09HZWFiYTFja3dIL3cwZ2MwWXJydVloUlZPODFxejVHcHgxbHhi?= =?utf-8?Q?wgH8vP3DooOzKCr4=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e8fa1e4-b421-4079-d8ca-08df312646e4 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2026 16:54:17.9426 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OD847NZUkIKzZPw7uGbaRyIvPSse80Oa4hRTKEHEVfsXt3OH8HDQtX2hwTBhLXgQwu5pE/ISvUAcYAgrt99VbLXghxJaKz1xUOk83Xipe4A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMBPR08MB11658 qmp_migrate() saves the CPR state before it opens the migration channel. If the channel is a file or an exec command and it can't be opened, qmp_migrate_finish() returns right away and migration_cleanup() never runs, so the CPR state file stays open. Close it there, next to the yank instance, which has the same problem. Fixes: 624e6e654e11 ("migration: cpr-transfer mode") Signed-off-by: Andrey Drobyshev --- migration/migration.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/migration.c b/migration/migration.c index 39f70328fc7..132f0d403b7 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -2412,6 +2412,7 @@ static void qmp_migrate_finish(MigrationAddress *addr, bool resume_requested, if (!resume_requested) { yank_unregister_instance(MIGRATION_YANK_INSTANCE); } + cpr_state_close(); migration_connect_set_error(s, local_err); error_propagate(errp, local_err); return; -- 2.47.1