From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020131.outbound.protection.outlook.com [52.101.69.131]) by lore.virtuozzo.com (Postfix) with ESMTPS id 69E268045D for ; Mon, 26 Oct 2026 11:11:21 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gfBk7z7RYPsKSk6qcRJ/mlTOAFjW2tsXY8bPBxciRrXPJlhTBSIXxqyCyhuc4rKNPgB+Oq+KHmfV45s1Cv1pM43IV1e7AwacQ/TMWgzrDqHqmu/agDUF/mGPH3fwbbQNpji0FKp3ahPwp13BqGtuNxnjAHJJY+6dJvm+xD1OxAdtJSpHrLYlfAGc0+XVmOOz/1sireinfRwYBI70kwzm61WBqydln/tFs+gb/MIdnfJH5zVO5FM3zaPXVkCESKVfZhniyYnXUtUUAUhj7yvag8R1XV0+BUmQVu5kV8qZdMSy/fnhYyUj0AxCPRxP/DJ86yiLWxk1hoyjMiSgez/pig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v4bzzFUs5FUeu+ae8i0ujhOEohnvZCsWP+SqJqsP9j8=; b=aLX0Yrwfj96y98qQf2ahW7UHfyQGY3w/3jVtCo4QIpgN48/73J2dbNVDggXzuBJbQI+38wacHy3EEQNgryJfP3lL4l/9mWtrEb648Gh7+c5Blmj4iZC/Pn9tUOo0Ylr1vgLTKIj575JoUdLe68BS4XJswEtDl5hFOV1G9D0q1+A/iDCHI8j0ckZp6lK3yxeRXM0r2opIKwZIk5LEuHqXOJsd7gjeeU3sIq5Vb8IA0L3t/YDrY+5HpacBJeE72oDeLpI/cqUVLfUsbDFd37TJYZ0vvy8xqNk+TgU+UQY6ewkJldPC9JLFOeUKd7j4jxRW3MWFkz2khXrULJGDRZ3F8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 2a00:1450:4864:20::32c) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=openvz.org; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=openvz.org; dkim=pass (signature was verified) header.d=openvz.org; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v4bzzFUs5FUeu+ae8i0ujhOEohnvZCsWP+SqJqsP9j8=; b=Hc7RaZrA/8wieroyT99RAYBP7rmtgDwwBoGNZ/QKDHb7f6Mg8fm5AyAaPbcfMRDoLAjQQSaNT9JfK8aLiKtDTfA5TsDdcazvHyHwCvRiKThIIri0/akDFihKccWRq7f4WpOdr9BtvPSwIYCj9Yl2Vs3/2t7afjHNpsseuAGaEQU= Received: from PR3P250CA0019.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:57::24) by PAVPR08MB10339.eurprd08.prod.outlook.com (2603:10a6:102:30c::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.22; Mon, 26 Oct 2026 11:11:17 +0000 Received: from ZR1PEPF0000E6AD.eurprd05.prod.outlook.com (2603:10a6:102:57:cafe::1e) by PR3P250CA0019.outlook.office365.com (2603:10a6:102:57::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.22 via Frontend Transport; Mon, 26 Oct 2026 11:11:17 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 2a00:1450:4864:20::32c) smtp.mailfrom=openvz.org; dkim=pass (signature was verified) header.d=openvz.org;dmarc=pass action=none header.from=openvz.org; Received-SPF: Pass (protection.outlook.com: domain of openvz.org designates 2a00:1450:4864:20::32c as permitted sender) receiver=protection.outlook.com; client-ip=2a00:1450:4864:20::32c; helo=mail-wm1-x32c.google.com; pr=C Received: from mail-wm1-x32c.google.com (2a00:1450:4864:20::32c) by ZR1PEPF0000E6AD.mail.protection.outlook.com (2603:10a6:918::154) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Mon, 26 Oct 2026 11:11:16 +0000 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4a35db1f202so12316225e9.3 for ; Mon, 26 Oct 2026 04:11:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1793013076; x=1793617876; darn=virtuozzo.com; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=v4bzzFUs5FUeu+ae8i0ujhOEohnvZCsWP+SqJqsP9j8=; b=Qs9J6k5DxUrCn0UjvzNXjqRJQ8i4jN7c3gpMKGfp0oi3ZKEBfaBhyJP4rTkPsfWtkW jhpxKs8wnPQSZFM62Zgna7+Q2UOfxgVY0h1Fdd1EUzO5W4xA5Ti9xd4xI7APbOy3Fuw5 FBWFa+sePtS2GGkVTuSLnk5hEsttej4ACAp9SL1UlatAKNEMPGjIc1LKSdzi96MKuF9Z veY0IpnP+cHUe0B+oauEOKgpS/qdeV/0hmVr/ahjIOYUeTU8vM5pNMy8q7RTfb+vaxNe rXXdGWQUTixs91oyeplz1ZozNl4NucxWHTwrTFNUB69+KImBtwNcIsgblG6PFixnb3F6 q5zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793013076; x=1793617876; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=v4bzzFUs5FUeu+ae8i0ujhOEohnvZCsWP+SqJqsP9j8=; b=h6eBIiqd47e4JMDc6XUn0yq7m1wpmIKbVbcGSM4tqtqtaVRakUD6DYHhY8Xakn63ZW 4b391lTruS7Fiw2DiNw6CRFTNCbn/Rhjg26/N1aepeErIziEHAokHxAlr1nUNJ5CFUYM DVC3xVHT3lne5n9uEyI9s3dwKxx4pTE/vznu7gHk1MCh5a8lm9rIgHdEn25L7wwbti5B EBOkft/HMWL4JJO0Wg7gAgsfbt9SDJ1TTWnDSnp3NpwRvo/5YD9B0QLIITX9S4fkDHO7 c6w4WGP8l5XBFcr1QgZ/lyRe8g4FrZC5mTLHiGtIBs3mVhf894t+3eAIYQE9Ps/VK/D6 bXcg== X-Gm-Message-State: AFq9FYJaWS+mJn30ZW1WvBd6GqOiLWSsYHyoYE5MefTRW2XN5EczTis4 YdJFBmcLscjKlktMBOVHpq11S6EgWgMs/6TQrfWA1+pBB/WSlFeS69avL3xEzCOUC4RgcA== X-Gm-Gg: AYBFou3Rtv004PmQotmklc5Zb33JJEKBCwXAI1+/XaLZ8qF8ny+feYDLLwEJtrtXTu+ peSDjFjN3lv9I0tCQCRnG0J9smfU9q17zklD3oxz+QM+NNAJkRxhqGMrnWkq/252zmiHem1ybCk XQXnZooxuov21REMqrwy3QOenJD7h0hajHFJpPj2tfBY8NfotlZevNRk/QYqfuTokgyuYXT9ZwL RnhwNLrkOYSwQGmHxUyaTFMCSXj1EPY5/hLmjrJTj1cyQa/d1rCoYXjnHfLFABQHHXiqRenDppb Gzy2g1odEcxW3X+ioZrCwdDduTyPvMdKkkMbuYNuOdMjHo2rk6XH3QDLhzTUp4YOel9k2O/St5q drnpMrIcFKl36Bn2LpSI6VwFfP5EehSYSWQpj9EVUmuMfWFRiZFyOh3emCvfv2xdjsKPKFuIbiU bZPSfdWfoA5oYpLNoUnupKKSk7vTL9DXTuJZXrRs3zb9Cd3q8CuWn+DQI+SpWqXYhoEsrpFHWzn 0Tko4+OucDCspOzJgYXZ20LvMc84qkw36ScnaE1F5nR0SDX+2A= X-Received: by 2002:a05:600c:4e12:b0:4a1:702f:c736 with SMTP id 5b1f17b1804b1-4a35ac3f7bdmr122302385e9.3.1793013075931; Mon, 26 Oct 2026 04:11:15 -0700 (PDT) Received: from athena.sw.ru ([2a06:5b06:b600:300:1a6:7f7f:f573:ba9e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a35a033702sm152410065e9.2.2026.10.26.04.11.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2026 04:11:15 -0700 (PDT) From: "Denis V. Lunev" To: andrey.drobyshev@virtuozzo.com Cc: svt-core@virtuozzo.com, den@openvz.org Subject: [PATCH hci-8.1 0/1] virtio-scsi: fix hot-plugged disk invisible in the guest #VSTOR-151351 Date: Mon, 26 Oct 2026 12:11:12 +0100 Message-ID: <20261026111113.145378-1-den@openvz.org> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: ZR1PEPF0000E6AD:EE_|PAVPR08MB10339:EE_ X-MS-Office365-Filtering-Correlation-Id: 0e8e75b5-2a9d-43e2-3a75-08df3351dacf X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 0 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704161411799003|82310400026|43022699015|9140799003|376014|48200799018|6059299003|61400799027|55112099003|18002099003|16102099003|56012099006|5063699009|261021123027099003|10067099003|261009223027099003|261022105027099003|261021121427099003; X-Microsoft-Antispam-Message-Info: kyNEK3lMi8WYahdgUTsEV5LMfakKmd6efshEf8co1HWZgt/8X13Gug1VIZ2P7qYOxBnHRs/zV+opXxBohBzuTNzwXOsGF6jR5cisOHXSlroHaQNKrrHgGzsaTtKOW5mEeZ8phRWlDDQyBKKkAQQ4+0Wy8RiE5XUQFeeAJ9nK4sw3P6IOQAKzHTzyR/aLA1lms5yw1JYMYsT1HL7KwjOg9Qt8BObngvbsAYfZwN6x5ab3Kqm9z8Q42w2m2tHdnHTcFUJWfwvZZMFMtSR4PH8keuoOcy59A/LQ1cFmiAyOW+R6/uv7RLyxEZZRPQwsfUOTDLQkxAhKvMhooJpc/c+U/OoSFWkUZJjrS6zBfA1OIhJQmbjDGmiZAkoNIYW2VAmQUNcg4/tfXMPCcIEanGZqlDxkB7qsmxoO5CsGSeKSlX4009e41C8PMarDBRjnOzVyU5Znda6b/ik0UG/ouB4163yfYjEzIvMEvL3JGjeDkJX164uTytnROIQ1Y/kao6yL8WHYj8b/2bkBlbZACsEPiTrIRR0lmF9usbz6x9sXOHcvXAmFIWiyJNMcj3lqGtqUCHq4T0oeZevwk2kX+wogem7uuLGIW3A9TGhzdPJQR2v4B0VrtgfyX26+qx9EcioQOFJEdZKnMc15O4Vi2/m/wohDKXXrCKSR0vUq+rS41brzjbwaVLMdUYs86036sacbLw+1dKeBlNZZDWY4IsoBmVxIsdQ1xmvPq2mWyREGezE+cOLPJnLyq+9588tL2rXzEZcbSIZAE8jStNbAc3CXiMyF/igSwvYzW0b4PoYSSBI4BgzMOZkOEfAaqXbKVmFf4JHthFQRlTOigm4ZtN6Qw6LjE6/zJcQrrCIyLqQqKgdUxzr5WpCCp41g4GvMvsjf X-Forefront-Antispam-Report: CIP:2a00:1450:4864:20::32c;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail-wm1-x32c.google.com;PTR:mail-wm1-x32c.google.com;CAT:NONE;SFS:(13230040)(704161411799003)(82310400026)(43022699015)(9140799003)(376014)(48200799018)(6059299003)(61400799027)(55112099003)(18002099003)(16102099003)(56012099006)(5063699009)(261021123027099003)(10067099003)(261009223027099003)(261022105027099003)(261021121427099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: +HxrbLZepC1eY2QVsXm9D1fb1/X+ONhMowwYxz3YSOfsJSjb2QyKuhibIouqC9TrJUbI7bs8uBByrL8SVteIgCCpGk+c+Kkpmds6nPRvdn6ZVFW1jN3uPYDWH9DZ8a5AsqtLZ4C6JPfWJTXw8xMR2/a0bndIQnXQkbaxfvBpimsNjEq1tss5Q10VlNBQy5bDoU+IDCwkmNJVjKBeWXQ9R1+n4no0gogQV9j8SejFQsOr18mIVHHrxfyR2IuYJdBQWgBWCCk3DEoYLujdtAbDWVeyOI9VkV9MEEXcHdp+yYQRYxCvgcjC7HpBn/PwfkzVBbWtF604CSBOYudxdqw6g+oieIz/QGCxUezyIpVLJ2c5snOtABp394PfXbBWEfAyboyiPaJ4lyXyAHV0sD6IJXJCV9v+93RQQkjqAvQqc58UNVLhO9zhB33r8n7cXy6d X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2026 11:11:16.5650 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0e8e75b5-2a9d-43e2-3a75-08df3351dacf X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: ZR1PEPF0000E6AD.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB10339 List-Id: A disk or CD-ROM hot-plugged into virtio-scsi sometimes never shows up in the guest until the bus is rescanned by hand. CI hits it with Windows Server guests (vioscsi) and with Linux guests, always with the controller on an iothread: VSTOR-151351, VSTOR-147722, VSTOR-150741 and the Linux tickets VSTOR-146483, 146499, 146614 and 147072. The RESCAN event is pushed from the plug() callback, before the device is realized, and the iothread request path does not see unrealized devices. A guest that scans right away gets BAD_TARGET and does not retry. The patch moves the event to a main-loop bottom half. Ilya Rudakov found the cause. This is the patch posted to qemu-devel on 2026-10-23, not yet merged: https://lore.kernel.org/qemu-devel/20261023162000.2796947-1-den@openvz.org/ The only difference is the non-const HotplugHandler argument of virtio_scsi_hotplug() in our tree. There is no test in the patch: a qtest or iotests client is served by the main loop and cannot get a request into the window inside device_add. On the upstream build, a Linux guest with the main thread stalled for 3 s in scsi_bus_set_ua() under gdb missed the hot-plugged LUN in 3 of 3 runs without the fix and saw it in 3 of 3 with it. On this tree, hw/scsi/virtio-scsi.c only has been build-checked. Signed-off-by: Denis V. Lunev Denis V. Lunev (1): virtio-scsi: fix hot-plug event racing device realize #VSTOR-151351 hw/scsi/virtio-scsi.c | 38 +++++++++++++++++++++++++++----------- 1 file changed, 27 insertions(+), 11 deletions(-) base-commit: f3c1d9ef263edfab8d2a273078493bb766dcf8f8 -- 2.53.0