From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11021138.outbound.protection.outlook.com [40.107.130.138]) by lore.virtuozzo.com (Postfix) with ESMTPS id D326F8017D for ; Mon, 26 Oct 2026 11:11:47 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TfPGzJJkQpuNt4j8vqfbB+/uVFJE7Bn+l5VorIxIX5meyYW3ZCDpG739V7jYuPMm6H4H2tpnS4zRWj6u/V6aotkgFH3XDxkyUJLI6Tq/MLAWITGEd5wjgf6GKsvqRTW/SOlnELSIBM7zwBoOHsnexoexZizTbNfyoGjgVykRSg1GkaTJWQRGJf1sW3jZP3CHQ0Z36ORed3a5uRlvci9Tnw9NeSw/LYqJY7IAHpr7kpJsSQHTQq8ZIh1u7MjSrWkxNmRqKZ6V4F74TxYAOrtHiLCYFEkGNsaKEryo+jYlqHpxpnhJHNPIR+GgC78Ze4M9BuCqGASM5YQ+5blvXzBCSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v4bzzFUs5FUeu+ae8i0ujhOEohnvZCsWP+SqJqsP9j8=; b=GB2yx3rKcAVGDnfhaC8imhoA9w7yxlNxZ4e8L69CKCPAtqkmWmMU7QIJ4yzCYPgRlBG9+ieBq6kczOEQO16botMIG3FjOws6GckSF3rL9BITuAw60Xko136hYaLM8XKOKOlULgMesABtrtF0ywWfKhC+MqAPe9cjbKfjd0aizolDMYcwkdjQgxP6AkfyyT/RUH1LoErPGskbt9raaWeSIQagZL+27X81rTM94K2uABu4ox04QxxHBG0tvBQb4jV/TR+yigmHLWO3UQ1Qny5whxg8QQb9WfSc/lvzpWQPY6tio4iptlTeeEmZ79LIdGLUhqQuNni27ZVcl7htWSwQtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 2a00:1450:4864:20::42a) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=openvz.org; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=openvz.org; dkim=pass (signature was verified) header.d=openvz.org; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v4bzzFUs5FUeu+ae8i0ujhOEohnvZCsWP+SqJqsP9j8=; b=Ye04dY0W1rPf0/2yeYmac6ASz5xlcPN4j27P2icTNGvrS2Xx11JDPIL7Y9ZV+2uTQPOqIvBKoBBsX0XM/eVIwvyDtC1T/uSHotnFqusB1JZhQwEhixq589oMWZh0AluU1nkmy6nTQcFiFyzgH9a7aVQxLrjpzgJoZIPYpUHYEvs= Received: from PR3P189CA0081.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:b4::26) by GV1PR08MB7899.eurprd08.prod.outlook.com (2603:10a6:150:5e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.22; Mon, 26 Oct 2026 11:11:42 +0000 Received: from MI3PEPF0000855C.eurprd05.prod.outlook.com (2603:10a6:102:b4:cafe::92) by PR3P189CA0081.outlook.office365.com (2603:10a6:102:b4::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.22 via Frontend Transport; Mon, 26 Oct 2026 11:11:38 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 2a00:1450:4864:20::42a) smtp.mailfrom=openvz.org; dkim=pass (signature was verified) header.d=openvz.org;dmarc=pass action=none header.from=openvz.org; Received-SPF: Pass (protection.outlook.com: domain of openvz.org designates 2a00:1450:4864:20::42a as permitted sender) receiver=protection.outlook.com; client-ip=2a00:1450:4864:20::42a; helo=mail-wr1-x42a.google.com; pr=C Received: from mail-wr1-x42a.google.com (2a00:1450:4864:20::42a) by MI3PEPF0000855C.mail.protection.outlook.com (2603:10a6:298:1::98) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Mon, 26 Oct 2026 11:11:37 +0000 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-48dee593f18so2122265f8f.3 for ; Mon, 26 Oct 2026 04:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1793013097; x=1793617897; darn=virtuozzo.com; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=v4bzzFUs5FUeu+ae8i0ujhOEohnvZCsWP+SqJqsP9j8=; b=nMI63RQ1vUOrGoruyyS1boYNoTmrP2B9hOUNilCrfa//HTX3MFfLt5/5k9vYQUUuUe vaae37bm3R+U2nWfffCySmj636vADwHHy4StgYr95BlJ71wTg6Bs3nQYygTEKZpZu96Z DmFYyAvCpu99QiEeTvX+5gpd9XA28bsmeLGUp30LUs3Qn46M0CjdgXfT+MRd02g7O8/t oDO0EF/ThlnmcL79BMuHt92bjezstrls50+4OzJmZLNHYvEnQSFws88C64Cf9i24toqd zJvBHIZ1Dh0E6SUsmcIQf/SJbN6ORbyvTlNGUHsX3eVZY5Mf5Glzrg3U1k5E2aoTPehQ 5wjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793013097; x=1793617897; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=v4bzzFUs5FUeu+ae8i0ujhOEohnvZCsWP+SqJqsP9j8=; b=jP4kMtJgKxrcfeHYkAhAV4NElwSgwGnBTtywSYE4u1rqP8AcrEnwoxuDG+vYQsQWKY xL7xxCzzUYQhNrmHRCaON+p+QK5M2dV441PO4cbTeBzupT5OF53NVMhatzQ+L88SULmE 7EfNeIwaAL16lF+TazFVsuI5mTjdp+i9JcGppOnNsLqNawYF1YdpljIEOBlp1mflYiaI eJ733u9O+lwfi1WHWwA7oRZET5rC0hleIXO90Rntsn9N/lVq2QPrUMtpFk9U4YQY73os fg4DFjQSH/sBsIvv8ZPHRgg27jJTJslXnAWI7+D+JoGvk7kjax3mB+QFZ0AlaVVBOrsc 6yhw== X-Gm-Message-State: AFq9FYKawci1GuRUCGSQPkquoy1ZOTn0YU1rGE7imLX73Dgo3aEjvumH RndG7mmFF90ok6XaMeWO2Zd+BS4pubtvhe77Pl7k62B5tRqM6AUx/riYihblrL31DbglhQ== X-Gm-Gg: AYBFou3NIYLEoHdgs1soIcAz0AdN3fzB2XW32FZ0ygWzd/zx49kGGEflnOz1ToCaoNf EBAnfJFsiiLqSRdikgOABhgZ04DX7qUzS83uculr6XLgNXDKZE2oS8l6TzkgheR1/mMB5ZdI4Gr +srpAdZEcLhuStR2bN+ZGtO367xLicN9h/TjCWQHgSD9ej5xTMh41aA9ftPDWLlJgiUWn2h6is8 c8esuViHIVoNh68a2XjvjgHpCCIEmD9i8udx2uBRRTYcsxfP+Mo6DMejf0P0BCH6OOwZUfpCT2p el80CVTisrfC/O3+H0zfGv6NAoLnLa4poinGWqxUkGPIS4SE/gS9eddE0Soary1cCCGIjV2b+1E We0WvPhKOhoCmDHmbK8el79YloxrgRCk+o6Iez/Ky+hj465jIefuN5wBTPaDq96UjfKAPLmMrof SQpOWXB8AEmpULw1t8gMccumjWd6CBdPH2MayMGjizUGmWfXRdmJDVqqgj/1NglhG3REfciX+4O Hfg3APUGkj+X2419anGFouO7C0hnClZYCIbc+GLAdzZ6pmFZgw= X-Received: by 2002:a05:6000:470d:b0:48e:d27:bee4 with SMTP id ffacd0b85a97d-48e3eb3cc3amr11634652f8f.2.1793013096745; Mon, 26 Oct 2026 04:11:36 -0700 (PDT) Received: from athena.sw.ru ([2a06:5b06:b600:300:1a6:7f7f:f573:ba9e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e3ece5e4asm15587335f8f.59.2026.10.26.04.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2026 04:11:36 -0700 (PDT) From: "Denis V. Lunev" To: andrey.drobyshev@virtuozzo.com Cc: svt-core@virtuozzo.com, den@openvz.org Subject: [PATCH hci-8.1 0/1] virtio-scsi: fix hot-plugged disk invisible in the guest #VSTOR-151351 Date: Mon, 26 Oct 2026 12:11:33 +0100 Message-ID: <20261026111134.145823-1-den@openvz.org> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI3PEPF0000855C:EE_|GV1PR08MB7899:EE_ X-MS-Office365-Filtering-Correlation-Id: 5823c8f5-c95d-4216-bb9b-08df3351e760 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 0 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704161411799003|376014|48200799018|6059299003|61400799027|9140799003|43022699015|82310400026|5063699009|56012099006|261009223027099003|261021123027099003|261022105027099003|261021121427099003|10067099003|55112099003|18002099003|16102099003|13003099007; X-Microsoft-Antispam-Message-Info: V4i3pCQKIpHp+t7eQkTiIOxiO2D0VeSU95WSKIWEEkRUVt7qCg+Pn9F2ZoXYfFQ7fTgoHnI/kpgKz/aFuE7dZMEP1bvv5wm8wpqv5qxA77EvU6zuHMBlLXk0yZbm9rLJWvF7QA4HxkczEaUmixyk4ePsobIOqVThJpjRmEpzidI6HpWZ+WK08LSgkL5FX2s9RTZ0LsUNJai3hMYt3A9DDa6dHzBOnQanmiwft7jP6HqJpDNO6Gg/eOfEfYttjyaSFLzAfSXs+dnf9QWP0zpdjW/WznRD7TC3RzxZA6LJ5eXgelfMc3yL6a5ZJXbCfab75mMl8PkDXX5y3SUBQEz310q9/PZiGJX3/MJ5qPNYG7mpVfAaU6stjte1fcSIxDeMpVZwA3xCComEFq0JE5zsu0HTnCdmYm5LAnmAYfiVEyuApMuZGFjpEwsNC25/PrG8twcfOuvoaT2SRue1szykkQWsx2GMPb8yGjD/N0lhRhjKcJYF4ZAZOZybyP2TyhpAqgVB0KZ9oa+Az+4aK0n6PqJSPJrnHTmLuRG5V/giZ9IbCwkMjFVTKo4QsT0rr77f+FTI/FcxcD4WsL6shthD9uGrR2lJq1HuF0KqkSZUzMpb2JreS5RjwMV5CJqcYNuWM6fZ5BqdXGrUZxbUJWJCDRnKEbYQTyWW6vwzfcAkWwncHIhKuFmi+tjkI2ewZPs+T+AnDGPlZXw1Mrpn5cFcXdkSQWwUkyT7POro7ydcv64hy+VIGzMHP5xujaImCy09Ux9BJVY8zFsVx98OWyQu2HXI7g8Bjf15PnM2MnRmsuk4DG6c+kHFWQSkkMzsLDibvk9zOOsUJhqFN7qGv/ctggU/G7q/AE63+17bNJHDMXcrfx9IclBWU4jSR6o9mV5C X-Forefront-Antispam-Report: CIP:2a00:1450:4864:20::42a;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail-wr1-x42a.google.com;PTR:mail-wr1-x42a.google.com;CAT:NONE;SFS:(13230040)(704161411799003)(376014)(48200799018)(6059299003)(61400799027)(9140799003)(43022699015)(82310400026)(5063699009)(56012099006)(261009223027099003)(261021123027099003)(261022105027099003)(261021121427099003)(10067099003)(55112099003)(18002099003)(16102099003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Yx19mJM540+8yuRHb7W4oyPqbtSrjJ/R7XICmgU+Uc+xz84w8PbWIoYI53EUulsU/OTiwHKUliRDVs5fYOXVhfw2Qx5RC0VlR2hE/lpWMnE/aNU7X4l9m81+VVwjkj3GcJWZOUrsGPv62lLRYzFarPiQDcVVbNHTxIf7639d1sRtNScTIiK7OSaZpnti5XGCw0dqPX4jjmCQPJDYJG9ASlPzsUzVJLuwk6Cu/hGhiq2gTzDo2qxW8Ye0YVtnB7/iLusV93eNAUV80GMt/Lp5SND/0opETuDzA/zhoclyn+kR93rZfS3SM+MtYJumK0N0XShAp+sdVlxzokbpWJJ7HzLwoFjTq4LFPvefMC5CflzIMNbjTR0W5gW9eSyFSql2NTnjicH3zE6emzeoT0otgqJUGscGI5fslZbJKZnsCpcJCS9j+puOR0sdaftYuJD6 X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2026 11:11:37.6633 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5823c8f5-c95d-4216-bb9b-08df3351e760 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MI3PEPF0000855C.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7899 List-Id: A disk or CD-ROM hot-plugged into virtio-scsi sometimes never shows up in the guest until the bus is rescanned by hand. CI hits it with Windows Server guests (vioscsi) and with Linux guests, always with the controller on an iothread: VSTOR-151351, VSTOR-147722, VSTOR-150741 and the Linux tickets VSTOR-146483, 146499, 146614 and 147072. The RESCAN event is pushed from the plug() callback, before the device is realized, and the iothread request path does not see unrealized devices. A guest that scans right away gets BAD_TARGET and does not retry. The patch moves the event to a main-loop bottom half. Ilya Rudakov found the cause. This is the patch posted to qemu-devel on 2026-10-23, not yet merged: https://lore.kernel.org/qemu-devel/20261023162000.2796947-1-den@openvz.org/ The only difference is the non-const HotplugHandler argument of virtio_scsi_hotplug() in our tree. There is no test in the patch: a qtest or iotests client is served by the main loop and cannot get a request into the window inside device_add. On the upstream build, a Linux guest with the main thread stalled for 3 s in scsi_bus_set_ua() under gdb missed the hot-plugged LUN in 3 of 3 runs without the fix and saw it in 3 of 3 with it. On this tree, hw/scsi/virtio-scsi.c only has been build-checked. Signed-off-by: Denis V. Lunev Denis V. Lunev (1): virtio-scsi: fix hot-plug event racing device realize #VSTOR-151351 hw/scsi/virtio-scsi.c | 38 +++++++++++++++++++++++++++----------- 1 file changed, 27 insertions(+), 11 deletions(-) base-commit: f3c1d9ef263edfab8d2a273078493bb766dcf8f8 -- 2.53.0