From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11021109.outbound.protection.outlook.com [52.101.70.109]) by lore.virtuozzo.com (Postfix) with ESMTPS id 96D418017D for ; Mon, 26 Oct 2026 19:37:22 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mV7kQSu0Jyw+woNdSxoama47GbdwFlNjBTx2DC7yGdE7hitw0PyxIAidfoNtsDNqzuZUmbfi+7A/4GeuJAbJOcOHjN0n9pTGjS6rwd04yZcNgsNKc7oZJ+kPicX7lGh38aoSP5lujL2Cy9OXZWocrN4vUpuGLu2BqDly/FddVJmV+xR5q6hfk4FuZSdDBNAHksCCtxZvrIPtuGaSPtrKgav3RjlIF7x3TqlBHkCP1i8IeOBRmb/YnT8gwnR2q3tJtAXiaEr+58B3Cd9Hjs7WANpHQ8SVlgqtFYpN3FPqbBcR62QYdOATp49yZKUU/Wg5W5s2hPHiWUIBTZz19PBTvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RR0l75Gk+83dmhHAfTv10RE4l8TnUexPfTKb3taJg54=; b=bOaThLIoZkGTTAres7IXzDTf6Y81Eqrpz+RqN42PWApRDRyoWQifek7lDtXvTA4gyH2ZuYtvayTLQASZdvImTHnREWNJJ+SwJGL55BZpIDj1LlNa3S3wrGF99bH5p0DikwE5vvx2NfSHjzyNyyL/K7fBOuArVb7hMjbQfJ4YJDDW/8WLeFthxr4a7VMDNRlMec5OgX948NTUEj6X70okUkdrw2GLAIFd7BIi4edM12GlpPPZMbEBV54Wpva5iZAtqPQMKfFiXGsaSbpLwr1pxK7iLb9fpI1dv26PfabW09kkoVxcWgxbTm8nNyC7RlGg1dKqqDGrpA8NsVNIAMwYyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 2a00:1450:4864:20::434) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=openvz.org; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=openvz.org; dkim=pass (signature was verified) header.d=openvz.org; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RR0l75Gk+83dmhHAfTv10RE4l8TnUexPfTKb3taJg54=; b=Qy+ehocztP5GdoRuf5Pb5q/CPtOFpOGQIqlvfJdEpac39ccwddo3EpuHGf4SG7dUPF84nz7llE9aezd+HMJ9aGztN2Jepzs1K84z+65TX2P3BAckQ65yLmS3/nTfVZdG5XxIfrYbNpQlvaUNzSk/1zWOCyhP0hErG49SQeFPO+g= Received: from AS9PR06CA0326.eurprd06.prod.outlook.com (2603:10a6:20b:45b::34) by PAXPR08MB6559.eurprd08.prod.outlook.com (2603:10a6:102:df::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.22; Mon, 26 Oct 2026 19:37:19 +0000 Received: from CPH1EPF00000525.eurprd05.prod.outlook.com (2603:10a6:20b:45b:cafe::4a) by AS9PR06CA0326.outlook.office365.com (2603:10a6:20b:45b::34) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.22 via Frontend Transport; Mon, 26 Oct 2026 19:37:19 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 2a00:1450:4864:20::434) smtp.mailfrom=openvz.org; dkim=pass (signature was verified) header.d=openvz.org;dmarc=pass action=none header.from=openvz.org; Received-SPF: Pass (protection.outlook.com: domain of openvz.org designates 2a00:1450:4864:20::434 as permitted sender) receiver=protection.outlook.com; client-ip=2a00:1450:4864:20::434; helo=mail-wr1-x434.google.com; pr=C Received: from mail-wr1-x434.google.com (2a00:1450:4864:20::434) by CPH1EPF00000525.mail.protection.outlook.com (2603:10a6:388::1e8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Mon, 26 Oct 2026 19:37:19 +0000 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-48afbd2c386so2084513f8f.3 for ; Mon, 26 Oct 2026 12:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1793043438; x=1793648238; darn=virtuozzo.com; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=RR0l75Gk+83dmhHAfTv10RE4l8TnUexPfTKb3taJg54=; b=P8aHTPNCRP0vJalfKL+Eo9en4odKC6dwLfWD5exm2tVXm5jsWzwdTFs/rzG4OabgBA enbZVVvbBbKdTirfR0w58VNKuhsMlxM4Fnkl6KvbIv8FHChCbOwkiBFWWiDNossrFVtT okw3TjwCzOd13LoMFoUOQu8Xyv8T1sK2UiJpQUyNTZgdyv1QSlV83pllO+dlfJcPvhXC SsR8MbwjNs5SKaknoKmnHVC4zs+5XrBtwqDvgqd1fbHytdFw7LXq2hN/Jl9PPTgB9Cl1 gp/E/gZhPz6UlsP1SHr77nhPwzRZltAHXPUCgxI0r5zVNRoIGM9CBrHOw+GWN/kwseFg 4WeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793043438; x=1793648238; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RR0l75Gk+83dmhHAfTv10RE4l8TnUexPfTKb3taJg54=; b=tQzPZ8efQWxzxIRnVnDBwXGWPPmD2JDxN8fWpVhnZfoDwzoPB8jp9JSPGpxxIwm0m+ LCluok9/oISPPc4MLXr7h6T3P2MQJLD72rwK4Rmo+VfMYALl9+JP8rdSNcVuNHwOtmTG kUCccgiQw+mxlaD9MN+RTjr9VuWCth/ucEX8wNsEeBxjQ88jT6xLZLWSrCxt6xcoDdw9 jFGvCQkUrp7/4Evtj6C/+DK0LIg5Ekcfg+QACrpBbwW6KmJDjPsgCGCv+rxj8PbtSwpF 9Xa0Ur3zCi+SipYIKn+loQQ7wq6jyo6/5x6LejpIz8twf/JjBhnlGezuV4E9DQArUhe6 XWTA== X-Gm-Message-State: AFq9FYIZ8E2rVE72Z4f0zjkhXXZ787tDs7qdfHokr0+4Djunz542gHnc JLyh1tOcgAKwnDGa9o4tee4ncCuDHJqShLz3hHfiyg+fQAcehaYenWzPRVLJMj4xmILe29snSZz hY3OPD88= X-Gm-Gg: AYBFou2XbsdWXP94TJEIsCHm0GLvrrDSLlxiPo01GjKXuhWRsoVzMxAxYW8dhl0InjY P4WBj0Ljfb2jBzUzarLGs71cRjYDt8u7SO5SM2Fes+C9rpbmgE+jKwnkfADFRhsCQ4I7g/Bs2NC cRe6I3fqQLnb2lUpoqUqEKzsO/kwcRyrHwcWo9ycQyARPn6nNwEAoYwWIv6zFn9zdgXlxgzxl6x t7Q6kXQSxU/wyo9S5tiv28ebbvhy+LSwoPAapWEffEr2Qr/zgTQTe4awcgnQwRQPTxHJP99iKr/ jaW3VWqFfhgR7wiOzzGjiBtCwNUM/Ykt+x9lEB9DJ48UDHn+Jyvl+4yuTxNDlxMEOiFVmvAHpw2 fmqPzIdfu2zSzW2snn3smJZtKva96VBHbmBqOdXvn2yFGi2tQkwrHeFvMaV5G9Q2N/kP5YQ3xQf gtgkGGeffrax3xqShFaPbmZpgZAP4eNavsHsTYheKohTQoIm0b7BhZib0UPxlQo6xh1SZWyY4MH 2rJbFASeAqrWyEJ2KWha6acxNW9zyyX9oY1CPjn9lA1f6rBOr0= X-Received: by 2002:a05:6000:4552:b0:48e:2bf0:e56e with SMTP id ffacd0b85a97d-48e3eb7632cmr9205864f8f.18.1793043438348; Mon, 26 Oct 2026 12:37:18 -0700 (PDT) Received: from athena.sw.ru ([2a06:5b06:b600:300:1a6:7f7f:f573:ba9e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e3ecd3555sm17641792f8f.42.2026.10.26.12.37.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2026 12:37:17 -0700 (PDT) From: "Denis V. Lunev" To: andrey.drobyshev@virtuozzo.com Cc: svt-core@virtuozzo.com, den@openvz.org Subject: [PATCH hci-8.1 0/1] qcow2: fix guest TRIM destroying internal snapshot data #VSTOR-144873 Date: Mon, 26 Oct 2026 20:37:14 +0100 Message-ID: <20261026193715.828224-1-den@openvz.org> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CPH1EPF00000525:EE_|PAXPR08MB6559:EE_ X-MS-Office365-Filtering-Correlation-Id: 3ca12b5a-4761-4b5b-0eba-08df33988c46 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 0 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704161411799003|9140799003|82310400026|43022699015|6059299003|48200799018|376014|61400799027|10067099003|55112099003|16102099003|261026121527099003|18002099003|5063699009|5023799004|56012099006|261021123027099003|261009223027099003|261022115727099003|261022075727099003|261021121427099003|261022105027099003|261026140227099003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?QOFnYaqDEzy5n5fc/dCQqgKZBxP1HBfj67a6fhM3PUvOWk6e3RMvKeR67iY3?= =?us-ascii?Q?qn2mDVTQshcIs7ZUvRVm+2FF2VzBksCWEXuyLVUsXVeA/pg2Dfgt/juxYqvR?= =?us-ascii?Q?iMKRMRevnzih27xUOG6g2qiDo1O7sLiwOmp0DSx8WPFJJ04aaQrEQ//6F7CW?= =?us-ascii?Q?2xrAmwOt1A2lpjhBhn+4vwX3TQrUeRBoKkBJWa+1HHCUtLLeV5lnvTSKFTot?= =?us-ascii?Q?SA0bIXwA67P0DmF8Ssy9hpnrA+bPqbWFgTfP3YNz++9baC57ThVHa0ijo8Cz?= =?us-ascii?Q?1YWO4WbXpT7zbwPcNnQq155U0FJfgzp5+r4WdVScf+BCL1nunlAbO+LO1F1s?= =?us-ascii?Q?tefYfpPOhg0c+L0y/NU0NM/fj4P42OO+eAQ5nS5cOLud4PQ9O/bkHXIVAZls?= =?us-ascii?Q?9ss+JLoYMIrIKNNZFYrEWUQYlp1PFmUaB8zvqnnHlgi0/pFh3Hh8R58JrdM1?= =?us-ascii?Q?sLqO7LEH7gxYcO5/LugEfe3Gk411Y7fjFtcL9FNGYsDtCrDAzpMVBizbS2s1?= =?us-ascii?Q?QUW+QO7vtmZ2uFxvsCAw5ms6MBs42WDllKvJe0CGfdW0cuPLSKdZJEd9vZxm?= =?us-ascii?Q?Q371u858hyOSErSwmdLUIMGvcga9roM/eMm18i8rA3Lz9g+QevqfZk6vci0W?= =?us-ascii?Q?qzjfnBt7G2uWGYWWWi5l5Eo6p2H7nBHe+av1wWsufTf5NznPyWN0lSkbjK2P?= =?us-ascii?Q?YCv7w6aD2aSrO6nJHhFFpormXeT/oy21G3wLyPharipWS1WgBhjsdXPUmw+d?= =?us-ascii?Q?cP5gxka/M0b1zOo2jpUUi9G55IXo4lzEuq1ZkghB81m2MPzOHHLRDRkLEhrS?= =?us-ascii?Q?xFs9NZ+PEirYOLHiZOpWwVySqv/4G5W11U6I/2VB9Eb7bVcOSZq2j4nEsZkS?= =?us-ascii?Q?yi0uzwJK1dJzUFF/r9Qq0WFixi0utsNW28OD+l95xtVnu8ObYhaUV4f4NfL/?= =?us-ascii?Q?XuKOjp6KIkt9IHeq1VK4dSLNfiqXWjnKDFUNQqDftJ0=3D?= X-Forefront-Antispam-Report: CIP:2a00:1450:4864:20::434;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail-wr1-x434.google.com;PTR:mail-wr1-x434.google.com;CAT:NONE;SFS:(13230040)(704161411799003)(9140799003)(82310400026)(43022699015)(6059299003)(48200799018)(376014)(61400799027)(10067099003)(55112099003)(16102099003)(261026121527099003)(18002099003)(5063699009)(5023799004)(56012099006)(261021123027099003)(261009223027099003)(261022115727099003)(261022075727099003)(261021121427099003)(261022105027099003)(261026140227099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: euiu3crCrtBbKZbqXyMwKyRyvvGiAtqk70nP95s8EuBEUJPxNUZnxe+AhhN98vsE8uAOlHpwwJem+LmZMIc1fg0wHdLvBRFQ9Q1rkQQRMlI8LAyoMpl5NvhlTMRHfPfXpkCLC7zxm7dZy39RRWOa0uhjPrzFmYQAHSFb8AuLCe4de4rSAkZrzzIfpIvV/qhPJDYmTaem2UKK1ScT0DzrZ8btEFTaqu7gVYfT0u+IB6UZrQmAekfJ2ilUBOLFHFCEGOrXT/fEzU5SqE+nh9XVFPug99tb/VAXzwbkTuIXfl4uLQr/5QiBFQ7iGxcGJGHtR8xK1uZ29LgDeQPm+td0sx/QSAetVX2oJKq44ixV33NsSglROveXOWkdrGmGKTB4RDkN+TdS7UYkU5e2a5bHFjmwMRynq/6rzlePZjHKk54rYtb55XtkC85J6GF1kvQY X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2026 19:37:19.0101 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3ca12b5a-4761-4b5b-0eba-08df33988c46 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: CPH1EPF00000525.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6559 List-Id: With extended_l2=on, a discard of part of a cluster that an internal snapshot still references punches the host range under it. The snapshot then reads zeroes there, and qemu-img check finds nothing wrong. Every VM disk has discard='unmap' and the image cache uses cluster_size=1M, extended_l2=on, so a guest TRIM after a snapshot is enough: CI reverts gave Windows guests partially zeroed files and left SLES btrfs guests unbootable. The bug comes with our "qcow2: make subclusters discardable" series, which is not upstream. The patch passes the discard to the host only for clusters owned by the active layer alone, and adds a case to iotest 271. iotest 271 on dev-cl04 fails without the fix (the snapshot reads zeroes after revert) and passes with it. Signed-off-by: Denis V. Lunev Denis V. Lunev (1): qcow2: fix subcluster discard punching data shared with a snapshot #VSTOR-144873 block/qcow2-cluster.c | 10 +++++++--- tests/qemu-iotests/271 | 18 ++++++++++++++++++ tests/qemu-iotests/271.out | 5 +++++ 3 files changed, 30 insertions(+), 3 deletions(-) base-commit: 9ad1f5893c80aa612f78cb40c4c8690097ebb9e9 -- 2.53.0