From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11021091.outbound.protection.outlook.com [52.101.65.91]) by lore.virtuozzo.com (Postfix) with ESMTPS id AA58080E7E for ; Thu, 29 Oct 2026 09:23:12 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TnhQzZ/mKiciSs/8S6C9U9afwMNoXEQN+Zm17A6LyNcvtXfIRmYWmq3YdrqMNL0kZbwoCKvZywolzIj+0w0c0Ord17Ut6yg2C2wILiLlRZbqHjxESTtD47narpxnaGsPxheDGWFSkbSekhyXrUzDFqfjymsWDhDw+bfRGX0fgJjWmb0pFJMr+tf+6ySQ4FRIhLOG3d+6bMWLIrKcQzvCtcMnSFReGOZI8WnUBJa3LhYtvceRDnNuF5oW9JbXI72vX/4Itf8yYjQgV4SfHl1NuqtSHajB/2ZBV+orQBNPYXy9cpx1kl3Tr3z7whYsPOJeRElLV5n2pKfY0e37wjk5XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XSSjgGecPOv3gX6sVcJRPkF296kSSeb2wwErcX4tWsk=; b=MJi0yN5N/E93SYsgkkpl4UBCZ8qh21bxj5tQ7hV0s5R1VDUPuiavrH4lwZcpzftZg6CXB4pb1ldjvsrTIGWxkY83qyB5Fqk9WDBhbCFIvJ3Xgr92DQyK4EbxeMe4G6+gkw7PNJSaAf43eXI4oZco0jRO2cf4tU5+MXnuYg/bh1sdduK5dg/ZhMoDrgPs+BNu7FYdS9O7JfI8npLai0XLc01iKSJfwmz188BG6+R7OsWiDcJMm5uI3RENhThCLMgqVIVKdfEjuKsXEdJ1vwwCKaQQ1s9DFqnDU6gsqL9d+/hIpVv3m5cxAh4FYrbGGsmOjktcywxGmJ0qxO5/JwEL1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 130.117.225.111) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=virtuozzo.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=virtuozzo.com; dkim=pass (signature was verified) header.d=virtuozzo.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XSSjgGecPOv3gX6sVcJRPkF296kSSeb2wwErcX4tWsk=; b=aD2taBoj9IO9Br6wf8Q4JQbYQBqqpMegnWQ6sV2ufXDmxYwd/EyK7Xx1ls9XigSL9hpYL29U7qw80DUN5tYmCBGoji5qYnggjQkQSzv1BZyWM8I+yCUKI1GK9Cmsh4g+vccOer4004j+Rb66Xi94KyMgetrB93rdctwjm+kVaQlYL9Wh+120E5E5JUkYo7XLWIDpuUf3xQI6GQLfhB/T/f111wHb4niquD/qJa1Eq2ewnLcONF+Gf/KM94ahuBRm8jgPkyLbz6S6V2nz8rPUUsUvRNwrS/wSDhzQBG+u+DKDLb6+HTdMfLHvxggBHClejZu/EX7eta96orU6/hvjmw== Received: from AS9PR04CA0064.eurprd04.prod.outlook.com (2603:10a6:20b:48b::17) by MI3PR08MB665546.eurprd08.prod.outlook.com (2603:10a6:290:203::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.8; Thu, 29 Oct 2026 09:23:08 +0000 Received: from AM2PEPF00070CF5.eurprd02.prod.outlook.com (2603:10a6:20b:48b:cafe::23) by AS9PR04CA0064.outlook.office365.com (2603:10a6:20b:48b::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.8 via Frontend Transport; Thu, 29 Oct 2026 09:23:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 130.117.225.111) smtp.mailfrom=virtuozzo.com; dkim=pass (signature was verified) header.d=virtuozzo.com;dmarc=pass action=none header.from=virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of virtuozzo.com designates 130.117.225.111 as permitted sender) receiver=protection.outlook.com; client-ip=130.117.225.111; helo=relay.virtuozzo.com; pr=C Received: from relay.virtuozzo.com (130.117.225.111) by AM2PEPF00070CF5.mail.protection.outlook.com (10.167.242.7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Thu, 29 Oct 2026 09:23:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=XSSjgGecPOv3gX6sVcJRPkF296kSSeb2wwErcX4tWsk=; b=aGj3AyZwdQP/ vxf/mjtR4Vcuic2tHG4w7+qQbqh54e9LoyAyFduqEke1u52EmuCdqq+sr2r5DXZ66ygsJ3m2wCEMV pJJdbY07AL1OKPSSt/rHkSEb6h5jXeAE72vMcPhJ8jAJQ1XKfEQKxiQrdw+pXOx4TZTjL0oPX2Yrw vAnwxrZxcSCQJ/StNXNgA0jCm0izHQJlVX0bK9n+sog3akAgFsJVy/D/0zLyw1h5FZKAS/yyTLoic UfN8IV+bPF3xGUp7jaANLZKICQRuTfNXJqmNKig038ALHwRc4/3WSYPyJnUwsI5A84kLyc3jsJhZJ w7skCyhQqExXsrvCA8rnEQ==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xMMHv-000QvD-06; Thu, 29 Oct 2026 10:23:04 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com, svt-core@virtuozzo.com Subject: [PATCH hci-8.1 v4 2/5] vhost-blk: reject num-queues above VHOST_BLK_MAX_QUEUES Date: Thu, 29 Oct 2026 10:22:58 +0100 Message-ID: <20261029092301.3286535-3-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261029092301.3286535-1-alexander.ivanov@virtuozzo.com> References: <20261029092301.3286535-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM2PEPF00070CF5:EE_|MI3PR08MB665546:EE_ X-MS-Office365-Filtering-Correlation-Id: a43e40c1-8285-4f4f-2100-08df359e3dd8 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|82310400026|23010399003|36860700016|261028144727099003|261026121527099003|261026140227099003|56012099006|261009223027099003|261021121427099003|261022105027099003|261021123027099003|10067099003|18002099003|22082099003|5113699003|6133799003; X-Microsoft-Antispam-Message-Info: n60hKsCYFN0xeWtN6NkzbeG5eNJc4/OGAE3TMI2jjN0iS2aDyEIiIJjeYAY4/jlnSum/2PDzOGCYW/kWTlVkc1RYrD1TRnXTk3iR6Qnuj8f6psP67TByVc/vgH8Dt/nH/znFxNSaN2VIJZLml9/JypHWzfFMAc6KechpacpPPKBJGERBXx1ScgFt2PPEoQNPF60Y6oOyb9FLfjKsy7MA7YA1KPdpTwmbtkapPwIzwHnxU2s8RxInCzyb/P6n11P3lCFu/NCM/VD9lqLNvOb2/MXaJXlmY6zZLVbpnJlBSlfxaqrvvqGnSTcltOogkKX+Q0H0NKldQBYjr9VEMlgpe9b1+mUvl/+E5J7aeukwXmViB1phQyDUJ9tjK5Lj7qwhFWkNVX07COOx4FtNOy3tIsaVzil2r1k53dsKa/fpPEiYiPVg6xsy9xfodWsz4p1WsTabbzOugsBseDCNmWdkZtvt7B2vqS2KKsQHle5cwbdI12l/NoZGkrWftJ+LiBpuRjTkNy6Yc7+uHIx2u2vJnO9xHJANOxGWwkAFWH04KN1+Om2Mzxp753RBWuLWVaSApc0MbPheaiXHS8pXvyf5aWk/WvzwnL9ocYu9zlNTI1bPDN+hUkp/1wanDSPBM/Uq8KMA7z7tHK8IXqlLADl6znbhafbhBjcpgkrT+X0Z614= X-Forefront-Antispam-Report: CIP:130.117.225.111;CTRY:CH;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:relay.virtuozzo.com;PTR:relay.virtuozzo.com;CAT:NONE;SFS:(13230040)(376014)(1800799024)(82310400026)(23010399003)(36860700016)(261028144727099003)(261026121527099003)(261026140227099003)(56012099006)(261009223027099003)(261021121427099003)(261022105027099003)(261021123027099003)(10067099003)(18002099003)(22082099003)(5113699003)(6133799003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Z7tMhyRUEDqOinm5zRkJBvPyuszoX142j6QpD6VKbEpGW9IucfeEVoKT0JEsJ4qd2QIYMxPmGBJs1a3IQR+uV7ViCcxOKwYaUXglPPU8xpTtgfZQUZ3jRD3rlVw0+Psw7pfTZNRh/Zzj6kpszCePjN0/oO5GVMliuLv0/9oJjUEKwx1IX0XwoWFuFsky0vjEgTK/bdd80PhKfEJfFwvsnT6IxbPUw68X3OtCm8nKnJiGcamixVVd0wYOYUB1kFoox7Nqf31G03f4G6M5jdicekgGb1NhgHH4iXe8XOuCRI43kRyWTZQu41ZMmNmiUsB1j6YEz15z/tv0N3imEYQpq8LOQzXdmY1VoqS/9WOkEXbwtrqZPKtUhtz0S/plLveLKeakfQfy8rHjZbpCFsJ/0vTvrU3Z9t10AKsrAj03t49600B37f4TakqKLCTKd9KM X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2026 09:23:06.8299 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a43e40c1-8285-4f4f-2100-08df359e3dd8 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=0bc7f26d-0264-416e-a6fc-8352af79c58f;Ip=[130.117.225.111];Helo=[relay.virtuozzo.com] X-MS-Exchange-CrossTenant-AuthSource: AM2PEPF00070CF5.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MI3PR08MB665546 Only the automatic num-queues value is capped at VHOST_BLK_MAX_QUEUES, an explicit one is taken as is. The kernel vhost-blk device has that many virtqueues and rejects any vq beyond them, so realize fails with an error that does not point at num-queues: qemu-system-x86_64: vhost_set_vring_call failed: No buffer space available (105) qemu-system-x86_64: vhost-blk: vhost initialization failed: No buffer space available Check num-queues against the limit up front instead. https://virtuozzo.atlassian.net/browse/VSTOR-107537 Fixes: 0ff3cb5ff28f ("block: add vhost-blk backend") Signed-off-by: Alexander Ivanov Reviewed-by: Andrey Drobyshev --- hw/block/vhost-blk.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/block/vhost-blk.c b/hw/block/vhost-blk.c index abddff02c6d..8a015d54fa7 100644 --- a/hw/block/vhost-blk.c +++ b/hw/block/vhost-blk.c @@ -598,8 +598,9 @@ static void vhost_blk_device_realize(DeviceState *dev, Error **errp) VHOST_BLK_MAX_QUEUES); } - if (!conf->num_queues) { - error_setg(errp, "vhost-blk: num-queues property must be larger than 0"); + if (!conf->num_queues || conf->num_queues > VHOST_BLK_MAX_QUEUES) { + error_setg(errp, "vhost-blk: invalid num-queues property (%" PRIu16 "), " + "must be 1-%d", conf->num_queues, VHOST_BLK_MAX_QUEUES); return; } -- 2.53.0