From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11023138.outbound.protection.outlook.com [40.107.162.138]) by lore.virtuozzo.com (Postfix) with ESMTPS id 9250A80E7E for ; Sat, 31 Oct 2026 15:35:36 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dTbDv4DpyAz+sCZXa36m3febgdNKUnbblHem0Rh/Nsig3LRhLNGk/jLWU8RmlvNYX2jxsFh2ECvMCvfw3MJNLjVa/NqrjeNAo7nCoROdBLhkbUmT4OD8L2FG9wkJ/T7KBx43CrTnP1Vva6ZXRj4ggZ6xoaxpAFNEcWWXHN5wVuop7jBeRNm7tZfbak36Njy0e+DBinDzf8nb1TcEhODnQKVLGh3L2V2iszqMg/HyLXt2hyR5YCRgJPfm2s2JUZG67ofQmw3PlxR08NUihtYiXTwPeeQswWQS7b/hRVEzbTWMoNh90xKbVPd6HCx92GJgKsinAAc80kD5Zpuxs118Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XSSjgGecPOv3gX6sVcJRPkF296kSSeb2wwErcX4tWsk=; b=sl3FIaG14yvTkEl60SXJapz5OQuAqgvKt0M4TdjhDZFwqMJHH1XW6jLq9lXa3ssGXyszxHO/RQ/J8eM4/YGChRHuY1yaExP3G1WiOjONbsSgnRo5/dz8djqwOFZc/auEOx9xzOfe1X1q5aa0d/zL4muGNNf0tCEui+T7DQp42wffIJ/Yp9cK86GhpmXi8nModm+mJcjit03VC/LSrLeocg/tSEJSSQ+iAIoYQsUZBBLIyF5X+nX/2H0leuN/IceBtEQ7ha4xiw7Q23p/tgtVJq1iTC0WDWvJnHDZq+vyoBObTXFFhOMCikWXKY7EkDhsu4B0wzT8lubvOQSTLV9FUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 130.117.225.111) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=virtuozzo.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=virtuozzo.com; dkim=pass (signature was verified) header.d=virtuozzo.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XSSjgGecPOv3gX6sVcJRPkF296kSSeb2wwErcX4tWsk=; b=OvAtqSyfEnlQuqM1yINR33H5YyA0wjRzwIyqlGpy4OuV1dkGixkodXsAdGKBVCYiX1eNtDz1TW+itWi0IPubq2H9pWQ5YT3VVM17tWZbn/aTwd5jacwcBFedoWDx86sD1kifzwUrRFjihF7wepsDM8T7NcfHcCL/U1kEV8TZLwdD5TxBd/ORKbzVteTKIW3LkIGpR50N86YGtUdRrtLXDDpWiJ21/DWMGvMbYJq9pQ98HyMuwzw9P3pJlXjmcribHBOZmUkxnnJn31wV1Gh7Y89ZhNCBAQc3SkDaxq25ibU8q4RwYRlLsPLQ8XNHymrISNxE8u2jT/41EwkTQEZ2sw== Received: from PA7P264CA0068.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:2de::14) by DB9PR08MB11532.eurprd08.prod.outlook.com (2603:10a6:10:608::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.11; Sat, 31 Oct 2026 15:35:33 +0000 Received: from MI3PEPF0000855B.eurprd05.prod.outlook.com (2603:10a6:102:2de:cafe::a) by PA7P264CA0068.outlook.office365.com (2603:10a6:102:2de::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.22 via Frontend Transport; Sat, 31 Oct 2026 15:35:33 +0000 X-MS-Exchange-Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 130.117.225.111) smtp.mailfrom=virtuozzo.com; dkim=pass (signature was verified) header.d=virtuozzo.com;dmarc=pass action=none header.from=virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of virtuozzo.com designates 130.117.225.111 as permitted sender) receiver=protection.outlook.com; client-ip=130.117.225.111; helo=relay.virtuozzo.com; pr=C Received: from relay.virtuozzo.com (130.117.225.111) by MI3PEPF0000855B.mail.protection.outlook.com (10.167.240.23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Sat, 31 Oct 2026 15:35:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=XSSjgGecPOv3gX6sVcJRPkF296kSSeb2wwErcX4tWsk=; b=uOqrdnbwo0tQ eKhwQQwnNFvVwiFd9Kxp6gl6Z8RbCcS5q1rZjFPxAJVvO5kpjdwOx7mya7EpmhbkmyO/p6zzN4oZT T6WLXYlGe0kdIjcep501YvD1IVDfMuuaLRb81N2rgietwlGnBaRAomKuw1TyMTtnnXbVIpA9V1wie 7koaHKzFKlXb5di5Ok54v+5OMWJopVza5ixqAFWiVKxJ9YAIrWIhaaiNM0INVUoIlNotvHw0OgcLS kVkaxLzfOmkyAtW6tvgBFvtV80SDLNG9QQPRGl/pfYSp4cYrIHGrJ0/WycxcIZzmDEXWugtnjcb1c GnD1uRk0coTAfJd9IUZPxQ==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xNB3O-00CuDQ-0s; Sat, 31 Oct 2026 16:35:27 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com, svt-core@virtuozzo.com Subject: [PATCH hci-8.1 v5 2/5] vhost-blk: reject num-queues above VHOST_BLK_MAX_QUEUES Date: Sat, 31 Oct 2026 16:35:25 +0100 Message-ID: <20261031153528.3857823-3-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261031153528.3857823-1-alexander.ivanov@virtuozzo.com> References: <20261031153528.3857823-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI3PEPF0000855B:EE_|DB9PR08MB11532:EE_ X-MS-Office365-Filtering-Correlation-Id: 0073063b-27fd-4b73-f2d8-08df37649a4c X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700016|376014|23010399003|1800799024|5113699003|6133799003|10067099003|18002099003|57112099003|22082099003|13003099007|261026140227099003|261021123027099003|261021121427099003|261026121527099003|261022105027099003|261009223027099003|261028144727099003; X-Microsoft-Antispam-Message-Info: ePSTEvJ8Fu29I0+lZNNvwfK0LswLkPAOJ9OV5hOZxT/Ig1H8RoFYzmFVsTvwfO6Wu5uhsw9rAikypA/Pa/1I+8EcNNXyllcxWdlMWnh6QFWgyWaTu4IT3iPRV2OI//YgcbWQ2L5j5XEQ3HC4ItGEDGCxxjTmG3aApeoUc263V9DV617eGEaVQu0Qz5zU7dgwozx2Zqa2dCGoNnQ826kpvWnWLMoGhorFth1rGMWpppU4FVv+8eRPSrlC8hJJgykqfP0Gp4EWdTog203aWYi7FGl4CUkrV2bsz2UcqQqh9dpOon5s1N0JoVD0UEPerY3GVf8WSEC6VThQdf9xPZT0Gt4FE6GVHZk/KuJgTKo17vuSXZRDTCwAytB0XYGu47at45p/C9iWBCSlXw97MagmWf4CO5lGQk/ZjkQpyRlhAeWJeBLn4bayf4VymyVGutK+LlUGKVQYJexE6Y5uohmeSBTUiiitiuJzl7wHnW/xpKeEM+IoM6QGBI9AoXfeC8GMizE8OhPufJQZ2w5nzShyXZsJ733bP09bb1xuEO3PJEdwk9S2wKNAzUyvytQQL5RlL7j35bM4Qvg026wxZEIWz4Tv/s4srZ8l70QyCv1fXtVuO+GDkhwUUz4YXxBPDq5VXO6pySQkLr3D/D49v0ZJPLcYD4HbJva5ZZRTGo7JJtpa2/zSnHPsJPCZrUQd/F5d/v56COWsjjoKH2RFWmWbcuwZapRIOIwb57NjXeN8K4ydFXyGm3NYjVfd0bUnpAemIKRgXBzrdY6m7i48800KyajQA95J21VNOxNr9BCAG4lMkx0K+WznrWDUhZG70iAwIQAF9JGf2+CIGqus0pnK/bMPhZB4nY/jf2iKml4NY/E/oQkiBGXTHFHjgdaTk2jf X-Forefront-Antispam-Report: CIP:130.117.225.111;CTRY:CH;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:relay.virtuozzo.com;PTR:relay.virtuozzo.com;CAT:NONE;SFS:(13230040)(82310400026)(36860700016)(376014)(23010399003)(1800799024)(5113699003)(6133799003)(10067099003)(18002099003)(57112099003)(22082099003)(13003099007)(261026140227099003)(261021123027099003)(261021121427099003)(261026121527099003)(261022105027099003)(261009223027099003)(261028144727099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: JIxNEkFw7vrS6CE0/o2a1hHybFX4Ow5ou+fmnZCPLxtdoYXk6cVGAHkSXvgUuXwWsRtKequwzLB/nPkF+Jsa3e2/CzZ/gQBnDiYVFENf30GdSUWQ2DJ/Zkl1GMIKQyvhOuW4FB5u4hFwN6qjC0EmQ3eLBlhkuNgtpPnCuz0O8Z4CL9g2hfCyYJ+OGwP+vpNis3QU1BuFDRZCje0a9numkp5huUmEKv0uJF6eBRvHu68numlEN6Fgw3r4VUJKSvto62kzZhDKipW1VTpIczJNIpeucMyZY32e2e4GJLGxtmt6Goo8Dd0AcskdYJgPFeAqdPvKHI1Aps5mKUNEVS/KeOJ2YqRNcnpk1cqgPS529Vuxb7hgQfX0GXRm4iwjB7igFZBowrkFgsA9f3/S8y6PunS5PzTc76knHfAItp4AzGBQs/dJXCnuvlyVU4EtbarS X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2026 15:35:33.4841 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0073063b-27fd-4b73-f2d8-08df37649a4c X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=0bc7f26d-0264-416e-a6fc-8352af79c58f;Ip=[130.117.225.111];Helo=[relay.virtuozzo.com] X-MS-Exchange-CrossTenant-AuthSource: MI3PEPF0000855B.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB11532 Only the automatic num-queues value is capped at VHOST_BLK_MAX_QUEUES, an explicit one is taken as is. The kernel vhost-blk device has that many virtqueues and rejects any vq beyond them, so realize fails with an error that does not point at num-queues: qemu-system-x86_64: vhost_set_vring_call failed: No buffer space available (105) qemu-system-x86_64: vhost-blk: vhost initialization failed: No buffer space available Check num-queues against the limit up front instead. https://virtuozzo.atlassian.net/browse/VSTOR-107537 Fixes: 0ff3cb5ff28f ("block: add vhost-blk backend") Signed-off-by: Alexander Ivanov Reviewed-by: Andrey Drobyshev --- hw/block/vhost-blk.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/block/vhost-blk.c b/hw/block/vhost-blk.c index abddff02c6d..8a015d54fa7 100644 --- a/hw/block/vhost-blk.c +++ b/hw/block/vhost-blk.c @@ -598,8 +598,9 @@ static void vhost_blk_device_realize(DeviceState *dev, Error **errp) VHOST_BLK_MAX_QUEUES); } - if (!conf->num_queues) { - error_setg(errp, "vhost-blk: num-queues property must be larger than 0"); + if (!conf->num_queues || conf->num_queues > VHOST_BLK_MAX_QUEUES) { + error_setg(errp, "vhost-blk: invalid num-queues property (%" PRIu16 "), " + "must be 1-%d", conf->num_queues, VHOST_BLK_MAX_QUEUES); return; } -- 2.53.0