From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11022135.outbound.protection.outlook.com [52.101.66.135]) by lore.virtuozzo.com (Postfix) with ESMTPS id C4E5181098 for ; Mon, 2 Nov 2026 10:36:24 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IQZyDndKepd2zX80iUO/p14N167mQ6C1BmFf1rQpK5QSmNi2cw8FTvCMh4pDtITk95hQnmaucVd/9sUESjd83HqFuhHR2N7/YniqBog8eZ6pgMm2J2mU1ojtmnNzHObE8awHwGx5jHFSvn8rkyvxPX7K2sH1xcF5pIJL0q/WVOveuCBm9aYbsk9IQnnQ9QIJRMI98fnmVOd+Ef2K/id2v79kaoj0kAlup6sv0hafDIz2pjUkgUwcR8SO0Coj2z5DICNzclxAVV/LncEQUuTzDEtVcfTkSpc0EofLccBdTXIiP81lejzg3XBvGaQ2quxSsKcFCurDIBW1RgcrSbX/RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Vl2nGLsOdR1rT1rPPRP1wtRiv7O73Djt8igMcAzGVY=; b=yxnjb2iRa+gEEBhk3iP7vTWmLNgR5dJPJOogZ9Vm2aepPlqV80rsd8C0JwXpd62GiOc8n2+ROd+7lVIGYnQ0/VLOjDWSCjBnYC/g7IaDz68v6P4ibuhN71VwU5T7ybofP+qjCoAqLTM1IhKiLV7FLy23MBG3q0zEIDvxIOigjTzwiDqwKhYSHVcUj+hRRm0vjPolwVM05m6wWKy77T1toVtw7gm1LuQBDnnzQ5T7ZxEbkH0aasfZBhMw3h32ub+qesiUVdf5ePqKgEQ092Lx4cSglF2BTmvkHm8mJ6FLCn8sdGU3rY0IeEdL4kiqrSfmr53b0wq0pZl9z1wiWFxNGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Vl2nGLsOdR1rT1rPPRP1wtRiv7O73Djt8igMcAzGVY=; b=Qx3sSf7dJPfxiUl9uJmrRri9ySIdP4qnwPTnmelc7wXpkV0eSnfA4tZvIzwsjMkFNUvib6LCDLVTn6ZqGi96+98au5oWc1cI4QtBQtye6pPpamjRLYXvBaouRLw5vi0nOgkseA2zZKq7Y9MX8SN0jmkGP9qOHc9oeJA8uEos1L7CE0PIjkltp05H/oBczB1x6g8QuQKo6aYPbPiBIuyLlRn6VdSPqqg+bjrQ5fHyxPAMNhCvWlu5N5CsBAs6HcLIONYNar9/5vVmrhiq9KrnpixDDIZuB7UnfJZ6efM2BN4rlbES4iAfAepBB8O9nfFathOVQ2yFCrbvkRdx+eGhXw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by DB4PR08MB8199.eurprd08.prod.outlook.com (2603:10a6:10:381::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Mon, 2 Nov 2026 10:36:22 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0569.011; Mon, 2 Nov 2026 10:36:22 +0000 From: Andrey Drobyshev Date: Mon, 02 Nov 2026 12:36:16 +0200 Subject: [PATCH QEMU HCI-8.1 v6 01/34] VZ: migration/cpr-exec: fix Error leak in preserve_ram() Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261102-vfio_v1-v6-1-9bc7cabc850d@virtuozzo.com> References: <20261102-vfio_v1-v6-0-9bc7cabc850d@virtuozzo.com> In-Reply-To: <20261102-vfio_v1-v6-0-9bc7cabc850d@virtuozzo.com> To: svt-core@virtuozzo.com Cc: Andrey Drobyshev X-Mailer: b4 0.16.0 X-ClientProxiedBy: VIVP296CA0048.AUTP296.PROD.OUTLOOK.COM (2603:10a6:800:353::18) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|DB4PR08MB8199:EE_ X-MS-Office365-Filtering-Correlation-Id: 1bba7488-398d-4558-bfab-08df38cd2346 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|23010399003|52116014|376014|38350700014|56012099006|261028144727099003|261026121527099003|261021121427099003|261026140227099003|261022105027099003|10067099003|18002099003|22082099003|5113699003; X-Microsoft-Antispam-Message-Info: jmwAdzOyzSzzvjyWJIhKOxQKN+8kado0d0fhu74CNkDnIvLYITOfBenRNMxgVNLwnAYaeOzn5LpO3tPHOwKKBFwRtOUq2diUuZ1Nwxm/11mhHkjlfEkIZnONoe3hR+xyEsBcPAcr4KyK6+kmxM2xMT2A/GenULH2XYxTNjHGklaC86/IWrQLBwEYuAdsXLPgRPfGfEOs5zLMmY7cwUraq1yeMXAmY2/RBPaKHTjioEpfYa34O6Ysfz99kbAO8z3D1ckE7xvWNN/IVPcColWIsEPJSmZmYDoTpXlIkTMmTThOiTcAg9JuQNNdjdd7BJG/4qagq7G2OvCTm1peHddwHCGUT3yA6hTjTHUaR9iNQSh5YQlx8Ukrx1xlRLGpRc+N3q9bVLdug0npeUpMal8ZQZqtAaVlGf1pPN2zSwiPYJ1Ig96A7rxt2OOTU0eLNnpl3CL5M8UCIii1MqKx7LeVRHoAzYB0AciL5JjfjgsCe4KiAJY/gK7TUyiPhSTVCPP+LQ0+7uHaE8XWqzQCu8X1m9hPvxR/MPjBeyEjGeD20ryYBsH6tQlltO9kS2vR8qhGeSL8cuxwdRp++55gq+qmj5ETi/fDyZMIxBi0hQ4/58S/d7enKZKEKOiu5mKjbah8xfDAw113FHQtm0QTWB9y31C4y95ZQ+ZJBQsZxb5kR7nV2BeQnr9vJw+kK1b7BKygZbE8+w/2jel1wIrOw+X139rmc/RHjm1IzV3dAFjbVV8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR08MB10656.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(23010399003)(52116014)(376014)(38350700014)(56012099006)(261028144727099003)(261026121527099003)(261021121427099003)(261026140227099003)(261022105027099003)(10067099003)(18002099003)(22082099003)(5113699003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHNMUGEyektTUkJzbTh0MkE0U1RTL01LRDNsVWRUKzR3Wm1xK1Zza2I5QzdU?= =?utf-8?B?bEsraVNHRFZ1WDNiT3o5ZTcrNDNtMTRMZmg3OWdpT0p4ektuTURpbjJ6QkVH?= =?utf-8?B?WHpsb0JGMGt2ODN3MCtTZkZYakNMaFRwM09LVldyRENBQjZJZzZLYlNrNXJs?= =?utf-8?B?NXh0dnhwb0d4VlFSUXRKbzJJRUdkNnVyT2hJaXc1NmFRVWsvdWJ0d3F5dzFC?= =?utf-8?B?a3hZRHFyd2x6dzZ1ZVZqWjl6YnZVUk4veEN4RFRYeUYyVCtHeDFPUEJCZDNC?= =?utf-8?B?bk5ncUNHWDVCQ2hDNFkxRjdNa1RsRUVxTENWVk9XSE1BZlFzK1ZRamlTdEVu?= =?utf-8?B?RUF6N0RkZFNVWkxtaUlYK0lOeU1wd1VHd3Yvc2s0bk4zSjFEWUllSW1oU2Rv?= =?utf-8?B?L2tCeHFBbnQ0K3h5aHlpbXV4QlpmSUR5a3RHWFRHdnJtMERHQXF4R2pacGNX?= =?utf-8?B?NFYyTEk3aGpqRUxGZ1FoOTNvU0tDR091MHl1aVc0T0VnUTREZzJpSUlUNy9F?= =?utf-8?B?bzRZWjRZdFNKWDFrSFlhRlVRcUsxREU5eFVCcXFNWFJCR0NVSngyMHRzaHJL?= =?utf-8?B?RHZzdW93SmUwSWZVZWgxZ3E0cTlmem1oRjNGeVc1REt5T0YvaDdsa2xxWUZR?= =?utf-8?B?azAwVkxDQXlXa0dIU2FVS1Bodm5FM09Gcy8rWFZzUXpmUU1DS1pMcjQ0T1c3?= =?utf-8?B?Y2J3UjRDb0x0L2dEQ2toMFQxU2thVnZ1WDJadWFCRUZZc0hrKzd4SlFyZ3Na?= =?utf-8?B?bm9tdUtLZHkvdndudUVtbnE5c3J0QWJTMUJmYXl3NW9hMVRkR2JGUUNrVUpv?= =?utf-8?B?eFMzSk91OUg4dWJ1aDF1Y09EOGpFb1NaWVUrUG5WYThNMXhHdlNQRkJOdkNN?= =?utf-8?B?ZitEdnhXc1N6cjJ3STEvWk0vdUd6bHk2VlhPUi9GYnBIbGZRZ1VvN3BnZ0NS?= =?utf-8?B?U2dNWlphY3VwWjNISldHK25qeU1Kb3BBT3pnUUtJbU1FcFBVc1AxZlg1dkxR?= =?utf-8?B?WEUxUnc2UGtDakNCdUtFRXg2blBUYWxYNTN3VW5ITHZOcjlJcjFFeUpWYlZ2?= =?utf-8?B?UDdVejJ3cHI2V2lRR05nR296ZmZPV3hZTFRmMjB5K0tDNXVTbGxYN3Nua0J6?= =?utf-8?B?N3owQ0xEdDJkZlh1dVpwNCtaN0tFeTN1ejR5TUt0d0RqMHVubUdqcFJnNVU4?= =?utf-8?B?RjdxZUlvcG5MZldnallUelJXUFprd3pCM3ROby9yTVFDejR1ZFRpaWJIMjN6?= =?utf-8?B?eG02YnRsdGl0Q2dHdloxKytZcVljS2VIaG1WUXFka0FPVmNjNVRQRDh3eFRC?= =?utf-8?B?WnRhZFpmSU5nZXdGWTBVSkUwQk1pZDZicmM2QzNaOGVzc3FXUlhyZjVqRU1o?= =?utf-8?B?bFNtaEVibDdPTDFuY0NodUN1NEJyMFZWM2hKUm9LSFlFNGZ2SVR2d2RVTkJ0?= =?utf-8?B?dFpFV3YrQWNLWGNDYmNxL2hjWEpWMld5ZCtmWmNQUmVhNi9ZVDZ2aFJwMnZn?= =?utf-8?B?OVhZUmEvc2FvcUgyQkRTRGVCV2dmUVZIR1dXYkIvZWJwU3RKalBvODRsaWx1?= =?utf-8?B?WWMwNVREdW1Td21QZ2FlUEtsWkN3ZmppWExiRXpnOWFUdjIxUjE1bVN6M0Ru?= =?utf-8?B?a3FhaW1hKzlLVXZHOWtUejlpMndoSDI1cFJOQ2hmeWNLQ05oV3UzREM2L3hm?= =?utf-8?B?dVlBdDd3UXVhS3lSYjYyVHN1UFhNdGdubm5rTlZKc2N1dlJaZHVWNUg2TVRL?= =?utf-8?B?Q2l3RzdjQ3lGMTd4VWcyandNWTJHNE5JUTlFSk5xK244V2dTdWZOcVZxdjBx?= =?utf-8?B?dDhTZG5XUG9XN0VGZzAxMUFBT0g0M2w3OWRJaUlVamU2d3BhaVZjbFpPQXJ6?= =?utf-8?B?cUF4S3J2WHJ2TlBTTllxMjk3SkVHYUFNZXpTcEJWYnJWZElydHFqSkpFNytr?= =?utf-8?B?OEsyV2U0MlpsMGZvbkNScDVkUmREUEJTRXo1NUF1L2lScHdYUnBTcU1VNUwy?= =?utf-8?B?UW9SM2RMcUNBRmNBSzR2c2RBL29mRzhyT0VCWXdxN0dXMTFLTjg0K0hoVEVz?= =?utf-8?B?eWc0T0tzbmF6ZWdvUlV2Y01RRkE3MisvSjRtNis1VklWei9OSjNyd0tIYk5S?= =?utf-8?B?M3BaQWQ4S1Ixb1hqalk0TkdQNkM3SmU4YU1yaC9rdFNPeWdQSVhmb29uUjlM?= =?utf-8?B?K05xakFmZkFyUVFqV2hTKzVYd0hPbVcwS1JWbVlUTlIrcEJ3cmtnLyt6NlAw?= =?utf-8?B?QVcyYjR5V2VKdkxHL3c0UFBCdGdGYk9ZczJla25Xdm0yK3dyK2ozVEZ2UThH?= =?utf-8?B?ZlViWk9tMStJbllBakh3V1pLYjcrcnZubjVxbVlsdnExM0dJcHg5MW9TdWM3?= =?utf-8?Q?oYnKBxvUCx/Zt56s=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1bba7488-398d-4558-bfab-08df38cd2346 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2026 10:36:22.2128 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: avTQqYkmGkX8ETOxCzdEHff6TNyZ9WYM9MDK5zM0OpKAwM0nfW7wWPfstCFKl55sS3oWqXKR7Nv7DokLXLpEy3iBLxcwibEQrRrdyNc9oc8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB8199 migrate_set_error() stores its own copy of the error, so free ours. Fixes: a3745506daf9 ("VZ: migration/cpr-exec: mark saved RAM blocks with MADV_DOEXEC before execve") Signed-off-by: Andrey Drobyshev --- migration/cpr-exec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/cpr-exec.c b/migration/cpr-exec.c index edace3f0bd8..9fd3515753a 100644 --- a/migration/cpr-exec.c +++ b/migration/cpr-exec.c @@ -148,6 +148,7 @@ static bool preserve_ram(cpr_ramblock_t ram, char *name) error_report_err(error_copy(err)); migrate_set_state(&s->state, s->state, MIGRATION_STATUS_FAILED); migrate_set_error(s, err); + error_free(err); return false; } -- 2.47.1