From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11021104.outbound.protection.outlook.com [52.101.70.104]) by lore.virtuozzo.com (Postfix) with ESMTPS id B11CD81229 for ; Tue, 3 Nov 2026 13:57:28 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eImqmBPiJ6qC9IejcxFivJ7Hxhkjtm51RIuVv+qjrxojyNWq6KlixqIy4Qah84wfsmnZ3lap8iTyMt7qQsmCKQPVwXITOsug5EVrApo5agt8/05WL4Yih4hQtV5LkEvAShaXK9he98uKxLM0P54zijoTs6cnKTZaO1hhPBGehWZdnoR5dWqQI3rxOQd0zxCA/+Pu0Mqgbg9Zg1vBCVcth7fAPnWvbNGxRJUOUIYOJkt4Ou6aJcUIGrZpXo0m39ZT1xXhcRPDxR16Pkor1IxTVDHts2iLSa0XhS9kSoMZMBYlcT7pcYBUh9GDi6TBvSlJ//v8iQx9KPKye9mcsObzHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Vl2nGLsOdR1rT1rPPRP1wtRiv7O73Djt8igMcAzGVY=; b=xSSSb+xZuaOYczVinwk+a0yAJW2pryChBBtcuGFZl4QlwZyZkU8vRkF9NXeHcJgVBi0fqlu3sgpU2RrKAm5TfKRNDr9TdRz3MtNGF3oXBd7fzsxSoiYIIkE4D/okW2uYhuQ4THrvVYdKj3mwNhVc8GXRp1GfzmfHgUa9r9kuffC3/GSCJQAOS4Te0Un5ApOuQrAjPvWzgomGAxKvPL4DQ2L88KjD0O+Vwmu9GK2nNr5e6CWG+XHQcjXBv2LrOMshdYoWDyE9dme2qjPPqHSf/QtQ1FdP+hn6GKw5/TidD6Afk7JY34+8bLr8hnqhOjwz7E0Vet9cbZEzkOwoh1ATwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Vl2nGLsOdR1rT1rPPRP1wtRiv7O73Djt8igMcAzGVY=; b=w3HAQEEJmyPbNgHd3PiJ13xZiS0PfhzIxIG6rNk0KH1M0UH9Fvtc/kf+M063XJyFOz0C0w3MWnhlucFrXRaYtFONSqVOq6EHMDhwobp963jNhYmCa2lR7rbudJmbubMvWl+2e9wCVj2bRs1DoBycoBVjMTWXr1HQQtsqeOEjQb/dEFXwDx30P0bxSq74e3f36PA/MMZWadcutksJZONufcuWnL+HtTsVXQOj+Ym2KPn8wzPVsxCg6dprkmxkCLEwZBl30FxNlaoHwwi+rrp8RpuXA5nqx+Moexg9YsEuolJhVc+Upy9gqtKo0RX58A6u7XYKZLPUlAjKxrdl9o6k+A== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by DB9PR08MB7423.eurprd08.prod.outlook.com (2603:10a6:10:370::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Tue, 3 Nov 2026 13:57:25 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0569.011; Tue, 3 Nov 2026 13:57:25 +0000 From: Andrey Drobyshev Date: Tue, 03 Nov 2026 15:57:16 +0200 Subject: [PATCH QEMU HCI-8.1 v7 01/35] VZ: migration/cpr-exec: fix Error leak in preserve_ram() Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261103-vfio_v1-v7-1-4467fdccbbe6@virtuozzo.com> References: <20261103-vfio_v1-v7-0-4467fdccbbe6@virtuozzo.com> In-Reply-To: <20261103-vfio_v1-v7-0-4467fdccbbe6@virtuozzo.com> To: svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com X-Mailer: b4 0.16.0 X-ClientProxiedBy: VI4PEPF00000153.AUTP296.PROD.OUTLOOK.COM (2603:10a6:808:1::86f) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|DB9PR08MB7423:EE_ X-MS-Office365-Filtering-Correlation-Id: b7322310-dbba-4ebc-5690-08df39b263ea X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|23010399003|18002099003|22082099003|38350700014|56012099006|261102123227099003|261028144727099003|261026140227099003|261021121427099003|261022105027099003|261026121527099003|10067099003|5113699003; X-Microsoft-Antispam-Message-Info: 5R832UnO4+e465umI5MGkeYDwVl13KzW9TLWXYlwodgQIxIUE5xHcrdvFMsH2AMUvw/iVIISm1a0Vun1KAM4BGEgRcVKyfJ42TZQr8xalY0ecP7BsNLqe63qDLlIzNw0dFVPIpohYqUbsu6LuG5La8w1dXNj7lITOfPhUrCRaJADJGwdDxySbUA1xNCobFC1Bb9SApSwMbzH2eChrDGZZ53HfHPgkowrvv79wy8c+mW6x9nufI6DrRdC+fONmQFYfaHAT7B6P+j3EX0dxflgPiRe4GzGtYQFYhS1z3tcyv9cpHpwk1AoIlNu4mbecErXoSdwir72MRU6N6AO1BqfWJEDWnpjyWw8VB/lfvUa87BYeG1I5EeBeQPVUtMKgwwtejjpX2UKCEYiIAbHFlHyOs5qAf/OG3mJZYaCLmnX/yrhspaYBcAtm0p53MpwHKTCbus1IBxdaBkt7cytT9U/Fs0bXfrpu+KMNj04Q4yl6Z2CKwgVKC/kJyYwRmXlc/m0EgwWhNqfZlGVK4qliTC2381je3Ra0lpeX/LNVZQUNtPN9ZAxopGNq0tVXRIsFtZ+P9VmB3gvQet8QjET0zzoJpbZYTaMvQsmWCoxZ1AYyNLA793FFUWhP75KZS08ytNcovvFqUVade8pTcnnFUQaPc5D5tOkLu/TJbHY6Sk4dp7ScSXDDrv2K2w+ToFjQsHwcHosMTuf5PsVa455cmZ+lOhlGGRoepOlBwCpYUN2+jA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR08MB10656.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(23010399003)(18002099003)(22082099003)(38350700014)(56012099006)(261102123227099003)(261028144727099003)(261026140227099003)(261021121427099003)(261022105027099003)(261026121527099003)(10067099003)(5113699003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RGpYZStRMW9pYk5SN1VjYzFnYndqdVFUS28zSElGWWFoNnBZVmx1UXo3Uzd0?= =?utf-8?B?VG14WWZwbVEySGFrMm1TcyswL0RsVDhaWGtpT090ZWZwSkhpUHJXaWdnbmsw?= =?utf-8?B?T3dXNmNGeFFUNU51RUdmWWtYUFVkbmNHY2oyRVN3RjRLbUFJN2dQaXJHTXJ6?= =?utf-8?B?T2FaVzZmWWlaY2h1b3pSM05Ba0FXaW9qZ1h1UVI4REdpWkpJYnhyQnYwWFYr?= =?utf-8?B?MG12RW4rTTVTUFZWSFhRSW9KZ3VqdjZEeUNmTS80dEdQNlRnbnpqaHRxTnZT?= =?utf-8?B?Mk5uYTdRNE5WNzZmM3Jac01mbVZxbEJsYUdLbU9keUVQMDFhOXBSaEo2KzN1?= =?utf-8?B?Q0E4WGlFZHZUNCtXM2dmUVpXRVp5R001NlFQNXRTL2F1WUVCU2RqVWZMeS90?= =?utf-8?B?NUVsSWFOeVF2Q3dIREo0aFl3U292eFFwL2ZoUDRNRWFlaGJzUlpwME9WaWFr?= =?utf-8?B?eWttODlYWjB6OUdQUlFCTkd6N3NOTVhWVzd1ZEh0Z2VDTzBpakhpUWRRSUhS?= =?utf-8?B?WXdZcE1TaHVWNGY2cGtkeDlzOWlvTkl4TWhZV2E3YnNJUGFnZjNUdWhPRi9Q?= =?utf-8?B?SnIwRW9XRXQwbEpYU3F3U2gzVS8wNjcwQWsrVlFPSm90WUR4V1NpNVVjN2xl?= =?utf-8?B?RkxrclpDUEVCT2RJdjN0K1FVaHFRdTZpUG1CWUVWSzM3VXlRQlNaT2lES3B5?= =?utf-8?B?M202N0oxS1d3T2o5eGdSZkYrS1JENElzeC9zclk1aDZnUktHaXlkT25RUXZx?= =?utf-8?B?Nm5NWWJGTjQ5MUVSOHdSTEcvK0x1c2VEWlMyR290VkdTVUo4ZWFkQzdGalR4?= =?utf-8?B?MG1ZWXozTWZrdUxkTkg4VUZ2cDJUc29vS1FTVW1aS285cUtJdnRFejNRTUtp?= =?utf-8?B?aHl5aEE5L2phU2JORmRkNDE0S1BLZEt1ejI4TFc0ZGxubUtOTE1HVjYydEg2?= =?utf-8?B?ZEZGQkEyTUdoVm9RSm9GeW9yd2VXOHVvM20wNzZtblZ3WXU5Nm9ReGNNV05Z?= =?utf-8?B?ZHVDUkZEaGZSMUNKYVdQa1lNUWloOHU5TE05REF6YVgyQ200amp2cWFnOGN1?= =?utf-8?B?U2JyOGt4NXN3aVcxTGVJTXJFNUZSQ21ESlo3ZGtlSDV2RXM0N2JDdGJGYS82?= =?utf-8?B?WUVkMkphTzd0b3piM0E0V1BjL0lkeG5icWJVWVYwWTBBZ1I2WjlLK1RUMlQx?= =?utf-8?B?TUh3Y2hpN3QvYzAxY2tQbldLMHRNRXZWRXNNYm1WMHhpbStRRHRKaFRpQmFW?= =?utf-8?B?aG9oMndtbmdFRWhwRnZ2OTNqMTYvYmFNb0xsb3NqS2NrQ2RMTGo0OXJ1ZjFU?= =?utf-8?B?akg5WDA5S29uK0Y3a2F3T3dnTS90cER2WDVlWWNLbXZMclRDam1KNmdWZkpm?= =?utf-8?B?SkxRVEo0YTN1bXlnWkFwYWM5Qk1iaVRUR3k1MHRQOVVQdUpRakppR1NQRnpj?= =?utf-8?B?UXpRcHhnbGdFSU1HLzA0M1lQVHphSUlLcjVTUUU0R1ZDeldYMTRML0w0SG0y?= =?utf-8?B?Q1htamRUQUhldU9WWEI2bXpoaDk0VjBOVXpJNHlnc3NDakR3dVcxcDZmajA0?= =?utf-8?B?N3FjY1EzR0lrTkhJOEhVQzVwY25Nall3Sm94WUZIVzFVa3krc3dla0pXZHly?= =?utf-8?B?RjAvUFFoTS9YSTdyZUJ1Q2o0MitQMFgvUXB4dG5nNWlIc05uUTliUWpmeHQ3?= =?utf-8?B?cy8wSk0zL2dmb2dOYkpCK0RnRGQzcHZqSmNEb1VyalYremdXTnNCUFVORk54?= =?utf-8?B?QkVjOVBYeEpOajFWT3BzSm44YW5mMjJTcmVCVEdBd2pSQitQcG5sQXVkNHNP?= =?utf-8?B?eGxTNHNIOWg0YTNFMjhwd1VLdkJYM0g2TmRqdnpta3gyb2ZXcENIQ2tJOWo0?= =?utf-8?B?RTNNZEpiL0pMZ3p1N3d5Zm1zZlZWSmVTQVBoNHRiUkhWUmMyK2Zxb3ZDZEgw?= =?utf-8?B?Wnp5QzJPbVdjZEhjcVBxRmZZQVAySFF0LzB0NGhtNzBQRXN1bVFBMlZsUjB0?= =?utf-8?B?eFFZK25DbTBIM3M3R1gyTTdHaFVwYmY5YkNieTJkZG9Pd2paTGRvd2dDUnRj?= =?utf-8?B?YUE5N0laL1ZsRytySkR4c3REekJEQU93NTBISmJvemM0NEJ2V0tEV0ZjK1hp?= =?utf-8?B?S2l5OWZ2NjZWb0RsazQ4V0RKTURzeWNCZ3NUWjRweDRkMEs5b08zZ2VmOTcz?= =?utf-8?B?VDdjTU5MbHZjbDhsUEltUWRVQm1SdjFtcVlkOFd3OE9nOVlqdlRVaFBMZjRH?= =?utf-8?B?d3RTS1k1UVBvTGZ1UkplZDNlLzgvdmdKNVVtbnFkVGdNdFI4ZndOZFFVSURN?= =?utf-8?B?QWgwejRQaWVEWS9yc0dIM1I0bkJCYzJuVGl0VUY0V3luWUV3Ym93RWtLY1FY?= =?utf-8?Q?w2a9fgfTycPdILgU=3D?= X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: b7322310-dbba-4ebc-5690-08df39b263ea X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2026 13:57:25.4097 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nH1IXAoMCEdP3OnZEItZfXbtZk32xNW1D6cEQBQE+HV2nSJAMqJOCxppDR5bfwc1/8BSJ2qJ0/kpmDxSZEoKox0CiYftJxMvxn31zsinlY0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7423 migrate_set_error() stores its own copy of the error, so free ours. Fixes: a3745506daf9 ("VZ: migration/cpr-exec: mark saved RAM blocks with MADV_DOEXEC before execve") Signed-off-by: Andrey Drobyshev --- migration/cpr-exec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/cpr-exec.c b/migration/cpr-exec.c index edace3f0bd8..9fd3515753a 100644 --- a/migration/cpr-exec.c +++ b/migration/cpr-exec.c @@ -148,6 +148,7 @@ static bool preserve_ram(cpr_ramblock_t ram, char *name) error_report_err(error_copy(err)); migrate_set_state(&s->state, s->state, MIGRATION_STATUS_FAILED); migrate_set_error(s, err); + error_free(err); return false; } -- 2.47.1