[PATCH hci-dev 6/6] tests/qtest/virtio-scsi: cover vz-x-blockdev-replace changing the size #VSTOR-130961

["Denis V. Lunev" <den@openvz.org>]

From: Denis V. Lunev <den@openvz.org>

replaced-node-size reaches bdrv_replace_child_bs() through qom-set and
blk_replace_bs(). The disk_replace migration uses vz-x-blockdev-replace
instead, which gets there from blockdev_replace() inside a transaction
of its own. Swap in a third, larger node that way as well and check that
the guest is told about the new capacity and can read past the old end.

Signed-off-by: Denis V. Lunev <den@openvz.org>
---
 tests/qtest/virtio-scsi-test.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/tests/qtest/virtio-scsi-test.c b/tests/qtest/virtio-scsi-test.c
index f1aaeb31559..4e2bcd7b485 100644
--- a/tests/qtest/virtio-scsi-test.c
+++ b/tests/qtest/virtio-scsi-test.c
@@ -251,6 +251,10 @@ static void test_replaced_node_size(void *obj, void *data,
     const uint8_t read_high_cdb[VIRTIO_SCSI_CDB_SIZE] = {
         0x28, 0x00, 0x00, 0x00, 0x10, 0x00, 0x00, 0x00, 0x01, 0x00
     };
+    /* READ(10), LBA 0x40000 (128 MiB), transfer length 1 */
+    const uint8_t read_huge_cdb[VIRTIO_SCSI_CDB_SIZE] = {
+        0x28, 0x00, 0x00, 0x04, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00
+    };
     struct virtio_scsi_cmd_resp resp;
 
     alloc = t_alloc;
@@ -280,6 +284,22 @@ static void test_replaced_node_size(void *obj, void *data,
     g_assert_cmphex(resp.response, ==, 0);
     g_assert_cmphex(resp.status, ==, GOOD);
 
+    qtest_qmp_assert_success(global_qtest,
+                             "{'execute': 'vz-x-blockdev-replace', "
+                             "'arguments': {'parent-type': 'qdev',"
+                             "  'qdev-id': 'scsi-hd0', 'new-child': 'huge'}}");
+
+    virtio_scsi_do_command(vs, read_huge_cdb, buf, sizeof(buf), NULL, 0, &resp);
+    g_assert_cmphex(resp.response, ==, 0);
+    g_assert_cmphex(resp.status, ==, CHECK_CONDITION);
+    g_assert_cmphex(resp.sense[2], ==, UNIT_ATTENTION);
+    g_assert_cmphex(resp.sense[12], ==, 0x2a);
+    g_assert_cmphex(resp.sense[13], ==, 0x09);
+
+    virtio_scsi_do_command(vs, read_huge_cdb, buf, sizeof(buf), NULL, 0, &resp);
+    g_assert_cmphex(resp.response, ==, 0);
+    g_assert_cmphex(resp.status, ==, GOOD);
+
     qvirtio_scsi_pci_free(vs);
 }
 
@@ -394,6 +414,8 @@ static void *virtio_scsi_setup_replace(GString *cmd_line, void *arg)
                     "size=1048576,node-name=small"
                     " -blockdev driver=null-co,read-zeroes=on,"
                     "size=134217728,node-name=big"
+                    " -blockdev driver=null-co,read-zeroes=on,"
+                    "size=268435456,node-name=huge"
                     " -device scsi-hd,id=scsi-hd0,drive=small,"
                     "lun=0,scsi-id=1");
     return arg;
-- 
2.53.0