From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11023111.outbound.protection.outlook.com [52.101.72.111]) by lore.virtuozzo.com (Postfix) with ESMTPS id 90A0D8017D for ; Thu, 5 Nov 2026 15:31:56 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bRkNnAEkE04/sQoF8g62ZZaVFTFPgSzBaS+eEeYy24FwzZO0KoMoxCJ0XYcSK8mBd6RpVwbdTgyUD52KKnK4d+ObJdQnCXJFxFOhGEPMkOLGKy4jx109kfI7IOKPqG4JF+ZU6x1vMGvrWkVXj/LJmW1QJ6kbifiNsHXH+kgOlL/jx5U2s6VcucloKG5f2nZz2mJ6Nt3oSiJWHP6aMJPQ2gXL1Nh62ueGZq/z8TsL4P1uvHAW+3cly1rPCNqndUrYWKg+w6LRmZIC9Wm0Aor3yjl27WYmLPA+bLhcP/fLAjV5ehdau604JvtFSL/1KRB7Mci9txKULdx4AhT2BAtjuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=07ZnrRFy1UYgjhNLVtMpf2/tP/0q0iODBkVjrbE4sbg=; b=oij0zH/kZuKNmw3ZbjJ1YiZwxeBLedFQi8tXy1rE4Ut32emmWgGeBcjhQAX8DxDAX6n61k09vBm6PEBIPbT6oNCxhay9o/+zNVJJSUOEG64mgWQ6PTEXrQGihy4OEtNBERtAf9QsCGgxFADzFraNAwoGSD2AtuOI8YQdZxASnv9oSIbnI0R4JzSJYRNztGJG1IR4BwH3flkMLG3akxR4VjaU281Bz41PnJddE1IPKWPB3oclYhZUlg4nGjSgbHr02RkWKrSNrB30PDK/0TstS+GdynMed2VzY7SZM491sW4yxhAcKK70SwwBb82xvVshtt1JHVulm0r8UoM8tML8GA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=07ZnrRFy1UYgjhNLVtMpf2/tP/0q0iODBkVjrbE4sbg=; b=ABQ+lm1qtLPsyWQR8c36BISDcsHRX3eVLfuZdHxD92TqnHLXLfHcnRYCHt0H/xQMpliz2HkjrOW2RPQxJ0RkDmBzlUm26ZyPQBGi7I9gdHu07edpVhGs0/tYAI11/WzDT2ifHjbd5GETF6yZtygnam6Udy1eACGyyDUxxk9afZMMx3njBkcIsIbaEN+ebZHBPMziVqY/ZQnyf93nVFEFXuw16wY9KayUQ5A3A8QuGlQULRh8TUsXSQ5RfDLxldQNH0EyvV+xgY56QNOuPALhc0jhzr9LcTiwyy9IEK+K2edX3/zBQdFKBi/4a5cKVVKAQ4eBUI26OIfIvwi5ZRpm8A== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by GV2PR08MB547301.eurprd08.prod.outlook.com (2603:10a6:150:3b9::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.592.10; Thu, 5 Nov 2026 15:31:54 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%4]) with mapi id 15.21.0592.009; Thu, 5 Nov 2026 15:31:54 +0000 Message-ID: <3e65b5c0-6553-4722-885b-3b868734a07b@virtuozzo.com> Date: Thu, 5 Nov 2026 17:31:53 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH hci-dev 0/2] qcow2, block: fix reopen of a dirty read-only node and of a corrupt node #VSTOR-140073 To: "Denis V. Lunev" Cc: svt-core@virtuozzo.com References: <20261104144113.1587724-1-den@openvz.org> Content-Language: en-US From: Andrey Drobyshev In-Reply-To: <20261104144113.1587724-1-den@openvz.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0198.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ad::8) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|GV2PR08MB547301:EE_ X-MS-Office365-Filtering-Correlation-Id: 8df68996-999e-4688-aa92-08df3b51eba6 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|1800799024|366016|56012099006|261009223027099003|261022075727099003|261021123027099003|261102123227099003|261021121427099003|261026121527099003|261022115727099003|261026140227099003|261028144727099003|261022105027099003|10067099003|22082099003|18002099003|5113699003; X-Microsoft-Antispam-Message-Info: EJJuMYuRFeIqSC0U21C/y8cMP69vrhP0mgJ2mcsHgsBo01f3K6RB2g3NRseEnoZAzZJMrJKoeJdv1TnK9HvnqbCxJAopSYl2Jq9mnutSF4zpbiNKtLxN1BF9oZYFIvwNVNP/pFvpnnasI5BTGUzDWJL72EPDCZSWVl56BzTGnizWEVS+3evxlhDj9XFm0blQ4eWany2HzF1GA6TVbqVyu1nEpi3wScsrZGMAF+dvz3DODHcyBbM6DmhJ/uPtw6LePXgBZpQasfIX9+srKsO7AbgBfq0JKE+D2QhSfvlMPPPZV4CUJ0KXgmmzZCHPJlhh72Wtej1ZeQh/pS2TJ2ISSnsMwaVJwOIJbE3s9OuQX+vyzDN8Gr3LHvrMDCtao8u5If7uTadG7KINT9X2jdCGhxOHtdgySZlNjDW06Q54gSUxe1pWtsaJBKlf5zp+4YxN0VdPQ219kFN43Oyo+/G9o97aG4uU1eWBwOEnteqW1Qlno5kt5KvgXRyYNNodPq7x3ZsRxhYOW4+nMRNQvjqxT/qCYktEuZvRah5p8kyeiKki9WLrW8o6uOQQQsMr+KAhIFzsXKDGZn+IaMQWr2JB4oq39giOGrrdehHmjNcq86bAJlc8tlE7dmW8GzwWl6cGyjh6Em2pHr9t4bpC7fARFXqkd4jCtijrBv4FIESktds= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR08MB10656.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(1800799024)(366016)(56012099006)(261009223027099003)(261022075727099003)(261021123027099003)(261102123227099003)(261021121427099003)(261026121527099003)(261022115727099003)(261026140227099003)(261028144727099003)(261022105027099003)(10067099003)(22082099003)(18002099003)(5113699003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2ZZTTZscTNNb01wNHNMMlNtSE84RDlFeW1aZk5CaU1XaTdSOFB1OWErcCtv?= =?utf-8?B?bzBXTkhuNkx3bmxoM3JzeVhjaEF1Rm5mem9lV3BNRzNFbk8rNTZnL0FFU2Zm?= =?utf-8?B?Y3hVQWtFWnBwL3YxYkdlUG9DUXNZd05RalRBcDUzYXhlOE40bUI0VXV6blpt?= =?utf-8?B?UGx6aXdobW5kTkU1dHc1MjJPUkxrR3l5Nm5wZ05RaTZkTDg4R21rWjdWdDBo?= =?utf-8?B?MHZ5RDgzYW8vN1I1TGw2NGdRKzdhODBsR3JpTC9QTVJxZDdMM2tuZ1dTU09v?= =?utf-8?B?R3VrTGVQZmFOdE16OUdTcmpKdEhzYzRQNklvaG0xbWhFUVlsV0NUd1A2T1FV?= =?utf-8?B?QXZsd09kTmhNckRJQWIxdjN3UDF2ZCtBL1YwQW0rR0U1dmpBaWllMzlHclFO?= =?utf-8?B?aTVoTG5jK2hZWUtDNk5SK3EyNU9Ob3RySmZuUGtJSEQ3NitSSGNWcXBZbGd6?= =?utf-8?B?Q3FkeVlPWVFiVk1YZ0hKUjNoWG9aRUljNUtGOUE3VFNqQUxML1Z2TWs1S3JE?= =?utf-8?B?VVM0bUdaMEZBTlRkb245dUc0eUdkZ2VGWkJMQ2RUQ2hGRWJQTlZobHRMMEdT?= =?utf-8?B?QzloWVRoZzJ6SXlJTVJ4SG94THUwZTMydTFxTkVJV0QvMnZXT200MGNwTmdP?= =?utf-8?B?N3Q5Q1BPc3Z4S1J1Y1RWVjhpVlF0bXNrVnpad0xPb1VJYTFaY1BKZks3QXlP?= =?utf-8?B?c21tUHQvcnlYWE5pWUE0RnNOdDBRU3NzZ0psaDZQQ01MRkRPRGNyTEhmQU9k?= =?utf-8?B?UW9ZcWVJTkJ6RGsyekNHTERra0ZXMUxqQmRnZURJclk3ZzVKTEQ0TkhLd0o2?= =?utf-8?B?WWpEa1ZaUnB2VlhwN2wvZ1ZZdkZxSHNrcU9FeVpvemJkc21oRkpLUysxRWlv?= =?utf-8?B?SjhtVEFRWVE4ZWNBV0JkYkZsdGJ2N3cyQXU5VEtxU0VKTzQrT0Y3N1NoTUdV?= =?utf-8?B?RUYrMG9xakJWcDE1MHQrb2tQWnVGSWNlM3ZuSks4WUp0MURkd01sYUI1NGdt?= =?utf-8?B?dEFWTE5iMmQrNEdTSzhocFdyc0F0YnR1RStxcXZERjUvbS9EdkZBQnREZWJY?= =?utf-8?B?aDlMZWZpc09IMUc4aVluLzlyY0VUN1VEb0tXK1NJRERiUUJ4Wnl2ajZXai9t?= =?utf-8?B?a00rWkxpU2NVWFBwNWxaUVk0ci9GYStudEN4VWpkU3hKdWNvUlIyY21YMGJF?= =?utf-8?B?YTZxSzQ0TUlFWlVXeU4vazk1VFlJT3lTeE9QeWtSa3I1YVd2WTkxYm9sbTNM?= =?utf-8?B?YTdrb3pROE9EYUNoQ240WFRDNDkvZnF2TG5HUUpRMnM1UUJQUUNKU2tVSS9H?= =?utf-8?B?eWRBc2ViZzBuNDdRY2hEUUN2K0dySzZ1b21qOUpUSE1UWDVFL0dUeUtmdHN3?= =?utf-8?B?SDI4dVpTZFI2b2R2MXZJVmRwWXdWTGJoL0lNVTRXMXhDOVRKb2VjVXZVcDh2?= =?utf-8?B?bXl3ZkFjdVJBTVRkTlJyOHdGS25UdzVxenFIY2QvemE5OVVwK3AyUHR4UUpa?= =?utf-8?B?NUtZMXQ3YmtRSVJaVlNTOWN6ZTI4QVlhRWFWbWFOTEhBZzh3WVNXc2NGK0Ri?= =?utf-8?B?K0tQbWZtUDJNNjllVVFpWmJLWmppTVg5YjFaNE9wS29pYlNlUmRjSGpzN1gy?= =?utf-8?B?NTE1NEREUDk1Y2tzcVhGaHJRYXZwUlFURFl2SU1qb3ZXNzZCMlkxNjdJdTBW?= =?utf-8?B?bmJKM25VNGJCR0RhU1BtMXFvQzlIYlVFUzBTanZXRFNRTXVaM25sd3V1SkVJ?= =?utf-8?B?UVA2LzFBazFFcWh5cys2Y1RPS3BveUkvcm1IT2lIQ2p4T3ZiMWRRZytqalVo?= =?utf-8?B?UFpyT2xLS0lEanZqMGtFd1hMNk4vckFJSUhadjM2blV6TG9qZFVWZFBrbGVM?= =?utf-8?B?bklTNWpCemViVk1kRWFaVks3V245aWUzY3BLQkZtcWNDeGk2YjBDN3VWZDRl?= =?utf-8?B?UGw3TzRtQmVKdVdxUXd0WjhTamdkWm92NUNHZWJnYnd5VXplWkJPYVlmOXJY?= =?utf-8?B?QjdXYi9EMkNOYlJjMWtrR0NzaTJldWdEMmIxcE5mRUZxQWYyRzUrU1RiZjRU?= =?utf-8?B?cElDVy9OOExWNENyalAwUHFkeFN6M0djeVVYQTU3ZnpZdW15QS9KM0p6T0h2?= =?utf-8?B?WHNmbXQ1Z1VuYXdVZVphMEI1aXhTNWlWYWZVdUhyYktTbVA1bHRVSENGRWdn?= =?utf-8?B?WVVYb3FiYnhLelRGY1k4dEVISWZLR2VBRzF4dE1pcEc4WTRuQWhwY3N6WHBM?= =?utf-8?B?LzdpMWpudkw2Vnh2N1k1MGFxdjdFOEU5aWZqK3lRT2RzbEZTZVdxYk9xR0ND?= =?utf-8?B?MnVQTDlnNkhjU2I5bWx2RUtiTnVwdGFRMHBlVUlJamVvWkxJOEhFcHU0VkJP?= =?utf-8?Q?KWzNzkWjR/sn71lg=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8df68996-999e-4688-aa92-08df3b51eba6 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2026 15:31:54.3096 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a9OQvxW09qwkvZlSTR42sQYyzKeg8mVkqa4MTzo+2N4AyP3RC05uPmGDGMr+I1Jo1uaJY9hSTE+YrpRKnUqmp3cS4X+oUdM2akN5Ig/Ezrk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB547301 On 11/4/26 4:41 PM, Denis V. Lunev wrote: > These are patches 1 and 2 of the hci-8.0 posting of September 16, merged > upstream as af28b65fae6 and efe98c2a093. The repair of a dirty image > that becomes writable is not part of this. > > - A read-only to read-only reopen of a dirty qcow2 image fails, or > aborts on the BLK_PERM_WRITE assertion in bdrv_co_write_req_prepare() > when the file node below is writable. > - A reopen of a node which qcow2_signal_corruption() left without a > driver crashes QEMU. commit_clean() reopens the base of a commit job > this way. > > Patch 1 is a clean pick. Patch 2 differs only in 060.out: HMP qemu-io on > this tree prints a failed read on the monitor instead of returning it. > > Tested on dev-cl04. Unpatched hci-dev fails the new 039 and 060 cases > with that assertion and with a segfault; with the series both pass. The > other reopen iotests, qcow2 and raw, give the same result with and > without it. > > Denis V. Lunev (2): > qcow2: do not clear the dirty bit when reopening a read-only node > #VSTOR-140073 > block: reject a reopen of an unusable node instead of crashing > #VSTOR-140073 > > block.c | 14 ++++++++++- > block/qcow2.c | 8 +++--- > tests/qemu-iotests/039 | 50 ++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/039.out | 20 +++++++++++++++ > tests/qemu-iotests/060 | 30 +++++++++++++++++++++++ > tests/qemu-iotests/060.out | 13 ++++++++++ > 6 files changed, 131 insertions(+), 4 deletions(-) > > > base-commit: ca7715cc68cdd379b9fbe32d794408bd87a6677e Ack Applied to hci-dev