From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11023103.outbound.protection.outlook.com [52.101.72.103]) by lore.virtuozzo.com (Postfix) with ESMTPS id 090298045D for ; Tue, 27 Oct 2026 10:56:52 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JQ/629pYTNefSgaDxRUWcSV/ZvUEl3cSa7kPfFOG0nR0yB1CqUQRcou1mLADn0oCuvnhmK5Qe1swZ75Vx0raJa5nFkN3hRlH22z8zanwo0x2aa5o1jYzdv8AI0zzCUXW/3QelAGNEF3kmzDk7gL3Z/s1Zb1ZNBSbVkOM8yITG7el8Utts64EDFOnexJGHPMDVuS5f8FVCN9rWXWWu6LLSdqZNRzPhpcqRKMtCfNdGFCOP8jvKCYyhd+7cuVvBfDrVjXiqMl/81w/smEseEVOt9VH4/d7JBsFgpXt8lTcAUl9JcR0OnEIoiacvoLH/gvm5vnhOtCoPrzzTUp4knky0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QKENuvtzryKvcoO7FummX3LOqLCP6lk9UWvMuEo98sU=; b=Bp3nUUDDq9eXlxcwExV2tM6ptKjtidP3qfFXP1GECBi+kpK8ioVR2ogB68drRYdcp0OjIzRuPXLc/UJGXLdIIwthAZj4eB34GGCSiCtFbWyes7iM2Hs9nAqY6nzEOQ1B/6tLwHSg8bwmOdCMPj26t8tCw+mKJ+C8MUW5ZYDyMOQvhd9c6H48aPbiSiP7giT3nZlFSW0mDfMKp8Rs6aVg8ukaJwpPkroADRCrnYMVmDP/t8WXMEs/RE4q0sUiqIf3lNevVlqNC81X18E8MZYWge1fXHK+v9hOs3mg/FvyjY8WirdvkQ4NHIKusz33wErhHuf4H54oFR/kR4JIcYRpEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QKENuvtzryKvcoO7FummX3LOqLCP6lk9UWvMuEo98sU=; b=IOnXfkpTjSCOqjzVmsTy5MYUAAkabSmNcyyFL4cBTogyhgYytfsQ/OyOyQOfcF0OAWqzx8I5/1b0E+Y7KuL+b3LZGvEm+Jo03/4naJBHEAKgJ/IyTlyTAj2o1V7I8+IOyKRrnke7ryoIqm9WIMMZxfUkrMYQGGHT9lUAXIAyclTZ220YMhdq3bxa5FOCv2wp0qET9SEg0Y6rVEnNEgENcfJDrh9ozMZm2NWJxfqZ1SRaWcUJ3wrLBKwxnPVWb7nBbTi1uyI7ABx9ArKdjgcAbW+5sKeZsQ7rWVeOKyupJUYMLtOj/9g07Yi1TmB0N+dV33Kb8uwJ/ZWbJ97HfWdEKA== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by DBBPR08MB6011.eurprd08.prod.outlook.com (2603:10a6:10:209::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.22; Tue, 27 Oct 2026 10:56:49 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0546.021; Tue, 27 Oct 2026 10:56:49 +0000 Message-ID: <41481659-a1e7-4ee8-948b-4bcba5f94023@virtuozzo.com> Date: Tue, 27 Oct 2026 12:56:48 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH hci-8.1 0/5] scsi-disk: fix UNMAP and WRITE SAME racing with inactivation #VSTOR-151532 To: "Denis V. Lunev" Cc: svt-core@virtuozzo.com References: <20261026174929.685720-1-den@openvz.org> Content-Language: en-US From: Andrey Drobyshev In-Reply-To: <20261026174929.685720-1-den@openvz.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0045.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:c7::14) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|DBBPR08MB6011:EE_ X-MS-Office365-Filtering-Correlation-Id: 6cbf36cb-6274-4e65-ea8b-08df3419005a X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|23010399003|1800799024|261026135527099003|56012099006|261026140227099003|5113699003|22082099003|18002099003|10067099003|261009223027099003|261021123027099003|261022105027099003|261021121427099003|261022075727099003|261026121527099003; X-Microsoft-Antispam-Message-Info: 5qSaOfrhDRYHku9TNWM+WHj/vckbAVKG5SFupmtEh2V6P7XHN/9yjEcCEeaQNAlIY6u0x47ciWHe0xk902KqKfliuaLKWvyBbJTs/fv9maIgsrv0Kp+S2QcTEZTV5rM1BA7tQCpx1XqsY3xzHN090cLeQXcJIru4efhdIeIpblgy9VPdIHigM5K5DWTN0MLavHNNDp5R16UTBp4wIxKB7UG20EsA4ADRodwPlFOTeUn6DHNwnNYlghu1Sp5ag6UqF/+uUJ/XKPC19i7kIipjPX4yPGpSWZHW2PgxG3NZe+J1TluLvt4HhLe2axyVDEWphu7SqqCjlwj2fKfXgJsEZrQB1wEgLW+R9rE5DY8OsHoUGCgevXa6aWo/6nnx/ztDwoBNjcgNIl9/yrJK9LJhuNu4jXdYdVYE0dvL1QYzxD78DXdxJjZ4OG4mo6GwYlacWOzp1viBRrKKlZFsEmRUxtOGBx1iJv0PReRoArmji+hiJ/kiFsYy+cVQua4d6E69eQU5f8VYxorshFWwzlUM92vwYvAZEmL1g93+cYudxIbrJsV+rQcCTei+hIYIKCpd2EYBg8GchRz9X390PvDSptfaBSB4Z9T8dK4whMWTqMiYUaByYEJW58fqPzalGVO8 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR08MB10656.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(23010399003)(1800799024)(261026135527099003)(56012099006)(261026140227099003)(5113699003)(22082099003)(18002099003)(10067099003)(261009223027099003)(261021123027099003)(261022105027099003)(261021121427099003)(261022075727099003)(261026121527099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VVNyT20waThsSkRaOWd1SjB2eHhzNTFIeHVEQjhlRTFOWVpxWnl3SmhmK0xl?= =?utf-8?B?d0lQaDNlaDhkSVpUUldOWlV0RUYvLzlvTENCeVluMGVISE5BNUJaSWQ0bGJz?= =?utf-8?B?L3dPWldDcExwZ1EzRnJYRGRUNkNYaGg0eVppbjJZaS8xY3IwVmliTG1DY2Ex?= =?utf-8?B?blVjWkVvYXJVUU5FVDIyODJ4b0lzTTJaK1N4eDJIMlJxOFZEOTVITXVqSW5j?= =?utf-8?B?MXlIQkpINGdObElpRUsrWmRGU3FLTHZndmhQTmV6dU5YUXJKSU9VQkRpczg5?= =?utf-8?B?cTBkSEcvMWw4MVBBcW5CKzV6cE5CeHNTVGpEN004aVYwcHYyU1I2R3NHeDg1?= =?utf-8?B?SVYxNEt3NzQ0TGppcXpSRUNyN21QOStDdGJYbGtpNndjY292M21iN3c0OFVT?= =?utf-8?B?Rk82NEppWGVaWk5BYzdnRzF5OGdDZUx4bm1iVUp1bFB0YVlrQUM0YjNsNVRL?= =?utf-8?B?UXpuREpkTmprTWRyZjRRTmw3d2NVK1JiNkhNR2ZlcmdIWHJVRXpIMWlJNXNr?= =?utf-8?B?YXZ1N2NwVnR2VkwyazltaERIelVtQjkzMEFTeFFldlkwWFhzdXU2Q3dUTHdw?= =?utf-8?B?RzV6engyMHNIakxXcWxnS0FJNkNKR25NQjdiTC9ucDVpcGdzYmVrOFBweXJR?= =?utf-8?B?WFVBZ2JheEFtSHdYTXdLeEpCWEVtc2ZzME9oRmFSR2hVTDArTCtnTnVDcmpV?= =?utf-8?B?UUJHY09UVXFSOFF4RlNhNXhZWDhHc05kRDhhY0JPRzN0WnVSTDVEUnJrcExj?= =?utf-8?B?TENwVFdidDFuYnVKNW9SQ2EweGdtVENsbWl6ZnJybE1MRDZMT0g4akNzZjRz?= =?utf-8?B?eGRjRnR0bldYdkpzWERqWGY4Q0FoRi9OcnpJSXJQRmMzelRBNjIxaDhFaXhL?= =?utf-8?B?cDJsQVFJbmxoeFArTXgwUnZKWW4yVzhrbE9YRHFQYXVSTXR2U3lYc0E4eW1L?= =?utf-8?B?U21tRWNHUGNMVkJjVk9TVE5Ja0RESGRkbHFGcDNzNk0wZTdERTZzWlVMMUFR?= =?utf-8?B?dVBrSzVLNHMrT1BnSjcxSmhGWlRqaFpzampoQllwdXVnNWFQSnNzQWNKOFFU?= =?utf-8?B?OGdpV0ZBZ1RHamJaTTJEUjgxRnl3cjJiWnFlbkhIa0h4VFU4VnB0c1FIQ3Bx?= =?utf-8?B?VEEzTzljdDRCSWttOVpTQ2l5SDk1S3Jqd1NYQTVxaUtHOVVCSHc5YkRkeTRn?= =?utf-8?B?S29Fd3haOUdWUUtacnpDcWRhZ0NyajdIUFY2Q3V2c09XNVJLRHhZU1E0bUJW?= =?utf-8?B?bUJGeGZ1SXk3d0d4WDV3TXVjZGJSSTJaM1lVNE81Z2ZWbSswdWxBYit0SHAr?= =?utf-8?B?RXdNRXFuaXRHTXBCcEd4clNyU1prZmZmVnV3Mko4NXdjQ2hBeGpianRVVEhu?= =?utf-8?B?SlExRmF1YWFkNm1GOUN6ZllSK2pZVUpZRDkrTWhrTVN3Q1VLUDVSRVFKUkpa?= =?utf-8?B?dDBEVjlsV2NUdmZ1WWptd0VMNUxTcUZkR2xaeGJYWUR4ejFMOVBDTTl5Q2dl?= =?utf-8?B?VWUzMFA1MVE2SVAwNTdPbmpBN3JZdDM4blFJN0hDM3VNajY5T2JaV1ZzYmha?= =?utf-8?B?UjBJd3hTVVFLK09hcW5aQ3NYYXhLWkc0K0hLNkZNREhCTTJ3Y3d6MWl2SGlQ?= =?utf-8?B?cU9WRnNLQVVYYXovNkM1ZWhCMVhpMG5BV3VuQXQxMzhuVmFmS3piemQ3eXY0?= =?utf-8?B?N05iR0wrUXZjQW5IbXdGWnV3ZldoUkZ3VkdnSHVGZGplSTJkNzNPbFlIZXE1?= =?utf-8?B?aHoxR2NTVnMzeVFYaHFqa1Nhb2pydEkrSTk4ZVpnWWtEODRhbEZoZE51MFpt?= =?utf-8?B?Unlqa3dzYTdkN0w4WHdnOGlEYzJIWmpFaXdHSU9KVWYyZVhsdy9pY0xDdkY1?= =?utf-8?B?UmxuaThGaUxIcFhPVXl3blVQWnA1T3FqMW55MnRQWmJKUXpZRi8rWjZrU1Rw?= =?utf-8?B?dTl0TEdHSnpZdGtiU3IxZHpuNnE3cjlSTjFkOUhUbkZsNkp3b3VURnRTTFAy?= =?utf-8?B?K00xbEdLRjI2dFVCeEVMU2Ricmdrc0FGUkhrcVZVY0tldlliczJHK2tQdWxG?= =?utf-8?B?SWYyNGhLTnVFNThiaFdDc1Fab05pZjhSYjR1ZFgzMzV1QUxBVS9KZTRKNGZB?= =?utf-8?B?ZExnTTVJS2grWnkvbUFNcitMbmxtTUpHQmx4K3I4emJDVXdaSlVSYzRnRVNs?= =?utf-8?B?NlA1ZTR3QnRVQ1ZVUHVVWUpDTTRMRTFYZ29Xd0xtc2QxcnV4cGZUQ1I1ZllN?= =?utf-8?B?ZWd3TXRQNkdpcWNsSVZ4dVhhbXYvcEZLcnlqSXBmWTlkV2dzd0JtYUhoOWJz?= =?utf-8?B?UWFMOVNsQnhUTWFKcEZWMEZrS1ZCY2JJQ1JsbThmRFl5ZWZMb01HSVhCNG55?= =?utf-8?Q?W6NI67xxmkT3Udq8=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6cbf36cb-6274-4e65-ea8b-08df3419005a X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2026 10:56:49.5836 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WZAIhYMJVCYPyuoHWYD6J0VbSxIaRVCJskF97RFWlQZ32rwDPEruuIJWw4EYWvib69Fd4U/ejW6f+4sbY7U4kBlq7kGwDdOUdVksscZ2CAw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6011 Let's hear what the upstream block maintainers have to say about this first: https://lore.kernel.org/qemu-devel/20261026174220.674460-1-den@openvz.org Andrey On 10/26/26 7:49 PM, Denis V. Lunev wrote: > scsi-disk splits UNMAP into one discard per descriptor and a non-zero > WRITE SAME into 512 KiB writes, submitting each step from the > completion callback of the previous one. A drain in between only waits > for the step in flight; the next one is queued by > blk_wait_while_drained() and resumed by drain_end. When the drain is > the one in bdrv_inactivate_all() (end of live migration, > blockdev-set-active), the resumed request hits an inactive node: > > bdrv_co_write_req_prepare: Assertion > `!(bs->open_flags & BDRV_O_INACTIVE)' failed. > > We hit this in production on a guest UNMAP with 38 descriptors. > > The fix follows the one Kevin did for IDE TRIM: > https://lore.kernel.org/qemu-devel/20260421161132.99878-1-kwolf@redhat.com/ > > Signed-off-by: Denis V. Lunev > Cc: Paolo Bonzini > Cc: Kevin Wolf > Cc: Hanna Reitz > Cc: Fabiano Rosas > Cc: Laurent Vivier > Cc: qemu-stable@nongnu.org > > Denis V. Lunev (5): > scsi-disk: check all UNMAP descriptors before discarding any > #VSTOR-151532 > scsi-disk: fix UNMAP racing with inactivation of block nodes > #VSTOR-151532 > scsi-disk: fix WRITE SAME racing with inactivation of block nodes > #VSTOR-151532 > virtio-scsi-test: split virtio_scsi_do_command() into submit and wait > #VSTOR-151532 > virtio-scsi-test: test UNMAP and WRITE SAME during inactivation > #VSTOR-151532 > > hw/scsi/scsi-disk.c | 278 +++++++++++++++++++-------------- > tests/qtest/virtio-scsi-test.c | 173 +++++++++++++++++--- > 2 files changed, 309 insertions(+), 142 deletions(-) > > base-commit: 81aea91c7f71cba39b4c3340579d45f0256a91d8 >