From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11023142.outbound.protection.outlook.com [40.107.159.142]) by lore.virtuozzo.com (Postfix) with ESMTPS id 6510780E7E for ; Wed, 4 Nov 2026 11:58:42 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YzAsbdmqZxXNfbBlc7umTCN2iIuhzq+qe0YEbS2PLka1+ZNoTzsRzLVvmz/6i7q52DLqrkxGuTgFz9SQnMFv3dttwqdEklZ5y8lge+xXHqP2lADvmkHd54R0rUinHpwZM3oKX6a5lD8gnMZV4DtihlqW5mURSIDZ5GNEWWPttSnZrov2w4c2Zce7niJzT+KyFOhnsg2Tg4XDaaJS+uCHDQfFqs7fqTgVIR3Fylq0bahr8LPhuJwSsq3okuOtUBNa4HrRsXK6waHyhfHSLduzQprbBK7S6tultJQhuAw0+GoXENsB8i5ToQAHDP3BlU+Qt8fnJJY60vYf1yhgUPXoKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7yKAqx9pZ2w37SOTGUf1Dpy1QTwW0sTfc6mLrelAR6Q=; b=eg6YrSnm6A/7Ooi2LnbvIEqErf9fRCyvv5zzPe+SvLRtBLmVrC9uWSe7wWzmaGh4B/DbDqNwrZaNR3F0ZBR38iEFvi+6K+rx4qYYKKzIhoxmJRvfcmhC0W42K5Yl0M0LkRrqggd4nYIZMTcngDwi0CNCHf11o6/rv+U0f1dp7DM0VGzGv48eo+OjLFZT8R+QRwaiKCInFajs6eni/RtwU5hNAmZZr2cwnHbQqX64YK7m58srJuKwul3hUF09FpSoGkG8E0ccYNy8/sw0K7z/QfMN9RoV26AUhb7mA+UWf9RAyn4Fht1FGy0KnDBwWeZ2RRxOzVUmCT4qIoe4jftU4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7yKAqx9pZ2w37SOTGUf1Dpy1QTwW0sTfc6mLrelAR6Q=; b=YKyDFeYvtfeLdNs/P62NwAGdqDcC1vSuLVlXY4EU2e5qydk6o8k8KF76OHzZSH5W4z9kQo93U5ZvwSWavPPYpKcKyqqfYaOeho/U6mxFBtYg6T/ArddUNlO2KXhcZJuLom/vAxpZohdlo/dT5/Jhahgs9BYj9mRhodPhYl1Q12hnvWogCv9YYhk++PxX6sZEp2qdsBcEBFC1ZSAGOc/uTEnvTG7C6edPmTFehLQZ//OEEqUky5lIDstrfwCYi+wezkjn6Lt6B0EvYPpYuBfDS8vRsUdj7GXWTQ0FDwvuQg315NoZrhyvCkgRLQT42dR7OVCFj85XYzKZY2nPVbhonQ== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by AS4PR08MB7407.eurprd08.prod.outlook.com (2603:10a6:20b:4e2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.592.9; Wed, 4 Nov 2026 11:58:41 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0569.011; Wed, 4 Nov 2026 11:58:41 +0000 Message-ID: <4b410700-173e-4912-bed9-cca131a6c2a5@virtuozzo.com> Date: Wed, 4 Nov 2026 13:58:40 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH hci-8.1 1/1] target/i386/kvm: fix latched INIT lost in kvm_put_vcpu_events() #VSTOR-153069 To: "Denis V. Lunev" Cc: svt-core@virtuozzo.com References: <20261103181817.834166-1-den@openvz.org> Content-Language: en-US From: Andrey Drobyshev In-Reply-To: <20261103181817.834166-1-den@openvz.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: ZR0P278CA0213.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:6a::19) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|AS4PR08MB7407:EE_ X-MS-Office365-Filtering-Correlation-Id: 46f8ae7e-046e-4e95-cf5b-08df3a6af7ea X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|1800799024|366016|56012099006|261021121427099003|261021123027099003|261102123227099003|10067099003|18002099003|22082099003|5113699003; X-Microsoft-Antispam-Message-Info: NF1SOf23KOGmBcmyV+mmyziYSewORckDia2Z/9A/LVv1JqBwwDHgMo57JwOlQmcWQgDi1KihRlfiW8b+6cxdWucmv7XloBkwc6zm9F0eJcN/pi1mWbMSxBoH00sC2rqhRJMzGw06pI1BzvaB/bhZi2KRIVo7UMCzc3q4p9KhQ342JdCC3rkXm9AJILolbNwsmES7be0XvhcKxiuTMnI686hTjOU0bQv10Ehs1qM1sndmf68rRyPkwrahYdQwXUNPqT+ZJCnqzf0UW38hiStPMeZmg0uzS1yFW/uOULiMwzxG37rtNpuPLR19S9JCwcQXEpcGfnoWzvWcTjdNdKmrdcmLHAeMiUa9Sv8i1hwgUKGHuYcYJXdkO78YmrnhearnuiaHqjds34NfVum3OSB9qhVGrMls27YbCZEDi0oYotqcf0kRuklLFRQdm/rUD7/aC6bobmIF9LjRI4873F/EDpM7JwROsVfa7hilb49SFbtSRvhZheEg3jfMFp7zH1K2qPJGSetNvJVa7ODmafg/MQO2lbQjKiApVZTL0UnVwDHfUbkm78o8bHRtjyAHMfNy8oo/0d26bOnO16ziGl8Tiv+/1L4DNSpJK4pU6IEMvCmQeB4QIilKAHaYfjYZgBdK7lyVqUtP7q8tV37Y9LpoMBLrr1B+4Kk7+KITdg8B8Qk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR08MB10656.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(23010399003)(1800799024)(366016)(56012099006)(261021121427099003)(261021123027099003)(261102123227099003)(10067099003)(18002099003)(22082099003)(5113699003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ejBtVTNuaitXQWxlUkVrWVQ5a20wMjZXU3BiRkdzc051YjVPZUhqWDRnOGJj?= =?utf-8?B?TlBuQUZsMjVZU0draWhDZ3JHYnFSMHgvVU0rL0gveVhhNWFDQW9FcmF6dnVu?= =?utf-8?B?MlZORVFnUC8xK0pwYk9LQTA5aTMxWlY0MkFNL1k4Z0FVZ3JYTDNjMU4yWkdm?= =?utf-8?B?NUdPdnM1aUdHS3hsK2VkK2ZCeldmZGkxTkt3SWtMYSs2WFIrWEtOYWxkVEJv?= =?utf-8?B?OWMzSmprQXE0UFBhN3ArSVNxY0VOYWk0WWR5TDVKQ09iUnpvOUt6N1ZqcHlt?= =?utf-8?B?QUpxOXVlelBPOE5PeEZkS2NCajZXeCtuRWNSRmpVdzN1Z3BLRU1vQVRjalJp?= =?utf-8?B?TmMzaDR1QXF1WU1ENTBQdmtRMC92ZVZTcmVvZ1BYSXBGZDFhRE9Bc3VzcXhJ?= =?utf-8?B?ZlZSSTYzRWl6Q0ZveFhJNXFrOXNQTWdBOUhPckxsSi9GV3hlZUg0UDlrczFt?= =?utf-8?B?Y3NhNWJINW1qa1NtUFlKL29PcnJ1UDR1U01QdDRNblBuK004Z1pZNjJTUnFV?= =?utf-8?B?K0RYZXg1Z2RCNExML1B5SUhEV21uTDRzUVRyVDlpVG9URVhMaWVVNHFsTk5z?= =?utf-8?B?d2J6NGU4L0tDelppRnNmZkEvaHFMa0RvVmY1ckRHRGpGb0toekRPc3pDYnYz?= =?utf-8?B?aTRvSUJNSUQvSUU5SXphdnFWRHp6Mk5qMFY2ODAvNmlrb3ViWG94VjI4RURI?= =?utf-8?B?SklCcjVucW9RRVJ4anlvTUxhVzVPdlpRVnVmU0ZuYjZObnlVTWdqc20yZFJU?= =?utf-8?B?b3BheVZLemh3NkQ4NGJubVlOdTV3NTN3WVRldHJUTXJ1dVB3QjJXZlc2V3VC?= =?utf-8?B?d01uRU1sZ3l1TkUxeEM4OHRuSUk1emYxZU0xM1V6OUw2QzhHVjB3OU5xWlAz?= =?utf-8?B?YUZyeGdJZjRNYVo4Y3ROTjhEZ21lM2R1ZytJYVlhb0tHdUIzMHVxdmN4Qi93?= =?utf-8?B?cFlyUU9ON3RHZEFoN2xxWUp1c1hVMnNxeENzNGVrdGs0VVZTekxzclZUdXZm?= =?utf-8?B?akViZ0lieWxNVVBYdUcxWFY3K3VpNFllWnZlSXZDNTBrOWtRVFd6QlFhY295?= =?utf-8?B?MU1yMzdxVkx3c09zRjFMK2hUMm1sbU1zYTRlY3QvTDY0ekROeUh2SXFMd0t0?= =?utf-8?B?WnhraDlNTTZSek94WU1EbkpvKzFBcVZMUUJ4NGVhcUZZN01WQy96UlhhcjFC?= =?utf-8?B?K0dzQ0tHa09BYU1KblhxUFExRnp1QXpjejVUdElHSUpSa2R6NFFIRXNhcVl5?= =?utf-8?B?cXFIekYzamVVejRLcVdBbjRoWjBnUzNkeEJYNlVWQys4SDJUSmhLeGF1eGNn?= =?utf-8?B?WUlZZytCYldJUzc2OEZTaUk5VysxaTg0dDlndWNUWWNuTWh0MHl5amYxWnpX?= =?utf-8?B?SzNzTldHM00wazdKTFArZzlOYVNWN2o3QWp0Vm1CelpuZTdGZC9iRDVPNjFW?= =?utf-8?B?UHM2ZHJBbCswL1drUks2RDFkY1pMMWxXdEJnNU9xdkcvMWw0WjJUdFBWSzhm?= =?utf-8?B?SlF4NjZRc3ZmcVRaaTNOZlM5YTU3T2E2bm84bTJuK2ljWWNvZDRvUE1JK1V4?= =?utf-8?B?VW9Pd01ScU1uTERMeHhnejNKVjdDWThEemt0MTJBYklIcFRRa2NjekY5dGVl?= =?utf-8?B?eUYwdi9FRFV2VzFPekJpSm1RYUxTSWtIM1NGMGZ6Ulo4OVlWNGk3RUs0Y2c4?= =?utf-8?B?ZzF4Y0sxSWJ5L3ZFQTd0aVlOUUhrODd2VWpqMTBpWDIzdmo2bWhvWkp5NENR?= =?utf-8?B?b2JmOExLaEpzRzZSelBkd0E3OVo3VzNpRnIzdTZ4cDdkZ3Z5QlJBZHVWWHlF?= =?utf-8?B?czRSNDBiWVllWGYzYWM2WUNPbTZMb21yT1NNamFDWXNPWmo5WGdpaFo5dFNj?= =?utf-8?B?TGtvK2dna0JYd1Brclp1S01sSmdaSi9wVi9keGdwYUdVVGlZZ0VkK0NVZHgr?= =?utf-8?B?VzNCSlNSNjVocFFsTEZSNzFjM0VGenkyVzFycVV1WTM1OC9BRzV0RWtoY3NG?= =?utf-8?B?L0lXdi9NVDJEcTBmR0NHQzlvUDl1OVpUYzlqelJLRWk4d2w1Z3ZpUVRJVGxF?= =?utf-8?B?dXdxNGRRcVd2d2JNdHBwZllIOWNqRVliU0RhY2c1RzVNcXdjMklDbDVsS3Jk?= =?utf-8?B?bG9jRXRhV01wS21vbG9VRmRhcmdxVWQydWJaZ01SZGdCUXdCOXE2VVQ0Kzd3?= =?utf-8?B?eC9tdk8zejRVNjJyRmJKczA5VXlSQXVMY3IvU1JtV2V5TEwxTURKVmhEVGVT?= =?utf-8?B?RGwzaVY2VWV5Ym5ENVI3NjJ1S0U2WjlMVENnSTRmZW5RL2FDR3ZrMmVSV0VP?= =?utf-8?B?dStIbElER2ZhQzZqQXlrbmpkanBIMll4NVBFaER6WnpyaFpZS09IQythQmN2?= =?utf-8?Q?3L0Kr9VYL+yYRJE0=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46f8ae7e-046e-4e95-cf5b-08df3a6af7ea X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2026 11:58:41.1330 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9DPeNwnD6EaU22SX7mrqmaZyqKR9hIlpPYft36sN70b20QINiD+HHKMbggqGG9pioD5M5gvImRFxUmDPwX4y7KaXlKH0CvFrSiRntgR40Kw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7407 On 11/3/26 8:18 PM, Denis V. Lunev wrote: > From: Denis V. Lunev > > CPU_INTERRUPT_INIT is 0x0400, while kvm_vcpu_events.smi.latched_init > is a __u8. The assignment truncates the masked value to 0, so every > KVM_SET_VCPU_EVENTS tells KVM to clear an INIT it has latched for a > vCPU in SMM. smi.pending survives only because CPU_INTERRUPT_SMI is > 0x0040; normalize both with !! like the neighbouring fields. > > Fixes: fc12d72e1082 ("target-i386: add support for SMBASE MSR and SMIs") > Cc: qemu-stable@nongnu.org > Signed-off-by: Denis V. Lunev > --- > target/i386/kvm/kvm.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c > index 8dc0f134990..6efe0e6b308 100644 > --- a/target/i386/kvm/kvm.c > +++ b/target/i386/kvm/kvm.c > @@ -5124,8 +5124,9 @@ static int kvm_put_vcpu_events(X86CPU *cpu, int level) > /* As soon as these are moved to the kernel, remove them > * from cs->interrupt_request. > */ > - events.smi.pending = cs->interrupt_request & CPU_INTERRUPT_SMI; > - events.smi.latched_init = cs->interrupt_request & CPU_INTERRUPT_INIT; > + events.smi.pending = !!(cs->interrupt_request & CPU_INTERRUPT_SMI); > + events.smi.latched_init = > + !!(cs->interrupt_request & CPU_INTERRUPT_INIT); > cs->interrupt_request &= ~(CPU_INTERRUPT_INIT | CPU_INTERRUPT_SMI); > } else { > /* Keep these in cs->interrupt_request. */ Ack Applied to hci-dev