From: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
To: Alexander Ivanov <alexander.ivanov@virtuozzo.com>,
andrey.zhadchenko@virtuozzo.com
Cc: svt-core@virtuozzo.com
Subject: Re: [PATCH hci-8.1 v3 2/4] vhost-blk: reject num-queues above VHOST_BLK_MAX_QUEUES
Date: Wed, 28 Oct 2026 17:31:02 +0200 [thread overview]
Message-ID: <68878ec5-cdf5-48b9-a2a5-11ba4b3beba0@virtuozzo.com> (raw)
In-Reply-To: <20261028123333.3145676-3-alexander.ivanov@virtuozzo.com>
On 10/28/26 2:33 PM, Alexander Ivanov wrote:
> Only the automatic num-queues value is capped at VHOST_BLK_MAX_QUEUES,
> an explicit one is taken as is. The kernel vhost-blk device has that
> many virtqueues and fails VHOST_SET_VRING_NUM on any vq beyond them,
> so such a device realizes fine and then never starts.
This claim isn't quite accurate:
> -device vhost-blk-pci,devpath=/dev/loop0,num-queues=33
> qemu-system-x86_64: vhost_set_vring_call failed: No buffer space available (105)
> qemu-system-x86_64: vhost-blk: vhost initialization failed: No buffer space available
So realize doesn't even work. Just adjust the commit message.
> Refuse it at realize instead.
>
> https://virtuozzo.atlassian.net/browse/VSTOR-107537
>
Let's also add the 'Fixes: 0ff3cb5ff28f ("...")' tag here.
> Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
> ---
> [...]
With that:
Reviewed-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
next prev parent reply other threads:[~2026-10-28 15:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 12:33 [PATCH hci-8.1 v3 0/4] vhost-blk: switch from VHOST_SET_NWORKERS to the mainstream worker ioctls Alexander Ivanov
2026-10-28 12:33 ` [PATCH hci-8.1 v3 1/4] vhost-backend: add vhost_set_fork_from_owner op Alexander Ivanov
2026-10-28 12:36 ` no-reply
2026-10-28 15:30 ` Andrey Drobyshev
2026-10-28 12:33 ` [PATCH hci-8.1 v3 2/4] vhost-blk: reject num-queues above VHOST_BLK_MAX_QUEUES Alexander Ivanov
2026-10-28 12:35 ` no-reply
2026-10-28 15:31 ` Andrey Drobyshev [this message]
2026-10-28 12:33 ` [PATCH hci-8.1 v3 3/4] vhost-blk: create kernel threads with the mainstream worker ioctls Alexander Ivanov
2026-10-28 12:38 ` no-reply
2026-10-28 15:31 ` Andrey Drobyshev
2026-10-28 12:33 ` [PATCH hci-8.1 v3 4/4] linux-headers: drop VHOST_SET_NWORKERS Alexander Ivanov
2026-10-28 12:36 ` no-reply
2026-10-28 15:31 ` Andrey Drobyshev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68878ec5-cdf5-48b9-a2a5-11ba4b3beba0@virtuozzo.com \
--to=andrey.drobyshev@virtuozzo.com \
--cc=alexander.ivanov@virtuozzo.com \
--cc=andrey.zhadchenko@virtuozzo.com \
--cc=svt-core@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox