From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11023093.outbound.protection.outlook.com [52.101.72.93]) by lore.virtuozzo.com (Postfix) with ESMTPS id 6A8CC802A7 for ; Mon, 5 Oct 2026 09:05:24 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wUiFtgOIG1HgFpPD65wRF+sjI3J3hyweMfJr8Nzz/o+mnXdVJUbDIjhzjyeLL3v76Kg0gS5IEzQZPNTUr9RhaVMGPZl7ac4iJF8+rL5mCKzhH95GxSG758rpOZNrlD1vhc38Amsihj0SO/d8Pz9W8hYXS5ielWOWkKZpba2e8/xXxVIUP9YX2jD7H6Eruy4rjZ5x57YswmYaO9adKzUhZOi8JHoWpFI/3Pzci0fIwrQJZLumB38kxb/GbtJ/fHSm3H7NgP476B+U+fqBPQUaD/CYBmhmIUggdMMX43SE2iDbqii5bdLk7b6tLhaoQSVDA/xYaTrmkDYOSUyp2AzWmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6RW3xPyAQAWAQBrPfX1g+IQIqiHkHPCOjY21jwdBG3A=; b=eL7hmbXGLVLDKj40AVsohMKtBfBYh4y1RGLOzaZcxijBNHWtxzzFHDCPGi4GD936BTmhWI8gY2rf/PYkf1RYdipyh6GdB8rZc837zH+UUwDBkb29nQwAo1qNznCrsaydX5Qwl6HdNMMZq9iCh4EFooW5rRx6Rb04wN8cHzIm4oZEkCC1lzItajrWsRNFPc8/fY8EBaV/ZtfXdvz3ECOR3VXk7vvTMlp1jgqIrr9iWmUHVVSDlGccB0kLHnkcjy9rmdE0Xod1YJRYWhytlXv6sPRUq6ctw0aAUUL3Mss326y+VO6NbPXPmt3LrC738UztL7NPbOyYruwbvByevvaCzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6RW3xPyAQAWAQBrPfX1g+IQIqiHkHPCOjY21jwdBG3A=; b=fOI33SnzvOJbBebnM9lx+cKJUonxnn8L2Iot5WS5oSbWopAKs1VKHA5nRJiuVUTa3sBvIhRNB/7OF8dsJ2HzFvb0RsfKCSjyKaC8i75VUN7FkzR4Y7Q0JHfTrg0KCWRmFOPZN7K6+Rb6/w9BiVZVAx0fYLrHDR5xFdFIlw1rc7yjIGcia//fKECUbRHqvctI1kYlQc7GU8aBzOBMRPyw/kNXA4GCbO0L89I+XwCRkNE0tU6unfhlaqyvCE+z6AQyznZxqfvPDJV0UIbRolpkYdwpITs3SYTwdNNYHI6rF876PuGbt4eN+JlWsbVGCS6B1FCKMpss7E5KY2HIEoyfjA== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by MIWPR08MB226003.eurprd08.prod.outlook.com (2603:10a6:290:d7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.14; Mon, 5 Oct 2026 09:05:22 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0496.010; Mon, 5 Oct 2026 09:05:22 +0000 Message-ID: <7d8af2c2-5497-463b-a862-0cc471217750@virtuozzo.com> Date: Mon, 5 Oct 2026 12:05:21 +0300 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] chardev: implement cpr_claim_fds() in the base class #VSTOR-148304 To: "Denis V. Lunev" , svt-core@virtuozzo.com Cc: den@virtuozzo.com References: <20261002164853.2130337-1-den@openvz.org> <20261002164853.2130337-2-den@openvz.org> Content-Language: en-US From: Andrey Drobyshev In-Reply-To: <20261002164853.2130337-2-den@openvz.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0109.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::9) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|MIWPR08MB226003:EE_ X-MS-Office365-Filtering-Correlation-Id: 253fdeb9-f364-4fdf-2375-08df22bfc93c X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|1800799024|376014|18002099003|22082099003|4143699003|10067099003|56012099006|5113699003; X-Microsoft-Antispam-Message-Info: kblEjk4BvsGnoFAi3RlCC06e05Vxgo4qmrNI/dCywIE216h7erC+XQmXMSOS5WnSqi9XalB+fQyLK2ekZILIMI3YgppdHJOCIm+OFG3ckH9gTC2VuYwPjk/jrn7ItXXORj8ci2seaw/FpOHVVlYISdcVKUq0F3mIBL0M/7RoKVY7JWlER9B1KLHYC+rSGGOzXM5HL06Zf8D2oXB98jWLpsbvfZLEHzyhb+gGT09AWp60y+u+32xxfDVuMPvdIJlZk6WToibOjCE/M9X1dggLcDvVJ7n3phwtwnvRrnSJmAs11TnA8zmgR/jIb16ahuZbZl0qWTyGR1sqYu+cEZj6pOYh5TpjLfwM/WAItQru+4jGTjLsOXdjG5lt63ZQC9bONqleKEma217uA/WJFO6Enr6RDstHEaEO4DuAZf/JrOLVeTNUfqVUKzy0TDNT1s98Npgn15tL3kBLNmcRltNpS2ePLaTN2TdlqXzg8sixUfKMya8nseOeoPcGczFf4fqt8SMuEASTCVUJw3pRqNPR8xYFFfcJBbhDWxrSmlBa1tSTRVkFmvSiShnXA4+2AqYsNMhdH58hYFM5D2UM+HO7M7thssusRRxpiZ8iJ0yuvYjTcXWHx8Fk057PWS4Wl3z6HJPXTwPt2P1S6gEJms2u/1cn16dcQ3Fi8mWllfucapY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI0PR08MB10656.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(1800799024)(376014)(18002099003)(22082099003)(4143699003)(10067099003)(56012099006)(5113699003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3FBV0dKT0ZTazlNYmx2N3BCY0xreG5velEwUmJPUFhFVU5zMGI5cyt3WGtT?= =?utf-8?B?a3dLQXZnelFQQUlQdjltc1hOMjBnMGFRb0kvd3hPcnRQa0Fob0x4L1lWZ3VG?= =?utf-8?B?UzgrK29yTWtabjZPdVlkcUtPVmYzZnhRUUdObEZzTmVtd3Y1Vi93Wkl1aE12?= =?utf-8?B?N29pVDJqQmk2d2hmbitTT294akVNWG5yUzdnb0IwblZSek9BT2NmQ2hWOGR4?= =?utf-8?B?OFJSbmxEYnYxcng2TUEvWEV3R1pLYXExSkt4WGxDcDdNZFo4QndScVhpUHRF?= =?utf-8?B?UEloUHNJbzB0amkzdU9DTDFCNGhpNXdWbjRXWVNTNzQ4YmVXUkZKallWeW1J?= =?utf-8?B?OFI4OCtGRHB0blJIRWlpeERLNllBb0FrSVViSVNmWTBYY3I3ajVwaDZHTGpR?= =?utf-8?B?aGRGUDIyMFVBTjFYeTArdHVLeTBmRFhiQjJzYmhZSXJqTkhhTjdVSmN6ZVJj?= =?utf-8?B?bzF0ekIzdEdFU3laNDVCQS9TT1hPcW5JMnBMdWFPV2daa1FvbnVTQVh5a1dD?= =?utf-8?B?TXlmbEZPSkFjN3YwVzR0SjF5L3ljaEtqNGM2UVRzd1JuMFVKdXY2bE5KUWJo?= =?utf-8?B?OUp2blcvTHJGYWhCOVQ3R2NyeGJUTkdMaGt2UFFyN1o4ajA1L0l2Mit5Q1Bw?= =?utf-8?B?TDNFVElZc09RV0tXQkxTVEdWS0xkL1Y5dEZRdUZ3eFpWcjZ1VWhDS2NvazV4?= =?utf-8?B?WUdHdll0ZE9LMnBGazNEc1N0b2taSDR1K3M2OFBMV3ZRdGdsc09peUNQd3kr?= =?utf-8?B?RW9JUkJhTlJBZXErRTlmNFZSUytkVTVkVi9vRWxTMjdPRDFqN2RCR0tQNHIv?= =?utf-8?B?cFNjc3FSbkRPYmJ6QUJJN29QNklBQTU0YUFXNnNGU1NHQ0FUSGZYQmZnaHBQ?= =?utf-8?B?eEI2bUQ0S2c1OXlONElUR2xmdVNnby9scExsTGowRFJsRTNpYVFVL0NqS0Qz?= =?utf-8?B?UTVVbGUyRmY3K21zeEczWnhyaHgxakNKRjNVcWNIRVpSVitiZ1U1ZGJEck04?= =?utf-8?B?b2hYcWtIL01yQjRjSFNCR2R1cDVqVGJ6dTZ0TytuaTBna0lEdUpHY0tscTVN?= =?utf-8?B?ZUV0MzhqcFdPTUNNc2ZjTlJSaEN6RnZXVUU4WHE0a1ducGU2aGh4d2lrVXdJ?= =?utf-8?B?RWZsdnZ6Y2RYOVpQaXQrYld1ck9QRXdoSFBVTWlJN3QzbHE2bWpMRm9oZEc0?= =?utf-8?B?Qloxb0QzZ0Z4bDJsQ0hKcTlOQjQ2ZFBkMVluekt2WGU0aXRteXdxS1RTNVp1?= =?utf-8?B?QTZLMEFveWFoWGU3aERuaTdlL0lZb1M3THEwSUtUbUZVWGoyZDVpSlpxbU1o?= =?utf-8?B?VzJJNTB1eG5GNnpSNXVCT1daNDFYUlh0K21nMlQxYkd4WkNXZ2FCTGRkTGo1?= =?utf-8?B?YlFTMDJpSTBvcG94a2FuVXdBTkhLakxkTzRDOE5NOWNrT2w3R2xGWTFGUm9w?= =?utf-8?B?YnoxTUF1UjRaMTJCdGR2aC9JT2ZtbC9odVFBamZEc0c3enpjdnRuMjVqM0NR?= =?utf-8?B?eVhMSzFSMzhyTm1UZmdBNCttTkhPUERTYVRyNEVuY291M252TEtnTy9kUnJO?= =?utf-8?B?ZTU4dG1ra1VFelY0cDh5Y0h2ZmxHOTBtOFAwZkhQblVJdGdtZTNOT0t6YXBw?= =?utf-8?B?QThidnY2dTA4UDg2dUIzMDRvbFYzNlZTRkNCYnRPSmlhS2Jva1VzenhpQUND?= =?utf-8?B?SStXK2tEQ2RWS0o0L3VVVmVSYUFRT05SQTZKOE5PaEtpb0lSNnh6ZUp5SkND?= =?utf-8?B?d29PMFkyYVFMY0tSN0o0dm9kYVlIQmxKQmJ4RXhqVnJqd2hFT01IRTRZbEFw?= =?utf-8?B?TktBTU1iYzFQSEt6TkpOZ2hWRzhmUkkrdzE5K1B2Y3ZXUFI3d241TGxTNWsv?= =?utf-8?B?ZHJsSUYySnJEdnhpc212REZ4UVRIaHRMZ2FOaWJPeGoxQkNndDZmRnpDbTNU?= =?utf-8?B?L0JZK3NKbGw5eEJtV01rMnA2MWEzaDZlN1FKVy95alc2TTZBK29kRFMya0pO?= =?utf-8?B?K0lZTkxpd3hKbDNmK0Z2Mm8xR1pMVllhVmpTK0RRaWs0MEYzZktDSzhVQlVq?= =?utf-8?B?WDRGc2k3NjhiOXk2WTV5T29rQW9XblZuL0k3UEcvV2dxR1VOUnpLbWY0TU1Q?= =?utf-8?B?MDBpRzJtQ2xQaExUdkdsRHJVRGk3b2Q0djlZSTVtQkFjUml1am1Qb25pQUxi?= =?utf-8?B?TTloYkxoNjExZFcyWVdzTUZCVm96OUhRbUNHTngxdkhWZ2pYTDU4OURJWk5p?= =?utf-8?B?RXdhbE1vZ3VOSG9EZnJKamdXQTNnSFlXaklPLzJqa2ZMTnBQNW5tc2tjKzRR?= =?utf-8?B?RUZVUnphaGwyY0U3bnNiQnFvYUsyY21yMWp0M2FzR0hDdUN5OXozNWM5empT?= =?utf-8?Q?hDq6EwWJbnUIyPxI=3D?= X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 253fdeb9-f364-4fdf-2375-08df22bfc93c X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2026 09:05:22.2036 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1dvYZqnWU5K275pt8Yw00llt5MSeIBKkzXM7k1U46euoWsK6xqaST4PoxlTp2fAoiPT7O3Hriq8XEOecxUJKMIX6Q+plGmyFC3wd3wKlbw8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MIWPR08MB226003 On 10/2/26 7:48 PM, Denis V. Lunev wrote: > From: Denis V. Lunev > > Give TYPE_CHARDEV an empty cpr_claim_fds() and make the file, pty and > socket backends chain to their parent's. Every chardev class then has > the hook, so qmp_chardev_change() calls it without a NULL check, and > state owned by the base class can be re-claimed there as well. > > No functional change. > > Signed-off-by: Denis V. Lunev > --- > [...] Reviewed-by: Andrey Drobyshev