From: no-reply@sashiko.virtuozzo.com
To: Alexander Ivanov <alexander.ivanov@virtuozzo.com>, den@openvz.org
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v3 5/5] dm-ploop: truncate unused tail of top delta on suspend
Date: Thu, 8 Oct 2026 14:15:55 +0000 [thread overview]
Message-ID: <010701a11bdee88e-ee925f7e-b676-4f82-91e0-57aea9332050-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261008140333.614909-6-alexander.ivanov@virtuozzo.com>
> Preallocated space and clusters at the end of the top delta freed by
> discard are never given back, so the file size never shrinks. Now that
> ploop reloads metadata on resume, we can truncate the top delta on
> suspend: the next resumed ploop (maybe of reloaded table) picks up the
> new file size.
>
> Add ploop_calc_used_end(), which returns the end of the last cluster
> used by the delta: either BAT area, the last mapped cluster or format
> extension. Metadata is read from disk rather than taken from memory:
> the next table load checks BAT entries against the file size (-EPROTO
> otherwise), while in-memory BAT may differ from on-disk one after
> failed BAT writeback. Skip it if md pages are not clean, as on-disk BAT
> may miss allocated clusters then.
>
> Userspace writes format extension (CBT) behind the last data cluster
> [ ... ]
>
> https://virtuozzo.atlassian.net/browse/VSTOR-148171
> Feature: dm-ploop: ploop target driver
>
> Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261008140333.614909-1-alexander.ivanov@virtuozzo.com?part=5
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-10-08 14:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 14:03 [Devel] [PATCH hci-8.1 v3 0/5] " Alexander Ivanov
2026-10-08 14:03 ` [Devel] [PATCH hci-8.1 v3 1/5] dm-ploop: fix lost wakeup in ploop_allocator() Alexander Ivanov
2026-10-08 14:07 ` no-reply
2026-10-08 16:51 ` Denis V. Lunev
2026-10-08 14:03 ` [Devel] [PATCH hci-8.1 v3 2/5] dm-ploop: set delta is_raw before applying its mappings Alexander Ivanov
2026-10-08 14:09 ` no-reply
2026-10-08 16:51 ` Denis V. Lunev
2026-10-09 6:28 ` Alexander Ivanov
2026-10-08 14:03 ` [Devel] [PATCH hci-8.1 v3 3/5] dm-ploop: factor out ploop_read_delta() from ploop_add_delta() Alexander Ivanov
2026-10-08 14:08 ` no-reply
2026-10-08 16:51 ` Denis V. Lunev
2026-10-08 14:03 ` [Devel] [PATCH hci-8.1 v3 4/5] dm-ploop: reload metadata on resume Alexander Ivanov
2026-10-08 14:18 ` no-reply
2026-10-08 16:51 ` Denis V. Lunev
2026-10-08 14:03 ` [Devel] [PATCH hci-8.1 v3 5/5] dm-ploop: truncate unused tail of top delta on suspend Alexander Ivanov
2026-10-08 14:15 ` no-reply [this message]
2026-10-08 16:51 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010701a11bdee88e-ee925f7e-b676-4f82-91e0-57aea9332050-000000@eu-central-1.amazonses.com \
--to=no-reply@sashiko.virtuozzo.com \
--cc=alexander.ivanov@virtuozzo.com \
--cc=den@openvz.org \
--cc=devel@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.