From: "Denis V. Lunev" <den@openvz.org>
To: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v3 1/5] dm-ploop: fix lost wakeup in ploop_allocator()
Date: Thu, 8 Oct 2026 18:51:19 +0200 [thread overview]
Message-ID: <20261008184500.review-dmploop-v3-1@openvz.org> (raw)
In-Reply-To: <20261008140333.614909-2-alexander.ivanov@virtuozzo.com>
On 08.10.2026 16:03, Alexander Ivanov wrote:
> + /*
> + * Set the state before checking the conditions, otherwise
> + * wake_up_process() from ploop_req_prealloc() or
> + * kthread_stop() may come in between and get lost.
> + */
> + set_current_state(TASK_INTERRUPTIBLE);
This is the canonical kthread loop and the commit message already
explains why. Please drop the comment.
With that:
Reviewed-by: Denis V. Lunev <den@openvz.org>
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-10-08 16:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 14:03 [Devel] [PATCH hci-8.1 v3 0/5] dm-ploop: truncate unused tail of top delta on suspend Alexander Ivanov
2026-10-08 14:03 ` [Devel] [PATCH hci-8.1 v3 1/5] dm-ploop: fix lost wakeup in ploop_allocator() Alexander Ivanov
2026-10-08 14:07 ` no-reply
2026-10-08 16:51 ` Denis V. Lunev [this message]
2026-10-08 14:03 ` [Devel] [PATCH hci-8.1 v3 2/5] dm-ploop: set delta is_raw before applying its mappings Alexander Ivanov
2026-10-08 14:09 ` no-reply
2026-10-08 16:51 ` Denis V. Lunev
2026-10-09 6:28 ` Alexander Ivanov
2026-10-08 14:03 ` [Devel] [PATCH hci-8.1 v3 3/5] dm-ploop: factor out ploop_read_delta() from ploop_add_delta() Alexander Ivanov
2026-10-08 14:08 ` no-reply
2026-10-08 16:51 ` Denis V. Lunev
2026-10-08 14:03 ` [Devel] [PATCH hci-8.1 v3 4/5] dm-ploop: reload metadata on resume Alexander Ivanov
2026-10-08 14:18 ` no-reply
2026-10-08 16:51 ` Denis V. Lunev
2026-10-08 14:03 ` [Devel] [PATCH hci-8.1 v3 5/5] dm-ploop: truncate unused tail of top delta on suspend Alexander Ivanov
2026-10-08 14:15 ` no-reply
2026-10-08 16:51 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261008184500.review-dmploop-v3-1@openvz.org \
--to=den@openvz.org \
--cc=alexander.ivanov@virtuozzo.com \
--cc=devel@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.