All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: no-reply@sashiko.virtuozzo.com
To: Alexander Ivanov <alexander.ivanov@virtuozzo.com>,
	 andrey.zhadchenko@virtuozzo.com
Cc: andrey.drobyshev@virtuozzo.com, svt-core@virtuozzo.com
Subject: Re: [PATCH hci-8.1 v6 3/7] vhost-blk: use a local vhost_dev pointer in start and stop
Date: Tue, 17 Nov 2026 17:41:32 +0000	[thread overview]
Message-ID: <010701a1ea99860d-03af8592-9e49-4cf2-bd85-351b15818844-000000@eu-central-1.amazonses.com> (raw)
In-Reply-To: <20261117173734.3225443-4-alexander.ivanov@virtuozzo.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] vhost-blk: Fixes: trailer on a no-functional-change refactor
--

commit 0d672950c3904c71a55c82c916f27588ac3348b7
Author: Alexander Ivanov <alexander.ivanov@virtuozzo.com>

vhost-blk: use a local vhost_dev pointer in start and stop

This commit adds a local struct vhost_dev pointer, hdev, in vhost_blk_start() and vhost_blk_stop(). It replaces the open-coded &s->dev and s->dev.<field> uses with hdev.

> vhost-blk: use a local vhost_dev pointer in start and stop
>
> Take &s->dev once into hdev in vhost_blk_start() and vhost_blk_stop()
> instead of spelling it out at every use. No functional change.
>
> https://virtuozzo.atlassian.net/browse/VSTOR-107537
>
> Fixes: 0ff3cb5ff28f ("block: add vhost-blk backend")
> Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>

[Severity: Low]
Should the Fixes: tag be dropped? The message says "No functional change", and the diff only introduces a local alias for &s->dev. Commit 0ff3cb5ff28f ("block: add vhost-blk backend") merely added the file, and nothing it introduced is being repaired here.

With the tag present, stable or downstream backport tooling may select this cosmetic cleanup as if it were a bug fix.

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261117173734.3225443-1-alexander.ivanov@virtuozzo.com?part=3

  reply	other threads:[~2026-11-17 17:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 17:37 [PATCH hci-8.1 v6 0/7] vhost-blk: switch from VHOST_SET_NWORKERS to the mainstream worker ioctls Alexander Ivanov
2026-11-17 17:37 ` [PATCH hci-8.1 v6 1/7] vhost-backend: add vhost_set_fork_from_owner op Alexander Ivanov
2026-11-17 17:39   ` no-reply
2026-11-17 17:37 ` [PATCH hci-8.1 v6 2/7] vhost-blk: reject num-queues above VHOST_BLK_MAX_QUEUES Alexander Ivanov
2026-11-17 17:40   ` no-reply
2026-11-17 17:37 ` [PATCH hci-8.1 v6 3/7] vhost-blk: use a local vhost_dev pointer in start and stop Alexander Ivanov
2026-11-17 17:41   ` no-reply [this message]
2026-11-17 17:37 ` [PATCH hci-8.1 v6 4/7] vhost-blk: fix vhost_blk_start() returning 0 on failure Alexander Ivanov
2026-11-17 17:42   ` no-reply
2026-11-17 17:37 ` [PATCH hci-8.1 v6 5/7] vhost-blk: reset the owner when vhost_blk_start() fails Alexander Ivanov
2026-11-17 17:43   ` no-reply
2026-11-17 17:37 ` [PATCH hci-8.1 v6 6/7] vhost-blk: create kernel threads with the mainstream worker ioctls Alexander Ivanov
2026-11-17 17:47   ` no-reply
2026-11-17 17:37 ` [PATCH hci-8.1 v6 7/7] linux-headers: drop VHOST_SET_NWORKERS Alexander Ivanov
2026-11-17 17:49   ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=010701a1ea99860d-03af8592-9e49-4cf2-bd85-351b15818844-000000@eu-central-1.amazonses.com \
    --to=no-reply@sashiko.virtuozzo.com \
    --cc=alexander.ivanov@virtuozzo.com \
    --cc=andrey.drobyshev@virtuozzo.com \
    --cc=andrey.zhadchenko@virtuozzo.com \
    --cc=svt-core@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.