From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1] selftests: forwarding: flush neighbours in the bridge locked port test
Date: Tue, 03 Nov 2026 14:04:52 +0100 [thread overview]
Message-ID: <179371109263.2402676.10064531398714880019.b4-review@b4> (raw)
In-Reply-To: <20261103021237.2465704-1-eva.kurchatova@virtuozzo.com>
On Tue, 03 Nov 2026 04:12:34 +0200, Eva Kurchatova wrote:
> While the port drops h1's traffic, h1's neighbour entry for h2 can go
> stale and start probes that the port drops too. If that resolution
> fails just after the port lets h1's traffic through again, the next
> ping gets "Destination Host Unreachable", ping stops at the first
> error because a deadline is set, and the test fails with, for example,
> "Ping did not work after replacing FDB entry".
Only locked_port_mab can fail this way, and the CI log shows only that
case failing. So please:
- keep only the flush in locked_port_mab and drop the other three;
- keep only "Fixes: 4a331d346996", b2b681a41251 goes with the dropped
hunks;
- describe the resolution that actually fails (below).
Why only MAB: its entry for 192.0.2.2 is left over from
locked_port_ipv4, and the port stays locked for two pings, long enough
for that entry to time out. In the other three cases the first ping
resolves a fresh entry, which stays REACHABLE longer than the port is
locked. The ipv6 flush would even hide the MAB failure: it also removes
the old IPv4 entry before the MAB case runs.
What fails: the stale entry's unicast probes failing reports nothing.
The error comes from the broadcast resolution that the locked ping
starts. It fails after the next ping has queued its first packet, and
that ping gets "Destination Host Unreachable".
Nit: say "the locked bridge port" in the first sentence, and name the
MAB check instead of "for example".
--
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
prev parent reply other threads:[~2026-11-03 13:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 2:12 Eva Kurchatova
2026-11-03 2:15 ` no-reply
2026-11-03 2:41 ` Eva Kurchatova (Virtuozzo)
2026-11-03 13:04 ` Konstantin Khorenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179371109263.2402676.10064531398714880019.b4-review@b4 \
--to=khorenko@virtuozzo.com \
--cc=devel@openvz.org \
--cc=eva.kurchatova@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.