From: "Eva Kurchatova (Virtuozzo)" <eva.kurchatova@virtuozzo.com>
To: no-reply@sashiko.virtuozzo.com, khorenko@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1] selftests: forwarding: flush neighbours in the bridge locked port test
Date: Tue, 3 Nov 2026 04:41:17 +0200 [thread overview]
Message-ID: <b9708241-7423-4382-8602-300ec14eb3c8@virtuozzo.com> (raw)
In-Reply-To: <010701a19f3098a5-0f3c07ac-90ac-458c-a219-0bcf3e1dada5-000000@eu-central-1.amazonses.com>
On 11/3/26 04:15, no-reply@sashiko.virtuozzo.com wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] selftests: commit message carries downstream-only Jira URL and Feature tag
> --
>
> commit 5c88239541683d62eb566e440a6cf1b940bf6161
> Author: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
>
> selftests: forwarding: flush neighbours in the bridge locked port test
>
> This patch adds "ip neigh flush" calls in bridge_locked_port.sh. Each call
> runs right after the FDB entry is added or replaced, so the next ping starts
> a fresh neighbour resolution instead of failing on a stale entry.
>
>> selftests: forwarding: flush neighbours in the bridge locked port test
>>
>> [ ... ]
>>
>> Fixes: b2b681a41251 ("selftests: forwarding: tests of locked port feature")
>> Fixes: 4a331d346996 ("selftests: forwarding: Add MAC Authentication Bypass (MAB) test cases")
>> https://virtuozzo.atlassian.net/browse/VSTOR-153057
>> Feature: fix selftests
>>
>> Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
> [Severity: Low]
> This isn't a bug in the code, but the commit message has two downstream-only
> lines:
>
> https://virtuozzo.atlassian.net/browse/VSTOR-153057
> Feature: fix selftests
>
> Upstream reviewers can't open the Jira URL, and "Feature:" isn't a
> recognised kernel trailer. Could both lines be dropped before this goes to
> netdev or linux-kselftest?
Indeed, but this is a Virtuozzo mailing list, and all patches have these
downstream lines by design. Do we have a way to make Sashiko understand
this from the get-go in future?
> The change in bridge_locked_port.sh looks fine. In each test the flush comes
> right after the "bridge fdb add" or "bridge fdb replace", before the ping
> that must succeed. The device it flushes (h1, or h1.100 in the VLAN test) is
> the same one the ping uses.
>
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-03 2:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 2:12 Eva Kurchatova
2026-11-03 2:15 ` no-reply
2026-11-03 2:41 ` Eva Kurchatova (Virtuozzo) [this message]
2026-11-03 13:04 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9708241-7423-4382-8602-300ec14eb3c8@virtuozzo.com \
--to=eva.kurchatova@virtuozzo.com \
--cc=devel@openvz.org \
--cc=khorenko@virtuozzo.com \
--cc=no-reply@sashiko.virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.