Re: [Devel] [PATCH hci-8.1 v9 08/10] dm-qcow2: flag the image for check if reftable relocation fails late

From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v9 08/10] dm-qcow2: flag the image for check if reftable relocation fails late
Date: Tue, 03 Nov 2026 18:50:49 +0100	[thread overview]
Message-ID: <179372824968.2555502.13251629144407705075.b4-review@b4> (raw)
In-Reply-To: <20261028150645.3222391-9-alexander.ivanov@virtuozzo.com>

I won't apply this version, please send v10 with the changes below.

On 10/28/26 16:06, Alexander Ivanov wrote:
> +err_hdr_written:
> +	QC_ERR(qcow2->tgt->ti, "failed to relocate refcount table");
> +	qcow2->tgt->md_writeback_error = true;
> +	return -EIO;

- Make the two messages differ and print the error code.

You answered that a WARN before every late failure tells the two
apart. The header write failure has no WARN, and the late paths use
WARN_ON_ONCE. So from the second failure on, both cases print the same
single line, and the error of the header write is not printed at all.

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel