From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 2/4] dm-ploop: fix a lost wakeup of the ploop_allocator() thread
Date: Wed, 04 Nov 2026 18:14:19 +0100 [thread overview]
Message-ID: <179381245947.2686233.1778067243396983116.b4-review@b4> (raw)
In-Reply-To: <20261103083642.130885-3-den@openvz.org>
I won't apply this version, please send v2 with the changes below.
On Tue, 03 Nov 2026 09:36:40 +0100, Denis V. Lunev wrote:
> ploop_allocate_cluster() until some later request wakes the thread. The
Item 2 of the cover letter reply: drop "until some later request wakes
the thread".
Why: ploop_req_prealloc() returns without a wakeup when the requested
size is already covered by prealloc_size, so later requests in the same
range do not wake the thread either. The stall does not end by itself.
Item 2 of the cover letter reply: add one sentence that the same
reorder fixes a lost kthread_stop() wakeup.
Why: the old loop tested kthread_should_stop() and only then set the
task state, so a kthread_stop() landing in between was lost the same
way and the device removal hung.
With that fixed:
Reviewed-by: Konstantin Khorenko <khorenko@virtuozzo.com>
--
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-04 17:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 8:36 [Devel] [PATCH hci-8.1 0/4] dm-ploop: fix the pio submission stop around cmds Denis V. Lunev
2026-11-03 8:36 ` [Devel] [PATCH hci-8.1 1/4] dm-ploop: fix pio submission racing with the suspend and resume of a cmd Denis V. Lunev
2026-11-03 8:40 ` no-reply
2026-11-04 17:14 ` Konstantin Khorenko
2026-11-03 8:36 ` [Devel] [PATCH hci-8.1 2/4] dm-ploop: fix a lost wakeup of the ploop_allocator() thread Denis V. Lunev
2026-11-03 8:39 ` no-reply
2026-11-04 17:14 ` Konstantin Khorenko [this message]
2026-11-03 8:36 ` [Devel] [PATCH hci-8.1 3/4] dm-ploop: wait for the ploop_allocator() thread before changing deltas[] Denis V. Lunev
2026-11-03 8:42 ` no-reply
2026-11-04 17:14 ` Konstantin Khorenko
2026-11-03 8:36 ` [Devel] [PATCH hci-8.1 4/4] dm-ploop: fix a failed cluster copy on grow leaving the BAT page busy Denis V. Lunev
2026-11-03 8:42 ` no-reply
2026-11-04 17:14 ` Konstantin Khorenko
2026-11-04 13:24 ` [Devel] [PATCH hci-8.1 0/4] dm-ploop: fix the pio submission stop around cmds Andrey Zhadchenko
2026-11-04 17:14 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179381245947.2686233.1778067243396983116.b4-review@b4 \
--to=khorenko@virtuozzo.com \
--cc=den@openvz.org \
--cc=devel@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.