From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 1/2] dm-ploop: fix flip_upper_deltas returning with two md_locks held
Date: Thu, 05 Nov 2026 13:58:48 +0100 [thread overview]
Message-ID: <179388352808.2823727.6444206565446181314.b4-review@b4> (raw)
In-Reply-To: <20261104214635.2063009-2-den@openvz.org>
I won't apply this version, please send v2 with the changes below.
On Wed, 04 Nov 2026 22:46:34 +0100, Denis V. Lunev wrote:
> there. The ploop library does not: its reverse merge clears those
> entries in the lower delta before it flips, and a device it mounted has
> the lower delta read-only, which the flip refuses before the check.
- drop "and a device it mounted has the lower delta read-only, which the
flip refuses before the check".
Item 1 of the cover letter reply. The library reloads the table with
PLOOP_RELOAD_RW2 before the flip, so the lower delta is read-write and
the check runs on every library flip. Clearing the shared entries with
the device suspended is what keeps the library away from this path.
The code is fine. With that fixed:
Reviewed-by: Konstantin Khorenko <khorenko@virtuozzo.com>
--
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-05 13:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 21:46 [Devel] [PATCH hci-8.1 0/2] dm-ploop: fix flip_upper_deltas panicking the host in its pre-flip check Denis V. Lunev
2026-11-04 21:46 ` [Devel] [PATCH hci-8.1 1/2] dm-ploop: fix flip_upper_deltas returning with two md_locks held Denis V. Lunev
2026-11-04 21:50 ` no-reply
2026-11-05 12:58 ` Konstantin Khorenko [this message]
2026-11-04 21:46 ` [Devel] [PATCH hci-8.1 2/2] dm-ploop: fix flip_upper_deltas walking past the BAT of the lower delta Denis V. Lunev
2026-11-04 21:50 ` no-reply
2026-11-05 12:58 ` Konstantin Khorenko
2026-11-05 12:36 ` [Devel] [PATCH hci-8.1 0/2] dm-ploop: fix flip_upper_deltas panicking the host in its pre-flip check Andrey Zhadchenko
2026-11-05 12:58 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179388352808.2823727.6444206565446181314.b4-review@b4 \
--to=khorenko@virtuozzo.com \
--cc=den@openvz.org \
--cc=devel@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.