From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 0/3] dm-ploop: fix writes to a read-only device hanging the host
Date: Tue, 10 Nov 2026 18:11:13 +0100 [thread overview]
Message-ID: <179433067371.3552165.8266037417518853942.b4-review@b4> (raw)
In-Reply-To: <20261109190604.1850504-1-den@openvz.org>
Applying the series with these fixes on my side:
- patches 2 and 3: commit message fixes, listed in the replies there;
- cover letter: "never completes" -> "can hang forever";
- cover letter: "never resubmitted. Any failing allocation leaves
them stuck" -> they wait for the next writeback of the page, which
may never come;
- cover letter: dropped "with EBADF" from the second bug;
- cover letter: dropped the sizes, counts and the host name from the
test section, and split the first paragraph.
On Mon, 9 Nov 2026 20:06:01 +0100, Denis V. Lunev wrote:
> A write that reaches a read-only ploop device never completes: the
> writer hangs in D state, and after a buffered write every later sync on
> the host hangs behind it until a reboot. Such writes come from a device
The write whose allocation fails completes with EIO, and a write to a
cluster already in the top delta completes. What hangs are the pios
parked on the same BAT page while the failed update was prepared.
> - when a cluster allocation or a discard fails, the pios parked on that
> BAT page are never resubmitted (patch 2). Any failing allocation
> leaves them stuck, not only one on a read-only device. Patch 1 moves
The next writeback of that page resubmits them, so after a single
-ENOMEM the next successful allocation on the page frees them. They
stay for good only when every allocation fails: a read-only device, or
no free cluster left.
> - ploop test suite, make -j48 test on dev-cl04, green for ploop and
The cover letter goes into each commit as the "Patchset description",
so the numbers and the host name would end up in the git log.
Not for this series: with it the libvzctl backup attach that mounts
the partition read-write fails with EIO, and with ploop PR 513 it fails
at open. Does libvzctl need a change too, and is there a ticket for it?
--
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-10 17:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 19:06 Denis V. Lunev
2026-11-09 19:06 ` [Devel] [PATCH hci-8.1 1/3] dm-ploop: factor out ploop_dispatch_md_waiters() Denis V. Lunev
2026-11-09 19:15 ` no-reply
2026-11-10 17:11 ` Konstantin Khorenko
2026-11-09 19:06 ` [Devel] [PATCH hci-8.1 2/3] dm-ploop: fix pios stuck in md->wait_llist after a failed BAT update Denis V. Lunev
2026-11-09 19:18 ` no-reply
2026-11-10 17:11 ` Konstantin Khorenko
2026-11-09 19:06 ` [Devel] [PATCH hci-8.1 3/3] dm-ploop: fail writes to a read-only device Denis V. Lunev
2026-11-09 19:19 ` no-reply
2026-11-10 17:11 ` Konstantin Khorenko
2026-11-10 17:11 ` Konstantin Khorenko [this message]
2026-11-10 17:11 ` [Devel] [PATCH hci-8.1 0/3] dm-ploop: fix writes to a read-only device hanging the host Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179433067371.3552165.8266037417518853942.b4-review@b4 \
--to=khorenko@virtuozzo.com \
--cc=den@openvz.org \
--cc=devel@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.