From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 2/3] dm-ploop: fix pios stuck in md->wait_llist after a failed BAT update
Date: Tue, 10 Nov 2026 18:11:13 +0100 [thread overview]
Message-ID: <179433067372.3552165.6566523190212756820.b4-review@b4> (raw)
In-Reply-To: <20261109190604.1850504-3-den@openvz.org>
Applying with these fixes on my side:
- "No writeback of the page is queued, so they are never resubmitted"
-> "They wait for the next writeback of the page, which never comes
when every allocation on it fails";
- the failure causes moved into a paragraph of their own, as a "- "
list.
On Mon, 9 Nov 2026 20:06:03 +0100, Denis V. Lunev wrote:
> MD_UPDATING and leaves the parked pios where they are. No writeback of
> the page is queued, so they are never resubmitted: the writers hang in
ploop_advance_local_after_bat_wb() drains md->wait_llist on every
writeback of the page, so after a single -ENOMEM the next write that
allocates on the same page frees the parked pios. The hang is
permanent only when every allocation on the page fails.
--
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-10 17:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 19:06 [Devel] [PATCH hci-8.1 0/3] dm-ploop: fix writes to a read-only device hanging the host Denis V. Lunev
2026-11-09 19:06 ` [Devel] [PATCH hci-8.1 1/3] dm-ploop: factor out ploop_dispatch_md_waiters() Denis V. Lunev
2026-11-09 19:15 ` no-reply
2026-11-10 17:11 ` Konstantin Khorenko
2026-11-09 19:06 ` [Devel] [PATCH hci-8.1 2/3] dm-ploop: fix pios stuck in md->wait_llist after a failed BAT update Denis V. Lunev
2026-11-09 19:18 ` no-reply
2026-11-10 17:11 ` Konstantin Khorenko [this message]
2026-11-09 19:06 ` [Devel] [PATCH hci-8.1 3/3] dm-ploop: fail writes to a read-only device Denis V. Lunev
2026-11-09 19:19 ` no-reply
2026-11-10 17:11 ` Konstantin Khorenko
2026-11-10 17:11 ` [Devel] [PATCH hci-8.1 0/3] dm-ploop: fix writes to a read-only device hanging the host Konstantin Khorenko
2026-11-10 17:11 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179433067372.3552165.6566523190212756820.b4-review@b4 \
--to=khorenko@virtuozzo.com \
--cc=den@openvz.org \
--cc=devel@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.