All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Vladimir Riabchun <vladimir.riabchun@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v3 3/6] ve/printk: Specify ve in printks
Date: Thu, 12 Nov 2026 17:35:40 +0100	[thread overview]
Message-ID: <179450134078.4060562.14805563857518430497.b4-review@b4> (raw)
In-Reply-To: <20261012-ve-printk-irq-v3-3-efc95fd5c78a@virtuozzo.com>

I won't apply this version, please send v4 with the changes below.

On Mon, 12 Oct 2026 00:52:30 +0200, Vladimir Riabchun <vladimir.riabchun@virtuozzo.com> wrote:
> +	struct ve_struct *__ve = get_exec_env();			\
> +									\
> +	if (WARN_ON_ONCE((dst & VE_LOG) && !in_task()))			\
> +		__ve = get_ve0();					\

Item 1 of the cover letter reply: rename this local to a name no
caller uses, and write "(dst)".

Why: ve_failcount_inc() has its own "__ve" and passes ve_name(__ve)
in the varargs. Inside this macro that name now means the local. At
this patch and patch 4 a failcount hit from a host task (vzctl moving
a netdev into a CT at its netif limit) prints "CT0" and goes to the
host log only. Patch 5 hides it, but the local still captures any
"__ve" a caller passes.

> +struct log_state *__ve_log_state(struct ve_struct *ve)

Item 2 of the cover letter reply: make it static.

Why: only printk.c calls it. Here it has no prototype, patch 4 adds
one to internal.h.

> Introduce ve_printk helpers that accept VE structure,
> so we can provide correct VE where get_exec_env is unreliable.
>
> This is true for ve_printk_deferred functions, and their users.

Item 3 of the cover letter reply: say what changes for users and add
the Fixes tags.

Why: the second sentence does not parse. The visible fix is that the
conntrack table full, expectation table full and TCPMSS messages from
softirq go to the log of net->owner_ve, not to the CT that was
interrupted. Also, ve_printk_ratelimited() with VE_LOG outside task
context now warns and prints to the host log. The tags name commits
a335738ad21cf ("ve/netfilter: ve_printk for "nf_conntrack: table
full"") and bc279343e9663 ("ve/netfilter: Send iptables/netfilter
kernel error messages to Containers").

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  parent reply	other threads:[~2026-11-12 16:37 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-11 22:52 [Devel] [PATCH hci-8.1 v3 0/6] ve/printk: Fix logs leakage via ve_printk called from IRQ context Vladimir Riabchun
2026-10-11 22:52 ` [Devel] [PATCH hci-8.1 v3 1/6] ve/printk: Add sanity checks in ve_printk functions Vladimir Riabchun
2026-10-11 22:57   ` no-reply
2026-11-12 16:35   ` Konstantin Khorenko
2026-10-11 22:52 ` [Devel] [PATCH hci-8.1 v3 2/6] ve/printk: Report potentially leaking usage of " Vladimir Riabchun
2026-10-11 22:59   ` no-reply
2026-10-26 15:21     ` Vladimir Riabchun
2026-11-12 16:35   ` Konstantin Khorenko
2026-10-11 22:52 ` [Devel] [PATCH hci-8.1 v3 3/6] ve/printk: Specify ve in printks Vladimir Riabchun
2026-10-11 23:02   ` no-reply
2026-10-26 15:27     ` Vladimir Riabchun
2026-11-12 16:35   ` Konstantin Khorenko [this message]
2026-10-11 22:52 ` [Devel] [PATCH hci-8.1 v3 4/6] ve/printk: Fix time virtualization Vladimir Riabchun
2026-10-11 23:03   ` no-reply
2026-10-26 15:36     ` Vladimir Riabchun
2026-11-12 16:35   ` Konstantin Khorenko
2026-10-11 22:52 ` [Devel] [PATCH hci-8.1 v3 5/6] ve/failcount: Use ve_printk with specified ve Vladimir Riabchun
2026-10-11 23:05   ` no-reply
2026-11-12 16:35   ` Konstantin Khorenko
2026-10-11 22:52 ` [Devel] [PATCH hci-8.1 v3 6/6] ve: add neigh_tbl failcounter Vladimir Riabchun
2026-10-11 23:04   ` no-reply
2026-10-12  7:59   ` Vasileios Almpanis
2026-11-12 16:35   ` Konstantin Khorenko
2026-10-12  7:59 ` [Devel] [PATCH hci-8.1 v3 0/6] ve/printk: Fix logs leakage via ve_printk called from IRQ context Vasileios Almpanis
2026-11-12 16:35 ` Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179450134078.4060562.14805563857518430497.b4-review@b4 \
    --to=khorenko@virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=vladimir.riabchun@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.