From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Vladimir Riabchun <vladimir.riabchun@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v3 6/6] ve: add neigh_tbl failcounter
Date: Thu, 12 Nov 2026 17:35:40 +0100 [thread overview]
Message-ID: <179450134079.4060562.4422130849455848574.b4-review@b4> (raw)
In-Reply-To: <20261012-ve-printk-irq-v3-6-efc95fd5c78a@virtuozzo.com>
I won't apply this version, please send v4 with the changes below.
On Mon, 12 Oct 2026 00:52:33 +0200, Vladimir Riabchun <vladimir.riabchun@virtuozzo.com> wrote:
> + ve_failcount_inc(ve, neigh_tbl);
Item 5 of the cover letter reply: call it only when !ve_is_super(ve).
Why: the host netns belongs to ve0 and ve0 is checked against the
same gc_thresh3. A node with more neighbours than that now logs
"CT0: hits the neigh_tbl limit, see the 'neigh_tbl' counter in
ve.failcount of the container's ve cgroup", and the root ve cgroup
has no ve.failcount file (CFTYPE_NOT_ON_ROOT). Vasileios asked about
this on v3 and it is still open.
> Feature: per-ve failcounters
> Feature: ve printk
Item 6 of the cover letter reply: keep one Feature: line, "per-ve
failcounters".
Why: one Feature: line per commit; this commit adds a failcounter.
A note on the v2 answer that the limit is global and does not depend
on the table type: arp and ndisc have their own gc_thresh3 and their
own per-VE counters, so one neigh_tbl failcount merges two limits. If
that is intended, fine, no change needed.
--
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-12 16:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-11 22:52 [Devel] [PATCH hci-8.1 v3 0/6] ve/printk: Fix logs leakage via ve_printk called from IRQ context Vladimir Riabchun
2026-10-11 22:52 ` [Devel] [PATCH hci-8.1 v3 1/6] ve/printk: Add sanity checks in ve_printk functions Vladimir Riabchun
2026-10-11 22:57 ` no-reply
2026-11-12 16:35 ` Konstantin Khorenko
2026-10-11 22:52 ` [Devel] [PATCH hci-8.1 v3 2/6] ve/printk: Report potentially leaking usage of " Vladimir Riabchun
2026-10-11 22:59 ` no-reply
2026-10-26 15:21 ` Vladimir Riabchun
2026-11-12 16:35 ` Konstantin Khorenko
2026-10-11 22:52 ` [Devel] [PATCH hci-8.1 v3 3/6] ve/printk: Specify ve in printks Vladimir Riabchun
2026-10-11 23:02 ` no-reply
2026-10-26 15:27 ` Vladimir Riabchun
2026-11-12 16:35 ` Konstantin Khorenko
2026-10-11 22:52 ` [Devel] [PATCH hci-8.1 v3 4/6] ve/printk: Fix time virtualization Vladimir Riabchun
2026-10-11 23:03 ` no-reply
2026-10-26 15:36 ` Vladimir Riabchun
2026-11-12 16:35 ` Konstantin Khorenko
2026-10-11 22:52 ` [Devel] [PATCH hci-8.1 v3 5/6] ve/failcount: Use ve_printk with specified ve Vladimir Riabchun
2026-10-11 23:05 ` no-reply
2026-11-12 16:35 ` Konstantin Khorenko
2026-10-11 22:52 ` [Devel] [PATCH hci-8.1 v3 6/6] ve: add neigh_tbl failcounter Vladimir Riabchun
2026-10-11 23:04 ` no-reply
2026-10-12 7:59 ` Vasileios Almpanis
2026-11-12 16:35 ` Konstantin Khorenko [this message]
2026-10-12 7:59 ` [Devel] [PATCH hci-8.1 v3 0/6] ve/printk: Fix logs leakage via ve_printk called from IRQ context Vasileios Almpanis
2026-11-12 16:35 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179450134079.4060562.4422130849455848574.b4-review@b4 \
--to=khorenko@virtuozzo.com \
--cc=devel@openvz.org \
--cc=vladimir.riabchun@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.