All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 0/8] ms/mptcp: stability fixes
Date: Thu, 12 Nov 2026 18:26:51 +0100	[thread overview]
Message-ID: <179450441149.4060562.12778470791653323060.b4-review@b4> (raw)
In-Reply-To: <20261106030306.16014-1-eva.kurchatova@virtuozzo.com>

I won't apply this version, please send v2 with the changes below.

On Fri, 06 Nov 2026 05:02:08 +0200, Eva Kurchatova <eva.kurchatova@virtuozzo.com> wrote:
> Paolo Abeni (8):
>   ms/mptcp: fix retransmission loop when csum is enabled
>   ms/mptcp: move the retrans loop to a separate helper
>   ms/mptcp: move the stale logic out of retrans scheduler
>   ms/mptcp: let the retrans scheduler do its job
>   ms/mptcp: explicitly drop over memory limits
>   ms/mptcp: implemented OoO queue pruning
>   ms/mptcp: being below memory limit is a likely() condition
>   ms/mptcp: avoid pruning for OoW data

The backports themselves match mainline. What to change for v2:

1. Add mainline 8ab24fdebc369 ("mptcp: close TOCTOU race while
   computing rcv_wnd") and da23be77e1292 ("mptcp: allow subflow rcv
   wnd to shrink") before patch 5. Both are Cc stable and come from
   the same 7.1-rc7 batch as patch 1.

2. Cover letter: say what the series fixes (endless retransmission
   with csum, receive stalls under memory pressure), which patches are
   only prerequisites (2-4), what was left out of the mainline series
   and why, and how it was tested.

3. Patch 3: fix the rebase note, mainline also moves only "stale" out
   of the bitfield.

4. Patch 6: name the two skipped mainline commits in the rebase note.

Separate patches, not needed for v2; I created a task for each:

1. Mainline 7538fa33bb2f6 ("mptcp: fix subflow bitfield misuse").
   Our tree still flips close_event_done under the msk lock only,
   in the same word as bits written under the subflow lock.
   https://virtuozzo.atlassian.net/browse/VSTOR-154927

2. Mainline e2ab913f68c7d ("mptcp: do not reschedule the RTX timer
   for fallback sockets"). After a fallback to TCP the MPTCP
   retransmit timer keeps being rearmed and fires as a no-op.
   https://virtuozzo.atlassian.net/browse/VSTOR-154928

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

      parent reply	other threads:[~2026-11-12 17:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06  3:02 Eva Kurchatova
2026-11-06  3:02 ` [Devel] [PATCH hci-8.1 1/8] ms/mptcp: fix retransmission loop when csum is enabled Eva Kurchatova
2026-11-06  3:07   ` no-reply
2026-11-06  3:02 ` [Devel] [PATCH hci-8.1 2/8] ms/mptcp: move the retrans loop to a separate helper Eva Kurchatova
2026-11-06  3:06   ` no-reply
2026-11-06  3:02 ` [Devel] [PATCH hci-8.1 3/8] ms/mptcp: move the stale logic out of retrans scheduler Eva Kurchatova
2026-11-06  3:07   ` no-reply
2026-11-12 17:26   ` Konstantin Khorenko
2026-11-06  3:02 ` [Devel] [PATCH hci-8.1 4/8] ms/mptcp: let the retrans scheduler do its job Eva Kurchatova
2026-11-06  3:10   ` no-reply
2026-11-06  3:02 ` [Devel] [PATCH hci-8.1 5/8] ms/mptcp: explicitly drop over memory limits Eva Kurchatova
2026-11-06  3:10   ` no-reply
2026-11-12 17:26   ` Konstantin Khorenko
2026-11-06  3:02 ` [Devel] [PATCH hci-8.1 6/8] ms/mptcp: implemented OoO queue pruning Eva Kurchatova
2026-11-06  3:11   ` no-reply
2026-11-12 17:26   ` Konstantin Khorenko
2026-11-06  3:02 ` [Devel] [PATCH hci-8.1 7/8] ms/mptcp: being below memory limit is a likely() condition Eva Kurchatova
2026-11-06  3:10   ` no-reply
2026-11-06  3:02 ` [Devel] [PATCH hci-8.1 8/8] ms/mptcp: avoid pruning for OoW data Eva Kurchatova
2026-11-06  3:11   ` no-reply
2026-11-12 17:26 ` Konstantin Khorenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179450441149.4060562.12778470791653323060.b4-review@b4 \
    --to=khorenko@virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=eva.kurchatova@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.