From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 2/2] selftests/ve: check the AIO ring size in a pseudosuper VE
Date: Fri, 13 Nov 2026 20:41:41 +0100 [thread overview]
Message-ID: <179459890135.57567.4896919865662693695.b4-review@b4> (raw)
In-Reply-To: <20261113-pr-ptikhomirov-vstor-154129-aio-pseudosuper-ring-v1-2-7d35d143fdc3@virtuozzo.com>
I won't apply this version, please send v2 with the changes below.
On Fri, 13 Nov 2026 16:08:45 +0100, Pavel Tikhomirov wrote:
> + cpus = sysconf(_SC_NPROCESSORS_CONF);
Item 4 of the cover letter reply: read
/sys/devices/system/cpu/possible here.
Why: the kernel sizes the ring by cpu_possible_mask, and what
_SC_NPROCESSORS_CONF returns depends on the libc. On a VM with CPU
hotplug slots the two can differ, and the test then skips when it
should run, or expects the wrong ring size.
> + self->ctid = make_ve(self->cgv2_fd, CTID_MIN);
> + ASSERT_GE(self->ctid, 0);
> +
> + ASSERT_EQ(prepare_namespaces(&self->ns_ctx, CLONE_NEWVE,
Item 5 of the cover letter reply: clean up the VE cgroup when setup
fails after make_ve().
Why: the harness skips FIXTURE_TEARDOWN when setup fails, so a failed
prepare_namespaces() leaves the VE cgroup in the host hierarchy.
> + EXPECT_EQ(set_pseudosuper(self, 1), 0);
> + EXPECT_EQ(ve_ring_nr(self, 1), ring_nr_pseudosuper(self, 1));
Item 5 of the cover letter reply: ASSERT_EQ here.
Why: if the write fails, the test goes on and reports a ring size
mismatch, which hides the cause.
--
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-13 19:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 15:08 [Devel] [PATCH hci-8.1 0/2] fs/aio: fix CT migration with AIO to a node with more CPUs Pavel Tikhomirov
2026-11-13 15:08 ` [Devel] [PATCH hci-8.1 1/2] fs/aio: restore the AIO ring of the dumped size in a pseudosuper VE Pavel Tikhomirov
2026-11-13 15:14 ` no-reply
2026-11-13 19:41 ` Konstantin Khorenko
2026-11-13 15:08 ` [Devel] [PATCH hci-8.1 2/2] selftests/ve: check the AIO ring " Pavel Tikhomirov
2026-11-13 15:15 ` no-reply
2026-11-13 19:41 ` Konstantin Khorenko [this message]
2026-11-13 19:41 ` [Devel] [PATCH hci-8.1 0/2] fs/aio: fix CT migration with AIO to a node with more CPUs Konstantin Khorenko
2026-11-16 10:33 ` Pavel Tikhomirov
2026-11-16 10:35 ` Pavel Tikhomirov
2026-11-16 10:35 ` Pavel Tikhomirov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179459890135.57567.4896919865662693695.b4-review@b4 \
--to=khorenko@virtuozzo.com \
--cc=devel@openvz.org \
--cc=ptikhomirov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.