All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
To: Konstantin Khorenko <khorenko@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 0/2] fs/aio: fix CT migration with AIO to a node with more CPUs
Date: Mon, 16 Nov 2026 11:35:20 +0100	[thread overview]
Message-ID: <5f1a844d-c261-4c19-b0b9-cfaa4128a968@virtuozzo.com> (raw)
In-Reply-To: <179459890134.57567.3765669749365305224.b4-review@b4>

On 11/13/26 20:41, Konstantin Khorenko wrote:
> 1. Patch 1, code: a restored ring below this node's minimum must not
>    lose slots in the per-CPU caches. E.g. mark such a context in
>    ioctx_alloc() and let put_reqs_available() and
>    __get_reqs_available() use ctx->reqs_available directly for it.
>    If you keep the cache, the commit message must state the real
>    bound instead of "slightly less reliable".

Done as you suggest: ioctx_alloc() marks such a context with
ctx->no_percpu_reqs, and put_reqs_available() and
__get_reqs_available() then use ctx->reqs_available directly, so no
free slots get stuck in the per-CPU caches.

> 2. Patch 1, commit message and comment: the VE is pseudosuper not only
>    for the restore. vzctl sets ve.pseudosuper on every CT start and
>    clears it just before it execs init. Say "while the CT is being
>    started or restored", or similar.

Changed to "which it is almost only for the restore". No AIO runs in
the CT start window, so the skip matters only for the restore, and I'd
rather not spell out the start details, so the commit stays focused.

> 3. Patch 1, commit message: say what fails without the patch: CRIU's
>    restore_aio_ring() reports "wrong aio" and the migration is
>    aborted.

Not changed: the message already says that CRIU needs a ring of the same
size and that with a bigger ring the restore fails.

> 4. Patch 2: read the CPU count from /sys/devices/system/cpu/possible,
>    the mask the kernel uses, not sysconf(_SC_NPROCESSORS_CONF).

Not changed: on vz10 glibc (2.39) sysconf(_SC_NPROCESSORS_CONF) already
reads /sys/devices/system/cpu/possible (checked with strace), so it is
the same mask.

> 5. Patch 2: do not leave the VE cgroup behind when FIXTURE_SETUP fails
>    after make_ve(), and use ASSERT_EQ for set_pseudosuper().

Done, both.

-- 
Best regards, Pavel Tikhomirov
Senior Software Developer, Virtuozzo.

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

      parent reply	other threads:[~2026-11-16 10:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 15:08 Pavel Tikhomirov
2026-11-13 15:08 ` [Devel] [PATCH hci-8.1 1/2] fs/aio: restore the AIO ring of the dumped size in a pseudosuper VE Pavel Tikhomirov
2026-11-13 15:14   ` no-reply
2026-11-13 19:41   ` Konstantin Khorenko
2026-11-13 15:08 ` [Devel] [PATCH hci-8.1 2/2] selftests/ve: check the AIO ring " Pavel Tikhomirov
2026-11-13 15:15   ` no-reply
2026-11-13 19:41   ` Konstantin Khorenko
2026-11-13 19:41 ` [Devel] [PATCH hci-8.1 0/2] fs/aio: fix CT migration with AIO to a node with more CPUs Konstantin Khorenko
2026-11-16 10:33   ` Pavel Tikhomirov
2026-11-16 10:35     ` Pavel Tikhomirov
2026-11-16 10:35   ` Pavel Tikhomirov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f1a844d-c261-4c19-b0b9-cfaa4128a968@virtuozzo.com \
    --to=ptikhomirov@virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=khorenko@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.