All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Andrey Zhadchenko <andrey.zhadchenko@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v3 0/8] dm-qcow2: per-qio fast path
Date: Fri, 13 Nov 2026 20:48:27 +0100	[thread overview]
Message-ID: <179459930734.57567.988092059411650557.b4-review@b4> (raw)
In-Reply-To: <20261113111126.793039-1-andrey.zhadchenko@virtuozzo.com>

I have reviewed v3: no objections to the code, but a few texts need
changing, see below.

I can change them myself when applying the patches, or you send v4 -
your call, Andrey. Either way I am waiting for Alexander Ivanov's
review.

On Fri, 13 Nov 2026 14:11:18 +0300, Andrey Zhadchenko wrote:
> Known limitation: fast path reads are not counted, and nothing pins
> their cluster between the L2 parse and the data submit. Main kwork
> may discard the cluster, free it and reuse it for another allocation
> in that window, and a fast path read then returns the data of another
> guest offset. A follow-up series fixes this:
> https://virtuozzo.atlassian.net/browse/VSTOR-154659

All v2 items are done. The writer count closes the failed L2 writeback
and the discard that frees a cluster under a counted write, and I
found no code defect in v3. What is left is text:

1. Patch 1, commit message and the comment above __handle_md_page():
   a second miss does not fail the qio. submit_read_md_page() inserts
   the page again and issues a new read; -EIO comes only when that
   insert loses a race again.

2. Patch 3, commit message: "either the fast path sees the entry
   cleared" becomes "either the fast path sees the index locked".

3. Patch 5 and the cover letter: VSTOR-154659 is resolved, it is the
   write counting already in the tree. The read race is VSTOR-154939,
   closed as Won't Fix. Say that it is accepted, and name VSTOR-154939
   instead of a follow-up series.

4. Patch 7, commit message: add the md page read on a cache miss in
   parse_metadata() and the read splits in process_read_qio() to the
   list of sleeps, and say that punch hole waits for direct I/O on ext4
   and xfs only.

Details are in the replies to the patches.

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

      parent reply	other threads:[~2026-11-13 19:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 11:11 Andrey Zhadchenko
2026-11-13 11:11 ` [Devel] [PATCH hci-8.1 v3 1/8] dm-qcow2: repeat md page lookup if it was inserted in parallel Andrey Zhadchenko
2026-11-13 11:22   ` no-reply
2026-11-13 19:48   ` Konstantin Khorenko
2026-11-13 11:11 ` [Devel] [PATCH hci-8.1 v3 2/8] dm-qcow2: prepare process_one_qio() for fastpath Andrey Zhadchenko
2026-11-13 11:26   ` no-reply
2026-11-13 11:11 ` [Devel] [PATCH hci-8.1 v3 3/8] dm-qcow2: count fast path writes in parse_metadata() Andrey Zhadchenko
2026-11-13 11:27   ` no-reply
2026-11-13 19:48   ` Konstantin Khorenko
2026-11-13 11:11 ` [Devel] [PATCH hci-8.1 v3 4/8] dm-qcow2: add per-qio work infrastructure Andrey Zhadchenko
2026-11-13 11:30   ` no-reply
2026-11-13 11:11 ` [Devel] [PATCH hci-8.1 v3 5/8] dm-qcow2: implement per-qio fast processing Andrey Zhadchenko
2026-11-13 11:31   ` no-reply
2026-11-13 19:48   ` Konstantin Khorenko
2026-11-13 11:11 ` [Devel] [PATCH hci-8.1 v3 6/8] dm-qcow2: add fast_path module parameter Andrey Zhadchenko
2026-11-13 11:31   ` no-reply
2026-11-13 11:11 ` [Devel] [PATCH hci-8.1 v3 7/8] dm-qcow2: process fast path qios in per-cpu batches on a workqueue Andrey Zhadchenko
2026-11-13 11:33   ` no-reply
2026-11-13 19:48   ` Konstantin Khorenko
2026-11-13 11:11 ` [Devel] [PATCH hci-8.1 v3 8/8] dm-qcow2: declare DM_TARGET_NOWAIT Andrey Zhadchenko
2026-11-13 11:33   ` no-reply
2026-11-13 19:48 ` Konstantin Khorenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179459930734.57567.988092059411650557.b4-review@b4 \
    --to=khorenko@virtuozzo.com \
    --cc=andrey.zhadchenko@virtuozzo.com \
    --cc=devel@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.