All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Mirian Shilakadze <mirian.shilakadze@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH vz10 v2 0/3] fs: let the host lock the protection flags of a mount
Date: Mon, 16 Nov 2026 18:13:33 +0100	[thread overview]
Message-ID: <179484921365.861498.10091913450295321372.b4-review@b4> (raw)
In-Reply-To: <20261116061256.54472-1-mirian.shilakadze@virtuozzo.com>

I won't apply this version, please send v3 with the changes below.

On Mon, 16 Nov 2026 10:12:51 +0400, Mirian Shilakadze <mirian.shilakadze@virtuozzo.com> wrote:
> Changes since v1, after Pavel's review and Sashiko's:

The kernel side looks right to me: the remount test under s_umount
closes the v1 race, and the s_umount -> namespace_sem order is the one
mount_too_revealing() already uses. What to change for v3:

1. Patch 3: not_recursive passes on a kernel without the feature, the
   unknown bits already fail with EINVAL. Lock the same mount without
   AT_RECURSIVE first and expect success.

2. Patch 3: skip instead of failing when the test is not run as root,
   when user namespaces are off, or when the kernel lacks the lock
   bits (Sashiko's point). Probe the bits once on a scratch clone.
   Close the handover() fd where the other tests do not.

3. Patch 3: add a check that statmount() reports the locks the kernel
   raised, on a mount copied into a new user and mount namespace.
   Patch 2 says it does, nothing tests it.

4. Patch 2 message: say that this changes what statmount() returns in
   every unprivileged container, not only on locked binds.

5. Patch 1 message: say why the ve0 test went away and why
   AT_RECURSIVE is refused.

6. Cover letter: link v1. b4 did not connect the two revisions, it has
   a new ticket and a new title.

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

      parent reply	other threads:[~2026-11-16 17:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  6:12 Mirian Shilakadze
2026-11-16  6:12 ` [Devel] [PATCH vz10 v2 1/3] fs: let the protection flags of a mount be locked from userspace Mirian Shilakadze
2026-11-16  6:24   ` no-reply
2026-11-16 17:13   ` Konstantin Khorenko
2026-11-16  6:12 ` [Devel] [PATCH vz10 v2 2/3] fs: report the locks of a mount in statmount() Mirian Shilakadze
2026-11-16  6:17   ` no-reply
2026-11-16 17:13   ` Konstantin Khorenko
2026-11-16  6:12 ` [Devel] [PATCH vz10 v2 3/3] selftests/ve: test locking a mount from the host Mirian Shilakadze
2026-11-16  6:38   ` no-reply
2026-11-16 17:13   ` Konstantin Khorenko
2026-11-16 17:13 ` Konstantin Khorenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179484921365.861498.10091913450295321372.b4-review@b4 \
    --to=khorenko@virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=mirian.shilakadze@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.