From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Mirian Shilakadze <mirian.shilakadze@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH vz10 v2 2/3] fs: report the locks of a mount in statmount()
Date: Mon, 16 Nov 2026 18:13:33 +0100 [thread overview]
Message-ID: <179484921365.861498.3351238853542398643.b4-review@b4> (raw)
In-Reply-To: <20261116061256.54472-3-mirian.shilakadze@virtuozzo.com>
I won't apply this version, please send v3 with the changes below.
On Mon, 16 Nov 2026 10:12:53 +0400, Mirian Shilakadze <mirian.shilakadze@virtuozzo.com> wrote:
> Report them in the mnt_attr of statmount(), as the MOUNT_ATTR_VE_LOCK_*
> attributes that raise them, whether the host raised them or the kernel
> did, as lock_mnt_tree() does on a mount copied across user namespaces.
Item 4 of the cover letter reply: say that this is a visible change in
every unprivileged container.
lock_mnt_tree() locks every protection set on a mount copied into a
new user namespace, so mnt_attr gains bits 63..60 on most mounts of
every container, ours or LXC. A tool there that feeds mnt_attr back
into mount_setattr() attr_set got 0 before and gets EPERM now. I am
fine with that, but the message has to say it.
--
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-16 17:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 6:12 [Devel] [PATCH vz10 v2 0/3] fs: let the host lock the protection flags of a mount Mirian Shilakadze
2026-11-16 6:12 ` [Devel] [PATCH vz10 v2 1/3] fs: let the protection flags of a mount be locked from userspace Mirian Shilakadze
2026-11-16 6:24 ` no-reply
2026-11-16 17:13 ` Konstantin Khorenko
2026-11-16 6:12 ` [Devel] [PATCH vz10 v2 2/3] fs: report the locks of a mount in statmount() Mirian Shilakadze
2026-11-16 6:17 ` no-reply
2026-11-16 17:13 ` Konstantin Khorenko [this message]
2026-11-16 6:12 ` [Devel] [PATCH vz10 v2 3/3] selftests/ve: test locking a mount from the host Mirian Shilakadze
2026-11-16 6:38 ` no-reply
2026-11-16 17:13 ` Konstantin Khorenko
2026-11-16 17:13 ` [Devel] [PATCH vz10 v2 0/3] fs: let the host lock the protection flags of a mount Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179484921365.861498.3351238853542398643.b4-review@b4 \
--to=khorenko@virtuozzo.com \
--cc=devel@openvz.org \
--cc=mirian.shilakadze@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.