All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Mirian Shilakadze <mirian.shilakadze@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH vz10 0/6] ve: give the pseudosuper privileges only to the tasks setting up a VE
Date: Mon, 16 Nov 2026 18:17:50 +0100	[thread overview]
Message-ID: <179484947038.861498.10218103446625210481.b4-review@b4> (raw)
In-Reply-To: <20261116104552.102938-1-mirian.shilakadze@virtuozzo.com>

I won't apply this version, please send v2 with the changes below.

On Mon, 16 Nov 2026 14:45:43 +0400, Mirian Shilakadze wrote:
> Mirian Shilakadze (6):
>   ve: tell ve_setup_task() which VE the task comes from
>   ve: hide only the tasks the host sends into a VE
>   ve: hide the tasks that set up a starting VE from the rest of it
>   cgroup: give the CT root file writes and hidden roots only to setup
>     tasks
>   fs: give the mount relaxations of a pseudosuper VE only to setup tasks
>   ve: give the remaining pseudosuper relaxations only to setup tasks

The design holds: the setup mark reaches only what vzctl and CRIU run
before an exec, every way into another task's fds goes through
task_still_dumpable(), and no ve0 caller loses a relaxation. What to
change for v2:

1. Patch 2 (and 3), code: a host task that moves from a starting VE
   straight into a running one keeps VD_VE_SETUP_TASK and is visible
   there. Keep it hidden, as it was before the series. Do not key
   this on the mm mark alone: CRIU-restored processes keep
   VD_VE_SETUP_TASK for life.

2. Patch 2, commit message: say why a container task must not get
   VD_VE_ENTER_TASK, and that a task entering its nested VE is no
   longer hidden there.

3. Patch 3, comments: the VD_VE_SETUP_TASK comment in mm_types.h says
   setup tasks are the only ones with the pseudosuper relaxations,
   which patch 5 makes untrue; the ve_current_is_pseudosuper()
   kernel-doc leaves out that it is true for ve0.

4. Patch 4, comment: the comment above ve_pseudosuper_write() still
   says dropping pseudosuper is allowed from any context.

5. Patch 5: do what Sashiko asked (the subject says "only to setup
   tasks" while the mount limit also lets VD_VE_ENTER_TASK through;
   a helper next to ve_current_is_pseudosuper() instead of the
   open-coded host_entered), and update the "In case of
   @is_pseudosuper set" comment in ve_devmnt_process().

6. Patch 6, comment: devcgroup_legacy_check_permission() still says
   everything is allowed in pseudosuper state.

7. Cover letter: "vzctl and CRIU need no change, the vzctl start path
   was already fixed under VSTOR-151174" is two sentences glued with a
   comma, and the series also works with older libvzctl. Say what
   VSTOR-151174 changed or drop the clause. Put blank lines around the
   "- 1/6" list.

Details are in the replies to the patches.

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  parent reply	other threads:[~2026-11-16 17:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 10:45 Mirian Shilakadze
2026-11-16 10:45 ` [Devel] [PATCH vz10 1/6] ve: tell ve_setup_task() which VE the task comes from Mirian Shilakadze
2026-11-16 10:50   ` no-reply
2026-11-16 10:45 ` [Devel] [PATCH vz10 2/6] ve: hide only the tasks the host sends into a VE Mirian Shilakadze
2026-11-16 10:50   ` no-reply
2026-11-16 17:17   ` Konstantin Khorenko
2026-11-16 10:45 ` [Devel] [PATCH vz10 3/6] ve: hide the tasks that set up a starting VE from the rest of it Mirian Shilakadze
2026-11-16 10:55   ` no-reply
2026-11-16 17:17   ` Konstantin Khorenko
2026-11-16 10:45 ` [Devel] [PATCH vz10 4/6] cgroup: give the CT root file writes and hidden roots only to setup tasks Mirian Shilakadze
2026-11-16 10:53   ` no-reply
2026-11-16 17:17   ` Konstantin Khorenko
2026-11-16 10:45 ` [Devel] [PATCH vz10 5/6] fs: give the mount relaxations of a pseudosuper VE " Mirian Shilakadze
2026-11-16 10:56   ` no-reply
2026-11-16 17:17   ` Konstantin Khorenko
2026-11-16 10:45 ` [Devel] [PATCH vz10 6/6] ve: give the remaining pseudosuper relaxations " Mirian Shilakadze
2026-11-16 10:56   ` no-reply
2026-11-16 17:17   ` Konstantin Khorenko
2026-11-16 17:17 ` Konstantin Khorenko [this message]
2026-11-17 10:21   ` [Devel] [PATCH vz10 0/6] ve: give the pseudosuper privileges only to the tasks setting up a VE Mirian Shilakadze

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179484947038.861498.10218103446625210481.b4-review@b4 \
    --to=khorenko@virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=mirian.shilakadze@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.