All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Mirian Shilakadze <mirian.shilakadze@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH vz10 2/6] ve: hide only the tasks the host sends into a VE
Date: Mon, 16 Nov 2026 18:17:50 +0100	[thread overview]
Message-ID: <179484947038.861498.9006081141204598287.b4-review@b4> (raw)
In-Reply-To: <20261116104552.102938-3-mirian.shilakadze@virtuozzo.com>

I won't apply this version, please send v2.

On Mon, 16 Nov 2026 14:45:45 +0400, Mirian Shilakadze wrote:
> +	if (task->mm && ve_is_super(old_ve) && ve->state != VE_STATE_STARTING)
>  		task->mm->vps_dumpable = VD_VE_ENTER_TASK;

Item 1 of the cover letter reply: keep a host task hidden when it
moves from one VE into another.

Why: setns() into a VE needs CAP_SYS_ADMIN only, so a host task in
starting VE A can setns() into running VE B. old_ve is then A, not
ve0, so the mark is left alone. With patch 3 the mm stays
VD_VE_SETUP_TASK, B is not pseudosuper, ve_vps_dumpable() returns
VD_PTRACE_COREDUMP, and B's root can ptrace the task and read its
fds. Before the series it got VD_VE_ENTER_TASK on entering B. Only a
hand-made flow does this, vzctl and CRIU always enter from ve0.

> A
> container task gets the mark too when it setns()es into its own VE, and
> the mark goes to the mm, which it may share with another task.

Item 2 of the cover letter reply: say why a container task must not
get the mark, and that a task entering its nested VE is no longer
hidden there.

Why: the reader sees what changes but not what was wrong with it, and
the nested VE case changes behaviour without a word.

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  parent reply	other threads:[~2026-11-16 17:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 10:45 [Devel] [PATCH vz10 0/6] ve: give the pseudosuper privileges only to the tasks setting up " Mirian Shilakadze
2026-11-16 10:45 ` [Devel] [PATCH vz10 1/6] ve: tell ve_setup_task() which VE the task comes from Mirian Shilakadze
2026-11-16 10:50   ` no-reply
2026-11-16 10:45 ` [Devel] [PATCH vz10 2/6] ve: hide only the tasks the host sends into a VE Mirian Shilakadze
2026-11-16 10:50   ` no-reply
2026-11-16 17:17   ` Konstantin Khorenko [this message]
2026-11-16 10:45 ` [Devel] [PATCH vz10 3/6] ve: hide the tasks that set up a starting VE from the rest of it Mirian Shilakadze
2026-11-16 10:55   ` no-reply
2026-11-16 17:17   ` Konstantin Khorenko
2026-11-16 10:45 ` [Devel] [PATCH vz10 4/6] cgroup: give the CT root file writes and hidden roots only to setup tasks Mirian Shilakadze
2026-11-16 10:53   ` no-reply
2026-11-16 17:17   ` Konstantin Khorenko
2026-11-16 10:45 ` [Devel] [PATCH vz10 5/6] fs: give the mount relaxations of a pseudosuper VE " Mirian Shilakadze
2026-11-16 10:56   ` no-reply
2026-11-16 17:17   ` Konstantin Khorenko
2026-11-16 10:45 ` [Devel] [PATCH vz10 6/6] ve: give the remaining pseudosuper relaxations " Mirian Shilakadze
2026-11-16 10:56   ` no-reply
2026-11-16 17:17   ` Konstantin Khorenko
2026-11-16 17:17 ` [Devel] [PATCH vz10 0/6] ve: give the pseudosuper privileges only to the tasks setting up a VE Konstantin Khorenko
2026-11-17 10:21   ` Mirian Shilakadze

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179484947038.861498.9006081141204598287.b4-review@b4 \
    --to=khorenko@virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=mirian.shilakadze@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.