[Devel] [PATCH hci-8.1 0/2] ms/checkpatch: accept the Assisted-by: LLM tag

[Devel] [PATCH hci-8.1 0/2] ms/checkpatch: accept the Assisted-by: LLM tag

[Konstantin Khorenko]

Let's allow uur patches to carry an "Assisted-by: LLM" line before the
Signed-off-by.
The checkpatch.pl in our tree does not know the tag and reports on every
such patch:

- WARNING: Non-standard signature: Assisted-by:
- ERROR: Unrecognized email address: 'LLM'

Patch 1 adds Assisted-by: to the known signatures and skips the e-mail
check for it. Alone it still warns on "LLM", because it expects the
AGENT_NAME:MODEL_VERSION form. Patch 2 accepts any non-empty value, which
is the form mainline documents since 816d9992d9ed ("coding-assistants:
simplify attribution").

Both are clean cherry-picks from mainline.

Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
---
Jeff Layton (1):
      ms/checkpatch.pl: adapt to new Assisted-by: format

Sasha Levin (1):
      ms/checkpatch: add support for Assisted-by tag

 scripts/checkpatch.pl | 11 +++++++++++
 1 file changed, 11 insertions(+)
---
base-commit: 91ab89ac68fe62d03f2d4da85a4570f02fd0fe12
change-id: 20261016-checkpatch-c054d6a300ea

Best regards,
--  
Konstantin Khorenko <khorenko@virtuozzo.com>

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

[Devel] [PATCH hci-8.1 1/2] ms/checkpatch: add support for Assisted-by tag

[Konstantin Khorenko]

From: Sasha Levin <sashal@kernel.org>

The Assisted-by tag was introduced in
Documentation/process/coding-assistants.rst for attributing AI tool
contributions to kernel patches.  However, checkpatch.pl did not recognize
this tag, causing two issues:

  WARNING: Non-standard signature: Assisted-by:
  ERROR: Unrecognized email address: 'AGENT_NAME:MODEL_VERSION'

Fix this by:
1. Adding Assisted-by to the recognized $signature_tags list
2. Skipping email validation for Assisted-by lines since they use the
   AGENT_NAME:MODEL_VERSION format instead of an email address
3. Warning when the Assisted-by value doesn't match the expected format

Link: https://lkml.kernel.org/r/20260311215818.518930-1-sashal@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
Reported-by: Bart Van Assche <bvanassche@acm.org>
Acked-by: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>
Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
(cherry picked from commit d1db4118489fffd2b2f612140b7acbb477880839)

Feature: fix ms/scripts
Assisted-by: LLM
Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
---
 scripts/checkpatch.pl | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index e7e6114535f04..c30ff25f70182 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -622,6 +622,7 @@ our $zero_initializer = qr{(?:(?:0[xX])?0+$Int_type?|NULL|false)\b};
 	Reviewed-by:|
 	Reported-by:|
 	Suggested-by:|
+	Assisted-by:|
 	To:|
 	Cc:
 )};
@@ -3072,6 +3073,15 @@ sub process {
 				}
 			}
 
+			# Assisted-by uses AGENT_NAME:MODEL_VERSION format, not email
+			if ($sign_off =~ /^Assisted-by:/i) {
+				if ($email !~ /^\S+:\S+/) {
+					WARN("BAD_SIGN_OFF",
+					     "Assisted-by expects 'AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]' format\n" . $herecurr);
+				}
+				next;
+			}
+
 			my ($email_name, $name_comment, $email_address, $comment) = parse_email($email);
 			my $suggested_email = format_email(($email_name, $name_comment, $email_address, $comment));
 			if ($suggested_email eq "") {

-- 
2.43.0

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

Re: [Devel] [PATCH hci-8.1 1/2] ms/checkpatch: add support for Assisted-by tag

[no-reply]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] checkpatch: Assisted-by block's unconditional next skips later per-line checks
--

commit 5a811b60fe8be1a0a89ee89ba84a4ed4223a05c3
Author: Sasha Levin <sashal@kernel.org>

ms/checkpatch: add support for Assisted-by tag

This commit teaches checkpatch.pl to recognize the Assisted-by tag. It adds
the tag to $signature_tags and skips email validation for Assisted-by lines.
It also warns when the value doesn't look like AGENT_NAME:MODEL_VERSION.

Link: https://lkml.kernel.org/r/20260311215818.518930-1-sashal@kernel.org

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl

[ ... ]

> @@ -3072,6 +3073,15 @@ sub process {
>  				}
>  			}
>  
> +			# Assisted-by uses AGENT_NAME:MODEL_VERSION format, not email
> +			if ($sign_off =~ /^Assisted-by:/i) {
> +				if ($email !~ /^\S+:\S+/) {
> +					WARN("BAD_SIGN_OFF",
> +					     "Assisted-by expects 'AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]' format\n" . $herecurr);
> +				}
> +				next;
> +			}
> +

[Severity: Low]
Does the unconditional next; here skip checks that should still run for
Assisted-by lines?

In process(), this block sits inside the per-line loop. For a line such as
"Assisted-by: X", $sign_off is "Assisted-by:", so the new block ends with
next; and jumps to the next input line.

That skips the "# Check for duplicate signatures" code that records
$signatures{$sig_nospace}, so duplicate Assisted-by lines would never be
reported as "Duplicate signature". It also skips the other per-line checks
that follow the signature block, such as the repeated-word check.

The follow-up patch 7d898d23 ("ms/checkpatch.pl: adapt to new Assisted-by:
format") changes only the value check, to an empty-value check with
different warning text. It keeps the unconditional next;, so the final
series state still skips those checks.

Would an if/else around the email validation, instead of next;, avoid this?

>  			my ($email_name, $name_comment, $email_address, $comment) = parse_email($email);
>  			my $suggested_email = format_email(($email_name, $name_comment, $email_address, $comment));
>  			if ($suggested_email eq "") {

[ ... ]

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261016-checkpatch-v1-0-3aceda8d9600@virtuozzo.com?part=1

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

[Devel] [PATCH hci-8.1 2/2] ms/checkpatch.pl: adapt to new Assisted-by: format

[Konstantin Khorenko]

From: Jeff Layton <jlayton@kernel.org>

There is a new format for the 'Assisted-by:' tag. Change checkpatch.pl
to just check that it has a value rather than testing for a specific
format.

Assisted-by: LLM
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Message-ID: <20260804-checkpatch-v1-1-27f29c79a46f@kernel.org>
(cherry picked from commit 2a8d68338ee77e200895f2697c56fd00094767f7)

Feature: fix ms/scripts
Assisted-by: LLM
Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
---
 scripts/checkpatch.pl | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index c30ff25f70182..d731293db83c1 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3073,11 +3073,12 @@ sub process {
 				}
 			}
 
-			# Assisted-by uses AGENT_NAME:MODEL_VERSION format, not email
+			# Assisted-by uses a free-form value (e.g. "LLM"), not an
+			# email address, so skip the email format checks below.
 			if ($sign_off =~ /^Assisted-by:/i) {
-				if ($email !~ /^\S+:\S+/) {
+				if ($email =~ /^\s*$/) {
 					WARN("BAD_SIGN_OFF",
-					     "Assisted-by expects 'AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]' format\n" . $herecurr);
+					     "Assisted-by requires a value\n" . $herecurr);
 				}
 				next;
 			}

-- 
2.43.0

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

Re: [Devel] [PATCH hci-8.1 2/2] ms/checkpatch.pl: adapt to new Assisted-by: format

[no-reply]

> From: Jeff Layton <jlayton@kernel.org>
> 
> There is a new format for the 'Assisted-by:' tag. Change checkpatch.pl
> to just check that it has a value rather than testing for a specific
> format.
> 
> Assisted-by: LLM
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> Signed-off-by: Jonathan Corbet <corbet@lwn.net>
> Message-ID: <20260804-checkpatch-v1-1-27f29c79a46f@kernel.org>
> (cherry picked from commit 2a8d68338ee77e200895f2697c56fd00094767f7)
> 
> Feature: fix ms/scripts
> Assisted-by: LLM
> Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261016-checkpatch-v1-0-3aceda8d9600@virtuozzo.com?part=2


_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

Re: [Devel] [PATCH hci-8.1 0/2] ms/checkpatch: accept the Assisted-by: LLM tag

[Konstantin Khorenko]

On Fri, 16 Oct 2026 23:33:31 +0200, Konstantin Khorenko wrote:
> ms/checkpatch: accept the Assisted-by: LLM tag
> 
> Let's allow uur patches to carry an "Assisted-by: LLM" line before the
> Signed-off-by.
> The checkpatch.pl in our tree does not know the tag and reports on every
> such patch:
> 
> [...]

Applied to branch-rh10-6.12.0-211.52.1.22.x.vz10-ovz, will be released in rh10-6.12.0-211.52.1.22.9.vz10, thanks!

[1/2] ms/checkpatch: add support for Assisted-by tag
      https://bitbucket.org/virtuozzocore/vzkernel.vzs/commits/1e963113d80f
[2/2] ms/checkpatch.pl: adapt to new Assisted-by: format
      https://bitbucket.org/virtuozzocore/vzkernel.vzs/commits/8026fb5599f9

-- 
Konstantin Khorenko <khorenko@virtuozzo.com>

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel