All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
To: andrey.zhadchenko@virtuozzo.com
Cc: devel@openvz.org
Subject: [Devel] [PATCH hci-8.1 v7 08/10] dm-ploop: fix flip_upper_deltas racing with resume
Date: Tue, 17 Nov 2026 18:17:41 +0100	[thread overview]
Message-ID: <20261117171743.3216794-9-alexander.ivanov@virtuozzo.com> (raw)
In-Reply-To: <20261117171743.3216794-1-alexander.ivanov@virtuozzo.com>

ploop_preresume() checks noresume under ctl_rwsem, drops the lock and
only then clears ->suspended. Messages are not serialized with resume:
target_message() uses the live table without md->suspend_lock, so
"set_noresume 1" followed by "flip_upper_deltas" can pass the check
in ploop_flip_upper_deltas() in that gap. The device then goes live
with noresume set and the top deltas swapped.

Clear ->suspended in the same critical section as the noresume check,
and only if it passes.

https://virtuozzo.atlassian.net/browse/VSTOR-148171
Feature: dm-ploop: ploop target driver

Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
 drivers/md/dm-ploop-target.c | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/drivers/md/dm-ploop-target.c b/drivers/md/dm-ploop-target.c
index 3b5f37a58bb1..bfadca7f12ae 100644
--- a/drivers/md/dm-ploop-target.c
+++ b/drivers/md/dm-ploop-target.c
@@ -764,19 +764,20 @@ static int ploop_preresume(struct dm_target *ti)
 	struct ploop *ploop = ti->private;
 	int ret = 0;
 
-	down_read(&ploop->ctl_rwsem);
+	down_write(&ploop->ctl_rwsem);
 	if (ploop->noresume)
 		ret = -EAGAIN;
-	up_read(&ploop->ctl_rwsem);
-
-	if (ret == 0) {
-		/*
-		 * We are singleton target. There will be
-		 * no more reasons to break resume.
-		 */
-		ploop_set_suspended(ti, false);
+	/*
+	 * We are singleton target. There will be no more reasons to break
+	 * resume. Clear it under the same lock as the noresume check, so
+	 * that flip_upper_deltas can't sneak in before the device goes live.
+	 */
+	if (ret == 0)
+		ploop->suspended = false;
+	up_write(&ploop->ctl_rwsem);
+
+	if (ret == 0)
 		ploop_set_wants_suspend(ti, false);
-	}
 	return ret;
 }
 ALLOW_ERROR_INJECTION(ploop_preresume, ERRNO);
-- 
2.53.0

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  parent reply	other threads:[~2026-11-17 17:19 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 17:17 [Devel] [PATCH hci-8.1 v7 00/10] dm-ploop: give back unused tail of top delta on suspend Alexander Ivanov
2026-11-17 17:17 ` [Devel] [PATCH hci-8.1 v7 01/10] dm-ploop: reject a delta header whose BAT does not cover the target Alexander Ivanov
2026-11-17 17:22   ` no-reply
2026-11-17 17:17 ` [Devel] [PATCH hci-8.1 v7 02/10] dm-ploop: reject empty deltas Alexander Ivanov
2026-11-17 17:22   ` no-reply
2026-11-17 17:17 ` [Devel] [PATCH hci-8.1 v7 03/10] dm-ploop: set delta is_raw before applying its mappings Alexander Ivanov
2026-11-17 17:25   ` no-reply
2026-11-17 18:23   ` Konstantin Khorenko
2026-11-17 17:17 ` [Devel] [PATCH hci-8.1 v7 04/10] dm-ploop: factor out ploop_read_delta() from ploop_add_delta() Alexander Ivanov
2026-11-17 17:24   ` no-reply
2026-11-17 17:17 ` [Devel] [PATCH hci-8.1 v7 05/10] dm-ploop: take bat_lock around md page lookup in ploop_llseek_hole() Alexander Ivanov
2026-11-17 17:27   ` no-reply
2026-11-17 17:17 ` [Devel] [PATCH hci-8.1 v7 06/10] dm-ploop: use wake_up() for inflight_md_wq Alexander Ivanov
2026-11-17 17:26   ` no-reply
2026-11-17 18:23   ` Konstantin Khorenko
2026-11-17 17:17 ` [Devel] [PATCH hci-8.1 v7 07/10] dm-ploop: fix use-after-free on the last inflight_md decrement Alexander Ivanov
2026-11-17 17:32   ` no-reply
2026-11-17 18:23   ` Konstantin Khorenko
2026-11-17 17:17 ` Alexander Ivanov [this message]
2026-11-17 17:28   ` [Devel] [PATCH hci-8.1 v7 08/10] dm-ploop: fix flip_upper_deltas racing with resume no-reply
2026-11-17 17:17 ` [Devel] [PATCH hci-8.1 v7 09/10] dm-ploop: reload metadata on resume Alexander Ivanov
2026-11-17 17:36   ` no-reply
2026-11-17 18:23   ` Konstantin Khorenko
2026-11-17 17:17 ` [Devel] [PATCH hci-8.1 v7 10/10] dm-ploop: truncate unused tail of top delta on suspend Alexander Ivanov
2026-11-17 17:40   ` no-reply
2026-11-17 18:23   ` Konstantin Khorenko
2026-11-17 18:23 ` [Devel] [PATCH hci-8.1 v7 00/10] dm-ploop: give back " Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117171743.3216794-9-alexander.ivanov@virtuozzo.com \
    --to=alexander.ivanov@virtuozzo.com \
    --cc=andrey.zhadchenko@virtuozzo.com \
    --cc=devel@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.