All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: "Denis V. Lunev" <den@virtuozzo.com>
To: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>,
	Alexander Ivanov <alexander.ivanov@virtuozzo.com>,
	andrey.zhadchenko@virtuozzo.com
Cc: svt-core@virtuozzo.com
Subject: Re: [PATCH hci-8.1 0/2] vhost-blk: support the werror/rerror policies
Date: Tue, 17 Nov 2026 19:14:55 +0100	[thread overview]
Message-ID: <48f199de-ef05-4bcd-aa1d-1bb29d9dcc29@virtuozzo.com> (raw)
In-Reply-To: <17bc3615-9d80-4e88-bc22-157c1bdfce77@virtuozzo.com>

On 11/17/26 11:59, Andrey Drobyshev wrote:
> AFAIU vhost-blk is targeted for hci-8.2, and therefore these patches are
> NOT meant for hci-8.1 (despite what subject line suggests).  Please confirm.
>
> On 11/17/26 12:50 PM, Alexander Ivanov wrote:
>> A vhost-blk disk completes requests to the guest from the kernel, so
>> QEMU never sees an I/O error and the werror/rerror policies cannot
>> work the usual way. The dm-qcow2 series holds a failed request
>> according to the policy and reports it with an IO_ERROR change
>> uevent. This series makes QEMU accept the policies and pause the VM
>> on that uevent.
>>
>> Patch 1 adds the werror and rerror properties, which libvirt passes
>> when the disk has error_policy or rerror_policy set. Without them
>> QEMU refuses to start such a VM.
>>
>> Patch 2 parses the IO_ERROR uevent and stops the VM with the io-error
>> reason and a BLOCK_IO_ERROR event when the policy says so. Migration
>> and savevm are blocked while requests are held in the kernel.
>>
>> ! Don't apply this patchset before the kernel patchset is applied.
>>
>> https://virtuozzo.atlassian.net/browse/VSTOR-152175
>>
>> Alexander Ivanov (2):
>>   vhost-blk: add the werror and rerror properties #VSTOR-152175
>>   vhost-blk: pause the VM on an IO_ERROR uevent from dm-qcow2
>>     #VSTOR-152175
>>
>>  hw/block/vhost-blk.c          | 112 +++++++++++++++++++++++++++++++++-
>>  include/hw/virtio/vhost-blk.h |   2 +
>>  2 files changed, 111 insertions(+), 3 deletions(-)
>>
question is correct. Anyway, we are to rebuild 8.1 for LA57.

@Andrey Drobyshev - if this is safe (not very dangerous) - take.
If not - 8.2

Den

      reply	other threads:[~2026-11-17 18:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 10:50 Alexander Ivanov
2026-11-17 10:50 ` [PATCH hci-8.1 1/2] vhost-blk: add the werror and rerror properties #VSTOR-152175 Alexander Ivanov
2026-11-17 11:03   ` no-reply
2026-11-17 18:12   ` Andrey Drobyshev
2026-11-17 10:50 ` [PATCH hci-8.1 2/2] vhost-blk: pause the VM on an IO_ERROR uevent from dm-qcow2 #VSTOR-152175 Alexander Ivanov
2026-11-17 11:05   ` no-reply
2026-11-17 18:12   ` Andrey Drobyshev
2026-11-17 10:59 ` [PATCH hci-8.1 0/2] vhost-blk: support the werror/rerror policies Andrey Drobyshev
2026-11-17 18:14   ` Denis V. Lunev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48f199de-ef05-4bcd-aa1d-1bb29d9dcc29@virtuozzo.com \
    --to=den@virtuozzo.com \
    --cc=alexander.ivanov@virtuozzo.com \
    --cc=andrey.drobyshev@virtuozzo.com \
    --cc=andrey.zhadchenko@virtuozzo.com \
    --cc=svt-core@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.