All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
To: andrey.zhadchenko@virtuozzo.com
Cc: andrey.drobyshev@virtuozzo.com, svt-core@virtuozzo.com
Subject: [PATCH hci-8.1 1/2] vhost-blk: add the werror and rerror properties #VSTOR-152175
Date: Tue, 17 Nov 2026 11:50:02 +0100	[thread overview]
Message-ID: <20261117105003.3082044-2-alexander.ivanov@virtuozzo.com> (raw)
In-Reply-To: <20261117105003.3082044-1-alexander.ivanov@virtuozzo.com>

libvirt passes werror and rerror to the device when the disk has
error_policy or rerror_policy set, and QEMU refuses to start such a VM
with vhost-blk.

Accept them with the defaults of other block devices: enospc for
writes and report for reads. dm-qcow2 holds the failed requests under
the same policy, which libvirt loads into its table. It has no ignore
policy, and enospc makes no sense for reads, so reject both.

https://virtuozzo.atlassian.net/browse/VSTOR-152175

Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
 hw/block/vhost-blk.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/hw/block/vhost-blk.c b/hw/block/vhost-blk.c
index abddff02c6d..354111a1b41 100644
--- a/hw/block/vhost-blk.c
+++ b/hw/block/vhost-blk.c
@@ -617,6 +617,24 @@ static void vhost_blk_device_realize(DeviceState *dev, Error **errp)
         return;
     }
 
+    if (conf->conf.werror == BLOCKDEV_ON_ERROR_AUTO) {
+        conf->conf.werror = BLOCKDEV_ON_ERROR_ENOSPC;
+    }
+    if (conf->conf.rerror == BLOCKDEV_ON_ERROR_AUTO) {
+        conf->conf.rerror = BLOCKDEV_ON_ERROR_REPORT;
+    }
+
+    if (conf->conf.werror == BLOCKDEV_ON_ERROR_IGNORE ||
+        conf->conf.rerror == BLOCKDEV_ON_ERROR_IGNORE) {
+        error_setg(errp, "vhost-blk: 'ignore' error policy is not supported");
+        return;
+    }
+
+    if (conf->conf.rerror == BLOCKDEV_ON_ERROR_ENOSPC) {
+        error_setg(errp, "vhost-blk: 'enospc' is not supported as rerror");
+        return;
+    }
+
     if (!vhost_blk_open_backend(s, errp)) {
         return;
     }
@@ -795,6 +813,7 @@ static const Property vhost_blk_properties[] = {
     DEFINE_PROP_BIT64("write-zeroes", VHostBlk, host_features,
                       VIRTIO_BLK_F_WRITE_ZEROES, false),
     DEFINE_PROP_STRING("serial", VHostBlk, conf.serial),
+    DEFINE_BLOCK_ERROR_PROPERTIES(VHostBlk, conf.conf),
 };
 
 static const VMStateDescription vmstate_vhost_blk = {
-- 
2.53.0


  reply	other threads:[~2026-11-17 10:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 10:50 [PATCH hci-8.1 0/2] vhost-blk: support the werror/rerror policies Alexander Ivanov
2026-11-17 10:50 ` Alexander Ivanov [this message]
2026-11-17 11:03   ` [PATCH hci-8.1 1/2] vhost-blk: add the werror and rerror properties #VSTOR-152175 no-reply
2026-11-17 18:12   ` Andrey Drobyshev
2026-11-17 10:50 ` [PATCH hci-8.1 2/2] vhost-blk: pause the VM on an IO_ERROR uevent from dm-qcow2 #VSTOR-152175 Alexander Ivanov
2026-11-17 11:05   ` no-reply
2026-11-17 18:12   ` Andrey Drobyshev
2026-11-17 10:59 ` [PATCH hci-8.1 0/2] vhost-blk: support the werror/rerror policies Andrey Drobyshev
2026-11-17 18:14   ` Denis V. Lunev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117105003.3082044-2-alexander.ivanov@virtuozzo.com \
    --to=alexander.ivanov@virtuozzo.com \
    --cc=andrey.drobyshev@virtuozzo.com \
    --cc=andrey.zhadchenko@virtuozzo.com \
    --cc=svt-core@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.