All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
Subject: Re: [Devel] [PATCH vz10 2/3] selftests: netdevsim: skip the rate tc-bw check without tool support
Date: Mon, 24 Aug 2026 15:48:05 +0200	[thread overview]
Message-ID: <61fc7bf1-8bb7-4287-a118-08e4a0fc5fe3@virtuozzo.com> (raw)
In-Reply-To: <20260821164137.813192-2-eva.kurchatova@virtuozzo.com>

On 8/21/26 18:41, Eva Kurchatova wrote:
> devlink from iproute2 6.11, which vz ships, has no tc-bw option, and
> the rate test fails on "Unknown option" rather than skipping.
> 
> https://virtuozzo.atlassian.net/browse/VSTOR-139651
> Feature: fix selftests
> Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
> ---
>  tools/testing/selftests/drivers/net/netdevsim/devlink.sh | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tools/testing/selftests/drivers/net/netdevsim/devlink.sh b/tools/testing/selftests/drivers/net/netdevsim/devlink.sh
> index 030762b203d7..e1dbbfc7da29 100755
> --- a/tools/testing/selftests/drivers/net/netdevsim/devlink.sh
> +++ b/tools/testing/selftests/drivers/net/netdevsim/devlink.sh
> @@ -616,6 +616,11 @@ rate_attr_tc_bw_check()
>  	local tc_bw=$2
>  	local debug_file=$3
>  
> +	if ! devlink port function rate help 2>&1 | grep -q tc-bw; then
> +		log_test_skip "tc-bw is not supported by devlink"

It will be printed 5 times, but probably 1 time is enough.

> +		return
> +	fi
> +
>  	local tc_bw_str=""
>  	for bw in $tc_bw; do
>  		local tc=${bw%%:*}


  reply	other threads:[~2026-08-24 13:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21 16:41 [Devel] [PATCH vz10 1/3] selftests: net: Adapt ethtool mq tests to fix in qdisc graft Eva Kurchatova
2026-08-21 16:41 ` [Devel] [PATCH vz10 2/3] selftests: netdevsim: skip the rate tc-bw check without tool support Eva Kurchatova
2026-08-24 13:48   ` Konstantin Khorenko [this message]
2026-08-24 13:50   ` [Devel] [PATCH vz10 v2] " Konstantin Khorenko
2026-08-25 14:41     ` [Devel] [PATCH RHEL10 COMMIT] " Konstantin Khorenko
2026-08-21 16:41 ` [Devel] [PATCH vz10 3/3] selftests: netdevsim: mark ethtool-features.sh executable Eva Kurchatova
2026-08-24 14:35   ` [Devel] [PATCH vz10 v2] " Konstantin Khorenko
2026-08-24 14:37     ` [Devel] [PATCH RHEL10 COMMIT] " Konstantin Khorenko
2026-08-24 13:36 ` [Devel] [PATCH vz10 1/3] selftests: net: Adapt ethtool mq tests to fix in qdisc graft Konstantin Khorenko
2026-08-24 14:36 ` [Devel] [PATCH RHEL10 COMMIT] ms/selftests: " Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61fc7bf1-8bb7-4287-a118-08e4a0fc5fe3@virtuozzo.com \
    --to=khorenko@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.