All Virtuozzo development lists (kernel + QEMU)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
Subject: [Devel] [PATCH vz10 v2] selftests: netdevsim: mark ethtool-features.sh executable
Date: Mon, 24 Aug 2026 16:35:28 +0200	[thread overview]
Message-ID: <20260824143528.456165-1-khorenko@virtuozzo.com> (raw)
In-Reply-To: <20260821164137.813192-3-eva.kurchatova@virtuozzo.com>

From: Eva Kurchatova <eva.kurchatova@virtuozzo.com>

The script is listed in TEST_PROGS but, unlike its 14 siblings there,
is not executable. Nothing actually fails: run_kselftest.sh falls back
to running a non-executable test through the interpreter from its
shebang, so the only effect is

  # Warning: file ethtool-features.sh is not executable

in the log. Still, the warning reads like a problem, kernel packaging
installs the script 0644 where every other test in the directory is
0755, and running it by hand needs an explicit interpreter.
Set the bit.

https://virtuozzo.atlassian.net/browse/VSTOR-139651
Feature: fix selftests
Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Reviewed-by: Konstantin Khorenko <khorenko@virtuozzo.com>
---
Changes in v2:
- commit message only, the mode change itself is unchanged.  v1 said
  the runner cannot start the script, which is not true: for a test
  that is not executable run_kselftest.sh falls back to the interpreter
  from its shebang, so nothing fails today.  Say what the patch really
  buys instead.

 tools/testing/selftests/drivers/net/netdevsim/ethtool-features.sh | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 tools/testing/selftests/drivers/net/netdevsim/ethtool-features.sh

diff --git a/tools/testing/selftests/drivers/net/netdevsim/ethtool-features.sh b/tools/testing/selftests/drivers/net/netdevsim/ethtool-features.sh
old mode 100644
new mode 100755
-- 
2.47.1


  reply	other threads:[~2026-08-24 14:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21 16:41 [Devel] [PATCH vz10 1/3] selftests: net: Adapt ethtool mq tests to fix in qdisc graft Eva Kurchatova
2026-08-21 16:41 ` [Devel] [PATCH vz10 2/3] selftests: netdevsim: skip the rate tc-bw check without tool support Eva Kurchatova
2026-08-24 13:48   ` Konstantin Khorenko
2026-08-24 13:50   ` [Devel] [PATCH vz10 v2] " Konstantin Khorenko
2026-08-25 14:41     ` [Devel] [PATCH RHEL10 COMMIT] " Konstantin Khorenko
2026-08-21 16:41 ` [Devel] [PATCH vz10 3/3] selftests: netdevsim: mark ethtool-features.sh executable Eva Kurchatova
2026-08-24 14:35   ` Konstantin Khorenko [this message]
2026-08-24 14:37     ` [Devel] [PATCH RHEL10 COMMIT] " Konstantin Khorenko
2026-08-24 13:36 ` [Devel] [PATCH vz10 1/3] selftests: net: Adapt ethtool mq tests to fix in qdisc graft Konstantin Khorenko
2026-08-24 14:36 ` [Devel] [PATCH RHEL10 COMMIT] ms/selftests: " Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260824143528.456165-1-khorenko@virtuozzo.com \
    --to=khorenko@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.